[INFO] crate sozuctl 0.11.0 is already in cache
[INFO] extracting crate sozuctl 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/sozuctl/0.11.0
[INFO] extracting crate sozuctl 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sozuctl/0.11.0
[INFO] validating manifest of sozuctl-0.11.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sozuctl-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sozuctl-0.11.0
[INFO] finished frobbing sozuctl-0.11.0
[INFO] frobbed toml for sozuctl-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/sozuctl/0.11.0/Cargo.toml
[INFO] started frobbing sozuctl-0.11.0
[INFO] finished frobbing sozuctl-0.11.0
[INFO] frobbed toml for sozuctl-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sozuctl/0.11.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sozuctl-0.11.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sozuctl/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1e3499fc411dd15e3c43814b5d2db58f49b61d64c5f91aadc7d573533cd266b1
[INFO] running `"docker" "start" "-a" "1e3499fc411dd15e3c43814b5d2db58f49b61d64c5f91aadc7d573533cd266b1"`
[INFO] [stderr]     Checking pool v0.1.4
[INFO] [stderr]    Compiling sozuctl v0.11.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking prettytable-rs v0.7.0
[INFO] [stderr]     Checking pem v0.5.1
[INFO] [stderr]     Checking sozu-command-lib v0.11.0
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/command.rs:305:13
[INFO] [stderr]     |
[INFO] [stderr] 305 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/command.rs:307:13
[INFO] [stderr]     |
[INFO] [stderr] 307 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:548:19
[INFO] [stderr]     |
[INFO] [stderr] 548 |                   worker: worker,
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: replace it with: `worker`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:811:7
[INFO] [stderr]     |
[INFO] [stderr] 811 |       address: address,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:814:7
[INFO] [stderr]     |
[INFO] [stderr] 814 |       sticky_id: sticky_id,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sticky_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:815:7
[INFO] [stderr]     |
[INFO] [stderr] 815 |       backup:    backup
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^ help: replace it with: `backup`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:823:5
[INFO] [stderr]     |
[INFO] [stderr] 823 |     address: address,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:844:7
[INFO] [stderr]     |
[INFO] [stderr] 844 |       fingerprint: fingerprint,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fingerprint`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/command.rs:1280:17
[INFO] [stderr]      |
[INFO] [stderr] 1280 |                 certificate: certificate,
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `certificate`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/command.rs:1281:17
[INFO] [stderr]      |
[INFO] [stderr] 1281 |                 certificate_chain: certificate_chain,
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `certificate_chain`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/command.rs:1282:17
[INFO] [stderr]      |
[INFO] [stderr] 1282 |                 key: key
[INFO] [stderr]      |                 ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/command.rs:305:13
[INFO] [stderr]     |
[INFO] [stderr] 305 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/command.rs:307:13
[INFO] [stderr]     |
[INFO] [stderr] 307 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:548:19
[INFO] [stderr]     |
[INFO] [stderr] 548 |                   worker: worker,
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: replace it with: `worker`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:811:7
[INFO] [stderr]     |
[INFO] [stderr] 811 |       address: address,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:814:7
[INFO] [stderr]     |
[INFO] [stderr] 814 |       sticky_id: sticky_id,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sticky_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:815:7
[INFO] [stderr]     |
[INFO] [stderr] 815 |       backup:    backup
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^ help: replace it with: `backup`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:823:5
[INFO] [stderr]     |
[INFO] [stderr] 823 |     address: address,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/command.rs:844:7
[INFO] [stderr]     |
[INFO] [stderr] 844 |       fingerprint: fingerprint,
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fingerprint`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/command.rs:1280:17
[INFO] [stderr]      |
[INFO] [stderr] 1280 |                 certificate: certificate,
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `certificate`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/command.rs:1281:17
[INFO] [stderr]      |
[INFO] [stderr] 1281 |                 certificate_chain: certificate_chain,
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `certificate_chain`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/command.rs:1282:17
[INFO] [stderr]      |
[INFO] [stderr] 1282 |                 key: key
[INFO] [stderr]      |                 ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/command.rs:1105:18
[INFO] [stderr]      |
[INFO] [stderr] 1105 |             } else {
[INFO] [stderr]      |  __________________^
[INFO] [stderr] 1106 | |             if let Some(CommandResponseData::Query(data)) = message.data {
[INFO] [stderr] 1107 | |               let mut table = Table::new();
[INFO] [stderr] 1108 | |               let mut header = Vec::new();
[INFO] [stderr] ...    |
[INFO] [stderr] 1150 | |             }
[INFO] [stderr] 1151 | |           }
[INFO] [stderr]      | |___________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1105 |           } else if let Some(CommandResponseData::Query(data)) = message.data {
[INFO] [stderr] 1106 |   let mut table = Table::new();
[INFO] [stderr] 1107 |   let mut header = Vec::new();
[INFO] [stderr] 1108 |   header.push(cell!("key"));
[INFO] [stderr] 1109 |   for ref key in data.keys() {
[INFO] [stderr] 1110 |     header.push(cell!(&key));
[INFO] [stderr]    ...
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/main.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     SubCmd::Config{ cmd: _ } => {}, // noop, handled at the beginning of the method
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Config { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/command.rs:1105:18
[INFO] [stderr]      |
[INFO] [stderr] 1105 |             } else {
[INFO] [stderr]      |  __________________^
[INFO] [stderr] 1106 | |             if let Some(CommandResponseData::Query(data)) = message.data {
[INFO] [stderr] 1107 | |               let mut table = Table::new();
[INFO] [stderr] 1108 | |               let mut header = Vec::new();
[INFO] [stderr] ...    |
[INFO] [stderr] 1150 | |             }
[INFO] [stderr] 1151 | |           }
[INFO] [stderr]      | |___________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1105 |           } else if let Some(CommandResponseData::Query(data)) = message.data {
[INFO] [stderr] 1106 |   let mut table = Table::new();
[INFO] [stderr] 1107 |   let mut header = Vec::new();
[INFO] [stderr] 1108 |   header.push(cell!("key"));
[INFO] [stderr] 1109 |   for ref key in data.keys() {
[INFO] [stderr] 1110 |     header.push(cell!(&key));
[INFO] [stderr]    ...
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/main.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     SubCmd::Config{ cmd: _ } => {}, // noop, handled at the beginning of the method
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Config { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:207:12
[INFO] [stderr]     |
[INFO] [stderr] 207 |         if &id != &message.id {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 207 |         if id != message.id {
[INFO] [stderr]     |            ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:255:18
[INFO] [stderr]     |
[INFO] [stderr] 255 |               if &id == &message.id {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 255 |               if id == message.id {
[INFO] [stderr]     |                  ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/command.rs:301:17
[INFO] [stderr]     |
[INFO] [stderr] 301 |             for ref worker in workers.iter() {
[INFO] [stderr]     |                 ^^^^^^^^^^    -------------- help: try: `let worker = &workers.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:324:22
[INFO] [stderr]     |
[INFO] [stderr] 324 |                   if &id != &message.id {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 324 |                   if id != message.id {
[INFO] [stderr]     |                      ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:399:18
[INFO] [stderr]     |
[INFO] [stderr] 399 |               if &id == &message.id {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 399 |               if id == message.id {
[INFO] [stderr]     |                  ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/command.rs:457:17
[INFO] [stderr]     |
[INFO] [stderr] 457 |             for ref worker in workers.iter().filter(|worker| worker.run_state == RunState::Running) {
[INFO] [stderr]     |                 ^^^^^^^^^^    --------------------------------------------------------------------- help: try: `let worker = &workers.iter().filter(|worker| worker.run_state == RunState::Running);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/command.rs:557:19
[INFO] [stderr]     |
[INFO] [stderr] 557 |               for ref worker in workers.iter() {
[INFO] [stderr]     |                   ^^^^^^^^^^    -------------- help: try: `let worker = &workers.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/command.rs:571:1
[INFO] [stderr]     |
[INFO] [stderr] 571 | / pub fn metrics(mut channel: Channel<CommandRequest,CommandResponse>, json: bool) {
[INFO] [stderr] 572 | |   let id = generate_id();
[INFO] [stderr] 573 | |   //println!("will send message for metrics with id {}", id);
[INFO] [stderr] 574 | |   channel.write_message(&CommandRequest::new(
[INFO] [stderr] ...   |
[INFO] [stderr] 743 | |   }
[INFO] [stderr] 744 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:601:16
[INFO] [stderr]     |
[INFO] [stderr] 601 |             if &id == &message.id {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 601 |             if id == message.id {
[INFO] [stderr]     |                ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/command.rs:647:36
[INFO] [stderr]     |
[INFO] [stderr] 647 |                       row.push(cell!(data.workers[wk].proxy.get(k)
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 648 | |                                    .map(|value| format!("{:?}", value)).unwrap_or(String::new())));
[INFO] [stderr]     | |________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 647 |                     row.push(cell!(data.workers[wk].proxy.get(k)
[INFO] [stderr] 648 |                                    .map(|value| format!("{:?}", value)).unwrap_or_default()));
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/command.rs:694:38
[INFO] [stderr]     |
[INFO] [stderr] 694 |                         row.push(cell!(worker.applications.get(id).and_then(|app| app.data.get(metric))
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 695 | |                                      .map(|value| format!("{:?}", value)).unwrap_or(String::new())));
[INFO] [stderr]     | |__________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 694 |                       row.push(cell!(worker.applications.get(id).and_then(|app| app.data.get(metric))
[INFO] [stderr] 695 |                                      .map(|value| format!("{:?}", value)).unwrap_or_default()));
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/command.rs:725:40
[INFO] [stderr]     |
[INFO] [stderr] 725 |                           row.push(cell!(worker.applications.get(id).and_then(|app| app.backends.get(backend))
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 726 | |                                        .and_then(|back| back.get(metric))
[INFO] [stderr] 727 | |                                        .map(|value| format!("{:?}", value)).unwrap_or(String::new())));
[INFO] [stderr]     | |____________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 725 |                         row.push(cell!(worker.applications.get(id).and_then(|app| app.backends.get(backend))
[INFO] [stderr] 726 |                                        .and_then(|back| back.get(metric))
[INFO] [stderr] 727 |                                        .map(|value| format!("{:?}", value)).unwrap_or_default()));
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/command.rs:746:1
[INFO] [stderr]     |
[INFO] [stderr] 746 | / pub fn add_application(channel: Channel<CommandRequest,CommandResponse>, timeout: u64, app_id: &str, sticky_session: bool, https_redirect: bool, send_proxy: bool, expect_proxy: bool, load_balancing_policy: LoadBalancingAlgorithms) {
[INFO] [stderr] 747 | |   let proxy_protocol = match (send_proxy, expect_proxy) {
[INFO] [stderr] 748 | |     (true, true) => Some(ProxyProtocolConfig::RelayHeader),
[INFO] [stderr] 749 | |     (true, false) => Some(ProxyProtocolConfig::SendHeader),
[INFO] [stderr] ...   |
[INFO] [stderr] 761 | |   }));
[INFO] [stderr] 762 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 42
[INFO] [stderr]     --> src/command.rs:882:1
[INFO] [stderr]      |
[INFO] [stderr] 882  | / pub fn query_application(mut channel: Channel<CommandRequest,CommandResponse>, json: bool, application_id: Option<String>, domain: Option<String>) {
[INFO] [stderr] 883  | |   if application_id.is_some() && domain.is_some() {
[INFO] [stderr] 884  | |     eprintln!("Error: Either request an application ID or a domain name");
[INFO] [stderr] 885  | |     exit(1);
[INFO] [stderr] ...    |
[INFO] [stderr] 1155 | |   }
[INFO] [stderr] 1156 | | }
[INFO] [stderr]      | |_^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/command.rs:891:50
[INFO] [stderr]     |
[INFO] [stderr] 891 |     let splitted: Vec<String> = domain.splitn(2, "/").map(|elem| elem.to_string()).collect();
[INFO] [stderr]     |                                                  ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/command.rs:893:8
[INFO] [stderr]     |
[INFO] [stderr] 893 |     if splitted.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `splitted.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/command.rs:972:17
[INFO] [stderr]     |
[INFO] [stderr] 972 | /                 if let &QueryAnswer::Applications(ref apps) = *metrics {
[INFO] [stderr] 973 | |                   for app in apps.iter() {
[INFO] [stderr] 974 | |                     let mut entry = application_data.entry(app).or_insert(Vec::new());
[INFO] [stderr] 975 | |                     entry.push((*key).clone());
[INFO] [stderr] ...   |
[INFO] [stderr] 996 | |                   }
[INFO] [stderr] 997 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 972 |                 if let QueryAnswer::Applications(ref apps) = *(*metrics) {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:974:65
[INFO] [stderr]     |
[INFO] [stderr] 974 |                     let mut entry = application_data.entry(app).or_insert(Vec::new());
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:978:69
[INFO] [stderr]     |
[INFO] [stderr] 978 |                       let mut entry = frontend_data.entry(frontend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:983:75
[INFO] [stderr]     |
[INFO] [stderr] 983 |                       let mut entry = https_frontend_data.entry(frontend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:988:73
[INFO] [stderr]     |
[INFO] [stderr] 988 |                       let mut entry = tcp_frontend_data.entry(frontend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:207:12
[INFO] [stderr]     |
[INFO] [stderr] 207 |         if &id != &message.id {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 207 |         if id != message.id {
[INFO] [stderr]     |            ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:993:67
[INFO] [stderr]     |
[INFO] [stderr] 993 |                       let mut entry = backend_data.entry(backend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:255:18
[INFO] [stderr]     |
[INFO] [stderr] 255 |               if &id == &message.id {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 255 |               if id == message.id {
[INFO] [stderr]     |                  ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]     --> src/command.rs:1004:82
[INFO] [stderr]      |
[INFO] [stderr] 1004 |                 row.push(cell!(key.configuration.clone().map(|conf| conf.app_id).unwrap_or(String::from(""))));
[INFO] [stderr]      |                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]     --> src/command.rs:1110:19
[INFO] [stderr]      |
[INFO] [stderr] 1110 |               for ref key in data.keys() {
[INFO] [stderr]      |                   ^^^^^^^    ----------- help: try: `let key = &data.keys();`
[INFO] [stderr]      |
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/command.rs:301:17
[INFO] [stderr]     |
[INFO] [stderr] 301 |             for ref worker in workers.iter() {
[INFO] [stderr]     |                 ^^^^^^^^^^    -------------- help: try: `let worker = &workers.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]     --> src/command.rs:1118:19
[INFO] [stderr]      |
[INFO] [stderr] 1118 |               for ref metrics in data.values() {
[INFO] [stderr]      |                   ^^^^^^^^^^^    ------------- help: try: `let metrics = &data.values();`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]     --> src/command.rs:1120:17
[INFO] [stderr]      |
[INFO] [stderr] 1120 | /                 if let &QueryAnswer::ApplicationsHashes(ref apps) = *metrics {
[INFO] [stderr] 1121 | |                   for (ref key, ref value) in apps.iter() {
[INFO] [stderr] 1122 | |                     (*(query_data.entry((*key).clone()).or_insert(Vec::new()))).push(*value);
[INFO] [stderr] 1123 | |                   }
[INFO] [stderr] 1124 | |                 }
[INFO] [stderr]      | |_________________^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]      |
[INFO] [stderr] 1120 |                 if let QueryAnswer::ApplicationsHashes(ref apps) = *(*metrics) {
[INFO] [stderr]      |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]     --> src/command.rs:1122:57
[INFO] [stderr]      |
[INFO] [stderr] 1122 |                     (*(query_data.entry((*key).clone()).or_insert(Vec::new()))).push(*value);
[INFO] [stderr]      |                                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:324:22
[INFO] [stderr]     |
[INFO] [stderr] 324 |                   if &id != &message.id {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 324 |                   if id != message.id {
[INFO] [stderr]     |                      ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:399:18
[INFO] [stderr]     |
[INFO] [stderr] 399 |               if &id == &message.id {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 399 |               if id == message.id {
[INFO] [stderr]     |                  ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/command.rs:457:17
[INFO] [stderr]     |
[INFO] [stderr] 457 |             for ref worker in workers.iter().filter(|worker| worker.run_state == RunState::Running) {
[INFO] [stderr]     |                 ^^^^^^^^^^    --------------------------------------------------------------------- help: try: `let worker = &workers.iter().filter(|worker| worker.run_state == RunState::Running);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/command.rs:557:19
[INFO] [stderr]     |
[INFO] [stderr] 557 |               for ref worker in workers.iter() {
[INFO] [stderr]     |                   ^^^^^^^^^^    -------------- help: try: `let worker = &workers.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/command.rs:571:1
[INFO] [stderr]     |
[INFO] [stderr] 571 | / pub fn metrics(mut channel: Channel<CommandRequest,CommandResponse>, json: bool) {
[INFO] [stderr] 572 | |   let id = generate_id();
[INFO] [stderr] 573 | |   //println!("will send message for metrics with id {}", id);
[INFO] [stderr] 574 | |   channel.write_message(&CommandRequest::new(
[INFO] [stderr] ...   |
[INFO] [stderr] 743 | |   }
[INFO] [stderr] 744 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/command.rs:601:16
[INFO] [stderr]     |
[INFO] [stderr] 601 |             if &id == &message.id {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 601 |             if id == message.id {
[INFO] [stderr]     |                ^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]     --> src/command.rs:1313:7
[INFO] [stderr]      |
[INFO] [stderr] 1313 |   for ref key in data.keys() {
[INFO] [stderr]      |       ^^^^^^^    ----------- help: try: `let key = &data.keys();`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/command.rs:647:36
[INFO] [stderr]     |
[INFO] [stderr] 647 |                       row.push(cell!(data.workers[wk].proxy.get(k)
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 648 | |                                    .map(|value| format!("{:?}", value)).unwrap_or(String::new())));
[INFO] [stderr]     | |________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 647 |                     row.push(cell!(data.workers[wk].proxy.get(k)
[INFO] [stderr] 648 |                                    .map(|value| format!("{:?}", value)).unwrap_or_default()));
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/command.rs:694:38
[INFO] [stderr]     |
[INFO] [stderr] 694 |                         row.push(cell!(worker.applications.get(id).and_then(|app| app.data.get(metric))
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 695 | |                                      .map(|value| format!("{:?}", value)).unwrap_or(String::new())));
[INFO] [stderr]     | |__________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 694 |                       row.push(cell!(worker.applications.get(id).and_then(|app| app.data.get(metric))
[INFO] [stderr] 695 |                                      .map(|value| format!("{:?}", value)).unwrap_or_default()));
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/command.rs:725:40
[INFO] [stderr]     |
[INFO] [stderr] 725 |                           row.push(cell!(worker.applications.get(id).and_then(|app| app.backends.get(backend))
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 726 | |                                        .and_then(|back| back.get(metric))
[INFO] [stderr] 727 | |                                        .map(|value| format!("{:?}", value)).unwrap_or(String::new())));
[INFO] [stderr]     | |____________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 725 |                         row.push(cell!(worker.applications.get(id).and_then(|app| app.backends.get(backend))
[INFO] [stderr] 726 |                                        .and_then(|back| back.get(metric))
[INFO] [stderr] 727 |                                        .map(|value| format!("{:?}", value)).unwrap_or_default()));
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/command.rs:746:1
[INFO] [stderr]     |
[INFO] [stderr] 746 | / pub fn add_application(channel: Channel<CommandRequest,CommandResponse>, timeout: u64, app_id: &str, sticky_session: bool, https_redirect: bool, send_proxy: bool, expect_proxy: bool, load_balancing_policy: LoadBalancingAlgorithms) {
[INFO] [stderr] 747 | |   let proxy_protocol = match (send_proxy, expect_proxy) {
[INFO] [stderr] 748 | |     (true, true) => Some(ProxyProtocolConfig::RelayHeader),
[INFO] [stderr] 749 | |     (true, false) => Some(ProxyProtocolConfig::SendHeader),
[INFO] [stderr] ...   |
[INFO] [stderr] 761 | |   }));
[INFO] [stderr] 762 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 42
[INFO] [stderr]     --> src/command.rs:882:1
[INFO] [stderr]      |
[INFO] [stderr] 882  | / pub fn query_application(mut channel: Channel<CommandRequest,CommandResponse>, json: bool, application_id: Option<String>, domain: Option<String>) {
[INFO] [stderr] 883  | |   if application_id.is_some() && domain.is_some() {
[INFO] [stderr] 884  | |     eprintln!("Error: Either request an application ID or a domain name");
[INFO] [stderr] 885  | |     exit(1);
[INFO] [stderr] ...    |
[INFO] [stderr] 1155 | |   }
[INFO] [stderr] 1156 | | }
[INFO] [stderr]      | |_^
[INFO] [stderr]      |
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/command.rs:891:50
[INFO] [stderr]     |
[INFO] [stderr] 891 |     let splitted: Vec<String> = domain.splitn(2, "/").map(|elem| elem.to_string()).collect();
[INFO] [stderr]     |                                                  ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/command.rs:893:8
[INFO] [stderr]     |
[INFO] [stderr] 893 |     if splitted.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `splitted.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/command.rs:972:17
[INFO] [stderr]     |
[INFO] [stderr] 972 | /                 if let &QueryAnswer::Applications(ref apps) = *metrics {
[INFO] [stderr] 973 | |                   for app in apps.iter() {
[INFO] [stderr] 974 | |                     let mut entry = application_data.entry(app).or_insert(Vec::new());
[INFO] [stderr] 975 | |                     entry.push((*key).clone());
[INFO] [stderr] ...   |
[INFO] [stderr] 996 | |                   }
[INFO] [stderr] 997 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 972 |                 if let QueryAnswer::Applications(ref apps) = *(*metrics) {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:974:65
[INFO] [stderr]     |
[INFO] [stderr] 974 |                     let mut entry = application_data.entry(app).or_insert(Vec::new());
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:978:69
[INFO] [stderr]     |
[INFO] [stderr] 978 |                       let mut entry = frontend_data.entry(frontend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:983:75
[INFO] [stderr]     |
[INFO] [stderr] 983 |                       let mut entry = https_frontend_data.entry(frontend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:988:73
[INFO] [stderr]     |
[INFO] [stderr] 988 |                       let mut entry = tcp_frontend_data.entry(frontend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/command.rs:993:67
[INFO] [stderr]     |
[INFO] [stderr] 993 |                       let mut entry = backend_data.entry(backend).or_insert(Vec::new());
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]     --> src/command.rs:1004:82
[INFO] [stderr]      |
[INFO] [stderr] 1004 |                 row.push(cell!(key.configuration.clone().map(|conf| conf.app_id).unwrap_or(String::from(""))));
[INFO] [stderr]      |                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]     --> src/command.rs:1110:19
[INFO] [stderr]      |
[INFO] [stderr] 1110 |               for ref key in data.keys() {
[INFO] [stderr]      |                   ^^^^^^^    ----------- help: try: `let key = &data.keys();`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]     --> src/command.rs:1118:19
[INFO] [stderr]      |
[INFO] [stderr] 1118 |               for ref metrics in data.values() {
[INFO] [stderr]      |                   ^^^^^^^^^^^    ------------- help: try: `let metrics = &data.values();`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]     --> src/command.rs:1120:17
[INFO] [stderr]      |
[INFO] [stderr] 1120 | /                 if let &QueryAnswer::ApplicationsHashes(ref apps) = *metrics {
[INFO] [stderr] 1121 | |                   for (ref key, ref value) in apps.iter() {
[INFO] [stderr] 1122 | |                     (*(query_data.entry((*key).clone()).or_insert(Vec::new()))).push(*value);
[INFO] [stderr] 1123 | |                   }
[INFO] [stderr] 1124 | |                 }
[INFO] [stderr]      | |_________________^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]      |
[INFO] [stderr] 1120 |                 if let QueryAnswer::ApplicationsHashes(ref apps) = *(*metrics) {
[INFO] [stderr]      |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]     --> src/command.rs:1122:57
[INFO] [stderr]      |
[INFO] [stderr] 1122 |                     (*(query_data.entry((*key).clone()).or_insert(Vec::new()))).push(*value);
[INFO] [stderr]      |                                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]     --> src/command.rs:1313:7
[INFO] [stderr]      |
[INFO] [stderr] 1313 |   for ref key in data.keys() {
[INFO] [stderr]      |       ^^^^^^^    ----------- help: try: `let key = &data.keys();`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:81:86
[INFO] [stderr]    |
[INFO] [stderr] 81 |             add_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), false)
[INFO] [stderr]    |                                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:84:89
[INFO] [stderr]    |
[INFO] [stderr] 84 |             remove_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), false)
[INFO] [stderr]    |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:89:86
[INFO] [stderr]    |
[INFO] [stderr] 89 |             add_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), true)
[INFO] [stderr]    |                                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:92:89
[INFO] [stderr]    |
[INFO] [stderr] 92 |             remove_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), true)
[INFO] [stderr]    |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:81:86
[INFO] [stderr]    |
[INFO] [stderr] 81 |             add_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), false)
[INFO] [stderr]    |                                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:84:89
[INFO] [stderr]    |
[INFO] [stderr] 84 |             remove_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), false)
[INFO] [stderr]    |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:89:86
[INFO] [stderr]    |
[INFO] [stderr] 89 |             add_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), true)
[INFO] [stderr]    |                                                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:92:89
[INFO] [stderr]    |
[INFO] [stderr] 92 |             remove_http_frontend(channel, timeout, &id, address, &hostname, &path_begin.unwrap_or("".to_string()), true)
[INFO] [stderr]    |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 25.26s
[INFO] running `"docker" "inspect" "1e3499fc411dd15e3c43814b5d2db58f49b61d64c5f91aadc7d573533cd266b1"`
[INFO] running `"docker" "rm" "-f" "1e3499fc411dd15e3c43814b5d2db58f49b61d64c5f91aadc7d573533cd266b1"`
[INFO] [stdout] 1e3499fc411dd15e3c43814b5d2db58f49b61d64c5f91aadc7d573533cd266b1