[INFO] crate sozu-command-futures 0.11.0 is already in cache [INFO] extracting crate sozu-command-futures 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/sozu-command-futures/0.11.0 [INFO] extracting crate sozu-command-futures 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sozu-command-futures/0.11.0 [INFO] validating manifest of sozu-command-futures-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sozu-command-futures-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sozu-command-futures-0.11.0 [INFO] finished frobbing sozu-command-futures-0.11.0 [INFO] frobbed toml for sozu-command-futures-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/sozu-command-futures/0.11.0/Cargo.toml [INFO] started frobbing sozu-command-futures-0.11.0 [INFO] finished frobbing sozu-command-futures-0.11.0 [INFO] frobbed toml for sozu-command-futures-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sozu-command-futures/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sozu-command-futures-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sozu-command-futures/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 849769b55e1d99f6d4de5296ed6b37af2412a9820f6861073c83251d195a8830 [INFO] running `"docker" "start" "-a" "849769b55e1d99f6d4de5296ed6b37af2412a9820f6861073c83251d195a8830"` [INFO] [stderr] Checking pool v0.1.4 [INFO] [stderr] Checking pem v0.5.1 [INFO] [stderr] Checking sozu-command-lib v0.11.0 [INFO] [stderr] Checking sozu-command-futures v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | let res = transport.upstream.poll_complete(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:140:36 [INFO] [stderr] | [INFO] [stderr] 140 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 141 | | if message.status == CommandStatus::Processing { [INFO] [stderr] 142 | | info!("processing: {:?}", message); [INFO] [stderr] 143 | | Ok(Async::NotReady) [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | } else if message.status == CommandStatus::Processing { [INFO] [stderr] 141 | info!("processing: {:?}", message); [INFO] [stderr] 142 | Ok(Async::NotReady) [INFO] [stderr] 143 | } else { [INFO] [stderr] 144 | Ok(Async::Ready(message)) [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | let res = transport.upstream.poll_complete(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:140:36 [INFO] [stderr] | [INFO] [stderr] 140 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 141 | | if message.status == CommandStatus::Processing { [INFO] [stderr] 142 | | info!("processing: {:?}", message); [INFO] [stderr] 143 | | Ok(Async::NotReady) [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | } else if message.status == CommandStatus::Processing { [INFO] [stderr] 141 | info!("processing: {:?}", message); [INFO] [stderr] 142 | Ok(Async::NotReady) [INFO] [stderr] 143 | } else { [INFO] [stderr] 144 | Ok(Async::Ready(message)) [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:109:66 [INFO] [stderr] | [INFO] [stderr] 109 | Err(Error::new(ErrorKind::ConnectionAborted, format!("could not send message"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send message".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:131:44 [INFO] [stderr] | [INFO] [stderr] 131 | return Err(From::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `From::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:155:70 [INFO] [stderr] | [INFO] [stderr] 155 | Error::new(ErrorKind::ConnectionAborted, format!("could not send message")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send message".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:164:58 [INFO] [stderr] | [INFO] [stderr] 164 | Error::new(ErrorKind::ConnectionAborted, format!("could not send message")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send message".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:109:66 [INFO] [stderr] | [INFO] [stderr] 109 | Err(Error::new(ErrorKind::ConnectionAborted, format!("could not send message"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send message".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:131:44 [INFO] [stderr] | [INFO] [stderr] 131 | return Err(From::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `From::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:155:70 [INFO] [stderr] | [INFO] [stderr] 155 | Error::new(ErrorKind::ConnectionAborted, format!("could not send message")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send message".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:164:58 [INFO] [stderr] | [INFO] [stderr] 164 | Error::new(ErrorKind::ConnectionAborted, format!("could not send message")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send message".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.74s [INFO] running `"docker" "inspect" "849769b55e1d99f6d4de5296ed6b37af2412a9820f6861073c83251d195a8830"` [INFO] running `"docker" "rm" "-f" "849769b55e1d99f6d4de5296ed6b37af2412a9820f6861073c83251d195a8830"` [INFO] [stdout] 849769b55e1d99f6d4de5296ed6b37af2412a9820f6861073c83251d195a8830