[INFO] crate sourcefile 0.1.4 is already in cache [INFO] extracting crate sourcefile 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/sourcefile/0.1.4 [INFO] extracting crate sourcefile 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sourcefile/0.1.4 [INFO] validating manifest of sourcefile-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sourcefile-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sourcefile-0.1.4 [INFO] finished frobbing sourcefile-0.1.4 [INFO] frobbed toml for sourcefile-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/sourcefile/0.1.4/Cargo.toml [INFO] started frobbing sourcefile-0.1.4 [INFO] finished frobbing sourcefile-0.1.4 [INFO] frobbed toml for sourcefile-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sourcefile/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sourcefile-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sourcefile/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d803cc966dbc456a2fc4d3d5fb7debb74fbb9fa5074fd284cfabe7fc212057a [INFO] running `"docker" "start" "-a" "1d803cc966dbc456a2fc4d3d5fb7debb74fbb9fa5074fd284cfabe7fc212057a"` [INFO] [stderr] Checking sourcefile v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn resolve_offset<'a>(&'a self, offset: usize) -> Option> { [INFO] [stderr] 63 | | // If there isn't a single line, always return None. [INFO] [stderr] 64 | | let mut line_acc = *self.line_lengths.get(0)?; [INFO] [stderr] 65 | | let mut line_idx = 0; [INFO] [stderr] ... | [INFO] [stderr] 84 | | Some(Position::new(&self.file_names[file_idx], line_idx - file_acc, offset - line_acc)) [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn resolve_offset_span<'a>(&'a self, start: usize, end: usize) -> Option> { [INFO] [stderr] 91 | | if end < start { [INFO] [stderr] 92 | | return None; [INFO] [stderr] 93 | | } [INFO] [stderr] ... | [INFO] [stderr] 97 | | }) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | Position { filename: filename.as_ref(), line, col } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn resolve_offset<'a>(&'a self, offset: usize) -> Option> { [INFO] [stderr] 63 | | // If there isn't a single line, always return None. [INFO] [stderr] 64 | | let mut line_acc = *self.line_lengths.get(0)?; [INFO] [stderr] 65 | | let mut line_idx = 0; [INFO] [stderr] ... | [INFO] [stderr] 84 | | Some(Position::new(&self.file_names[file_idx], line_idx - file_acc, offset - line_acc)) [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn resolve_offset_span<'a>(&'a self, start: usize, end: usize) -> Option> { [INFO] [stderr] 91 | | if end < start { [INFO] [stderr] 92 | | return None; [INFO] [stderr] 93 | | } [INFO] [stderr] ... | [INFO] [stderr] 97 | | }) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | Position { filename: filename.as_ref(), line, col } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:166:19 [INFO] [stderr] | [INFO] [stderr] 166 | fn test_files<'a>(files: &[impl AsRef], [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:169:42 [INFO] [stderr] | [INFO] [stderr] 169 | offset_span_tests: &[((usize, usize), [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 170 | | (usize, usize, usize), [INFO] [stderr] 171 | | (usize, usize, usize))]) [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.76s [INFO] running `"docker" "inspect" "1d803cc966dbc456a2fc4d3d5fb7debb74fbb9fa5074fd284cfabe7fc212057a"` [INFO] running `"docker" "rm" "-f" "1d803cc966dbc456a2fc4d3d5fb7debb74fbb9fa5074fd284cfabe7fc212057a"` [INFO] [stdout] 1d803cc966dbc456a2fc4d3d5fb7debb74fbb9fa5074fd284cfabe7fc212057a