[INFO] crate source-map-mappings-wasm-api 0.5.0 is already in cache [INFO] extracting crate source-map-mappings-wasm-api 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/source-map-mappings-wasm-api/0.5.0 [INFO] extracting crate source-map-mappings-wasm-api 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/source-map-mappings-wasm-api/0.5.0 [INFO] validating manifest of source-map-mappings-wasm-api-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of source-map-mappings-wasm-api-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing source-map-mappings-wasm-api-0.5.0 [INFO] finished frobbing source-map-mappings-wasm-api-0.5.0 [INFO] frobbed toml for source-map-mappings-wasm-api-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/source-map-mappings-wasm-api/0.5.0/Cargo.toml [INFO] started frobbing source-map-mappings-wasm-api-0.5.0 [INFO] finished frobbing source-map-mappings-wasm-api-0.5.0 [INFO] frobbed toml for source-map-mappings-wasm-api-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/source-map-mappings-wasm-api/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting source-map-mappings-wasm-api-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/source-map-mappings-wasm-api/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31795c57e3eba7f9de59bc0d622f4d1b252d4699591ff992b9aecd96766323d9 [INFO] running `"docker" "start" "-a" "31795c57e3eba7f9de59bc0d622f4d1b252d4699591ff992b9aecd96766323d9"` [INFO] [stderr] Checking vlq v0.5.1 [INFO] [stderr] Checking source-map-mappings v0.5.0 [INFO] [stderr] Checking source-map-mappings-wasm-api v0.5.0 (/opt/crater/workdir) [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut usize`) [INFO] [stderr] --> src/lib.rs:197:20 [INFO] [stderr] | [INFO] [stderr] 197 | let mappings = mappings as *mut usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:242:23 [INFO] [stderr] | [INFO] [stderr] 242 | Box::from_raw(mappings); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:250:6 [INFO] [stderr] | [INFO] [stderr] 250 | ) -> &'a mut Mappings { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | _scope: &'a (), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:329:55 [INFO] [stderr] | [INFO] [stderr] 329 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:328:5 [INFO] [stderr] | [INFO] [stderr] 328 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:343:55 [INFO] [stderr] | [INFO] [stderr] 343 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:354:55 [INFO] [stderr] | [INFO] [stderr] 354 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:392:55 [INFO] [stderr] | [INFO] [stderr] 392 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:391:5 [INFO] [stderr] | [INFO] [stderr] 391 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:415:55 [INFO] [stderr] | [INFO] [stderr] 415 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:443:55 [INFO] [stderr] | [INFO] [stderr] 443 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `source-map-mappings-wasm-api`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut usize`) [INFO] [stderr] --> src/lib.rs:197:20 [INFO] [stderr] | [INFO] [stderr] 197 | let mappings = mappings as *mut usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:242:23 [INFO] [stderr] | [INFO] [stderr] 242 | Box::from_raw(mappings); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:250:6 [INFO] [stderr] | [INFO] [stderr] 250 | ) -> &'a mut Mappings { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | _scope: &'a (), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:329:55 [INFO] [stderr] | [INFO] [stderr] 329 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:328:5 [INFO] [stderr] | [INFO] [stderr] 328 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:343:55 [INFO] [stderr] | [INFO] [stderr] 343 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:354:55 [INFO] [stderr] | [INFO] [stderr] 354 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:392:55 [INFO] [stderr] | [INFO] [stderr] 392 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:391:5 [INFO] [stderr] | [INFO] [stderr] 391 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:415:55 [INFO] [stderr] | [INFO] [stderr] 415 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:443:55 [INFO] [stderr] | [INFO] [stderr] 443 | let mappings = unsafe { mappings_mut(&this_scope, mappings) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let this_scope =` [INFO] [stderr] --> src/lib.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | let this_scope = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `source-map-mappings-wasm-api`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "31795c57e3eba7f9de59bc0d622f4d1b252d4699591ff992b9aecd96766323d9"` [INFO] running `"docker" "rm" "-f" "31795c57e3eba7f9de59bc0d622f4d1b252d4699591ff992b9aecd96766323d9"` [INFO] [stdout] 31795c57e3eba7f9de59bc0d622f4d1b252d4699591ff992b9aecd96766323d9