[INFO] crate soup 0.3.0 is already in cache [INFO] extracting crate soup 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/soup/0.3.0 [INFO] extracting crate soup 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/soup/0.3.0 [INFO] validating manifest of soup-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of soup-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing soup-0.3.0 [INFO] finished frobbing soup-0.3.0 [INFO] frobbed toml for soup-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/soup/0.3.0/Cargo.toml [INFO] started frobbing soup-0.3.0 [INFO] finished frobbing soup-0.3.0 [INFO] frobbed toml for soup-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/soup/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting soup-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/soup/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c20a52833c5d47da6c43260bad3fe7a7f06137a5027e2bb02155d372a3e5c5ef [INFO] running `"docker" "start" "-a" "c20a52833c5d47da6c43260bad3fe7a7f06137a5027e2bb02155d372a3e5c5ef"` [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Checking string_cache v0.7.3 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking soup v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/attribute.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 48 | | if attr_value.matches(v) { [INFO] [stderr] 49 | | return true; [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | } else if attr_value.matches(v) { [INFO] [stderr] 48 | return true; [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/attribute.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 48 | | if attr_value.matches(v) { [INFO] [stderr] 49 | | return true; [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | } else if attr_value.matches(v) { [INFO] [stderr] 48 | return true; [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:288:30 [INFO] [stderr] | [INFO] [stderr] 288 | const TEST_HTML_STRING: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / match node.data { [INFO] [stderr] 37 | | NodeData::Element { ref name, ref attrs, ..} => { [INFO] [stderr] 38 | | let attrs = attrs.borrow(); [INFO] [stderr] 39 | | for attr in attrs.iter() { [INFO] [stderr] ... | [INFO] [stderr] 55 | | _ => (), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | if let NodeData::Element { ref name, ref attrs, ..} = node.data { [INFO] [stderr] 37 | let attrs = attrs.borrow(); [INFO] [stderr] 38 | for attr in attrs.iter() { [INFO] [stderr] 39 | let k = attr.name.local.as_ref(); [INFO] [stderr] 40 | let v = attr.value.as_ref(); [INFO] [stderr] 41 | if attr_name.matches(k) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node_ext.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / match node.data { [INFO] [stderr] 150 | | NodeData::Text { [INFO] [stderr] 151 | | ref contents, .. [INFO] [stderr] 152 | | } => result.push(contents.borrow().to_string()), [INFO] [stderr] 153 | | _ => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 149 | if let NodeData::Text { [INFO] [stderr] 150 | ref contents, .. [INFO] [stderr] 151 | } = node.data { result.push(contents.borrow().to_string()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/attribute.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / match node.data { [INFO] [stderr] 37 | | NodeData::Element { ref name, ref attrs, ..} => { [INFO] [stderr] 38 | | let attrs = attrs.borrow(); [INFO] [stderr] 39 | | for attr in attrs.iter() { [INFO] [stderr] ... | [INFO] [stderr] 55 | | _ => (), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | if let NodeData::Element { ref name, ref attrs, ..} = node.data { [INFO] [stderr] 37 | let attrs = attrs.borrow(); [INFO] [stderr] 38 | for attr in attrs.iter() { [INFO] [stderr] 39 | let k = attr.name.local.as_ref(); [INFO] [stderr] 40 | let v = attr.value.as_ref(); [INFO] [stderr] 41 | if attr_name.matches(k) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node_ext.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / match node.data { [INFO] [stderr] 150 | | NodeData::Text { [INFO] [stderr] 151 | | ref contents, .. [INFO] [stderr] 152 | | } => result.push(contents.borrow().to_string()), [INFO] [stderr] 153 | | _ => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 149 | if let NodeData::Text { [INFO] [stderr] 150 | ref contents, .. [INFO] [stderr] 151 | } = node.data { result.push(contents.borrow().to_string()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/soup.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | const THREE_SISTERS: &'static str = include_str!("data/three_sisters.html"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> tests/soup.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | for (i, tag) in soup.tag(Regex::new("^b").unwrap()).find_all().enumerate() { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/soup.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | let foo = soup.attr("class", "foo").find().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/soup.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let bar = soup.attr("class", "bar").find().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> tests/soup.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | let baz = soup.attr("id", "baz").find(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.67s [INFO] running `"docker" "inspect" "c20a52833c5d47da6c43260bad3fe7a7f06137a5027e2bb02155d372a3e5c5ef"` [INFO] running `"docker" "rm" "-f" "c20a52833c5d47da6c43260bad3fe7a7f06137a5027e2bb02155d372a3e5c5ef"` [INFO] [stdout] c20a52833c5d47da6c43260bad3fe7a7f06137a5027e2bb02155d372a3e5c5ef