[INFO] crate sounding-analysis 0.9.3 is already in cache [INFO] extracting crate sounding-analysis 0.9.3 into work/ex/clippy-test-run/sources/stable/reg/sounding-analysis/0.9.3 [INFO] extracting crate sounding-analysis 0.9.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sounding-analysis/0.9.3 [INFO] validating manifest of sounding-analysis-0.9.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sounding-analysis-0.9.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sounding-analysis-0.9.3 [INFO] finished frobbing sounding-analysis-0.9.3 [INFO] frobbed toml for sounding-analysis-0.9.3 written to work/ex/clippy-test-run/sources/stable/reg/sounding-analysis/0.9.3/Cargo.toml [INFO] started frobbing sounding-analysis-0.9.3 [INFO] finished frobbing sounding-analysis-0.9.3 [INFO] frobbed toml for sounding-analysis-0.9.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sounding-analysis/0.9.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sounding-analysis-0.9.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sounding-analysis/0.9.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5fc2484bee966643ef5679f7e6520ca46a0dbd0902fa29c84ad79e89055ce7e [INFO] running `"docker" "start" "-a" "b5fc2484bee966643ef5679f7e6520ca46a0dbd0902fa29c84ad79e89055ce7e"` [INFO] [stderr] Checking metfor v0.4.1 [INFO] [stderr] Checking optional v0.5.0 [INFO] [stderr] Checking sounding-base v0.8.1 [INFO] [stderr] Checking sounding-analysis v0.9.3 (/opt/crater/workdir) [INFO] [stderr] Checking sounding-validate v0.8.1 [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/layers.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/layers.rs:50:48 [INFO] [stderr] | [INFO] [stderr] 50 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/layers.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parcel_profile.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | / let mut lcl_data = None; [INFO] [stderr] 238 | | // Check to see if we are passing the lcl [INFO] [stderr] 239 | | if p0 > lcl_pressure && p < lcl_pressure { [INFO] [stderr] 240 | | lcl_data = Some(( [INFO] [stderr] ... | [INFO] [stderr] 245 | | )); [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 237 | let lcl_data = if p0 > lcl_pressure && p < lcl_pressure { Some(( [INFO] [stderr] 238 | lcl_pressure, [INFO] [stderr] 239 | lcl_height, [INFO] [stderr] 240 | metfor::virtual_temperature_c(lcl_temperature, lcl_temperature, lcl_pressure)?, [INFO] [stderr] 241 | metfor::virtual_temperature_c(lcl_env_temperature, lcl_env_dp, lcl_pressure)?, [INFO] [stderr] 242 | )) } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parcel_profile.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | / let mut prof_cross_data = None; [INFO] [stderr] 249 | | // Check to see if the parcel and environment soundings have crossed [INFO] [stderr] 250 | | if (pcl_t0 < env_t0 && pcl_t > env_t) || (pcl_t0 > env_t0 && pcl_t < env_t) { [INFO] [stderr] 251 | | let tgt_pres = linear_interp(0.0, pcl_t - env_t, pcl_t0 - env_t0, p, p0); [INFO] [stderr] ... | [INFO] [stderr] 255 | | prof_cross_data = Some((tgt_pres, h2, env_t2, env_t2)); [INFO] [stderr] 256 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let prof_cross_data = if (pcl_t0 < env_t0 && pcl_t > env_t) || (pcl_t0 > env_t0 && pcl_t < env_t) { ..; Some((tgt_pres, h2, env_t2, env_t2)) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/layers.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/layers.rs:50:48 [INFO] [stderr] | [INFO] [stderr] 50 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/layers.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parcel_profile.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | / let mut lcl_data = None; [INFO] [stderr] 238 | | // Check to see if we are passing the lcl [INFO] [stderr] 239 | | if p0 > lcl_pressure && p < lcl_pressure { [INFO] [stderr] 240 | | lcl_data = Some(( [INFO] [stderr] ... | [INFO] [stderr] 245 | | )); [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 237 | let lcl_data = if p0 > lcl_pressure && p < lcl_pressure { Some(( [INFO] [stderr] 238 | lcl_pressure, [INFO] [stderr] 239 | lcl_height, [INFO] [stderr] 240 | metfor::virtual_temperature_c(lcl_temperature, lcl_temperature, lcl_pressure)?, [INFO] [stderr] 241 | metfor::virtual_temperature_c(lcl_env_temperature, lcl_env_dp, lcl_pressure)?, [INFO] [stderr] 242 | )) } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parcel_profile.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | / let mut prof_cross_data = None; [INFO] [stderr] 249 | | // Check to see if the parcel and environment soundings have crossed [INFO] [stderr] 250 | | if (pcl_t0 < env_t0 && pcl_t > env_t) || (pcl_t0 > env_t0 && pcl_t < env_t) { [INFO] [stderr] 251 | | let tgt_pres = linear_interp(0.0, pcl_t - env_t, pcl_t0 - env_t0, p, p0); [INFO] [stderr] ... | [INFO] [stderr] 255 | | prof_cross_data = Some((tgt_pres, h2, env_t2, env_t2)); [INFO] [stderr] 256 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let prof_cross_data = if (pcl_t0 < env_t0 && pcl_t > env_t) || (pcl_t0 > env_t0 && pcl_t < env_t) { ..; Some((tgt_pres, h2, env_t2, env_t2)) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/utils/level_tests.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | assert!(level_pressures.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!level_pressures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/utils/mod.rs:319:38 [INFO] [stderr] | [INFO] [stderr] 319 | let mut f = File::open(location).expect(&format!("Error opening file: {:#?}", location)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error opening file: {:#?}", location))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/utils/mod.rs:323:10 [INFO] [stderr] | [INFO] [stderr] 323 | .expect(&format!("Error reading file: {:#?}", location)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading file: {:#?}", location))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/utils/mod.rs:458:12 [INFO] [stderr] | [INFO] [stderr] 458 | if tokens.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/utils/level_tests.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | assert!(level_pressures.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!level_pressures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/utils/mod.rs:319:38 [INFO] [stderr] | [INFO] [stderr] 319 | let mut f = File::open(location).expect(&format!("Error opening file: {:#?}", location)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error opening file: {:#?}", location))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/utils/mod.rs:323:10 [INFO] [stderr] | [INFO] [stderr] 323 | .expect(&format!("Error reading file: {:#?}", location)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading file: {:#?}", location))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/utils/mod.rs:458:12 [INFO] [stderr] | [INFO] [stderr] 458 | if tokens.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.93s [INFO] running `"docker" "inspect" "b5fc2484bee966643ef5679f7e6520ca46a0dbd0902fa29c84ad79e89055ce7e"` [INFO] running `"docker" "rm" "-f" "b5fc2484bee966643ef5679f7e6520ca46a0dbd0902fa29c84ad79e89055ce7e"` [INFO] [stdout] b5fc2484bee966643ef5679f7e6520ca46a0dbd0902fa29c84ad79e89055ce7e