[INFO] crate sorting 1.1.0 is already in cache [INFO] extracting crate sorting 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/sorting/1.1.0 [INFO] extracting crate sorting 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sorting/1.1.0 [INFO] validating manifest of sorting-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sorting-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sorting-1.1.0 [INFO] finished frobbing sorting-1.1.0 [INFO] frobbed toml for sorting-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/sorting/1.1.0/Cargo.toml [INFO] started frobbing sorting-1.1.0 [INFO] finished frobbing sorting-1.1.0 [INFO] frobbed toml for sorting-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sorting/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sorting-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sorting/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02595a477238a7ea56d1aecfe4a9fe3e67ffa284681fa5ee33a6e53465ac05d8 [INFO] running `"docker" "start" "-a" "02595a477238a7ea56d1aecfe4a9fe3e67ffa284681fa5ee33a6e53465ac05d8"` [INFO] [stderr] Checking sorting v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping elements of `vec` manually [INFO] [stderr] --> src/slowsort.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / let buffer = vec[m]; [INFO] [stderr] 22 | | vec[m] = vec[j]; [INFO] [stderr] 23 | | vec[j] = buffer; [INFO] [stderr] | |___________________________^ help: try: `vec.swap(m, j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bogosort.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_sorted(vec: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bogosort.rs:37:19 [INFO] [stderr] | [INFO] [stderr] 37 | while self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `vec` manually [INFO] [stderr] --> src/slowsort.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / let buffer = vec[m]; [INFO] [stderr] 22 | | vec[m] = vec[j]; [INFO] [stderr] 23 | | vec[j] = buffer; [INFO] [stderr] | |___________________________^ help: try: `vec.swap(m, j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bogosort.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_sorted(vec: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bogosort.rs:37:19 [INFO] [stderr] | [INFO] [stderr] 37 | while self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.56s [INFO] running `"docker" "inspect" "02595a477238a7ea56d1aecfe4a9fe3e67ffa284681fa5ee33a6e53465ac05d8"` [INFO] running `"docker" "rm" "-f" "02595a477238a7ea56d1aecfe4a9fe3e67ffa284681fa5ee33a6e53465ac05d8"` [INFO] [stdout] 02595a477238a7ea56d1aecfe4a9fe3e67ffa284681fa5ee33a6e53465ac05d8