[INFO] crate sorted-list 0.2.0 is already in cache [INFO] extracting crate sorted-list 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/sorted-list/0.2.0 [INFO] extracting crate sorted-list 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sorted-list/0.2.0 [INFO] validating manifest of sorted-list-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sorted-list-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sorted-list-0.2.0 [INFO] finished frobbing sorted-list-0.2.0 [INFO] frobbed toml for sorted-list-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sorted-list/0.2.0/Cargo.toml [INFO] started frobbing sorted-list-0.2.0 [INFO] finished frobbing sorted-list-0.2.0 [INFO] frobbed toml for sorted-list-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sorted-list/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sorted-list-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sorted-list/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0ebfb2e3754c9a83032a057a5c37174d8ff2a0071e85d854efb6b34edd1d366 [INFO] running `"docker" "start" "-a" "e0ebfb2e3754c9a83032a057a5c37174d8ff2a0071e85d854efb6b34edd1d366"` [INFO] [stderr] Checking sorted-list v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:561:9 [INFO] [stderr] | [INFO] [stderr] 561 | /// 1000, 100 => 4.08s (3.76s release) originally [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `SortedList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / impl SortedList { [INFO] [stderr] 41 | | /// Creates a new as small as possible `SortedList` [INFO] [stderr] 42 | | pub fn new() -> Self { [INFO] [stderr] 43 | | SortedList { keys: Vec::new(), values: Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SortedList` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Self { [INFO] [stderr] 43 | | SortedList { keys: Vec::new(), values: Vec::new() } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 175 | | Ok(pos) [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:171:43 [INFO] [stderr] | [INFO] [stderr] 171 | if pos == self.keys.len() { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 172 | | // this is off by one ... [INFO] [stderr] 173 | | Ok(pos) [INFO] [stderr] 174 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:364:19 [INFO] [stderr] | [INFO] [stderr] 364 | keys: self.keys.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 364 | keys: &(*self.keys).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 364 | keys: &std::vec::Vec::clone(self.keys), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | values: self.values.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 365 | values: &(*self.values).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 365 | values: &std::vec::Vec::clone(self.values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:378:33 [INFO] [stderr] | [INFO] [stderr] 378 | while let Some(tuple) = clone.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for tuple in clone { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sorted-list`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `SortedList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / impl SortedList { [INFO] [stderr] 41 | | /// Creates a new as small as possible `SortedList` [INFO] [stderr] 42 | | pub fn new() -> Self { [INFO] [stderr] 43 | | SortedList { keys: Vec::new(), values: Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SortedList` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Self { [INFO] [stderr] 43 | | SortedList { keys: Vec::new(), values: Vec::new() } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 175 | | Ok(pos) [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:171:43 [INFO] [stderr] | [INFO] [stderr] 171 | if pos == self.keys.len() { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 172 | | // this is off by one ... [INFO] [stderr] 173 | | Ok(pos) [INFO] [stderr] 174 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:364:19 [INFO] [stderr] | [INFO] [stderr] 364 | keys: self.keys.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 364 | keys: &(*self.keys).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 364 | keys: &std::vec::Vec::clone(self.keys), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | values: self.values.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 365 | values: &(*self.values).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 365 | values: &std::vec::Vec::clone(self.values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:378:33 [INFO] [stderr] | [INFO] [stderr] 378 | while let Some(tuple) = clone.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for tuple in clone { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sorted-list`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e0ebfb2e3754c9a83032a057a5c37174d8ff2a0071e85d854efb6b34edd1d366"` [INFO] running `"docker" "rm" "-f" "e0ebfb2e3754c9a83032a057a5c37174d8ff2a0071e85d854efb6b34edd1d366"` [INFO] [stdout] e0ebfb2e3754c9a83032a057a5c37174d8ff2a0071e85d854efb6b34edd1d366