[INFO] crate sophon-wasm 0.18.1 is already in cache [INFO] extracting crate sophon-wasm 0.18.1 into work/ex/clippy-test-run/sources/stable/reg/sophon-wasm/0.18.1 [INFO] extracting crate sophon-wasm 0.18.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sophon-wasm/0.18.1 [INFO] validating manifest of sophon-wasm-0.18.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sophon-wasm-0.18.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sophon-wasm-0.18.1 [INFO] finished frobbing sophon-wasm-0.18.1 [INFO] frobbed toml for sophon-wasm-0.18.1 written to work/ex/clippy-test-run/sources/stable/reg/sophon-wasm/0.18.1/Cargo.toml [INFO] started frobbing sophon-wasm-0.18.1 [INFO] finished frobbing sophon-wasm-0.18.1 [INFO] frobbed toml for sophon-wasm-0.18.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sophon-wasm/0.18.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sophon-wasm-0.18.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sophon-wasm/0.18.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4cdd62670a6deca57080100f04632cb8c712431d9392cb226ea203caa6ca1b38 [INFO] running `"docker" "start" "-a" "4cdd62670a6deca57080100f04632cb8c712431d9392cb226ea203caa6ca1b38"` [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking sophon-wasm v0.18.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | sections: sections, ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:225:28 [INFO] [stderr] | [INFO] [stderr] 225 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:225:40 [INFO] [stderr] | [INFO] [stderr] 225 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/primitives.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | form: form, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `form` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | elem_type: elem_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | limits: limits, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `limits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | maximum: maximum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maximum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | internal: internal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | internal: internal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | Ok(Local { count: count.into(), value_type: value_type }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | FuncBody { locals: locals, opcodes: opcodes } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | FuncBody { locals: locals, opcodes: opcodes } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `opcodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:106:23 [INFO] [stderr] | [INFO] [stderr] 106 | Ok(FuncBody { locals: locals, opcodes: opcodes }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:106:39 [INFO] [stderr] | [INFO] [stderr] 106 | Ok(FuncBody { locals: locals, opcodes: opcodes }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `opcodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:15:40 [INFO] [stderr] | [INFO] [stderr] 15 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:15:56 [INFO] [stderr] | [INFO] [stderr] 15 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | ValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | OptionalValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/global.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/data.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:588:4 [INFO] [stderr] | [INFO] [stderr] 588 | module_instance: module_instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:589:4 [INFO] [stderr] | [INFO] [stderr] 589 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:591:4 [INFO] [stderr] | [INFO] [stderr] 591 | locals: locals, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:652:4 [INFO] [stderr] | [INFO] [stderr] 652 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:653:4 [INFO] [stderr] | [INFO] [stderr] 653 | block_type: block_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/native.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:45:4 [INFO] [stderr] | [INFO] [stderr] 45 | functions: functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:46:4 [INFO] [stderr] | [INFO] [stderr] 46 | tables: tables, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | globals: globals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `globals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | maximum_size: maximum_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maximum_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:134:4 [INFO] [stderr] | [INFO] [stderr] 134 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:135:4 [INFO] [stderr] | [INFO] [stderr] 135 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:136:4 [INFO] [stderr] | [INFO] [stderr] 136 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:155:4 [INFO] [stderr] | [INFO] [stderr] 155 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:178:4 [INFO] [stderr] | [INFO] [stderr] 178 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:222:4 [INFO] [stderr] | [INFO] [stderr] 222 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:223:4 [INFO] [stderr] | [INFO] [stderr] 223 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:224:4 [INFO] [stderr] | [INFO] [stderr] 224 | imports: imports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:227:4 [INFO] [stderr] | [INFO] [stderr] 227 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:228:4 [INFO] [stderr] | [INFO] [stderr] 228 | tables: tables, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:229:4 [INFO] [stderr] | [INFO] [stderr] 229 | globals: globals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `globals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:657:4 [INFO] [stderr] | [INFO] [stderr] 657 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:970:4 [INFO] [stderr] | [INFO] [stderr] 970 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:971:4 [INFO] [stderr] | [INFO] [stderr] 971 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:990:4 [INFO] [stderr] | [INFO] [stderr] 990 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1072:4 [INFO] [stderr] | [INFO] [stderr] 1072 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1073:4 [INFO] [stderr] | [INFO] [stderr] 1073 | block_type: block_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1074:4 [INFO] [stderr] | [INFO] [stderr] 1074 | begin_position: begin_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `begin_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1075:4 [INFO] [stderr] | [INFO] [stderr] 1075 | branch_position: branch_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `branch_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1076:4 [INFO] [stderr] | [INFO] [stderr] 1076 | end_position: end_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/table.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | variable_type: variable_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variable_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/table.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | var: var, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | variable_type: variable_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variable_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | variable_type: variable_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variable_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | sections: sections, ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/module.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:225:28 [INFO] [stderr] | [INFO] [stderr] 225 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/section.rs:225:40 [INFO] [stderr] | [INFO] [stderr] 225 | Ok(CustomSection { name: name, payload: payload }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/primitives.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | form: form, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `form` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/types.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | elem_type: elem_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | limits: limits, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `limits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | maximum: maximum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maximum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | module_str: module_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/import_entry.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | external: external, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `external` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | internal: internal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | field_str: field_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/export_entry.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | internal: internal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `internal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | global_type: global_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/global_entry.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | init_expr: init_expr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | Local { count: count, value_type: value_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | Ok(Local { count: count.into(), value_type: value_type }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | FuncBody { locals: locals, opcodes: opcodes } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | FuncBody { locals: locals, opcodes: opcodes } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `opcodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:106:23 [INFO] [stderr] | [INFO] [stderr] 106 | Ok(FuncBody { locals: locals, opcodes: opcodes }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/func.rs:106:39 [INFO] [stderr] | [INFO] [stderr] 106 | Ok(FuncBody { locals: locals, opcodes: opcodes }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `opcodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:15:40 [INFO] [stderr] | [INFO] [stderr] 15 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:15:56 [INFO] [stderr] | [INFO] [stderr] 15 | ElementSegment { index: index, offset: offset, members: members } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elements/segment.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/module.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/code.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | ValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | OptionalValueTypeBuilder { callback: callback } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/misc.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/import.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/memory.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/table.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/export.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/global.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/data.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:600:4 [INFO] [stderr] | [INFO] [stderr] 600 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:602:4 [INFO] [stderr] | [INFO] [stderr] 602 | locals: locals, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:588:4 [INFO] [stderr] | [INFO] [stderr] 588 | module_instance: module_instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:589:4 [INFO] [stderr] | [INFO] [stderr] 589 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:663:4 [INFO] [stderr] | [INFO] [stderr] 663 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:664:4 [INFO] [stderr] | [INFO] [stderr] 664 | block_type: block_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_type` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:591:4 [INFO] [stderr] | [INFO] [stderr] 591 | locals: locals, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:652:4 [INFO] [stderr] | [INFO] [stderr] 652 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/validator.rs:653:4 [INFO] [stderr] | [INFO] [stderr] 653 | block_type: block_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/stack.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | limit: limit [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/stack.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | limit: limit [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/native.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:45:4 [INFO] [stderr] | [INFO] [stderr] 45 | functions: functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:46:4 [INFO] [stderr] | [INFO] [stderr] 46 | tables: tables, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/imports.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | globals: globals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `globals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | maximum_size: maximum_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maximum_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:134:4 [INFO] [stderr] | [INFO] [stderr] 134 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:135:4 [INFO] [stderr] | [INFO] [stderr] 135 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/memory.rs:136:4 [INFO] [stderr] | [INFO] [stderr] 136 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:155:4 [INFO] [stderr] | [INFO] [stderr] 155 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:178:4 [INFO] [stderr] | [INFO] [stderr] 178 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:222:4 [INFO] [stderr] | [INFO] [stderr] 222 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:223:4 [INFO] [stderr] | [INFO] [stderr] 223 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:224:4 [INFO] [stderr] | [INFO] [stderr] 224 | imports: imports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:227:4 [INFO] [stderr] | [INFO] [stderr] 227 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:228:4 [INFO] [stderr] | [INFO] [stderr] 228 | tables: tables, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:229:4 [INFO] [stderr] | [INFO] [stderr] 229 | globals: globals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `globals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/module.rs:657:4 [INFO] [stderr] | [INFO] [stderr] 657 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:970:4 [INFO] [stderr] | [INFO] [stderr] 970 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:971:4 [INFO] [stderr] | [INFO] [stderr] 971 | externals: externals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `externals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:990:4 [INFO] [stderr] | [INFO] [stderr] 990 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1072:4 [INFO] [stderr] | [INFO] [stderr] 1072 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1073:4 [INFO] [stderr] | [INFO] [stderr] 1073 | block_type: block_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1074:4 [INFO] [stderr] | [INFO] [stderr] 1074 | begin_position: begin_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `begin_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1075:4 [INFO] [stderr] | [INFO] [stderr] 1075 | branch_position: branch_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `branch_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/runner.rs:1076:4 [INFO] [stderr] | [INFO] [stderr] 1076 | end_position: end_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/table.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | variable_type: variable_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variable_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/table.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | var: var, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | variable_type: variable_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variable_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | is_mutable: is_mutable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_mutable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/variable.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | variable_type: variable_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variable_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:600:4 [INFO] [stderr] | [INFO] [stderr] 600 | module: module, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:602:4 [INFO] [stderr] | [INFO] [stderr] 602 | locals: locals, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:663:4 [INFO] [stderr] | [INFO] [stderr] 663 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validation/func.rs:664:4 [INFO] [stderr] | [INFO] [stderr] 664 | block_type: block_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/stack.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | limit: limit [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/stack.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | limit: limit [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | magic: 0x6d736100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6d73_6100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/validator.rs:12:32 [INFO] [stderr] | [INFO] [stderr] 12 | const NATURAL_ALIGNMENT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/interpreter/validator.rs:405:3 [INFO] [stderr] | [INFO] [stderr] 405 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 406 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 407 | | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 405 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 406 | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 407 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/interpreter/validator.rs:418:3 [INFO] [stderr] | [INFO] [stderr] 418 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 419 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 420 | | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 421 | | } [INFO] [stderr] 422 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 418 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 419 | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 420 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/interpreter/validator.rs:462:4 [INFO] [stderr] | [INFO] [stderr] 462 | if top_frame.frame_type == BlockFrameType::IfTrue { [INFO] [stderr] | _____________^ [INFO] [stderr] 463 | | if top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 464 | | return Err(Error::Validation(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 465 | | } [INFO] [stderr] 466 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 462 | if top_frame.frame_type == BlockFrameType::IfTrue && top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 463 | return Err(Error::Validation(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 464 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:502:26 [INFO] [stderr] | [INFO] [stderr] 502 | const EXP_MASK: u32 = 0x7F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:503:26 [INFO] [stderr] | [INFO] [stderr] 503 | const QNAN_MASK: u32 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:504:26 [INFO] [stderr] | [INFO] [stderr] 504 | const FRACT_MASK: u32 = 0x007FFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:520:26 [INFO] [stderr] | [INFO] [stderr] 520 | const EXP_MASK: u64 = 0x7FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:521:26 [INFO] [stderr] | [INFO] [stderr] 521 | const QNAN_MASK: u64 = 0x0001000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:522:26 [INFO] [stderr] | [INFO] [stderr] 522 | const FRACT_MASK: u64 = 0x000FFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x000F_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/validation/func.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | const NATURAL_ALIGNMENT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/validation/func.rs:409:3 [INFO] [stderr] | [INFO] [stderr] 409 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 410 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 411 | | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 409 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 410 | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 411 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/validation/func.rs:422:3 [INFO] [stderr] | [INFO] [stderr] 422 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 423 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 424 | | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 425 | | } [INFO] [stderr] 426 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 422 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 423 | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 424 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/validation/func.rs:466:4 [INFO] [stderr] | [INFO] [stderr] 466 | if top_frame.frame_type == BlockFrameType::IfTrue { [INFO] [stderr] | _____________^ [INFO] [stderr] 467 | | if top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 468 | | return Err(Error(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 469 | | } [INFO] [stderr] 470 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 466 | if top_frame.frame_type == BlockFrameType::IfTrue && top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 467 | return Err(Error(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 468 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | magic: 0x6d736100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6d73_6100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:337:29 [INFO] [stderr] | [INFO] [stderr] 337 | assert_eq!(I64Const(9223372036854775807), func.code().elements()[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | assert_eq!(I64Const(-9223372036854775808), func.code().elements()[1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:339:30 [INFO] [stderr] | [INFO] [stderr] 339 | assert_eq!(I64Const(-1152894205662152753), func.code().elements()[2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_152_894_205_662_152_753` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:353:30 [INFO] [stderr] | [INFO] [stderr] 353 | assert_eq!(I32Const(-2147483648), func.code().elements()[16]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/module.rs:354:29 [INFO] [stderr] | [INFO] [stderr] 354 | assert_eq!(I32Const(2147483647), func.code().elements()[17]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1018:13 [INFO] [stderr] | [INFO] [stderr] 1018 | 08u8, // 8 bytes overall [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1018 | 8u8, // 8 bytes overall [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1018 | 0o8u8, // 8 bytes overall [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1063:56 [INFO] [stderr] | [INFO] [stderr] 1063 | let section: Section = deserialize_buffer(vec![08u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1063 | let section: Section = deserialize_buffer(vec![8u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1063 | let section: Section = deserialize_buffer(vec![0o8u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1063:62 [INFO] [stderr] | [INFO] [stderr] 1063 | let section: Section = deserialize_buffer(vec![08u8, 01u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1063 | let section: Section = deserialize_buffer(vec![08u8, 1u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1063 | let section: Section = deserialize_buffer(vec![08u8, 0o1u8, 00u8]).expect("Start section to deserialize"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1071:37 [INFO] [stderr] | [INFO] [stderr] 1071 | assert_eq!(serialized, vec![08u8, 01u8, 00u8]); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1071 | assert_eq!(serialized, vec![8u8, 01u8, 00u8]); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1071 | assert_eq!(serialized, vec![0o8u8, 01u8, 00u8]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/elements/section.rs:1071:43 [INFO] [stderr] | [INFO] [stderr] 1071 | assert_eq!(serialized, vec![08u8, 01u8, 00u8]); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1071 | assert_eq!(serialized, vec![08u8, 1u8, 00u8]); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1071 | assert_eq!(serialized, vec![08u8, 0o1u8, 00u8]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:698:14 [INFO] [stderr] | [INFO] [stderr] 698 | -9223372036854775808, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:706:13 [INFO] [stderr] | [INFO] [stderr] 706 | 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:714:14 [INFO] [stderr] | [INFO] [stderr] 714 | -2147483648, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elements/primitives.rs:722:13 [INFO] [stderr] | [INFO] [stderr] 722 | 2147483647, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/validator.rs:12:32 [INFO] [stderr] | [INFO] [stderr] 12 | const NATURAL_ALIGNMENT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/interpreter/validator.rs:405:3 [INFO] [stderr] | [INFO] [stderr] 405 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 406 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 407 | | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 405 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 406 | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 407 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/interpreter/validator.rs:418:3 [INFO] [stderr] | [INFO] [stderr] 418 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 419 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 420 | | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 421 | | } [INFO] [stderr] 422 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 418 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 419 | return Err(Error::Validation(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 420 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/interpreter/validator.rs:462:4 [INFO] [stderr] | [INFO] [stderr] 462 | if top_frame.frame_type == BlockFrameType::IfTrue { [INFO] [stderr] | _____________^ [INFO] [stderr] 463 | | if top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 464 | | return Err(Error::Validation(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 465 | | } [INFO] [stderr] 466 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 462 | if top_frame.frame_type == BlockFrameType::IfTrue && top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 463 | return Err(Error::Validation(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 464 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:502:26 [INFO] [stderr] | [INFO] [stderr] 502 | const EXP_MASK: u32 = 0x7F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:503:26 [INFO] [stderr] | [INFO] [stderr] 503 | const QNAN_MASK: u32 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:504:26 [INFO] [stderr] | [INFO] [stderr] 504 | const FRACT_MASK: u32 = 0x007FFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:520:26 [INFO] [stderr] | [INFO] [stderr] 520 | const EXP_MASK: u64 = 0x7FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:521:26 [INFO] [stderr] | [INFO] [stderr] 521 | const QNAN_MASK: u64 = 0x0001000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/value.rs:522:26 [INFO] [stderr] | [INFO] [stderr] 522 | const FRACT_MASK: u64 = 0x000FFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x000F_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/interpreter/tests/basics.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | const SIGNATURE_I32_I32: &'static [ValueType] = &[ValueType::I32, ValueType::I32]; [INFO] [stderr] | -^^^^^^^------------ help: consider removing `'static`: `&[ValueType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/interpreter/tests/basics.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | const SIGNATURES: &'static [UserFunctionDescriptor] = &[ [INFO] [stderr] | -^^^^^^^------------------------- help: consider removing `'static`: `&[UserFunctionDescriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/interpreter/tests/basics.rs:125:23 [INFO] [stderr] | [INFO] [stderr] 125 | const NO_SIGNATURES: &'static [UserFunctionDescriptor] = &[]; [INFO] [stderr] | -^^^^^^^------------------------- help: consider removing `'static`: `&[UserFunctionDescriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:484:20 [INFO] [stderr] | [INFO] [stderr] 484 | Opcode::F32Const(0x40400000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:485:20 [INFO] [stderr] | [INFO] [stderr] 485 | Opcode::F64Const(0x4010000000000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4010_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:572:89 [INFO] [stderr] | [INFO] [stderr] 572 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(3628800)); [INFO] [stderr] | ^^^^^^^ help: consider: `3_628_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:780:20 [INFO] [stderr] | [INFO] [stderr] 780 | Opcode::F32Const(0x3F800000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:781:20 [INFO] [stderr] | [INFO] [stderr] 781 | Opcode::F32Const(0x40000000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:790:20 [INFO] [stderr] | [INFO] [stderr] 790 | Opcode::F64Const(0x3FF0000000000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:791:20 [INFO] [stderr] | [INFO] [stderr] 791 | Opcode::F64Const(0x4000000000000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:975:89 [INFO] [stderr] | [INFO] [stderr] 975 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(2147483646)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_646` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:982:90 [INFO] [stderr] | [INFO] [stderr] 982 | assert_eq!(module.execute_index(11, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(536870899)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `536_870_899` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:985:91 [INFO] [stderr] | [INFO] [stderr] 985 | assert_eq!(module.execute_index(14, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-1610612749)); // 2684354547 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_610_612_749` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1135:89 [INFO] [stderr] | [INFO] [stderr] 1135 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(9223372036854775806)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_806` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1142:90 [INFO] [stderr] | [INFO] [stderr] 1142 | assert_eq!(module.execute_index(11, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(2305843009213693939)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `2_305_843_009_213_693_939` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1145:91 [INFO] [stderr] | [INFO] [stderr] 1145 | assert_eq!(module.execute_index(14, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(-6917529027641081869)); // 11529215046068469747 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_917_529_027_641_081_869` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1157:22 [INFO] [stderr] | [INFO] [stderr] 1157 | Opcode::F32Const(0x3FA00000), // 1.25 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3FA0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1158:22 [INFO] [stderr] | [INFO] [stderr] 1158 | Opcode::F32Const(0x40700000), // 3.75 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4070_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1166:22 [INFO] [stderr] | [INFO] [stderr] 1166 | Opcode::F32Const(0x40900000), // 4.5 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4090_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1167:22 [INFO] [stderr] | [INFO] [stderr] 1167 | Opcode::F32Const(0x461C4000), // 1e4 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x461C_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1175:22 [INFO] [stderr] | [INFO] [stderr] 1175 | Opcode::F32Const(0x449A5000), // 1234.5 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x449A_5000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1176:22 [INFO] [stderr] | [INFO] [stderr] 1176 | Opcode::F32Const(0xC0DC0000), // -6.875 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC0DC_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1184:22 [INFO] [stderr] | [INFO] [stderr] 1184 | Opcode::F32Const(0x56B5E621), // 1e14 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x56B5_E621` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1185:22 [INFO] [stderr] | [INFO] [stderr] 1185 | Opcode::F32Const(0xC8435000), // -2e5 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC843_5000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1193:22 [INFO] [stderr] | [INFO] [stderr] 1193 | Opcode::F32Const(0x00000000), // 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1194:22 [INFO] [stderr] | [INFO] [stderr] 1194 | Opcode::F32Const(0x00000000), // 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1202:22 [INFO] [stderr] | [INFO] [stderr] 1202 | Opcode::F32Const(0x00000000), // 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1203:22 [INFO] [stderr] | [INFO] [stderr] 1203 | Opcode::F32Const(0x00000000), // 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1211:22 [INFO] [stderr] | [INFO] [stderr] 1211 | Opcode::F32Const(0x00000000), // 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1212:22 [INFO] [stderr] | [INFO] [stderr] 1212 | Opcode::F32Const(0x00000000), // 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1221:89 [INFO] [stderr] | [INFO] [stderr] 1221 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(5.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1222:90 [INFO] [stderr] | [INFO] [stderr] 1222 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-9995.500000)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `9_995.500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1223:90 [INFO] [stderr] | [INFO] [stderr] 1223 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-8487.187500)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `8_487.187_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1224:90 [INFO] [stderr] | [INFO] [stderr] 1224 | assert_eq!(module.execute_index(3, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-500000000.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `500_000_000.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1225:89 [INFO] [stderr] | [INFO] [stderr] 1225 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1226:89 [INFO] [stderr] | [INFO] [stderr] 1226 | assert_eq!(module.execute_index(5, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1227:89 [INFO] [stderr] | [INFO] [stderr] 1227 | assert_eq!(module.execute_index(6, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1239:22 [INFO] [stderr] | [INFO] [stderr] 1239 | Opcode::F64Const(0x41CD6F3458800000), // 987654321 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x41CD_6F34_5880_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1240:22 [INFO] [stderr] | [INFO] [stderr] 1240 | Opcode::F64Const(0x419D6F3454000000), // 123456789 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x419D_6F34_5400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1248:22 [INFO] [stderr] | [INFO] [stderr] 1248 | Opcode::F64Const(0x4C33A8A41D39B24E), // 1234e56 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4C33_A8A4_1D39_B24E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1249:22 [INFO] [stderr] | [INFO] [stderr] 1249 | Opcode::F64Const(0x44DD1DE3D2D5C713), // 5.5e23 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x44DD_1DE3_D2D5_C713` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1257:22 [INFO] [stderr] | [INFO] [stderr] 1257 | Opcode::F64Const(0xC132C4B000000000), // -123e4 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xC132_C4B0_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1258:22 [INFO] [stderr] | [INFO] [stderr] 1258 | Opcode::F64Const(0x416789FE40000000), // 12341234 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4167_89FE_4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1266:22 [INFO] [stderr] | [INFO] [stderr] 1266 | Opcode::F64Const(0x6974E718D7D7625A), // 1e200 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x6974_E718_D7D7_625A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1267:22 [INFO] [stderr] | [INFO] [stderr] 1267 | Opcode::F64Const(0x4A511B0EC57E649A), // 1e50 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4A51_1B0E_C57E_649A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1275:22 [INFO] [stderr] | [INFO] [stderr] 1275 | Opcode::F64Const(0x0000000000000000), // 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1276:22 [INFO] [stderr] | [INFO] [stderr] 1276 | Opcode::F64Const(0x0000000000000000), // 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1284:22 [INFO] [stderr] | [INFO] [stderr] 1284 | Opcode::F64Const(0x0000000000000000), // 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1285:22 [INFO] [stderr] | [INFO] [stderr] 1285 | Opcode::F64Const(0x0000000000000000), // 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1293:22 [INFO] [stderr] | [INFO] [stderr] 1293 | Opcode::F64Const(0x0000000000000000), // 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1294:22 [INFO] [stderr] | [INFO] [stderr] 1294 | Opcode::F64Const(0x0000000000000000), // 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1303:89 [INFO] [stderr] | [INFO] [stderr] 1303 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(1111111110.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_111_111_110.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1304:89 [INFO] [stderr] | [INFO] [stderr] 1304 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(123400000000000007812762268812638756607430593436581896388608.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `123_400_000_000_000_007_812_762_268_812_638_756_607_430_593_436_581_896_388_608.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1305:90 [INFO] [stderr] | [INFO] [stderr] 1305 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-15179717820000.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `15_179_717_820_000.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1309:89 [INFO] [stderr] | [INFO] [stderr] 1309 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1310:89 [INFO] [stderr] | [INFO] [stderr] 1310 | assert_eq!(module.execute_index(5, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1311:89 [INFO] [stderr] | [INFO] [stderr] 1311 | assert_eq!(module.execute_index(6, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1323:22 [INFO] [stderr] | [INFO] [stderr] 1323 | Opcode::I32Const(0x40900000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4090_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1331:22 [INFO] [stderr] | [INFO] [stderr] 1331 | Opcode::F32Const(0xC0600000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC060_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1339:22 [INFO] [stderr] | [INFO] [stderr] 1339 | Opcode::I64Const(0x405f480000000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x405f_4800_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1347:22 [INFO] [stderr] | [INFO] [stderr] 1347 | Opcode::F64Const(0x42099C82CC000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4209_9C82_CC00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1357:90 [INFO] [stderr] | [INFO] [stderr] 1357 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-1067450368)); // 3227516928 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_067_450_368` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1358:89 [INFO] [stderr] | [INFO] [stderr] 1358 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(125.125000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `125.125_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1359:89 [INFO] [stderr] | [INFO] [stderr] 1359 | assert_eq!(module.execute_index(3, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(4758506566875873280)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_758_506_566_875_873_280` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1951:22 [INFO] [stderr] | [INFO] [stderr] 1951 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1952:22 [INFO] [stderr] | [INFO] [stderr] 1952 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1960:22 [INFO] [stderr] | [INFO] [stderr] 1960 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1961:22 [INFO] [stderr] | [INFO] [stderr] 1961 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1969:22 [INFO] [stderr] | [INFO] [stderr] 1969 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1970:22 [INFO] [stderr] | [INFO] [stderr] 1970 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1978:22 [INFO] [stderr] | [INFO] [stderr] 1978 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1979:22 [INFO] [stderr] | [INFO] [stderr] 1979 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1987:22 [INFO] [stderr] | [INFO] [stderr] 1987 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1988:22 [INFO] [stderr] | [INFO] [stderr] 1988 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1996:22 [INFO] [stderr] | [INFO] [stderr] 1996 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1997:22 [INFO] [stderr] | [INFO] [stderr] 1997 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2005:22 [INFO] [stderr] | [INFO] [stderr] 2005 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2006:22 [INFO] [stderr] | [INFO] [stderr] 2006 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2014:22 [INFO] [stderr] | [INFO] [stderr] 2014 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2015:22 [INFO] [stderr] | [INFO] [stderr] 2015 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2023:22 [INFO] [stderr] | [INFO] [stderr] 2023 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2024:22 [INFO] [stderr] | [INFO] [stderr] 2024 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2032:22 [INFO] [stderr] | [INFO] [stderr] 2032 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2033:22 [INFO] [stderr] | [INFO] [stderr] 2033 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2041:22 [INFO] [stderr] | [INFO] [stderr] 2041 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2042:22 [INFO] [stderr] | [INFO] [stderr] 2042 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2050:22 [INFO] [stderr] | [INFO] [stderr] 2050 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2051:22 [INFO] [stderr] | [INFO] [stderr] 2051 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2059:22 [INFO] [stderr] | [INFO] [stderr] 2059 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2060:22 [INFO] [stderr] | [INFO] [stderr] 2060 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2068:22 [INFO] [stderr] | [INFO] [stderr] 2068 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2069:22 [INFO] [stderr] | [INFO] [stderr] 2069 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2077:22 [INFO] [stderr] | [INFO] [stderr] 2077 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2078:22 [INFO] [stderr] | [INFO] [stderr] 2078 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2086:22 [INFO] [stderr] | [INFO] [stderr] 2086 | Opcode::F32Const(0x3F800000), // 1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2087:22 [INFO] [stderr] | [INFO] [stderr] 2087 | Opcode::F32Const(0xBF800000), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2123:22 [INFO] [stderr] | [INFO] [stderr] 2123 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2124:22 [INFO] [stderr] | [INFO] [stderr] 2124 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2132:22 [INFO] [stderr] | [INFO] [stderr] 2132 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2133:22 [INFO] [stderr] | [INFO] [stderr] 2133 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2141:22 [INFO] [stderr] | [INFO] [stderr] 2141 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2142:22 [INFO] [stderr] | [INFO] [stderr] 2142 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2150:22 [INFO] [stderr] | [INFO] [stderr] 2150 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2151:22 [INFO] [stderr] | [INFO] [stderr] 2151 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2159:22 [INFO] [stderr] | [INFO] [stderr] 2159 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2160:22 [INFO] [stderr] | [INFO] [stderr] 2160 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2168:22 [INFO] [stderr] | [INFO] [stderr] 2168 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2169:22 [INFO] [stderr] | [INFO] [stderr] 2169 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2177:22 [INFO] [stderr] | [INFO] [stderr] 2177 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2178:22 [INFO] [stderr] | [INFO] [stderr] 2178 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2186:22 [INFO] [stderr] | [INFO] [stderr] 2186 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2187:22 [INFO] [stderr] | [INFO] [stderr] 2187 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2195:22 [INFO] [stderr] | [INFO] [stderr] 2195 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2196:22 [INFO] [stderr] | [INFO] [stderr] 2196 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2204:22 [INFO] [stderr] | [INFO] [stderr] 2204 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2205:22 [INFO] [stderr] | [INFO] [stderr] 2205 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2213:22 [INFO] [stderr] | [INFO] [stderr] 2213 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2214:22 [INFO] [stderr] | [INFO] [stderr] 2214 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2222:22 [INFO] [stderr] | [INFO] [stderr] 2222 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2223:22 [INFO] [stderr] | [INFO] [stderr] 2223 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2231:22 [INFO] [stderr] | [INFO] [stderr] 2231 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2232:22 [INFO] [stderr] | [INFO] [stderr] 2232 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2240:22 [INFO] [stderr] | [INFO] [stderr] 2240 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2241:22 [INFO] [stderr] | [INFO] [stderr] 2241 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2249:22 [INFO] [stderr] | [INFO] [stderr] 2249 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2250:22 [INFO] [stderr] | [INFO] [stderr] 2250 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2258:22 [INFO] [stderr] | [INFO] [stderr] 2258 | Opcode::F64Const(0x3FF0000000000000), // 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2259:22 [INFO] [stderr] | [INFO] [stderr] 2259 | Opcode::F64Const(0xBFF0000000000000), // -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2303:22 [INFO] [stderr] | [INFO] [stderr] 2303 | Opcode::F32Const(0xC2C83F35), // -100.12345 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC2C8_3F35` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2311:22 [INFO] [stderr] | [INFO] [stderr] 2311 | Opcode::F32Const(0x4F32D05E), // 3e9 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4F32_D05E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2319:22 [INFO] [stderr] | [INFO] [stderr] 2319 | Opcode::F64Const(0xC05907E69AD42C3D), // -100.12345 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xC059_07E6_9AD4_2C3D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2327:22 [INFO] [stderr] | [INFO] [stderr] 2327 | Opcode::F64Const(0x41E65A0BC0000000), // 3e9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x41E6_5A0B_C000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2338:90 [INFO] [stderr] | [INFO] [stderr] 2338 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-1294967296)); // 3000000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2340:90 [INFO] [stderr] | [INFO] [stderr] 2340 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-1294967296)); // 3000000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2368:22 [INFO] [stderr] | [INFO] [stderr] 2368 | Opcode::F32Const(0xC2C83F35), // -100.12345 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC2C8_3F35` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2378:22 [INFO] [stderr] | [INFO] [stderr] 2378 | Opcode::F32Const(0x4F32D05E), // 3e9 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4F32_D05E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2380:22 [INFO] [stderr] | [INFO] [stderr] 2380 | Opcode::I64Const(3000000000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2388:22 [INFO] [stderr] | [INFO] [stderr] 2388 | Opcode::F64Const(0xC05907E69AD42C3D), // -100.12345 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xC059_07E6_9AD4_2C3D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2398:22 [INFO] [stderr] | [INFO] [stderr] 2398 | Opcode::F64Const(0x41E65A0BC0000000), // 3e9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x41E6_5A0B_C000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2400:22 [INFO] [stderr] | [INFO] [stderr] 2400 | Opcode::I64Const(3000000000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2409:89 [INFO] [stderr] | [INFO] [stderr] 2409 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(4294967295)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2442:22 [INFO] [stderr] | [INFO] [stderr] 2442 | Opcode::F64Const(0x41678C29DCCCCCCD), // 12345678.9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4167_8C29_DCCC_CCCD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2467:90 [INFO] [stderr] | [INFO] [stderr] 2467 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2468:89 [INFO] [stderr] | [INFO] [stderr] 2468 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(4294967296.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `4_294_967_296.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2469:89 [INFO] [stderr] | [INFO] [stderr] 2469 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(12345679.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `12_345_679.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2470:89 [INFO] [stderr] | [INFO] [stderr] 2470 | assert_eq!(module.execute_index(3, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2471:89 [INFO] [stderr] | [INFO] [stderr] 2471 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2499:22 [INFO] [stderr] | [INFO] [stderr] 2499 | Opcode::F32Const(0x4B3C614F), // 12345678.9 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4B3C_614F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2524:90 [INFO] [stderr] | [INFO] [stderr] 2524 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2525:89 [INFO] [stderr] | [INFO] [stderr] 2525 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(4294967295.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `4_294_967_295.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2526:89 [INFO] [stderr] | [INFO] [stderr] 2526 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(12345679.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `12_345_679.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2527:89 [INFO] [stderr] | [INFO] [stderr] 2527 | assert_eq!(module.execute_index(3, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2528:89 [INFO] [stderr] | [INFO] [stderr] 2528 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2666:89 [INFO] [stderr] | [INFO] [stderr] 2666 | assert_eq!(module.execute_index(6, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(4294967295)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2690:89 [INFO] [stderr] | [INFO] [stderr] 2690 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(25.750000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `25.750_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2714:89 [INFO] [stderr] | [INFO] [stderr] 2714 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(1023.875000)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1_023.875_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2760:23 [INFO] [stderr] | [INFO] [stderr] 2760 | Opcode::I32Const(-123456), [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2771:90 [INFO] [stderr] | [INFO] [stderr] 2771 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-16909061)); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_909_061` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2772:90 [INFO] [stderr] | [INFO] [stderr] 2772 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-859059511)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `859_059_511` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2773:90 [INFO] [stderr] | [INFO] [stderr] 2773 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-123456)); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2785:23 [INFO] [stderr] | [INFO] [stderr] 2785 | Opcode::I64Const(-1229782938247303429), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_229_782_938_247_303_429` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2788:23 [INFO] [stderr] | [INFO] [stderr] 2788 | Opcode::I64Const(-1229782938247303428), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_229_782_938_247_303_428` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2791:23 [INFO] [stderr] | [INFO] [stderr] 2791 | Opcode::I64Const(-1229782938247303427), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_229_782_938_247_303_427` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2794:23 [INFO] [stderr] | [INFO] [stderr] 2794 | Opcode::I64Const(-1229782938247303426), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_229_782_938_247_303_426` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2805:23 [INFO] [stderr] | [INFO] [stderr] 2805 | Opcode::I64Const(-1229782938247312695), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_229_782_938_247_312_695` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2808:23 [INFO] [stderr] | [INFO] [stderr] 2808 | Opcode::I64Const(-1229782938247312181), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_229_782_938_247_312_181` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2819:23 [INFO] [stderr] | [INFO] [stderr] 2819 | Opcode::I64Const(-123456), [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2830:23 [INFO] [stderr] | [INFO] [stderr] 2830 | Opcode::I64Const(-4981613551475109875), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_981_613_551_475_109_875` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2841:89 [INFO] [stderr] | [INFO] [stderr] 2841 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(4278058235)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_058_235` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2842:89 [INFO] [stderr] | [INFO] [stderr] 2842 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(3435907785)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_435_907_785` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2843:89 [INFO] [stderr] | [INFO] [stderr] 2843 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(4294843840)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_843_840` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2844:90 [INFO] [stderr] | [INFO] [stderr] 2844 | assert_eq!(module.execute_index(3, vec![].into()).unwrap().unwrap(), RuntimeValue::I64(-4981613551475109875)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_981_613_551_475_109_875` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2858:22 [INFO] [stderr] | [INFO] [stderr] 2858 | Opcode::F32Const(0x3FC00000), // 1.5 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3FC0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2869:89 [INFO] [stderr] | [INFO] [stderr] 2869 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(1069547520)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_069_547_520` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2883:22 [INFO] [stderr] | [INFO] [stderr] 2883 | Opcode::F64Const(0xC08F460000000000), // -1000.75 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xC08F_4600_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2894:90 [INFO] [stderr] | [INFO] [stderr] 2894 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(-1064352256)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_064_352_256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3025:22 [INFO] [stderr] | [INFO] [stderr] 3025 | Opcode::F32Const(0x42C80000), // 100 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x42C8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3033:22 [INFO] [stderr] | [INFO] [stderr] 3033 | Opcode::F32Const(0xC2C80000), // -100 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC2C8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3041:22 [INFO] [stderr] | [INFO] [stderr] 3041 | Opcode::F32Const(0xC2C80000), // -100 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC2C8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3050:22 [INFO] [stderr] | [INFO] [stderr] 3050 | Opcode::F32Const(0x42C80000), // 100 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x42C8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3058:22 [INFO] [stderr] | [INFO] [stderr] 3058 | Opcode::F32Const(0xBF400000), // -0.75 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF40_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3066:22 [INFO] [stderr] | [INFO] [stderr] 3066 | Opcode::F32Const(0xBF400000), // -0.75 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF40_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3074:22 [INFO] [stderr] | [INFO] [stderr] 3074 | Opcode::F32Const(0xBF400000), // -0.75 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF40_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3082:22 [INFO] [stderr] | [INFO] [stderr] 3082 | Opcode::F32Const(0x3FA00000), // 1.25 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3FA0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3090:22 [INFO] [stderr] | [INFO] [stderr] 3090 | Opcode::F32Const(0x3FE00000), // 1.75 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3FE0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3099:90 [INFO] [stderr] | [INFO] [stderr] 3099 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-100.000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `100.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3100:89 [INFO] [stderr] | [INFO] [stderr] 3100 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(100.000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `100.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3102:89 [INFO] [stderr] | [INFO] [stderr] 3102 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(10.000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `10.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3103:90 [INFO] [stderr] | [INFO] [stderr] 3103 | assert_eq!(module.execute_index(5, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3104:90 [INFO] [stderr] | [INFO] [stderr] 3104 | assert_eq!(module.execute_index(6, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3105:90 [INFO] [stderr] | [INFO] [stderr] 3105 | assert_eq!(module.execute_index(7, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3106:89 [INFO] [stderr] | [INFO] [stderr] 3106 | assert_eq!(module.execute_index(8, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3107:89 [INFO] [stderr] | [INFO] [stderr] 3107 | assert_eq!(module.execute_index(9, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(2.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `2.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3128:22 [INFO] [stderr] | [INFO] [stderr] 3128 | Opcode::F64Const(0x4059000000000000), // 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4059_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3136:22 [INFO] [stderr] | [INFO] [stderr] 3136 | Opcode::F64Const(0xC059000000000000), // -100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xC059_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3144:22 [INFO] [stderr] | [INFO] [stderr] 3144 | Opcode::F64Const(0xC059000000000000 ), // -100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xC059_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3153:22 [INFO] [stderr] | [INFO] [stderr] 3153 | Opcode::F64Const(0x4059000000000000), // 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4059_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3161:22 [INFO] [stderr] | [INFO] [stderr] 3161 | Opcode::F64Const(0xBFE8000000000000), // -0.75 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFE8_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3169:22 [INFO] [stderr] | [INFO] [stderr] 3169 | Opcode::F64Const(0xBFE8000000000000), // -0.75 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFE8_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3177:22 [INFO] [stderr] | [INFO] [stderr] 3177 | Opcode::F64Const(0xBFE8000000000000), // -0.75 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBFE8_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3185:22 [INFO] [stderr] | [INFO] [stderr] 3185 | Opcode::F64Const(0x3FF4000000000000), // 1.25 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF4_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3193:22 [INFO] [stderr] | [INFO] [stderr] 3193 | Opcode::F64Const(0x3FFC000000000000), // 1.75 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FFC_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3202:90 [INFO] [stderr] | [INFO] [stderr] 3202 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-100.000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `100.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3203:89 [INFO] [stderr] | [INFO] [stderr] 3203 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(100.000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `100.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3205:89 [INFO] [stderr] | [INFO] [stderr] 3205 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(10.000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `10.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3206:90 [INFO] [stderr] | [INFO] [stderr] 3206 | assert_eq!(module.execute_index(5, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3207:90 [INFO] [stderr] | [INFO] [stderr] 3207 | assert_eq!(module.execute_index(6, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3208:90 [INFO] [stderr] | [INFO] [stderr] 3208 | assert_eq!(module.execute_index(7, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-0.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3209:89 [INFO] [stderr] | [INFO] [stderr] 3209 | assert_eq!(module.execute_index(8, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3210:89 [INFO] [stderr] | [INFO] [stderr] 3210 | assert_eq!(module.execute_index(9, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(2.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `2.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/interpreter/tests/wasm.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const FUNCTION_NAME: &'static str = "_inc_i32"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/interpreter/tests/wasm.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | const FUNCTION_NAME: &'static str = "_accumulate_u8"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/validation/func.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | const NATURAL_ALIGNMENT: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/validation/func.rs:409:3 [INFO] [stderr] | [INFO] [stderr] 409 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 410 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 411 | | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 409 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 410 | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 411 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/validation/func.rs:422:3 [INFO] [stderr] | [INFO] [stderr] 422 | if align != NATURAL_ALIGNMENT { [INFO] [stderr] | _________^ [INFO] [stderr] 423 | | if 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 424 | | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 425 | | } [INFO] [stderr] 426 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 422 | if align != NATURAL_ALIGNMENT && 1u32.checked_shl(align).unwrap_or(u32::MAX) > max_align { [INFO] [stderr] 423 | return Err(Error(format!("Too large memory alignment 2^{} (expected at most {})", align, max_align))); [INFO] [stderr] 424 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/validation/func.rs:466:4 [INFO] [stderr] | [INFO] [stderr] 466 | if top_frame.frame_type == BlockFrameType::IfTrue { [INFO] [stderr] | _____________^ [INFO] [stderr] 467 | | if top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 468 | | return Err(Error(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 469 | | } [INFO] [stderr] 470 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 466 | if top_frame.frame_type == BlockFrameType::IfTrue && top_frame.block_type != BlockType::NoResult { [INFO] [stderr] 467 | return Err(Error(format!("If block without else required to have NoResult block type. But it have {:?} type", top_frame.block_type))); [INFO] [stderr] 468 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | if let &Section::Code(ref code_section) = section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | if let Section::Code(ref code_section) = *section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | if let &Section::Type(ref type_section) = section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let Section::Type(ref type_section) = *section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | if let &Section::Import(ref import_section) = section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | if let Section::Import(ref import_section) = *section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | if let &Section::Global(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | if let Section::Global(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | if let &Section::Export(ref export_section) = section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | if let Section::Export(ref export_section) = *section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | if let &Section::Table(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | if let Section::Table(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | if let &Section::Data(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | if let Section::Data(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | if let &Section::Element(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | if let Section::Element(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | if let &Section::Memory(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | if let Section::Memory(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | if let &Section::Function(ref sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | if let Section::Function(ref sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | if let &Section::Start(sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | if let Section::Start(sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elements/module.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | reader.read(&mut magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elements/section.rs:75:37 [INFO] [stderr] | [INFO] [stderr] 75 | Section::Custom(CustomSection::deserialize(reader)?.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CustomSection::deserialize(reader)?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:314:29 [INFO] [stderr] | [INFO] [stderr] 314 | .filter(|entry| match entry.external() { &External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 314 | .filter(|entry| match *entry.external() { External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:321:29 [INFO] [stderr] | [INFO] [stderr] 321 | .filter(|entry| match entry.external() { &External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | .filter(|entry| match *entry.external() { External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let b = u8buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | let b = u8buf[0] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | res |= ((b & 0x7f) as i32) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:301:20 [INFO] [stderr] | [INFO] [stderr] 301 | res |= ((b & 0x7f) as i64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/elements/primitives.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | v @ _ => Err(Error::InvalidVarUint1(v)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | / match self { [INFO] [stderr] 301 | | &Opcode::Block(_) | &Opcode::Loop(_) | &Opcode::If(_) => true, [INFO] [stderr] 302 | | _ => false, [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 300 | match *self { [INFO] [stderr] 301 | Opcode::Block(_) | Opcode::Loop(_) | Opcode::If(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | / match self { [INFO] [stderr] 310 | | &Opcode::End => true, [INFO] [stderr] 311 | | _ => false, [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 309 | match *self { [INFO] [stderr] 310 | Opcode::End => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | if types.types().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!types.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if import.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!import.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if functions.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!functions.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | if table.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if memory.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!memory.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if global.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!global.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if export.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!export.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if element.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!element.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if code.bodies().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if data.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::module::ModuleBuilder` [INFO] [stderr] --> src/builder/module.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new() -> Self { [INFO] [stderr] 142 | | ModuleBuilder::with_callback(Identity) [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | impl Default for builder::module::ModuleBuilder { [INFO] [stderr] 140 | fn default() -> Self { [INFO] [stderr] 141 | Self::new() [INFO] [stderr] 142 | } [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignatureBuilder` [INFO] [stderr] --> src/builder/code.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | SignatureBuilder::with_callback(Identity) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for builder::code::SignatureBuilder { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignaturesBuilder` [INFO] [stderr] --> src/builder/code.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Self { [INFO] [stderr] 124 | | SignaturesBuilder::with_callback(Identity) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 121 | impl Default for builder::code::SignaturesBuilder { [INFO] [stderr] 122 | fn default() -> Self { [INFO] [stderr] 123 | Self::new() [INFO] [stderr] 124 | } [INFO] [stderr] 125 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::FunctionBuilder` [INFO] [stderr] --> src/builder/code.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | / pub fn new() -> Self { [INFO] [stderr] 248 | | FunctionBuilder::with_callback(Identity) [INFO] [stderr] 249 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | impl Default for builder::code::FunctionBuilder { [INFO] [stderr] 247 | fn default() -> Self { [INFO] [stderr] 248 | Self::new() [INFO] [stderr] 249 | } [INFO] [stderr] 250 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::import::ImportBuilder` [INFO] [stderr] --> src/builder/import.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | ImportBuilder::with_callback(Identity) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for builder::import::ImportBuilder { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::memory::MemoryBuilder` [INFO] [stderr] --> src/builder/memory.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | MemoryBuilder::with_callback(Identity) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for builder::memory::MemoryBuilder { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::table::TableBuilder` [INFO] [stderr] --> src/builder/table.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | TableBuilder::with_callback(Identity) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for builder::table::TableBuilder { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::export::ExportBuilder` [INFO] [stderr] --> src/builder/export.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | ExportBuilder::with_callback(Identity) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for builder::export::ExportBuilder { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::global::GlobalBuilder` [INFO] [stderr] --> src/builder/global.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | GlobalBuilder::with_callback(Identity) [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for builder::global::GlobalBuilder { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::data::DataSegmentBuilder` [INFO] [stderr] --> src/builder/data.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | DataSegmentBuilder::with_callback(Identity) [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for builder::data::DataSegmentBuilder { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | match opcode { [INFO] [stderr] | _________^ [INFO] [stderr] 123 | | &Opcode::Unreachable => Ok(InstructionOutcome::Unreachable), [INFO] [stderr] 124 | | &Opcode::Nop => Ok(InstructionOutcome::ValidateNextInstruction), [INFO] [stderr] 125 | | &Opcode::Block(block_type) => Validator::validate_block(context, block_type), [INFO] [stderr] ... | [INFO] [stderr] 311 | | &Opcode::F64ReinterpretI64 => Validator::validate_cvtop(context, ValueType::I64.into(), ValueType::F64.into()), [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | match *opcode { [INFO] [stderr] 123 | Opcode::Unreachable => Ok(InstructionOutcome::Unreachable), [INFO] [stderr] 124 | Opcode::Nop => Ok(InstructionOutcome::ValidateNextInstruction), [INFO] [stderr] 125 | Opcode::Block(block_type) => Validator::validate_block(context, block_type), [INFO] [stderr] 126 | Opcode::Loop(block_type) => Validator::validate_loop(context, block_type), [INFO] [stderr] 127 | Opcode::If(block_type) => Validator::validate_if(context, block_type), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/validator.rs:500:71 [INFO] [stderr] | [INFO] [stderr] 500 | fn validate_br_table(context: &mut FunctionValidationContext, table: &Vec, default: u32) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/validator.rs:600:6 [INFO] [stderr] | [INFO] [stderr] 600 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 600 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/interpreter/validator.rs:600:28 [INFO] [stderr] | [INFO] [stderr] 600 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/interpreter/validator.rs:612:4 [INFO] [stderr] | [INFO] [stderr] 612 | stack_value_type @ _ => Err(Error::Validation(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/interpreter/validator.rs:621:4 [INFO] [stderr] | [INFO] [stderr] 621 | stack_value_type @ _ => Err(Error::Validation(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/validator.rs:643:6 [INFO] [stderr] | [INFO] [stderr] 643 | Ok(self.value_stack.push(StackValueType::AnyUnlimited)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 643 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/validator.rs:651:6 [INFO] [stderr] | [INFO] [stderr] 651 | Ok(self.frame_stack.push(BlockFrame { [INFO] [stderr] | ____________^ [INFO] [stderr] 652 | | frame_type: frame_type, [INFO] [stderr] 653 | | block_type: block_type, [INFO] [stderr] 654 | | begin_position: self.position, [INFO] [stderr] ... | [INFO] [stderr] 657 | | value_stack_len: self.value_stack.len(), [INFO] [stderr] 658 | | })?) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 651 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/validator.rs:690:20 [INFO] [stderr] | [INFO] [stderr] 690 | self.return_type.ok_or(Error::Validation("Trying to return from expression".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation("Trying to return from expression".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/validator.rs:697:5 [INFO] [stderr] | [INFO] [stderr] 697 | .ok_or(Error::Validation(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/validator.rs:702:46 [INFO] [stderr] | [INFO] [stderr] 702 | .global(ItemIndex::IndexSpace(idx), None, self.externals.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.externals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter/validator.rs:757:16 [INFO] [stderr] | [INFO] [stderr] 757 | pub fn is_any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:758:3 [INFO] [stderr] | [INFO] [stderr] 758 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 759 | | &StackValueType::Any => true, [INFO] [stderr] 760 | | _ => false, [INFO] [stderr] 761 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 758 | match *self { [INFO] [stderr] 759 | StackValueType::Any => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter/validator.rs:764:26 [INFO] [stderr] | [INFO] [stderr] 764 | pub fn is_any_unlimited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:765:3 [INFO] [stderr] | [INFO] [stderr] 765 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 766 | | &StackValueType::AnyUnlimited => true, [INFO] [stderr] 767 | | _ => false, [INFO] [stderr] 768 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 765 | match *self { [INFO] [stderr] 766 | StackValueType::AnyUnlimited => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter/validator.rs:771:20 [INFO] [stderr] | [INFO] [stderr] 771 | pub fn value_type(&self) -> ValueType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:772:3 [INFO] [stderr] | [INFO] [stderr] 772 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 773 | | &StackValueType::Any | &StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 774 | | &StackValueType::Specific(value_type) => value_type, [INFO] [stderr] 775 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 772 | match *self { [INFO] [stderr] 773 | StackValueType::Any | StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 774 | StackValueType::Specific(value_type) => value_type, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 49 | | &UserFunctionDescriptor::Static(name, _, _) => name, [INFO] [stderr] 50 | | &UserFunctionDescriptor::Heap(ref name, _, _) => name, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | UserFunctionDescriptor::Static(name, _, _) => name, [INFO] [stderr] 50 | UserFunctionDescriptor::Heap(ref name, _, _) => name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 57 | | &UserFunctionDescriptor::Static(_, params, _) => params, [INFO] [stderr] 58 | | &UserFunctionDescriptor::Heap(_, ref params, _) => params, [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | UserFunctionDescriptor::Static(_, params, _) => params, [INFO] [stderr] 58 | UserFunctionDescriptor::Heap(_, ref params, _) => params, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 65 | | &UserFunctionDescriptor::Static(_, _, result) => result, [INFO] [stderr] 66 | | &UserFunctionDescriptor::Heap(_, _, result) => result, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | UserFunctionDescriptor::Static(_, _, result) => result, [INFO] [stderr] 66 | UserFunctionDescriptor::Heap(_, _, result) => result, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/native.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | fn export_entry<'b>(&self, name: &str, required_type: &ExportEntryType) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:127:4 [INFO] [stderr] | [INFO] [stderr] 127 | match required_type { [INFO] [stderr] | _____________^ [INFO] [stderr] 128 | | &ExportEntryType::Any => return Ok(Internal::Function(composite_index)), [INFO] [stderr] 129 | | &ExportEntryType::Function(ref required_type) => { [INFO] [stderr] 130 | | let actual_type = self.function_type(ItemIndex::Internal(composite_index)) [INFO] [stderr] ... | [INFO] [stderr] 147 | | _ => (), [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *required_type { [INFO] [stderr] 128 | ExportEntryType::Any => return Ok(Internal::Function(composite_index)), [INFO] [stderr] 129 | ExportEntryType::Function(ref required_type) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:152:4 [INFO] [stderr] | [INFO] [stderr] 152 | match required_type { [INFO] [stderr] | _____________^ [INFO] [stderr] 153 | | &ExportEntryType::Any => { [INFO] [stderr] 154 | | return Ok(Internal::Global(composite_index)) [INFO] [stderr] 155 | | } [INFO] [stderr] ... | [INFO] [stderr] 174 | | _ => (), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *required_type { [INFO] [stderr] 153 | ExportEntryType::Any => { [INFO] [stderr] 154 | return Ok(Internal::Global(composite_index)) [INFO] [stderr] 155 | } [INFO] [stderr] 156 | ExportEntryType::Global(ref required_type) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/native.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | .ok_or(Error::Native(format!("trying to get native global with index {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Native(format!("trying to get native global with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/native.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | .ok_or(Error::Native(format!("missing native function with index {}", index)))?)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Native(format!("missing native function with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/interpreter/native.rs:232:2 [INFO] [stderr] | [INFO] [stderr] 232 | fn function_body<'b>(&'b self, _internal_index: u32) -> Result>, Error> { [INFO] [stderr] | _____^ [INFO] [stderr] 233 | | Ok(None) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/native.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | .ok_or(Error::Native(format!("trying to call native function with index {}", index)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Native(format!("trying to call native function with index {}", index)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/interpreter/native.rs:243:11 [INFO] [stderr] | [INFO] [stderr] 243 | .ok_or(Error::Native(format!("trying to call native function with index {}", index)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Native(format!("trying to call native function with index {}", index))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/imports.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | match import_entry.external() { [INFO] [stderr] | _________________^ [INFO] [stderr] 35 | | &External::Function(_) => functions.push(import_index), [INFO] [stderr] 36 | | &External::Table(_) => tables.push(import_index), [INFO] [stderr] 37 | | &External::Memory(_) => memory.push(import_index), [INFO] [stderr] 38 | | &External::Global(_) => globals.push(import_index), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *import_entry.external() { [INFO] [stderr] 35 | External::Function(_) => functions.push(import_index), [INFO] [stderr] 36 | External::Table(_) => tables.push(import_index), [INFO] [stderr] 37 | External::Memory(_) => memory.push(import_index), [INFO] [stderr] 38 | External::Global(_) => globals.push(import_index), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:69:4 [INFO] [stderr] | [INFO] [stderr] 69 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:91:4 [INFO] [stderr] | [INFO] [stderr] 91 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:102:4 [INFO] [stderr] | [INFO] [stderr] 102 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/imports.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | .ok_or(Error::Program("program unloaded".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Program("program unloaded".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/imports.rs:117:33 [INFO] [stderr] | [INFO] [stderr] 117 | .and_then(|p| p.module(name).ok_or(Error::Program(format!("module {} is not loaded", name)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Program(format!("module {} is not loaded", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/imports.rs:122:80 [INFO] [stderr] | [INFO] [stderr] 122 | let (_, export) = self.external_export(externals, import, &required_type.map(|ft| ExportEntryType::Function(ft)).unwrap_or(ExportEntryType::Any))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ExportEntryType::Function` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/imports.rs:152:93 [INFO] [stderr] | [INFO] [stderr] 152 | let (module, export) = self.external_export(externals, import, &required_type.clone().map(|rt| ExportEntryType::Global(rt)).unwrap_or(ExportEntryType::Any))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ExportEntryType::Global` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/imports.rs:152:67 [INFO] [stderr] | [INFO] [stderr] 152 | let (module, export) = self.external_export(externals, import, &required_type.clone().map(|rt| ExportEntryType::Global(rt)).unwrap_or(ExportEntryType::Any))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `required_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/memory.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | .ok_or(Error::Memory(format!("initial memory size must be at most {} pages", LINEAR_MEMORY_MAX_PAGES)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("initial memory size must be at most {} pages", LINEAR_MEMORY_MAX_PAGES)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/memory.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | .ok_or(Error::Memory(format!("trying to access memory block of size {} from offset {}", size, offset)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access memory block of size {} from offset {}", size, offset)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/memory.rs:165:29 [INFO] [stderr] | [INFO] [stderr] 165 | return Err(Error::Memory(format!("non-overlapping copy is used for overlapping regions"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non-overlapping copy is used for overlapping regions".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/module.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | fn export_entry<'a>(&self, name: &str, required_type: &ExportEntryType) -> Result; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/interpreter/module.rs:75:2 [INFO] [stderr] | [INFO] [stderr] 75 | fn function_body<'a>(&'a self, internal_index: u32) -> Result>, Error>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/module.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn new<'a>(program: Weak, name: String, module: Module) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/module.rs:241:42 [INFO] [stderr] | [INFO] [stderr] 241 | if func_type.return_type() != None || func_type.params().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!func_type.params().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | match export.internal() { [INFO] [stderr] | _________________^ [INFO] [stderr] 250 | | &Internal::Function(function_index) => { [INFO] [stderr] 251 | | self.require_function(ItemIndex::IndexSpace(function_index)).map(|_| ())?; [INFO] [stderr] 252 | | self.exports.entry(export.field().into()).or_insert_with(Default::default).push(Internal::Function(function_index)); [INFO] [stderr] ... | [INFO] [stderr] 270 | | }, [INFO] [stderr] 271 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 249 | match *export.internal() { [INFO] [stderr] 250 | Internal::Function(function_index) => { [INFO] [stderr] 251 | self.require_function(ItemIndex::IndexSpace(function_index)).map(|_| ())?; [INFO] [stderr] 252 | self.exports.entry(export.field().into()).or_insert_with(Default::default).push(Internal::Function(function_index)); [INFO] [stderr] 253 | }, [INFO] [stderr] 254 | Internal::Global(global_index) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | match import.external() { [INFO] [stderr] | _________________^ [INFO] [stderr] 279 | | // for functions we need to check if function type matches in both modules [INFO] [stderr] 280 | | &External::Function(ref function_type_index) => { [INFO] [stderr] 281 | | // External::Function points to function type in type section in this module [INFO] [stderr] ... | [INFO] [stderr] 351 | | }, [INFO] [stderr] 352 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 278 | match *import.external() { [INFO] [stderr] 279 | // for functions we need to check if function type matches in both modules [INFO] [stderr] 280 | External::Function(ref function_type_index) => { [INFO] [stderr] 281 | // External::Function points to function type in type section in this module [INFO] [stderr] 282 | let import_function_type = self.function_type_by_index(*function_type_index)?; [INFO] [stderr] 283 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:381:68 [INFO] [stderr] | [INFO] [stderr] 381 | let function_body = code_section.bodies().get(index as usize).ok_or(Error::Validation(format!("Missing body for function {}", index)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation(format!("Missing body for function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:454:6 [INFO] [stderr] | [INFO] [stderr] 454 | .ok_or(Error::Function(format!("missing internal function {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing internal function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:456:7 [INFO] [stderr] | [INFO] [stderr] 456 | .ok_or(Error::Function(format!("missing internal function {}", index)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing internal function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:459:6 [INFO] [stderr] | [INFO] [stderr] 459 | .ok_or(Error::Function(format!("missing external function {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing external function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:461:7 [INFO] [stderr] | [INFO] [stderr] 461 | .ok_or(Error::Function(format!("missing external function {}", index)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing external function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:462:24 [INFO] [stderr] | [INFO] [stderr] 462 | .and_then(|import| match import.external() { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 463 | | &External::Function(type_idx) => Ok(type_idx), [INFO] [stderr] 464 | | _ => Err(Error::Function(format!("external function {} is pointing to non-function import", index))), [INFO] [stderr] 465 | | }), [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 462 | .and_then(|import| match *import.external() { [INFO] [stderr] 463 | External::Function(type_idx) => Ok(type_idx), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | .ok_or(Error::Function(format!("missing executable export with name {}", name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing executable export with name {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:487:6 [INFO] [stderr] | [INFO] [stderr] 487 | .ok_or(Error::Function(format!("missing exported function with name {}", name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing exported function with name {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:483:15 [INFO] [stderr] | [INFO] [stderr] 483 | .find(|i| match i { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 484 | | &&Internal::Function(_) => true, [INFO] [stderr] 485 | | _ => false, [INFO] [stderr] 486 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 483 | .find(|i| match *i { [INFO] [stderr] 484 | &Internal::Function(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | .map(|i| match i { [INFO] [stderr] | __________________________^ [INFO] [stderr] 489 | | &Internal::Function(index) => index, [INFO] [stderr] 490 | | _ => unreachable!(), // checked couple of lines above [INFO] [stderr] 491 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 488 | .map(|i| match *i { [INFO] [stderr] 489 | Internal::Function(index) => index, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/module.rs:496:18 [INFO] [stderr] | [INFO] [stderr] 496 | fn export_entry<'a>(&self, name: &str, required_type: &ExportEntryType) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:498:5 [INFO] [stderr] | [INFO] [stderr] 498 | .ok_or(Error::Function(format!("missing export entry with name {}", name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing export entry with name {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:515:6 [INFO] [stderr] | [INFO] [stderr] 515 | .ok_or(Error::Program(format!("unresolved export {}", name)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Program(format!("unresolved export {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter/module.rs:499:18 [INFO] [stderr] | [INFO] [stderr] 499 | .and_then(|l| l.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 500 | | .find(|i| match required_type { [INFO] [stderr] 501 | | &ExportEntryType::Any => true, [INFO] [stderr] 502 | | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] ... | [INFO] [stderr] 513 | | }) [INFO] [stderr] 514 | | .map(|i| *i) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 499 | .and_then(|l| l.iter() [INFO] [stderr] 500 | .find(|i| match required_type { [INFO] [stderr] 501 | &ExportEntryType::Any => true, [INFO] [stderr] 502 | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] 503 | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] 504 | _ => false, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:500:15 [INFO] [stderr] | [INFO] [stderr] 500 | .find(|i| match required_type { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 501 | | &ExportEntryType::Any => true, [INFO] [stderr] 502 | | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] 503 | | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] ... | [INFO] [stderr] 512 | | }, [INFO] [stderr] 513 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 500 | .find(|i| match *required_type { [INFO] [stderr] 501 | ExportEntryType::Any => true, [INFO] [stderr] 502 | ExportEntryType::Global(global_type) => match i { [INFO] [stderr] 503 | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] 504 | _ => false, [INFO] [stderr] 505 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:502:47 [INFO] [stderr] | [INFO] [stderr] 502 | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 503 | | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] 504 | | _ => false, [INFO] [stderr] 505 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 502 | &ExportEntryType::Global(global_type) => match *i { [INFO] [stderr] 503 | &Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:506:55 [INFO] [stderr] | [INFO] [stderr] 506 | &ExportEntryType::Function(ref required_type) => match i { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 507 | | &&Internal::Function(function_index) => [INFO] [stderr] 508 | | self.function_type(ItemIndex::IndexSpace(function_index)) [INFO] [stderr] 509 | | .map(|ft| ft == *required_type) [INFO] [stderr] 510 | | .unwrap_or(false), [INFO] [stderr] 511 | | _ => false, [INFO] [stderr] 512 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 506 | &ExportEntryType::Function(ref required_type) => match *i { [INFO] [stderr] 507 | &Internal::Function(function_index) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:522:6 [INFO] [stderr] | [INFO] [stderr] 522 | .ok_or(Error::Table(format!("trying to access table with local index {} when there are only {} local tables", index, self.tables.len()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to access table with local index {} when there are only {} local tables", index, self.tables.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:524:6 [INFO] [stderr] | [INFO] [stderr] 524 | .ok_or(Error::Table(format!("trying to access external table with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to access external table with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:526:7 [INFO] [stderr] | [INFO] [stderr] 526 | .ok_or(Error::Table(format!("trying to access external table with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to access external table with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:535:6 [INFO] [stderr] | [INFO] [stderr] 535 | .ok_or(Error::Memory(format!("trying to access memory with local index {} when there are only {} memory regions", index, self.memory.len()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access memory with local index {} when there are only {} memory regions", index, self.memory.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:537:6 [INFO] [stderr] | [INFO] [stderr] 537 | .ok_or(Error::Memory(format!("trying to access external memory with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access external memory with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:539:7 [INFO] [stderr] | [INFO] [stderr] 539 | .ok_or(Error::Memory(format!("trying to access external memory with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access external memory with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:548:6 [INFO] [stderr] | [INFO] [stderr] 548 | .ok_or(Error::Global(format!("trying to access global with local index {} when there are only {} globals", index, self.globals.len()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to access global with local index {} when there are only {} globals", index, self.globals.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:550:6 [INFO] [stderr] | [INFO] [stderr] 550 | .ok_or(Error::Global(format!("trying to access external global with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to access external global with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:552:7 [INFO] [stderr] | [INFO] [stderr] 552 | .ok_or(Error::Global(format!("trying to access external global with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to access external global with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:563:6 [INFO] [stderr] | [INFO] [stderr] 563 | .ok_or(Error::Function(format!("trying to access external function with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to access external function with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:565:7 [INFO] [stderr] | [INFO] [stderr] 565 | .ok_or(Error::Function(format!("trying to access external function with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to access external function with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:566:19 [INFO] [stderr] | [INFO] [stderr] 566 | .and_then(|e| match e.external() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 567 | | &External::Function(type_index) => self.function_type_by_index(type_index), [INFO] [stderr] 568 | | _ => Err(Error::Function(format!("exported function {} is not a function", index))), [INFO] [stderr] 569 | | }), [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 566 | .and_then(|e| match *e.external() { [INFO] [stderr] 567 | External::Function(type_index) => self.function_type_by_index(type_index), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:575:5 [INFO] [stderr] | [INFO] [stderr] 575 | .ok_or(Error::Validation(format!("type reference {} exists in module without type section", type_index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation(format!("type reference {} exists in module without type section", type_index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/interpreter/module.rs:624:2 [INFO] [stderr] | [INFO] [stderr] 624 | fn function_body<'a>(&'a self, internal_index: u32) -> Result>, Error> { [INFO] [stderr] | _____^ [INFO] [stderr] 625 | | let function_body = self.module [INFO] [stderr] 626 | | .code_section() [INFO] [stderr] 627 | | .ok_or(Error::Function(format!("trying to call function with index {} in module without code section", internal_index))) [INFO] [stderr] ... | [INFO] [stderr] 638 | | })) [INFO] [stderr] 639 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:627:5 [INFO] [stderr] | [INFO] [stderr] 627 | .ok_or(Error::Function(format!("trying to call function with index {} in module without code section", internal_index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to call function with index {} in module without code section", internal_index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:630:6 [INFO] [stderr] | [INFO] [stderr] 630 | .ok_or(Error::Function(format!("trying to call function with index {} in module with {} functions codes", internal_index, s.bodies().len()))))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to call function with index {} in module with {} functions codes", internal_index, s.bodies().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:632:5 [INFO] [stderr] | [INFO] [stderr] 632 | .ok_or(Error::Function(format!("trying to call non-validated internal function {}", internal_index)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to call non-validated internal function {}", internal_index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:689:2 [INFO] [stderr] | [INFO] [stderr] 689 | match first_opcode { [INFO] [stderr] | _____^ [INFO] [stderr] 690 | | &Opcode::GetGlobal(index) => { [INFO] [stderr] 691 | | let index = match imports.parse_global_index(ItemIndex::IndexSpace(index)) { [INFO] [stderr] 692 | | ItemIndex::External(index) => index, [INFO] [stderr] ... | [INFO] [stderr] 706 | | _ => Err(Error::Initialization(format!("not-supported {:?} instruction in instantiation-time initializer", first_opcode))), [INFO] [stderr] 707 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 689 | match *first_opcode { [INFO] [stderr] 690 | Opcode::GetGlobal(index) => { [INFO] [stderr] 691 | let index = match imports.parse_global_index(ItemIndex::IndexSpace(index)) { [INFO] [stderr] 692 | ItemIndex::External(index) => index, [INFO] [stderr] 693 | _ => return Err(Error::Global(format!("trying to initialize with non-external global {}", index))), [INFO] [stderr] 694 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:696:6 [INFO] [stderr] | [INFO] [stderr] 696 | .ok_or(Error::Global(format!("trying to initialize with external global with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to initialize with external global with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:698:7 [INFO] [stderr] | [INFO] [stderr] 698 | .ok_or(Error::Global(format!("trying to initialize with external global with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to initialize with external global with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:713:3 [INFO] [stderr] | [INFO] [stderr] 713 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 714 | | &FunctionSignature::Module(ft) => ft.return_type(), [INFO] [stderr] 715 | | &FunctionSignature::User(fd) => fd.return_type(), [INFO] [stderr] 716 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 713 | match *self { [INFO] [stderr] 714 | FunctionSignature::Module(ft) => ft.return_type(), [INFO] [stderr] 715 | FunctionSignature::User(fd) => fd.return_type(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:721:3 [INFO] [stderr] | [INFO] [stderr] 721 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 722 | | &FunctionSignature::Module(ft) => ft.params(), [INFO] [stderr] 723 | | &FunctionSignature::User(fd) => fd.params(), [INFO] [stderr] 724 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 721 | match *self { [INFO] [stderr] 722 | FunctionSignature::Module(ft) => ft.params(), [INFO] [stderr] 723 | FunctionSignature::User(fd) => fd.params(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:730:3 [INFO] [stderr] | [INFO] [stderr] 730 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 731 | | &FunctionSignature::Module(ft1) => match other { [INFO] [stderr] 732 | | &FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | | &FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] ... | [INFO] [stderr] 738 | | }, [INFO] [stderr] 739 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 730 | match *self { [INFO] [stderr] 731 | FunctionSignature::Module(ft1) => match other { [INFO] [stderr] 732 | &FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | &FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] 734 | }, [INFO] [stderr] 735 | FunctionSignature::User(ft1) => match other { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:731:39 [INFO] [stderr] | [INFO] [stderr] 731 | &FunctionSignature::Module(ft1) => match other { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 732 | | &FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | | &FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] 734 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 731 | &FunctionSignature::Module(ft1) => match *other { [INFO] [stderr] 732 | FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:735:37 [INFO] [stderr] | [INFO] [stderr] 735 | &FunctionSignature::User(ft1) => match other { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 736 | | &FunctionSignature::User(ft2) => ft1 == ft2, [INFO] [stderr] 737 | | &FunctionSignature::Module(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] 738 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 735 | &FunctionSignature::User(ft1) => match *other { [INFO] [stderr] 736 | FunctionSignature::User(ft2) => ft1 == ft2, [INFO] [stderr] 737 | FunctionSignature::Module(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::program::ProgramInstance` [INFO] [stderr] --> src/interpreter/program.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 23 | | ProgramInstance { [INFO] [stderr] 24 | | essence: Arc::new(ProgramInstanceEssence::new()), [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for interpreter::program::ProgramInstance { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::program::ProgramInstanceEssence` [INFO] [stderr] --> src/interpreter/program.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | ProgramInstanceEssence { [INFO] [stderr] 56 | | modules: RwLock::new(HashMap::new()), [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/runner.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | match opcode { [INFO] [stderr] | _________^ [INFO] [stderr] 156 | | &Opcode::Unreachable => Interpreter::run_unreachable(context), [INFO] [stderr] 157 | | &Opcode::Nop => Interpreter::run_nop(context), [INFO] [stderr] 158 | | &Opcode::Block(block_type) => Interpreter::run_block(context, labels, block_type), [INFO] [stderr] ... | [INFO] [stderr] 344 | | &Opcode::F64ReinterpretI64 => Interpreter::run_reinterpret::(context), [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *opcode { [INFO] [stderr] 156 | Opcode::Unreachable => Interpreter::run_unreachable(context), [INFO] [stderr] 157 | Opcode::Nop => Interpreter::run_nop(context), [INFO] [stderr] 158 | Opcode::Block(block_type) => Interpreter::run_block(context, labels, block_type), [INFO] [stderr] 159 | Opcode::Loop(block_type) => Interpreter::run_loop(context, labels, block_type), [INFO] [stderr] 160 | Opcode::If(block_type) => Interpreter::run_if(context, labels, block_type), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/runner.rs:405:60 [INFO] [stderr] | [INFO] [stderr] 405 | fn run_br_table<'a>(context: &mut FunctionContext, table: &Vec, default: u32) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:497:14 [INFO] [stderr] | [INFO] [stderr] 497 | .and_then(|b| T::from_little_endian(b)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::from_little_endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:508:14 [INFO] [stderr] | [INFO] [stderr] 508 | .and_then(|b| T::from_little_endian(b)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::from_little_endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:972:49 [INFO] [stderr] | [INFO] [stderr] 972 | return_type: function_type.return_type().map(|vt| BlockType::Value(vt)).unwrap_or(BlockType::NoResult), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BlockType::Value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:983:63 [INFO] [stderr] | [INFO] [stderr] 983 | let function_return_type = function_type.return_type().map(|vt| BlockType::Value(vt)).unwrap_or(BlockType::NoResult); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BlockType::Value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/runner.rs:1026:5 [INFO] [stderr] | [INFO] [stderr] 1026 | .ok_or(Error::Local(format!("expected to have local with index {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Local(format!("expected to have local with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/runner.rs:1033:5 [INFO] [stderr] | [INFO] [stderr] 1033 | .ok_or(Error::Local(format!("expected to have local with index {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Local(format!("expected to have local with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/runner.rs:1071:6 [INFO] [stderr] | [INFO] [stderr] 1071 | Ok(self.frame_stack.push(BlockFrame { [INFO] [stderr] | ____________^ [INFO] [stderr] 1072 | | frame_type: frame_type, [INFO] [stderr] 1073 | | block_type: block_type, [INFO] [stderr] 1074 | | begin_position: begin_position, [INFO] [stderr] ... | [INFO] [stderr] 1077 | | value_stack_len: self.value_stack.len(), [INFO] [stderr] 1078 | | })?) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1071 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/runner.rs:1082:6 [INFO] [stderr] | [INFO] [stderr] 1082 | Ok(self.frame_stack.pop().map(|_| ())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1082 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/table.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(Error::Table(format!("trying to read table item with index {} when there are only {} items", offset, buffer_len))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to read table item with index {} when there are only {} items", offset, buffer_len)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/table.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | .ok_or(Error::Table(format!("trying to update table item with index {} when there are only {} items", offset, buffer_len))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to update table item with index {} when there are only {} items", offset, buffer_len)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:185:26 [INFO] [stderr] | [INFO] [stderr] 185 | _ => Err(Error::Value(format!("32-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:194:26 [INFO] [stderr] | [INFO] [stderr] 194 | _ => Err(Error::Value(format!("32-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | _ => Err(Error::Value(format!("64-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"64-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:212:26 [INFO] [stderr] | [INFO] [stderr] 212 | _ => Err(Error::Value(format!("32-bit float value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit float value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | _ => Err(Error::Value(format!("64-bit float value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"64-bit float value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:230:26 [INFO] [stderr] | [INFO] [stderr] 230 | _ => Err(Error::Value(format!("32-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:239:26 [INFO] [stderr] | [INFO] [stderr] 239 | _ => Err(Error::Value(format!("64-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"64-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 289 | impl_try_truncate_into!(f32, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 289 | impl_try_truncate_into!(f32, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 290 | impl_try_truncate_into!(f32, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 290 | impl_try_truncate_into!(f32, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 291 | impl_try_truncate_into!(f64, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 291 | impl_try_truncate_into!(f64, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 291 | impl_try_truncate_into!(f64, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 292 | impl_try_truncate_into!(f64, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 292 | impl_try_truncate_into!(f64, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 293 | impl_try_truncate_into!(f32, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 293 | impl_try_truncate_into!(f32, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_try_truncate_into!(f32, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 294 | impl_try_truncate_into!(f32, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 295 | impl_try_truncate_into!(f64, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 295 | impl_try_truncate_into!(f64, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 295 | impl_try_truncate_into!(f64, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 296 | impl_try_truncate_into!(f64, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 296 | impl_try_truncate_into!(f64, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 308 | impl_extend_into!(i8, i32); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 309 | impl_extend_into!(u8, i32); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 310 | impl_extend_into!(i16, i32); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_extend_into!(u16, i32); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_extend_into!(i8, i64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_extend_into!(u8, i64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 314 | impl_extend_into!(i16, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 315 | impl_extend_into!(u16, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 316 | impl_extend_into!(i32, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 317 | impl_extend_into!(u32, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 318 | impl_extend_into!(u32, u64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 320 | impl_extend_into!(i32, f64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 322 | impl_extend_into!(u32, f64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 325 | impl_extend_into!(f32, f64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/value.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | .ok_or(Error::Value("invalid little endian buffer".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Value("invalid little endian buffer".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/value.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | .ok_or(Error::Value("invalid little endian buffer".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Value("invalid little endian buffer".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/interpreter/value.rs:515:11 [INFO] [stderr] | [INFO] [stderr] 515 | unsafe { ::std::mem::transmute(v) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/interpreter/value.rs:533:11 [INFO] [stderr] | [INFO] [stderr] 533 | unsafe { ::std::mem::transmute(v) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:579:38 [INFO] [stderr] | [INFO] [stderr] 579 | fn leading_zeros(self) -> $type { self.leading_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 594 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:580:39 [INFO] [stderr] | [INFO] [stderr] 580 | fn trailing_zeros(self) -> $type { self.trailing_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 594 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:581:35 [INFO] [stderr] | [INFO] [stderr] 581 | fn count_ones(self) -> $type { self.count_ones() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 594 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:579:38 [INFO] [stderr] | [INFO] [stderr] 579 | fn leading_zeros(self) -> $type { self.leading_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 595 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:580:39 [INFO] [stderr] | [INFO] [stderr] 580 | fn trailing_zeros(self) -> $type { self.trailing_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 595 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:581:35 [INFO] [stderr] | [INFO] [stderr] 581 | fn count_ones(self) -> $type { self.count_ones() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 595 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/validation/func.rs:504:71 [INFO] [stderr] | [INFO] [stderr] 504 | fn validate_br_table(context: &mut FunctionValidationContext, table: &Vec, default: u32) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/validation/func.rs:611:6 [INFO] [stderr] | [INFO] [stderr] 611 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 611 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/validation/func.rs:611:28 [INFO] [stderr] | [INFO] [stderr] 611 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/validation/func.rs:623:4 [INFO] [stderr] | [INFO] [stderr] 623 | stack_value_type @ _ => Err(Error(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/validation/func.rs:632:4 [INFO] [stderr] | [INFO] [stderr] 632 | stack_value_type @ _ => Err(Error(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/validation/func.rs:654:6 [INFO] [stderr] | [INFO] [stderr] 654 | Ok(self.value_stack.push(StackValueType::AnyUnlimited)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 654 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/validation/func.rs:662:6 [INFO] [stderr] | [INFO] [stderr] 662 | Ok(self.frame_stack.push(BlockFrame { [INFO] [stderr] | ____________^ [INFO] [stderr] 663 | | frame_type: frame_type, [INFO] [stderr] 664 | | block_type: block_type, [INFO] [stderr] 665 | | begin_position: self.position, [INFO] [stderr] ... | [INFO] [stderr] 668 | | value_stack_len: self.value_stack.len(), [INFO] [stderr] 669 | | })?) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 662 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/validation/func.rs:701:20 [INFO] [stderr] | [INFO] [stderr] 701 | self.return_type.ok_or(Error("Trying to return from expression".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("Trying to return from expression".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/validation/func.rs:708:5 [INFO] [stderr] | [INFO] [stderr] 708 | .ok_or(Error(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validation/func.rs:722:12 [INFO] [stderr] | [INFO] [stderr] 722 | fn is_any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation/func.rs:723:3 [INFO] [stderr] | [INFO] [stderr] 723 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 724 | | &StackValueType::Any => true, [INFO] [stderr] 725 | | _ => false, [INFO] [stderr] 726 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 723 | match *self { [INFO] [stderr] 724 | StackValueType::Any => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validation/func.rs:729:22 [INFO] [stderr] | [INFO] [stderr] 729 | fn is_any_unlimited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation/func.rs:730:3 [INFO] [stderr] | [INFO] [stderr] 730 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 731 | | &StackValueType::AnyUnlimited => true, [INFO] [stderr] 732 | | _ => false, [INFO] [stderr] 733 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 730 | match *self { [INFO] [stderr] 731 | StackValueType::AnyUnlimited => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validation/func.rs:736:16 [INFO] [stderr] | [INFO] [stderr] 736 | fn value_type(&self) -> ValueType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation/func.rs:737:3 [INFO] [stderr] | [INFO] [stderr] 737 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 738 | | &StackValueType::Any | &StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 739 | | &StackValueType::Specific(value_type) => value_type, [INFO] [stderr] 740 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 737 | match *self { [INFO] [stderr] 738 | StackValueType::Any | StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 739 | StackValueType::Specific(value_type) => value_type, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/validation/mod.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | .ok_or(Error(format!("Missing body for function {}", index)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error(format!("Missing body for function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validation/mod.rs:75:42 [INFO] [stderr] | [INFO] [stderr] 75 | if return_ty != BlockType::NoResult || params.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/validation/mod.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|ts| ts.types().into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/common/stack.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | .ok_or(Error("non-empty stack expected".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("non-empty stack expected".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/common/stack.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | .ok_or(Error("non-empty stack expected".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("non-empty stack expected".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/common/stack.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | .ok_or(Error("non-empty stack expected".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("non-empty stack expected".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sophon-wasm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | if let &Section::Code(ref code_section) = section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | if let Section::Code(ref code_section) = *section { return Some(code_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | if let &Section::Type(ref type_section) = section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let Section::Type(ref type_section) = *section { return Some(type_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | if let &Section::Import(ref import_section) = section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | if let Section::Import(ref import_section) = *section { return Some(import_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | if let &Section::Global(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | if let Section::Global(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | if let &Section::Export(ref export_section) = section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | if let Section::Export(ref export_section) = *section { return Some(export_section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | if let &Section::Table(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | if let Section::Table(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | if let &Section::Data(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | if let Section::Data(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | if let &Section::Element(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | if let Section::Element(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | if let &Section::Memory(ref section) = section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | if let Section::Memory(ref section) = *section { return Some(section); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | if let &Section::Function(ref sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | if let Section::Function(ref sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | if let &Section::Start(sect) = section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | if let Section::Start(sect) = *section { return Some(sect); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elements/module.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | reader.read(&mut magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | if let &Section::Type(_) = x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 279 | if let Section::Type(_) = *x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | if let &Section::Import(_) = x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 297 | if let Section::Import(_) = *x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/module.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | if let &Section::Code(_) = x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 315 | if let Section::Code(_) = *x { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elements/section.rs:75:37 [INFO] [stderr] | [INFO] [stderr] 75 | Section::Custom(CustomSection::deserialize(reader)?.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CustomSection::deserialize(reader)?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:314:29 [INFO] [stderr] | [INFO] [stderr] 314 | .filter(|entry| match entry.external() { &External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 314 | .filter(|entry| match *entry.external() { External::Function(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:321:29 [INFO] [stderr] | [INFO] [stderr] 321 | .filter(|entry| match entry.external() { &External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | .filter(|entry| match *entry.external() { External::Global(_) => true, _ => false }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/section.rs:755:13 [INFO] [stderr] | [INFO] [stderr] 755 | / match section { [INFO] [stderr] 756 | | &Section::Import(ref import_section) => { [INFO] [stderr] 757 | | assert_eq!(25, import_section.entries().len()); [INFO] [stderr] 758 | | found = true [INFO] [stderr] 759 | | }, [INFO] [stderr] 760 | | _ => { } [INFO] [stderr] 761 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 755 | if let &Section::Import(ref import_section) = section { [INFO] [stderr] 756 | assert_eq!(25, import_section.entries().len()); [INFO] [stderr] 757 | found = true [INFO] [stderr] 758 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/section.rs:755:13 [INFO] [stderr] | [INFO] [stderr] 755 | / match section { [INFO] [stderr] 756 | | &Section::Import(ref import_section) => { [INFO] [stderr] 757 | | assert_eq!(25, import_section.entries().len()); [INFO] [stderr] 758 | | found = true [INFO] [stderr] 759 | | }, [INFO] [stderr] 760 | | _ => { } [INFO] [stderr] 761 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 755 | match *section { [INFO] [stderr] 756 | Section::Import(ref import_section) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/section.rs:803:9 [INFO] [stderr] | [INFO] [stderr] 803 | / match section { [INFO] [stderr] 804 | | Section::Function(fn_section) => { [INFO] [stderr] 805 | | assert_eq!(4, fn_section.entries().len(), "There should be 4 functions total"); [INFO] [stderr] 806 | | }, [INFO] [stderr] ... | [INFO] [stderr] 809 | | } [INFO] [stderr] 810 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 803 | if let Section::Function(fn_section) = section { [INFO] [stderr] 804 | assert_eq!(4, fn_section.entries().len(), "There should be 4 functions total"); [INFO] [stderr] 805 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elements/section.rs:818:9 [INFO] [stderr] | [INFO] [stderr] 818 | / match section { [INFO] [stderr] 819 | | Section::Function(fn_section) => { [INFO] [stderr] 820 | | assert_eq!(6, fn_section.entries()[1].type_ref()); [INFO] [stderr] 821 | | }, [INFO] [stderr] ... | [INFO] [stderr] 824 | | } [INFO] [stderr] 825 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 818 | if let Section::Function(fn_section) = section { [INFO] [stderr] 819 | assert_eq!(6, fn_section.entries()[1].type_ref()); [INFO] [stderr] 820 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elements/section.rs:870:18 [INFO] [stderr] | [INFO] [stderr] 870 | let t1 = match &type_section.types()[1] { [INFO] [stderr] | __________________^ [INFO] [stderr] 871 | | &Type::Function(ref func_type) => func_type [INFO] [stderr] 872 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 870 | let t1 = match type_section.types()[1] { [INFO] [stderr] 871 | Type::Function(ref func_type) => func_type [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let b = u8buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | let b = u8buf[0] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u8buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | res |= ((b & 0x7f) as i32) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/elements/primitives.rs:301:20 [INFO] [stderr] | [INFO] [stderr] 301 | res |= ((b & 0x7f) as i64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/elements/primitives.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | v @ _ => Err(Error::InvalidVarUint1(v)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/elements/primitives.rs:744:24 [INFO] [stderr] | [INFO] [stderr] 744 | let v3: i8 = (*vars.get(1).unwrap()).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vars[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | / match self { [INFO] [stderr] 301 | | &Opcode::Block(_) | &Opcode::Loop(_) | &Opcode::If(_) => true, [INFO] [stderr] 302 | | _ => false, [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 300 | match *self { [INFO] [stderr] 301 | Opcode::Block(_) | Opcode::Loop(_) | Opcode::If(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/elements/ops.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | / match self { [INFO] [stderr] 310 | | &Opcode::End => true, [INFO] [stderr] 311 | | _ => false, [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 309 | match *self { [INFO] [stderr] 310 | Opcode::End => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/elements/ops.rs:1201:5 [INFO] [stderr] | [INFO] [stderr] 1201 | / match &opcodes[0] { [INFO] [stderr] 1202 | | &Opcode::If(_) => (), [INFO] [stderr] 1203 | | _ => panic!("Should be deserialized as if opcode"), [INFO] [stderr] 1204 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1201 | match opcodes[0] { [INFO] [stderr] 1202 | Opcode::If(_) => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | if types.types().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!types.types().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if import.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!import.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if functions.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!functions.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | if table.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | if memory.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!memory.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if global.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!global.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if export.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!export.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if element.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!element.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if code.bodies().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!code.bodies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder/module.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if data.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::module::ModuleBuilder` [INFO] [stderr] --> src/builder/module.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new() -> Self { [INFO] [stderr] 142 | | ModuleBuilder::with_callback(Identity) [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | impl Default for builder::module::ModuleBuilder { [INFO] [stderr] 140 | fn default() -> Self { [INFO] [stderr] 141 | Self::new() [INFO] [stderr] 142 | } [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignatureBuilder` [INFO] [stderr] --> src/builder/code.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | SignatureBuilder::with_callback(Identity) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for builder::code::SignatureBuilder { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::SignaturesBuilder` [INFO] [stderr] --> src/builder/code.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Self { [INFO] [stderr] 124 | | SignaturesBuilder::with_callback(Identity) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 121 | impl Default for builder::code::SignaturesBuilder { [INFO] [stderr] 122 | fn default() -> Self { [INFO] [stderr] 123 | Self::new() [INFO] [stderr] 124 | } [INFO] [stderr] 125 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::code::FunctionBuilder` [INFO] [stderr] --> src/builder/code.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | / pub fn new() -> Self { [INFO] [stderr] 248 | | FunctionBuilder::with_callback(Identity) [INFO] [stderr] 249 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | impl Default for builder::code::FunctionBuilder { [INFO] [stderr] 247 | fn default() -> Self { [INFO] [stderr] 248 | Self::new() [INFO] [stderr] 249 | } [INFO] [stderr] 250 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::import::ImportBuilder` [INFO] [stderr] --> src/builder/import.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | ImportBuilder::with_callback(Identity) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for builder::import::ImportBuilder { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::memory::MemoryBuilder` [INFO] [stderr] --> src/builder/memory.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | MemoryBuilder::with_callback(Identity) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for builder::memory::MemoryBuilder { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::table::TableBuilder` [INFO] [stderr] --> src/builder/table.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | TableBuilder::with_callback(Identity) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for builder::table::TableBuilder { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::export::ExportBuilder` [INFO] [stderr] --> src/builder/export.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | ExportBuilder::with_callback(Identity) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for builder::export::ExportBuilder { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::global::GlobalBuilder` [INFO] [stderr] --> src/builder/global.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | GlobalBuilder::with_callback(Identity) [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for builder::global::GlobalBuilder { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::data::DataSegmentBuilder` [INFO] [stderr] --> src/builder/data.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | DataSegmentBuilder::with_callback(Identity) [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for builder::data::DataSegmentBuilder { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | match opcode { [INFO] [stderr] | _________^ [INFO] [stderr] 123 | | &Opcode::Unreachable => Ok(InstructionOutcome::Unreachable), [INFO] [stderr] 124 | | &Opcode::Nop => Ok(InstructionOutcome::ValidateNextInstruction), [INFO] [stderr] 125 | | &Opcode::Block(block_type) => Validator::validate_block(context, block_type), [INFO] [stderr] ... | [INFO] [stderr] 311 | | &Opcode::F64ReinterpretI64 => Validator::validate_cvtop(context, ValueType::I64.into(), ValueType::F64.into()), [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | match *opcode { [INFO] [stderr] 123 | Opcode::Unreachable => Ok(InstructionOutcome::Unreachable), [INFO] [stderr] 124 | Opcode::Nop => Ok(InstructionOutcome::ValidateNextInstruction), [INFO] [stderr] 125 | Opcode::Block(block_type) => Validator::validate_block(context, block_type), [INFO] [stderr] 126 | Opcode::Loop(block_type) => Validator::validate_loop(context, block_type), [INFO] [stderr] 127 | Opcode::If(block_type) => Validator::validate_if(context, block_type), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/validator.rs:500:71 [INFO] [stderr] | [INFO] [stderr] 500 | fn validate_br_table(context: &mut FunctionValidationContext, table: &Vec, default: u32) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/validator.rs:600:6 [INFO] [stderr] | [INFO] [stderr] 600 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 600 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/interpreter/validator.rs:600:28 [INFO] [stderr] | [INFO] [stderr] 600 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/interpreter/validator.rs:612:4 [INFO] [stderr] | [INFO] [stderr] 612 | stack_value_type @ _ => Err(Error::Validation(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/interpreter/validator.rs:621:4 [INFO] [stderr] | [INFO] [stderr] 621 | stack_value_type @ _ => Err(Error::Validation(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/validator.rs:643:6 [INFO] [stderr] | [INFO] [stderr] 643 | Ok(self.value_stack.push(StackValueType::AnyUnlimited)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 643 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/validator.rs:651:6 [INFO] [stderr] | [INFO] [stderr] 651 | Ok(self.frame_stack.push(BlockFrame { [INFO] [stderr] | ____________^ [INFO] [stderr] 652 | | frame_type: frame_type, [INFO] [stderr] 653 | | block_type: block_type, [INFO] [stderr] 654 | | begin_position: self.position, [INFO] [stderr] ... | [INFO] [stderr] 657 | | value_stack_len: self.value_stack.len(), [INFO] [stderr] 658 | | })?) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 651 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/validator.rs:690:20 [INFO] [stderr] | [INFO] [stderr] 690 | self.return_type.ok_or(Error::Validation("Trying to return from expression".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation("Trying to return from expression".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/validator.rs:697:5 [INFO] [stderr] | [INFO] [stderr] 697 | .ok_or(Error::Validation(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/validator.rs:702:46 [INFO] [stderr] | [INFO] [stderr] 702 | .global(ItemIndex::IndexSpace(idx), None, self.externals.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.externals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter/validator.rs:757:16 [INFO] [stderr] | [INFO] [stderr] 757 | pub fn is_any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:758:3 [INFO] [stderr] | [INFO] [stderr] 758 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 759 | | &StackValueType::Any => true, [INFO] [stderr] 760 | | _ => false, [INFO] [stderr] 761 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 758 | match *self { [INFO] [stderr] 759 | StackValueType::Any => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter/validator.rs:764:26 [INFO] [stderr] | [INFO] [stderr] 764 | pub fn is_any_unlimited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:765:3 [INFO] [stderr] | [INFO] [stderr] 765 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 766 | | &StackValueType::AnyUnlimited => true, [INFO] [stderr] 767 | | _ => false, [INFO] [stderr] 768 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 765 | match *self { [INFO] [stderr] 766 | StackValueType::AnyUnlimited => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter/validator.rs:771:20 [INFO] [stderr] | [INFO] [stderr] 771 | pub fn value_type(&self) -> ValueType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/validator.rs:772:3 [INFO] [stderr] | [INFO] [stderr] 772 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 773 | | &StackValueType::Any | &StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 774 | | &StackValueType::Specific(value_type) => value_type, [INFO] [stderr] 775 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 772 | match *self { [INFO] [stderr] 773 | StackValueType::Any | StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 774 | StackValueType::Specific(value_type) => value_type, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 49 | | &UserFunctionDescriptor::Static(name, _, _) => name, [INFO] [stderr] 50 | | &UserFunctionDescriptor::Heap(ref name, _, _) => name, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | UserFunctionDescriptor::Static(name, _, _) => name, [INFO] [stderr] 50 | UserFunctionDescriptor::Heap(ref name, _, _) => name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 57 | | &UserFunctionDescriptor::Static(_, params, _) => params, [INFO] [stderr] 58 | | &UserFunctionDescriptor::Heap(_, ref params, _) => params, [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | UserFunctionDescriptor::Static(_, params, _) => params, [INFO] [stderr] 58 | UserFunctionDescriptor::Heap(_, ref params, _) => params, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 65 | | &UserFunctionDescriptor::Static(_, _, result) => result, [INFO] [stderr] 66 | | &UserFunctionDescriptor::Heap(_, _, result) => result, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | UserFunctionDescriptor::Static(_, _, result) => result, [INFO] [stderr] 66 | UserFunctionDescriptor::Heap(_, _, result) => result, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/native.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | fn export_entry<'b>(&self, name: &str, required_type: &ExportEntryType) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:127:4 [INFO] [stderr] | [INFO] [stderr] 127 | match required_type { [INFO] [stderr] | _____________^ [INFO] [stderr] 128 | | &ExportEntryType::Any => return Ok(Internal::Function(composite_index)), [INFO] [stderr] 129 | | &ExportEntryType::Function(ref required_type) => { [INFO] [stderr] 130 | | let actual_type = self.function_type(ItemIndex::Internal(composite_index)) [INFO] [stderr] ... | [INFO] [stderr] 147 | | _ => (), [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *required_type { [INFO] [stderr] 128 | ExportEntryType::Any => return Ok(Internal::Function(composite_index)), [INFO] [stderr] 129 | ExportEntryType::Function(ref required_type) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/native.rs:152:4 [INFO] [stderr] | [INFO] [stderr] 152 | match required_type { [INFO] [stderr] | _____________^ [INFO] [stderr] 153 | | &ExportEntryType::Any => { [INFO] [stderr] 154 | | return Ok(Internal::Global(composite_index)) [INFO] [stderr] 155 | | } [INFO] [stderr] ... | [INFO] [stderr] 174 | | _ => (), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | match *required_type { [INFO] [stderr] 153 | ExportEntryType::Any => { [INFO] [stderr] 154 | return Ok(Internal::Global(composite_index)) [INFO] [stderr] 155 | } [INFO] [stderr] 156 | ExportEntryType::Global(ref required_type) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/native.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | .ok_or(Error::Native(format!("trying to get native global with index {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Native(format!("trying to get native global with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/native.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | .ok_or(Error::Native(format!("missing native function with index {}", index)))?)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Native(format!("missing native function with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/interpreter/native.rs:232:2 [INFO] [stderr] | [INFO] [stderr] 232 | fn function_body<'b>(&'b self, _internal_index: u32) -> Result>, Error> { [INFO] [stderr] | _____^ [INFO] [stderr] 233 | | Ok(None) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/native.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | .ok_or(Error::Native(format!("trying to call native function with index {}", index)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Native(format!("trying to call native function with index {}", index)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/interpreter/native.rs:243:11 [INFO] [stderr] | [INFO] [stderr] 243 | .ok_or(Error::Native(format!("trying to call native function with index {}", index)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Native(format!("trying to call native function with index {}", index))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/imports.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | match import_entry.external() { [INFO] [stderr] | _________________^ [INFO] [stderr] 35 | | &External::Function(_) => functions.push(import_index), [INFO] [stderr] 36 | | &External::Table(_) => tables.push(import_index), [INFO] [stderr] 37 | | &External::Memory(_) => memory.push(import_index), [INFO] [stderr] 38 | | &External::Global(_) => globals.push(import_index), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *import_entry.external() { [INFO] [stderr] 35 | External::Function(_) => functions.push(import_index), [INFO] [stderr] 36 | External::Table(_) => tables.push(import_index), [INFO] [stderr] 37 | External::Memory(_) => memory.push(import_index), [INFO] [stderr] 38 | External::Global(_) => globals.push(import_index), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:69:4 [INFO] [stderr] | [INFO] [stderr] 69 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:91:4 [INFO] [stderr] | [INFO] [stderr] 91 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `index @ _` pattern can be written as just `index` [INFO] [stderr] --> src/interpreter/imports.rs:102:4 [INFO] [stderr] | [INFO] [stderr] 102 | index @ _ => index, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/imports.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | .ok_or(Error::Program("program unloaded".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Program("program unloaded".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/imports.rs:117:33 [INFO] [stderr] | [INFO] [stderr] 117 | .and_then(|p| p.module(name).ok_or(Error::Program(format!("module {} is not loaded", name)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Program(format!("module {} is not loaded", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/imports.rs:122:80 [INFO] [stderr] | [INFO] [stderr] 122 | let (_, export) = self.external_export(externals, import, &required_type.map(|ft| ExportEntryType::Function(ft)).unwrap_or(ExportEntryType::Any))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ExportEntryType::Function` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/imports.rs:152:93 [INFO] [stderr] | [INFO] [stderr] 152 | let (module, export) = self.external_export(externals, import, &required_type.clone().map(|rt| ExportEntryType::Global(rt)).unwrap_or(ExportEntryType::Any))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ExportEntryType::Global` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/imports.rs:152:67 [INFO] [stderr] | [INFO] [stderr] 152 | let (module, export) = self.external_export(externals, import, &required_type.clone().map(|rt| ExportEntryType::Global(rt)).unwrap_or(ExportEntryType::Any))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `required_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/memory.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | .ok_or(Error::Memory(format!("initial memory size must be at most {} pages", LINEAR_MEMORY_MAX_PAGES)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("initial memory size must be at most {} pages", LINEAR_MEMORY_MAX_PAGES)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/memory.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | .ok_or(Error::Memory(format!("trying to access memory block of size {} from offset {}", size, offset)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access memory block of size {} from offset {}", size, offset)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/memory.rs:165:29 [INFO] [stderr] | [INFO] [stderr] 165 | return Err(Error::Memory(format!("non-overlapping copy is used for overlapping regions"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non-overlapping copy is used for overlapping regions".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/module.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | fn export_entry<'a>(&self, name: &str, required_type: &ExportEntryType) -> Result; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/interpreter/module.rs:75:2 [INFO] [stderr] | [INFO] [stderr] 75 | fn function_body<'a>(&'a self, internal_index: u32) -> Result>, Error>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/module.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn new<'a>(program: Weak, name: String, module: Module) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/module.rs:241:42 [INFO] [stderr] | [INFO] [stderr] 241 | if func_type.return_type() != None || func_type.params().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!func_type.params().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | match export.internal() { [INFO] [stderr] | _________________^ [INFO] [stderr] 250 | | &Internal::Function(function_index) => { [INFO] [stderr] 251 | | self.require_function(ItemIndex::IndexSpace(function_index)).map(|_| ())?; [INFO] [stderr] 252 | | self.exports.entry(export.field().into()).or_insert_with(Default::default).push(Internal::Function(function_index)); [INFO] [stderr] ... | [INFO] [stderr] 270 | | }, [INFO] [stderr] 271 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 249 | match *export.internal() { [INFO] [stderr] 250 | Internal::Function(function_index) => { [INFO] [stderr] 251 | self.require_function(ItemIndex::IndexSpace(function_index)).map(|_| ())?; [INFO] [stderr] 252 | self.exports.entry(export.field().into()).or_insert_with(Default::default).push(Internal::Function(function_index)); [INFO] [stderr] 253 | }, [INFO] [stderr] 254 | Internal::Global(global_index) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | match import.external() { [INFO] [stderr] | _________________^ [INFO] [stderr] 279 | | // for functions we need to check if function type matches in both modules [INFO] [stderr] 280 | | &External::Function(ref function_type_index) => { [INFO] [stderr] 281 | | // External::Function points to function type in type section in this module [INFO] [stderr] ... | [INFO] [stderr] 351 | | }, [INFO] [stderr] 352 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 278 | match *import.external() { [INFO] [stderr] 279 | // for functions we need to check if function type matches in both modules [INFO] [stderr] 280 | External::Function(ref function_type_index) => { [INFO] [stderr] 281 | // External::Function points to function type in type section in this module [INFO] [stderr] 282 | let import_function_type = self.function_type_by_index(*function_type_index)?; [INFO] [stderr] 283 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:381:68 [INFO] [stderr] | [INFO] [stderr] 381 | let function_body = code_section.bodies().get(index as usize).ok_or(Error::Validation(format!("Missing body for function {}", index)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation(format!("Missing body for function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:454:6 [INFO] [stderr] | [INFO] [stderr] 454 | .ok_or(Error::Function(format!("missing internal function {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing internal function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:456:7 [INFO] [stderr] | [INFO] [stderr] 456 | .ok_or(Error::Function(format!("missing internal function {}", index)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing internal function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:459:6 [INFO] [stderr] | [INFO] [stderr] 459 | .ok_or(Error::Function(format!("missing external function {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing external function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:461:7 [INFO] [stderr] | [INFO] [stderr] 461 | .ok_or(Error::Function(format!("missing external function {}", index)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing external function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:462:24 [INFO] [stderr] | [INFO] [stderr] 462 | .and_then(|import| match import.external() { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 463 | | &External::Function(type_idx) => Ok(type_idx), [INFO] [stderr] 464 | | _ => Err(Error::Function(format!("external function {} is pointing to non-function import", index))), [INFO] [stderr] 465 | | }), [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 462 | .and_then(|import| match *import.external() { [INFO] [stderr] 463 | External::Function(type_idx) => Ok(type_idx), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | .ok_or(Error::Function(format!("missing executable export with name {}", name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing executable export with name {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:487:6 [INFO] [stderr] | [INFO] [stderr] 487 | .ok_or(Error::Function(format!("missing exported function with name {}", name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing exported function with name {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:483:15 [INFO] [stderr] | [INFO] [stderr] 483 | .find(|i| match i { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 484 | | &&Internal::Function(_) => true, [INFO] [stderr] 485 | | _ => false, [INFO] [stderr] 486 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 483 | .find(|i| match *i { [INFO] [stderr] 484 | &Internal::Function(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | .map(|i| match i { [INFO] [stderr] | __________________________^ [INFO] [stderr] 489 | | &Internal::Function(index) => index, [INFO] [stderr] 490 | | _ => unreachable!(), // checked couple of lines above [INFO] [stderr] 491 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 488 | .map(|i| match *i { [INFO] [stderr] 489 | Internal::Function(index) => index, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/interpreter/module.rs:496:18 [INFO] [stderr] | [INFO] [stderr] 496 | fn export_entry<'a>(&self, name: &str, required_type: &ExportEntryType) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:498:5 [INFO] [stderr] | [INFO] [stderr] 498 | .ok_or(Error::Function(format!("missing export entry with name {}", name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("missing export entry with name {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:515:6 [INFO] [stderr] | [INFO] [stderr] 515 | .ok_or(Error::Program(format!("unresolved export {}", name)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Program(format!("unresolved export {}", name)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter/module.rs:499:18 [INFO] [stderr] | [INFO] [stderr] 499 | .and_then(|l| l.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 500 | | .find(|i| match required_type { [INFO] [stderr] 501 | | &ExportEntryType::Any => true, [INFO] [stderr] 502 | | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] ... | [INFO] [stderr] 513 | | }) [INFO] [stderr] 514 | | .map(|i| *i) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 499 | .and_then(|l| l.iter() [INFO] [stderr] 500 | .find(|i| match required_type { [INFO] [stderr] 501 | &ExportEntryType::Any => true, [INFO] [stderr] 502 | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] 503 | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] 504 | _ => false, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:500:15 [INFO] [stderr] | [INFO] [stderr] 500 | .find(|i| match required_type { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 501 | | &ExportEntryType::Any => true, [INFO] [stderr] 502 | | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] 503 | | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] ... | [INFO] [stderr] 512 | | }, [INFO] [stderr] 513 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 500 | .find(|i| match *required_type { [INFO] [stderr] 501 | ExportEntryType::Any => true, [INFO] [stderr] 502 | ExportEntryType::Global(global_type) => match i { [INFO] [stderr] 503 | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] 504 | _ => false, [INFO] [stderr] 505 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:502:47 [INFO] [stderr] | [INFO] [stderr] 502 | &ExportEntryType::Global(global_type) => match i { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 503 | | &&Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] 504 | | _ => false, [INFO] [stderr] 505 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 502 | &ExportEntryType::Global(global_type) => match *i { [INFO] [stderr] 503 | &Internal::Global(global_index) => self.global(ItemIndex::IndexSpace(global_index), Some(global_type), None).map(|_| true).unwrap_or(false), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:506:55 [INFO] [stderr] | [INFO] [stderr] 506 | &ExportEntryType::Function(ref required_type) => match i { [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 507 | | &&Internal::Function(function_index) => [INFO] [stderr] 508 | | self.function_type(ItemIndex::IndexSpace(function_index)) [INFO] [stderr] 509 | | .map(|ft| ft == *required_type) [INFO] [stderr] 510 | | .unwrap_or(false), [INFO] [stderr] 511 | | _ => false, [INFO] [stderr] 512 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 506 | &ExportEntryType::Function(ref required_type) => match *i { [INFO] [stderr] 507 | &Internal::Function(function_index) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:522:6 [INFO] [stderr] | [INFO] [stderr] 522 | .ok_or(Error::Table(format!("trying to access table with local index {} when there are only {} local tables", index, self.tables.len()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to access table with local index {} when there are only {} local tables", index, self.tables.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:524:6 [INFO] [stderr] | [INFO] [stderr] 524 | .ok_or(Error::Table(format!("trying to access external table with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to access external table with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:526:7 [INFO] [stderr] | [INFO] [stderr] 526 | .ok_or(Error::Table(format!("trying to access external table with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to access external table with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:535:6 [INFO] [stderr] | [INFO] [stderr] 535 | .ok_or(Error::Memory(format!("trying to access memory with local index {} when there are only {} memory regions", index, self.memory.len()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access memory with local index {} when there are only {} memory regions", index, self.memory.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:537:6 [INFO] [stderr] | [INFO] [stderr] 537 | .ok_or(Error::Memory(format!("trying to access external memory with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access external memory with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:539:7 [INFO] [stderr] | [INFO] [stderr] 539 | .ok_or(Error::Memory(format!("trying to access external memory with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Memory(format!("trying to access external memory with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:548:6 [INFO] [stderr] | [INFO] [stderr] 548 | .ok_or(Error::Global(format!("trying to access global with local index {} when there are only {} globals", index, self.globals.len()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to access global with local index {} when there are only {} globals", index, self.globals.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:550:6 [INFO] [stderr] | [INFO] [stderr] 550 | .ok_or(Error::Global(format!("trying to access external global with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to access external global with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:552:7 [INFO] [stderr] | [INFO] [stderr] 552 | .ok_or(Error::Global(format!("trying to access external global with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to access external global with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:563:6 [INFO] [stderr] | [INFO] [stderr] 563 | .ok_or(Error::Function(format!("trying to access external function with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to access external function with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:565:7 [INFO] [stderr] | [INFO] [stderr] 565 | .ok_or(Error::Function(format!("trying to access external function with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to access external function with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:566:19 [INFO] [stderr] | [INFO] [stderr] 566 | .and_then(|e| match e.external() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 567 | | &External::Function(type_index) => self.function_type_by_index(type_index), [INFO] [stderr] 568 | | _ => Err(Error::Function(format!("exported function {} is not a function", index))), [INFO] [stderr] 569 | | }), [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 566 | .and_then(|e| match *e.external() { [INFO] [stderr] 567 | External::Function(type_index) => self.function_type_by_index(type_index), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:575:5 [INFO] [stderr] | [INFO] [stderr] 575 | .ok_or(Error::Validation(format!("type reference {} exists in module without type section", type_index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Validation(format!("type reference {} exists in module without type section", type_index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/interpreter/module.rs:624:2 [INFO] [stderr] | [INFO] [stderr] 624 | fn function_body<'a>(&'a self, internal_index: u32) -> Result>, Error> { [INFO] [stderr] | _____^ [INFO] [stderr] 625 | | let function_body = self.module [INFO] [stderr] 626 | | .code_section() [INFO] [stderr] 627 | | .ok_or(Error::Function(format!("trying to call function with index {} in module without code section", internal_index))) [INFO] [stderr] ... | [INFO] [stderr] 638 | | })) [INFO] [stderr] 639 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:627:5 [INFO] [stderr] | [INFO] [stderr] 627 | .ok_or(Error::Function(format!("trying to call function with index {} in module without code section", internal_index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to call function with index {} in module without code section", internal_index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:630:6 [INFO] [stderr] | [INFO] [stderr] 630 | .ok_or(Error::Function(format!("trying to call function with index {} in module with {} functions codes", internal_index, s.bodies().len()))))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to call function with index {} in module with {} functions codes", internal_index, s.bodies().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:632:5 [INFO] [stderr] | [INFO] [stderr] 632 | .ok_or(Error::Function(format!("trying to call non-validated internal function {}", internal_index)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Function(format!("trying to call non-validated internal function {}", internal_index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:689:2 [INFO] [stderr] | [INFO] [stderr] 689 | match first_opcode { [INFO] [stderr] | _____^ [INFO] [stderr] 690 | | &Opcode::GetGlobal(index) => { [INFO] [stderr] 691 | | let index = match imports.parse_global_index(ItemIndex::IndexSpace(index)) { [INFO] [stderr] 692 | | ItemIndex::External(index) => index, [INFO] [stderr] ... | [INFO] [stderr] 706 | | _ => Err(Error::Initialization(format!("not-supported {:?} instruction in instantiation-time initializer", first_opcode))), [INFO] [stderr] 707 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 689 | match *first_opcode { [INFO] [stderr] 690 | Opcode::GetGlobal(index) => { [INFO] [stderr] 691 | let index = match imports.parse_global_index(ItemIndex::IndexSpace(index)) { [INFO] [stderr] 692 | ItemIndex::External(index) => index, [INFO] [stderr] 693 | _ => return Err(Error::Global(format!("trying to initialize with non-external global {}", index))), [INFO] [stderr] 694 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:696:6 [INFO] [stderr] | [INFO] [stderr] 696 | .ok_or(Error::Global(format!("trying to initialize with external global with index {} in module without import section", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to initialize with external global with index {} in module without import section", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/module.rs:698:7 [INFO] [stderr] | [INFO] [stderr] 698 | .ok_or(Error::Global(format!("trying to initialize with external global with index {} in module with {}-entries import section", index, s.entries().len())))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Global(format!("trying to initialize with external global with index {} in module with {}-entries import section", index, s.entries().len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:713:3 [INFO] [stderr] | [INFO] [stderr] 713 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 714 | | &FunctionSignature::Module(ft) => ft.return_type(), [INFO] [stderr] 715 | | &FunctionSignature::User(fd) => fd.return_type(), [INFO] [stderr] 716 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 713 | match *self { [INFO] [stderr] 714 | FunctionSignature::Module(ft) => ft.return_type(), [INFO] [stderr] 715 | FunctionSignature::User(fd) => fd.return_type(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:721:3 [INFO] [stderr] | [INFO] [stderr] 721 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 722 | | &FunctionSignature::Module(ft) => ft.params(), [INFO] [stderr] 723 | | &FunctionSignature::User(fd) => fd.params(), [INFO] [stderr] 724 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 721 | match *self { [INFO] [stderr] 722 | FunctionSignature::Module(ft) => ft.params(), [INFO] [stderr] 723 | FunctionSignature::User(fd) => fd.params(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:730:3 [INFO] [stderr] | [INFO] [stderr] 730 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 731 | | &FunctionSignature::Module(ft1) => match other { [INFO] [stderr] 732 | | &FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | | &FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] ... | [INFO] [stderr] 738 | | }, [INFO] [stderr] 739 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 730 | match *self { [INFO] [stderr] 731 | FunctionSignature::Module(ft1) => match other { [INFO] [stderr] 732 | &FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | &FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] 734 | }, [INFO] [stderr] 735 | FunctionSignature::User(ft1) => match other { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:731:39 [INFO] [stderr] | [INFO] [stderr] 731 | &FunctionSignature::Module(ft1) => match other { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 732 | | &FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | | &FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] 734 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 731 | &FunctionSignature::Module(ft1) => match *other { [INFO] [stderr] 732 | FunctionSignature::Module(ft2) => ft1 == ft2, [INFO] [stderr] 733 | FunctionSignature::User(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/module.rs:735:37 [INFO] [stderr] | [INFO] [stderr] 735 | &FunctionSignature::User(ft1) => match other { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 736 | | &FunctionSignature::User(ft2) => ft1 == ft2, [INFO] [stderr] 737 | | &FunctionSignature::Module(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] 738 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 735 | &FunctionSignature::User(ft1) => match *other { [INFO] [stderr] 736 | FunctionSignature::User(ft2) => ft1 == ft2, [INFO] [stderr] 737 | FunctionSignature::Module(ft2) => ft1.params() == ft2.params() && ft1.return_type() == ft2.return_type(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `interpreter::program::ProgramInstance` [INFO] [stderr] --> src/interpreter/program.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 23 | | ProgramInstance { [INFO] [stderr] 24 | | essence: Arc::new(ProgramInstanceEssence::new()), [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for interpreter::program::ProgramInstance { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::program::ProgramInstanceEssence` [INFO] [stderr] --> src/interpreter/program.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | ProgramInstanceEssence { [INFO] [stderr] 56 | | modules: RwLock::new(HashMap::new()), [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter/runner.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | match opcode { [INFO] [stderr] | _________^ [INFO] [stderr] 156 | | &Opcode::Unreachable => Interpreter::run_unreachable(context), [INFO] [stderr] 157 | | &Opcode::Nop => Interpreter::run_nop(context), [INFO] [stderr] 158 | | &Opcode::Block(block_type) => Interpreter::run_block(context, labels, block_type), [INFO] [stderr] ... | [INFO] [stderr] 344 | | &Opcode::F64ReinterpretI64 => Interpreter::run_reinterpret::(context), [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *opcode { [INFO] [stderr] 156 | Opcode::Unreachable => Interpreter::run_unreachable(context), [INFO] [stderr] 157 | Opcode::Nop => Interpreter::run_nop(context), [INFO] [stderr] 158 | Opcode::Block(block_type) => Interpreter::run_block(context, labels, block_type), [INFO] [stderr] 159 | Opcode::Loop(block_type) => Interpreter::run_loop(context, labels, block_type), [INFO] [stderr] 160 | Opcode::If(block_type) => Interpreter::run_if(context, labels, block_type), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/runner.rs:405:60 [INFO] [stderr] | [INFO] [stderr] 405 | fn run_br_table<'a>(context: &mut FunctionContext, table: &Vec, default: u32) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:497:14 [INFO] [stderr] | [INFO] [stderr] 497 | .and_then(|b| T::from_little_endian(b)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::from_little_endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:508:14 [INFO] [stderr] | [INFO] [stderr] 508 | .and_then(|b| T::from_little_endian(b)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::from_little_endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:972:49 [INFO] [stderr] | [INFO] [stderr] 972 | return_type: function_type.return_type().map(|vt| BlockType::Value(vt)).unwrap_or(BlockType::NoResult), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BlockType::Value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/runner.rs:983:63 [INFO] [stderr] | [INFO] [stderr] 983 | let function_return_type = function_type.return_type().map(|vt| BlockType::Value(vt)).unwrap_or(BlockType::NoResult); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BlockType::Value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/runner.rs:1026:5 [INFO] [stderr] | [INFO] [stderr] 1026 | .ok_or(Error::Local(format!("expected to have local with index {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Local(format!("expected to have local with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/runner.rs:1033:5 [INFO] [stderr] | [INFO] [stderr] 1033 | .ok_or(Error::Local(format!("expected to have local with index {}", index))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Local(format!("expected to have local with index {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/runner.rs:1071:6 [INFO] [stderr] | [INFO] [stderr] 1071 | Ok(self.frame_stack.push(BlockFrame { [INFO] [stderr] | ____________^ [INFO] [stderr] 1072 | | frame_type: frame_type, [INFO] [stderr] 1073 | | block_type: block_type, [INFO] [stderr] 1074 | | begin_position: begin_position, [INFO] [stderr] ... | [INFO] [stderr] 1077 | | value_stack_len: self.value_stack.len(), [INFO] [stderr] 1078 | | })?) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1071 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/interpreter/runner.rs:1082:6 [INFO] [stderr] | [INFO] [stderr] 1082 | Ok(self.frame_stack.pop().map(|_| ())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1082 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/table.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(Error::Table(format!("trying to read table item with index {} when there are only {} items", offset, buffer_len))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to read table item with index {} when there are only {} items", offset, buffer_len)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/table.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | .ok_or(Error::Table(format!("trying to update table item with index {} when there are only {} items", offset, buffer_len))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Table(format!("trying to update table item with index {} when there are only {} items", offset, buffer_len)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:185:26 [INFO] [stderr] | [INFO] [stderr] 185 | _ => Err(Error::Value(format!("32-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:194:26 [INFO] [stderr] | [INFO] [stderr] 194 | _ => Err(Error::Value(format!("32-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | _ => Err(Error::Value(format!("64-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"64-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:212:26 [INFO] [stderr] | [INFO] [stderr] 212 | _ => Err(Error::Value(format!("32-bit float value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit float value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | _ => Err(Error::Value(format!("64-bit float value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"64-bit float value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:230:26 [INFO] [stderr] | [INFO] [stderr] 230 | _ => Err(Error::Value(format!("32-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"32-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/value.rs:239:26 [INFO] [stderr] | [INFO] [stderr] 239 | _ => Err(Error::Value(format!("64-bit int value expected"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"64-bit int value expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 289 | impl_try_truncate_into!(f32, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 289 | impl_try_truncate_into!(f32, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 290 | impl_try_truncate_into!(f32, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 290 | impl_try_truncate_into!(f32, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 291 | impl_try_truncate_into!(f64, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 291 | impl_try_truncate_into!(f64, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 291 | impl_try_truncate_into!(f64, i32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 292 | impl_try_truncate_into!(f64, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 292 | impl_try_truncate_into!(f64, i64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 293 | impl_try_truncate_into!(f32, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 293 | impl_try_truncate_into!(f32, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_try_truncate_into!(f32, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 294 | impl_try_truncate_into!(f32, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 295 | impl_try_truncate_into!(f64, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 295 | impl_try_truncate_into!(f64, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(result)` [INFO] [stderr] ... [INFO] [stderr] 295 | impl_try_truncate_into!(f64, u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result as $from - self.trunc()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 296 | impl_try_truncate_into!(f64, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | if result as $from != self.trunc() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 296 | impl_try_truncate_into!(f64, u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 308 | impl_extend_into!(i8, i32); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 309 | impl_extend_into!(u8, i32); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 310 | impl_extend_into!(i16, i32); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_extend_into!(u16, i32); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_extend_into!(i8, i64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_extend_into!(u8, i64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 314 | impl_extend_into!(i16, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 315 | impl_extend_into!(u16, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 316 | impl_extend_into!(i32, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 317 | impl_extend_into!(u32, i64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 318 | impl_extend_into!(u32, u64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 320 | impl_extend_into!(i32, f64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 322 | impl_extend_into!(u32, f64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | self as $into [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 325 | impl_extend_into!(f32, f64); [INFO] [stderr] | ---------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/value.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | .ok_or(Error::Value("invalid little endian buffer".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Value("invalid little endian buffer".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter/value.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | .ok_or(Error::Value("invalid little endian buffer".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Value("invalid little endian buffer".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/interpreter/value.rs:515:11 [INFO] [stderr] | [INFO] [stderr] 515 | unsafe { ::std::mem::transmute(v) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/interpreter/value.rs:533:11 [INFO] [stderr] | [INFO] [stderr] 533 | unsafe { ::std::mem::transmute(v) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:579:38 [INFO] [stderr] | [INFO] [stderr] 579 | fn leading_zeros(self) -> $type { self.leading_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 594 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:580:39 [INFO] [stderr] | [INFO] [stderr] 580 | fn trailing_zeros(self) -> $type { self.trailing_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 594 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:581:35 [INFO] [stderr] | [INFO] [stderr] 581 | fn count_ones(self) -> $type { self.count_ones() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 594 | impl_integer!(i64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:579:38 [INFO] [stderr] | [INFO] [stderr] 579 | fn leading_zeros(self) -> $type { self.leading_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.leading_zeros())` [INFO] [stderr] ... [INFO] [stderr] 595 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:580:39 [INFO] [stderr] | [INFO] [stderr] 580 | fn trailing_zeros(self) -> $type { self.trailing_zeros() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.trailing_zeros())` [INFO] [stderr] ... [INFO] [stderr] 595 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/value.rs:581:35 [INFO] [stderr] | [INFO] [stderr] 581 | fn count_ones(self) -> $type { self.count_ones() as $type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.count_ones())` [INFO] [stderr] ... [INFO] [stderr] 595 | impl_integer!(u64); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | impl_float!(f32, i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.fract().abs() - 0.5).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:607:8 [INFO] [stderr] | [INFO] [stderr] 607 | if self.fract().abs() != 0.5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:612:8 [INFO] [stderr] | [INFO] [stderr] 612 | if round.rem(2.0) == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(round.rem(2.0) - -1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/value.rs:614:15 [INFO] [stderr] | [INFO] [stderr] 614 | } else if round.rem(2.0) == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | impl_float!(f64, i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/interpreter/tests/basics.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | self.memory.set(0, &vec![sum]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: you can use a slice directly: `&[sum]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/tests/basics.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | self.values.push(sum as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(sum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/tests/basics.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | Ok(Some(RuntimeValue::I32(sum as i32))) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(sum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/interpreter/tests/basics.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | self.memory.set(0, &vec![diff]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[diff]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/tests/basics.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | self.values.push(diff as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/tests/basics.rs:186:31 [INFO] [stderr] | [INFO] [stderr] 186 | Ok(Some(RuntimeValue::I32(diff as i32))) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/interpreter/tests/basics.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | _ => Err(Error::Trap("not implemented".into()).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Trap("not implemented".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/interpreter/tests/basics.rs:279:20 [INFO] [stderr] | [INFO] [stderr] 279 | memory.set(0, &vec![sum]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: you can use a slice directly: `&[sum]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/tests/basics.rs:280:32 [INFO] [stderr] | [INFO] [stderr] 280 | Ok(Some(RuntimeValue::I32(sum as i32))) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(sum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/interpreter/tests/basics.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | _ => Err(Error::Trap("not implemented".into()).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Trap("not implemented".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `x @ _` pattern can be written as just `x` [INFO] [stderr] --> src/interpreter/tests/basics.rs:499:4 [INFO] [stderr] | [INFO] [stderr] 499 | x @ _ => panic!("unexpected result for test_case {:?}: {:?}", test_case, x), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `x @ _` pattern can be written as just `x` [INFO] [stderr] --> src/interpreter/tests/basics.rs:537:4 [INFO] [stderr] | [INFO] [stderr] 537 | x @ _ => panic!("unexpected result for test_case {:?}: {:?}", test_case, x), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `x @ _` pattern can be written as just `x` [INFO] [stderr] --> src/interpreter/tests/basics.rs:567:4 [INFO] [stderr] | [INFO] [stderr] 567 | x @ _ => panic!("unexpected result for test_case {:?}: {:?}", test_case, x), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `x @ _` pattern can be written as just `x` [INFO] [stderr] --> src/interpreter/tests/basics.rs:605:4 [INFO] [stderr] | [INFO] [stderr] 605 | x @ _ => panic!("unexpected result for test_case {:?}: {:?}", test_case, x), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1221:89 [INFO] [stderr] | [INFO] [stderr] 1221 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(5.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1222:90 [INFO] [stderr] | [INFO] [stderr] 1222 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-9995.500000)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `9_995.5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1223:90 [INFO] [stderr] | [INFO] [stderr] 1223 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-8487.187500)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `8_487.187_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1224:90 [INFO] [stderr] | [INFO] [stderr] 1224 | assert_eq!(module.execute_index(3, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-500000000.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1303:89 [INFO] [stderr] | [INFO] [stderr] 1303 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(1111111110.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1_111_111_110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1304:89 [INFO] [stderr] | [INFO] [stderr] 1304 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(123400000000000007812762268812638756607430593436581896388608.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `123_400_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1305:90 [INFO] [stderr] | [INFO] [stderr] 1305 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(-15179717820000.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `15_179_717_820_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1364:1 [INFO] [stderr] | [INFO] [stderr] 1364 | / fn compare_i32() { [INFO] [stderr] 1365 | | let module = module() [INFO] [stderr] 1366 | | .function() [INFO] [stderr] 1367 | | .signature().return_type().i32().build() [INFO] [stderr] ... | [INFO] [stderr] 1649 | | assert_eq!(module.execute_index(27, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(1)); [INFO] [stderr] 1650 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/interpreter/tests/wabt.rs:1654:1 [INFO] [stderr] | [INFO] [stderr] 1654 | / fn compare_i64() { [INFO] [stderr] 1655 | | let module = module() [INFO] [stderr] 1656 | | .function() [INFO] [stderr] 1657 | | .signature().return_type().i32().build() [INFO] [stderr] ... | [INFO] [stderr] 1939 | | assert_eq!(module.execute_index(27, vec![].into()).unwrap().unwrap(), RuntimeValue::I32(1)); [INFO] [stderr] 1940 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2467:90 [INFO] [stderr] | [INFO] [stderr] 2467 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2468:89 [INFO] [stderr] | [INFO] [stderr] 2468 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(4294967296.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4_294_967_300` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2469:89 [INFO] [stderr] | [INFO] [stderr] 2469 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(12345679.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `12_345_679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2525:89 [INFO] [stderr] | [INFO] [stderr] 2525 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F64(4294967295.000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:2690:89 [INFO] [stderr] | [INFO] [stderr] 2690 | assert_eq!(module.execute_index(0, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(25.750000)); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `25.75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3099:90 [INFO] [stderr] | [INFO] [stderr] 3099 | assert_eq!(module.execute_index(1, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-100.000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3100:89 [INFO] [stderr] | [INFO] [stderr] 3100 | assert_eq!(module.execute_index(2, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(100.000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3102:89 [INFO] [stderr] | [INFO] [stderr] 3102 | assert_eq!(module.execute_index(4, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(10.000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3104:90 [INFO] [stderr] | [INFO] [stderr] 3104 | assert_eq!(module.execute_index(6, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(-1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3106:89 [INFO] [stderr] | [INFO] [stderr] 3106 | assert_eq!(module.execute_index(8, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(1.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/interpreter/tests/wabt.rs:3107:89 [INFO] [stderr] | [INFO] [stderr] 3107 | assert_eq!(module.execute_index(9, vec![].into()).unwrap().unwrap(), RuntimeValue::F32(2.000000)); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/interpreter/tests/wasm.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | let accu = BUF.into_iter().fold(0 as i32, |a, b| a + *b as i32); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/interpreter/tests/wasm.rs:72:58 [INFO] [stderr] | [INFO] [stderr] 72 | let accu = BUF.into_iter().fold(0 as i32, |a, b| a + *b as i32); [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/validation/func.rs:504:71 [INFO] [stderr] | [INFO] [stderr] 504 | fn validate_br_table(context: &mut FunctionValidationContext, table: &Vec, default: u32) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/validation/func.rs:611:6 [INFO] [stderr] | [INFO] [stderr] 611 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 611 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/validation/func.rs:611:28 [INFO] [stderr] | [INFO] [stderr] 611 | Ok(self.value_stack.push(value_type.into())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/validation/func.rs:623:4 [INFO] [stderr] | [INFO] [stderr] 623 | stack_value_type @ _ => Err(Error(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `stack_value_type @ _` pattern can be written as just `stack_value_type` [INFO] [stderr] --> src/validation/func.rs:632:4 [INFO] [stderr] | [INFO] [stderr] 632 | stack_value_type @ _ => Err(Error(format!("Expected value of type {:?} on top of stack. Got {:?}", value_type, stack_value_type))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/validation/func.rs:654:6 [INFO] [stderr] | [INFO] [stderr] 654 | Ok(self.value_stack.push(StackValueType::AnyUnlimited)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 654 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/validation/func.rs:662:6 [INFO] [stderr] | [INFO] [stderr] 662 | Ok(self.frame_stack.push(BlockFrame { [INFO] [stderr] | ____________^ [INFO] [stderr] 663 | | frame_type: frame_type, [INFO] [stderr] 664 | | block_type: block_type, [INFO] [stderr] 665 | | begin_position: self.position, [INFO] [stderr] ... | [INFO] [stderr] 668 | | value_stack_len: self.value_stack.len(), [INFO] [stderr] 669 | | })?) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 662 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/validation/func.rs:701:20 [INFO] [stderr] | [INFO] [stderr] 701 | self.return_type.ok_or(Error("Trying to return from expression".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("Trying to return from expression".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/validation/func.rs:708:5 [INFO] [stderr] | [INFO] [stderr] 708 | .ok_or(Error(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error(format!("Trying to access local with index {} when there are only {} locals", idx, self.locals.len())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validation/func.rs:722:12 [INFO] [stderr] | [INFO] [stderr] 722 | fn is_any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation/func.rs:723:3 [INFO] [stderr] | [INFO] [stderr] 723 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 724 | | &StackValueType::Any => true, [INFO] [stderr] 725 | | _ => false, [INFO] [stderr] 726 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 723 | match *self { [INFO] [stderr] 724 | StackValueType::Any => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validation/func.rs:729:22 [INFO] [stderr] | [INFO] [stderr] 729 | fn is_any_unlimited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation/func.rs:730:3 [INFO] [stderr] | [INFO] [stderr] 730 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 731 | | &StackValueType::AnyUnlimited => true, [INFO] [stderr] 732 | | _ => false, [INFO] [stderr] 733 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 730 | match *self { [INFO] [stderr] 731 | StackValueType::AnyUnlimited => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validation/func.rs:736:16 [INFO] [stderr] | [INFO] [stderr] 736 | fn value_type(&self) -> ValueType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validation/func.rs:737:3 [INFO] [stderr] | [INFO] [stderr] 737 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 738 | | &StackValueType::Any | &StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 739 | | &StackValueType::Specific(value_type) => value_type, [INFO] [stderr] 740 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 737 | match *self { [INFO] [stderr] 738 | StackValueType::Any | StackValueType::AnyUnlimited => unreachable!("must be checked by caller"), [INFO] [stderr] 739 | StackValueType::Specific(value_type) => value_type, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/validation/mod.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | .ok_or(Error(format!("Missing body for function {}", index)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error(format!("Missing body for function {}", index)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validation/mod.rs:75:42 [INFO] [stderr] | [INFO] [stderr] 75 | if return_ty != BlockType::NoResult || params.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/validation/mod.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|ts| ts.types().into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/common/stack.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | .ok_or(Error("non-empty stack expected".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("non-empty stack expected".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/common/stack.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | .ok_or(Error("non-empty stack expected".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("non-empty stack expected".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/common/stack.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | .ok_or(Error("non-empty stack expected".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error("non-empty stack expected".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sophon-wasm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4cdd62670a6deca57080100f04632cb8c712431d9392cb226ea203caa6ca1b38"` [INFO] running `"docker" "rm" "-f" "4cdd62670a6deca57080100f04632cb8c712431d9392cb226ea203caa6ca1b38"` [INFO] [stdout] 4cdd62670a6deca57080100f04632cb8c712431d9392cb226ea203caa6ca1b38