[INFO] crate sonos_discovery 0.0.1 is already in cache [INFO] extracting crate sonos_discovery 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/sonos_discovery/0.0.1 [INFO] extracting crate sonos_discovery 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sonos_discovery/0.0.1 [INFO] validating manifest of sonos_discovery-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sonos_discovery-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sonos_discovery-0.0.1 [INFO] finished frobbing sonos_discovery-0.0.1 [INFO] frobbed toml for sonos_discovery-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/sonos_discovery/0.0.1/Cargo.toml [INFO] started frobbing sonos_discovery-0.0.1 [INFO] finished frobbing sonos_discovery-0.0.1 [INFO] frobbed toml for sonos_discovery-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sonos_discovery/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sonos_discovery-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sonos_discovery/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b79a542618201a2aa45003f8b2a57866694a37345fefd5ee6303bfe9776529d [INFO] running `"docker" "start" "-a" "9b79a542618201a2aa45003f8b2a57866694a37345fefd5ee6303bfe9776529d"` [INFO] [stderr] Checking socket v0.0.7 [INFO] [stderr] Checking sonos_discovery v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | socket: socket [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | socket: socket [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:144:89 [INFO] [stderr] | [INFO] [stderr] 144 | let (_addr, data) = match receiver.recv_timeout(std::time::Duration::new(0, 500000000)) { [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:67:91 [INFO] [stderr] | [INFO] [stderr] 67 | fn create_socket(socket_family: i32, socket_type: i32, protocol: i32, socket_options: &Vec<(i32, i32, i32)>) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, i32, i32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | let player_search = r#"M-SEARCH * HTTP/1.1 [INFO] [stderr] | _____________________________^ [INFO] [stderr] 89 | | HOST: 239.255.255.250:1900 [INFO] [stderr] 90 | | MAN: "ssdp:discover" [INFO] [stderr] 91 | | MX: 1 [INFO] [stderr] 92 | | ST: urn:schemas-upnp-org:device:ZonePlayer:1"#.as_bytes(); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 88 | let player_search = br#"M-SEARCH * HTTP/1.1 [INFO] [stderr] 89 | HOST: 239.255.255.250:1900 [INFO] [stderr] 90 | MAN: "ssdp:discover" [INFO] [stderr] 91 | MX: 1 [INFO] [stderr] 92 | ST: urn:schemas-upnp-org:device:ZonePlayer:1"#; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | while time.elapsed().as_secs() < timeout as u64 && devices.len() < device_count { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | / match socket.recvfrom(1024, 0) { [INFO] [stderr] 131 | | Ok((__addr, _data)) => { [INFO] [stderr] 132 | | // TODO: Add logging, fail on multiple send errors? [INFO] [stderr] 133 | | match sender.send((__addr, _data)) { [INFO] [stderr] ... | [INFO] [stderr] 138 | | Err(_) => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Ok((__addr, _data)) = socket.recvfrom(1024, 0) { [INFO] [stderr] 131 | // TODO: Add logging, fail on multiple send errors? [INFO] [stderr] 132 | match sender.send((__addr, _data)) { [INFO] [stderr] 133 | Ok(_) => {} [INFO] [stderr] 134 | Err(_) => {} [INFO] [stderr] 135 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | / match sender.send((__addr, _data)) { [INFO] [stderr] 134 | | Ok(_) => {} [INFO] [stderr] 135 | | Err(_) => {} [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____________________________^ help: try this: `if let Ok(_) = sender.send((__addr, _data)) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:144:89 [INFO] [stderr] | [INFO] [stderr] 144 | let (_addr, data) = match receiver.recv_timeout(std::time::Duration::new(0, 500000000)) { [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:67:91 [INFO] [stderr] | [INFO] [stderr] 67 | fn create_socket(socket_family: i32, socket_type: i32, protocol: i32, socket_options: &Vec<(i32, i32, i32)>) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, i32, i32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | let player_search = r#"M-SEARCH * HTTP/1.1 [INFO] [stderr] | _____________________________^ [INFO] [stderr] 89 | | HOST: 239.255.255.250:1900 [INFO] [stderr] 90 | | MAN: "ssdp:discover" [INFO] [stderr] 91 | | MX: 1 [INFO] [stderr] 92 | | ST: urn:schemas-upnp-org:device:ZonePlayer:1"#.as_bytes(); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 88 | let player_search = br#"M-SEARCH * HTTP/1.1 [INFO] [stderr] 89 | HOST: 239.255.255.250:1900 [INFO] [stderr] 90 | MAN: "ssdp:discover" [INFO] [stderr] 91 | MX: 1 [INFO] [stderr] 92 | ST: urn:schemas-upnp-org:device:ZonePlayer:1"#; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | while time.elapsed().as_secs() < timeout as u64 && devices.len() < device_count { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | / match socket.recvfrom(1024, 0) { [INFO] [stderr] 131 | | Ok((__addr, _data)) => { [INFO] [stderr] 132 | | // TODO: Add logging, fail on multiple send errors? [INFO] [stderr] 133 | | match sender.send((__addr, _data)) { [INFO] [stderr] ... | [INFO] [stderr] 138 | | Err(_) => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Ok((__addr, _data)) = socket.recvfrom(1024, 0) { [INFO] [stderr] 131 | // TODO: Add logging, fail on multiple send errors? [INFO] [stderr] 132 | match sender.send((__addr, _data)) { [INFO] [stderr] 133 | Ok(_) => {} [INFO] [stderr] 134 | Err(_) => {} [INFO] [stderr] 135 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | / match sender.send((__addr, _data)) { [INFO] [stderr] 134 | | Ok(_) => {} [INFO] [stderr] 135 | | Err(_) => {} [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____________________________^ help: try this: `if let Ok(_) = sender.send((__addr, _data)) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.16s [INFO] running `"docker" "inspect" "9b79a542618201a2aa45003f8b2a57866694a37345fefd5ee6303bfe9776529d"` [INFO] running `"docker" "rm" "-f" "9b79a542618201a2aa45003f8b2a57866694a37345fefd5ee6303bfe9776529d"` [INFO] [stdout] 9b79a542618201a2aa45003f8b2a57866694a37345fefd5ee6303bfe9776529d