[INFO] crate sonnerie 0.4.0 is already in cache [INFO] extracting crate sonnerie 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/sonnerie/0.4.0 [INFO] extracting crate sonnerie 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sonnerie/0.4.0 [INFO] validating manifest of sonnerie-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sonnerie-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sonnerie-0.4.0 [INFO] finished frobbing sonnerie-0.4.0 [INFO] frobbed toml for sonnerie-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/sonnerie/0.4.0/Cargo.toml [INFO] started frobbing sonnerie-0.4.0 [INFO] finished frobbing sonnerie-0.4.0 [INFO] frobbed toml for sonnerie-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sonnerie/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sonnerie-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sonnerie/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53fcc10debde7dc2c2124f79e5f09e202da8a5e7b8092561ed5f458db89301a5 [INFO] running `"docker" "start" "-a" "53fcc10debde7dc2c2124f79e5f09e202da8a5e7b8092561ed5f458db89301a5"` [INFO] [stderr] Checking escape_string v0.1.1 [INFO] [stderr] Checking intrusive-collections v0.7.8 [INFO] [stderr] Checking range v0.3.1 [INFO] [stderr] Checking linestream v0.1.0 [INFO] [stderr] Checking daemonize v0.3.0 [INFO] [stderr] Checking rustyline v2.1.0 [INFO] [stderr] Checking sonnerie-api v0.4.1 [INFO] [stderr] Checking sonnerie v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/protocol.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | service: service, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `service` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:216:7 [INFO] [stderr] | [INFO] [stderr] 216 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:265:6 [INFO] [stderr] | [INFO] [stderr] 265 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:269:4 [INFO] [stderr] | [INFO] [stderr] 269 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:500:7 [INFO] [stderr] | [INFO] [stderr] 500 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:503:5 [INFO] [stderr] | [INFO] [stderr] 503 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:136:4 [INFO] [stderr] | [INFO] [stderr] 136 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:138:4 [INFO] [stderr] | [INFO] [stderr] 138 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:586:4 [INFO] [stderr] | [INFO] [stderr] 586 | first_timestamp: first_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:587:4 [INFO] [stderr] | [INFO] [stderr] 587 | last_timestamp: last_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1060:4 [INFO] [stderr] | [INFO] [stderr] 1060 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1061:4 [INFO] [stderr] | [INFO] [stderr] 1061 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1062:4 [INFO] [stderr] | [INFO] [stderr] 1062 | series_id: series_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `series_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1069:4 [INFO] [stderr] | [INFO] [stderr] 1069 | generator: generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1323:4 [INFO] [stderr] | [INFO] [stderr] 1323 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blocks.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blocks.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | wal: wal, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | let mut s = Segment{ offset: offset, data: data }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | let mut s = Segment{ offset: offset, data: data }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:90:4 [INFO] [stderr] | [INFO] [stderr] 90 | merge_state: merge_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `merge_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:91:4 [INFO] [stderr] | [INFO] [stderr] 91 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:92:4 [INFO] [stderr] | [INFO] [stderr] 92 | metadatapath: metadatapath, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `metadatapath` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:93:4 [INFO] [stderr] | [INFO] [stderr] 93 | unflushed_wal_files: unflushed_wal_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unflushed_wal_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_wal.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_wal.rs:130:4 [INFO] [stderr] | [INFO] [stderr] 130 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_wal.rs:131:4 [INFO] [stderr] | [INFO] [stderr] 131 | generation: generation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/client.rs:241:4 [INFO] [stderr] | [INFO] [stderr] 241 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdin, "")` [INFO] [stderr] --> src/client.rs:363:16 [INFO] [stderr] | [INFO] [stderr] 363 | let _ = writeln!(stdin, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdin, "")` [INFO] [stderr] --> src/client.rs:426:16 [INFO] [stderr] | [INFO] [stderr] 426 | let _ = writeln!(stdin, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdin, "")` [INFO] [stderr] --> src/client.rs:476:16 [INFO] [stderr] | [INFO] [stderr] 476 | let _ = writeln!(stdin, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row_format.rs:142:4 [INFO] [stderr] | [INFO] [stderr] 142 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row_format.rs:143:4 [INFO] [stderr] | [INFO] [stderr] 143 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:216:7 [INFO] [stderr] | [INFO] [stderr] 216 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:265:6 [INFO] [stderr] | [INFO] [stderr] 265 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:269:4 [INFO] [stderr] | [INFO] [stderr] 269 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:500:7 [INFO] [stderr] | [INFO] [stderr] 500 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(writer, "")` [INFO] [stderr] --> src/service.rs:503:5 [INFO] [stderr] | [INFO] [stderr] 503 | writeln!(writer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:136:4 [INFO] [stderr] | [INFO] [stderr] 136 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:138:4 [INFO] [stderr] | [INFO] [stderr] 138 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:586:4 [INFO] [stderr] | [INFO] [stderr] 586 | first_timestamp: first_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:587:4 [INFO] [stderr] | [INFO] [stderr] 587 | last_timestamp: last_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1060:4 [INFO] [stderr] | [INFO] [stderr] 1060 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1061:4 [INFO] [stderr] | [INFO] [stderr] 1061 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1062:4 [INFO] [stderr] | [INFO] [stderr] 1062 | series_id: series_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `series_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1069:4 [INFO] [stderr] | [INFO] [stderr] 1069 | generator: generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata.rs:1323:4 [INFO] [stderr] | [INFO] [stderr] 1323 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blocks.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blocks.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | wal: wal, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | let mut s = Segment{ offset: offset, data: data }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wal.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | let mut s = Segment{ offset: offset, data: data }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:90:4 [INFO] [stderr] | [INFO] [stderr] 90 | merge_state: merge_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `merge_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:91:4 [INFO] [stderr] | [INFO] [stderr] 91 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:92:4 [INFO] [stderr] | [INFO] [stderr] 92 | metadatapath: metadatapath, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `metadatapath` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:93:4 [INFO] [stderr] | [INFO] [stderr] 93 | unflushed_wal_files: unflushed_wal_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unflushed_wal_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_wal.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_wal.rs:130:4 [INFO] [stderr] | [INFO] [stderr] 130 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_wal.rs:131:4 [INFO] [stderr] | [INFO] [stderr] 131 | generation: generation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/client.rs:241:4 [INFO] [stderr] | [INFO] [stderr] 241 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdin, "")` [INFO] [stderr] --> src/client.rs:363:16 [INFO] [stderr] | [INFO] [stderr] 363 | let _ = writeln!(stdin, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdin, "")` [INFO] [stderr] --> src/client.rs:426:16 [INFO] [stderr] | [INFO] [stderr] 426 | let _ = writeln!(stdin, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdin, "")` [INFO] [stderr] --> src/client.rs:476:16 [INFO] [stderr] | [INFO] [stderr] 476 | let _ = writeln!(stdin, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row_format.rs:142:4 [INFO] [stderr] | [INFO] [stderr] 142 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row_format.rs:143:4 [INFO] [stderr] | [INFO] [stderr] 143 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/protocol.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | else if l.starts_with(">") [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/metadata.rs:256:3 [INFO] [stderr] | [INFO] [stderr] 256 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/metadata.rs:255:11 [INFO] [stderr] | [INFO] [stderr] 255 | let f = parse_row_format(&v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/metadata.rs:269:3 [INFO] [stderr] | [INFO] [stderr] 269 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/metadata.rs:266:11 [INFO] [stderr] | [INFO] [stderr] 266 | let v = c.query(&[&name]).unwrap() [INFO] [stderr] | _________________^ [INFO] [stderr] 267 | | .next() [INFO] [stderr] 268 | | .map(|e| e.unwrap().get(0)); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/metadata.rs:327:3 [INFO] [stderr] | [INFO] [stderr] 327 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/metadata.rs:324:11 [INFO] [stderr] | [INFO] [stderr] 324 | let v = c.query(&[&name]).unwrap() [INFO] [stderr] | _________________^ [INFO] [stderr] 325 | | .next() [INFO] [stderr] 326 | | .map(|e| e.unwrap().get::<_,i64>(0) as u64); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wal.rs:299:4 [INFO] [stderr] | [INFO] [stderr] 299 | return Segment [INFO] [stderr] | _____________^ [INFO] [stderr] 300 | | { [INFO] [stderr] 301 | | offset: s.offset + len_to_create, [INFO] [stderr] 302 | | data: &s.data[len_to_create..], [INFO] [stderr] 303 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 299 | Segment [INFO] [stderr] 300 | { [INFO] [stderr] 301 | offset: s.offset + len_to_create, [INFO] [stderr] 302 | data: &s.data[len_to_create..], [INFO] [stderr] 303 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/disk_wal.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const MAGIC: &'static [u8] = b"tsrust.wal.0000\n"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:83:36 [INFO] [stderr] | [INFO] [stderr] 83 | self.file.write_i32::(0x07010503).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0701_0503` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | self.file.write_i32::(0x0d011e00).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0d01_1e00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:156:15 [INFO] [stderr] | [INFO] [stderr] 156 | if code == 0x0d011e00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0d01_1e00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:158:20 [INFO] [stderr] | [INFO] [stderr] 158 | else if code == 0x07010503 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0701_0503` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/service.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | fn one_command(&mut self, cmd: &str, remainder: &str) -> Result<(), String> [INFO] [stderr] | _____^ [INFO] [stderr] 73 | | { [INFO] [stderr] 74 | | let ref mut writer = self.writer; [INFO] [stderr] 75 | | let ref mut db = self.db; [INFO] [stderr] ... | [INFO] [stderr] 514 | | Ok(()) [INFO] [stderr] 515 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | let ref mut writer = self.writer; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let writer = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | let ref mut db = self.db; [INFO] [stderr] | ----^^^^^^^^^^----------- help: try: `let db = &mut self.db;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | let ref mut cache_last_series_id = self.cache_last_series_id; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- help: try: `let cache_last_series_id = &mut self.cache_last_series_id;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/service.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(_) = tx.create_series(&name, &format) [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 115 | | { [INFO] [stderr] 116 | | writeln!(writer, "creating a timeseries named \"{}\"", name).unwrap(); [INFO] [stderr] 117 | | } [INFO] [stderr] ... | [INFO] [stderr] 120 | | writeln!(writer, "error: format \"{}\" does not match existing", format).unwrap(); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________________- help: try this: `if tx.create_series(&name, &format).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/service.rs:184:11 [INFO] [stderr] | [INFO] [stderr] 184 | if let Some(_) = self.transaction.take() [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 185 | | { [INFO] [stderr] 186 | | writeln!(writer, "transaction ended").unwrap(); [INFO] [stderr] 187 | | } [INFO] [stderr] ... | [INFO] [stderr] 190 | | writeln!(writer, "error: not in a transaction").unwrap(); [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____________- help: try this: `if self.transaction.take().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/service.rs:428:22 [INFO] [stderr] | [INFO] [stderr] 428 | .ok_or_else(|| format!("failed to parse line"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to parse line".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metadata.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn as_read_transaction(self) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metadata.rs:172:3 [INFO] [stderr] | [INFO] [stderr] 172 | mut self, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:171:2 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn as_write_transaction<'db>( [INFO] [stderr] | _____^ [INFO] [stderr] 172 | | mut self, [INFO] [stderr] 173 | | new_generation: u64, [INFO] [stderr] 174 | | finishing_on: &'db Db, [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:411:14 [INFO] [stderr] | [INFO] [stderr] 411 | assert!(keeping1.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping1.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | assert!(keeping2.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping2.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:436:14 [INFO] [stderr] | [INFO] [stderr] 436 | assert!(keeping.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:454:14 [INFO] [stderr] | [INFO] [stderr] 454 | assert!(keeping.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:796:7 [INFO] [stderr] | [INFO] [stderr] 796 | if blocks_group.len() == 0 { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `blocks_group.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:1228:12 [INFO] [stderr] | [INFO] [stderr] 1228 | assert!(one.len()>0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!one.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:1229:12 [INFO] [stderr] | [INFO] [stderr] 1229 | assert!(two.len()>0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!two.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/metadata.rs:1357:15 [INFO] [stderr] | [INFO] [stderr] 1357 | fn to_sqlite(&self) -> i64 [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/wal.rs:116:7 [INFO] [stderr] | [INFO] [stderr] 116 | let ref in_flight = *in_flight_ptr; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------ help: try: `let in_flight = &(*in_flight_ptr);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/wal.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | while s.data.len()!=0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/wal.rs:182:7 [INFO] [stderr] | [INFO] [stderr] 182 | let ref part_data = part.data; [INFO] [stderr] | ----^^^^^^^^^^^^^------------- help: try: `let part_data = &part.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/wal.rs:310:6 [INFO] [stderr] | [INFO] [stderr] 310 | if s.data.len() == 0 { return s.clone(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/disk_wal.rs:137:7 [INFO] [stderr] | [INFO] [stderr] 137 | let ref mut f = self.file; [INFO] [stderr] | ----^^^^^^^^^------------- help: try: `let f = &mut self.file;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/client.rs:431:12 [INFO] [stderr] | [INFO] [stderr] 431 | if let Err(_) = res [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 432 | | { [INFO] [stderr] 433 | | let _ = writeln!(stdin, "(unexpected failure)"); [INFO] [stderr] 434 | | return Some(false); [INFO] [stderr] 435 | | } [INFO] [stderr] | |_________________- help: try this: `if res.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/client.rs:481:12 [INFO] [stderr] | [INFO] [stderr] 481 | if let Err(_) = res [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 482 | | { [INFO] [stderr] 483 | | let _ = writeln!(stdin, "(unexpected failure)"); [INFO] [stderr] 484 | | return Some(false); [INFO] [stderr] 485 | | } [INFO] [stderr] | |_________________- help: try this: `if res.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/row_format.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | fn to_stored_format(&self, ts: &Timestamp, from: &str, dest: &mut Vec) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/row_format.rs:278:3 [INFO] [stderr] | [INFO] [stderr] 278 | let v; [INFO] [stderr] | _________^ [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | if t == "nan" [INFO] [stderr] 281 | | { v = ::std::f32::NAN; } [INFO] [stderr] ... | [INFO] [stderr] 285 | | .map_err(|e| format!("while parsing {}: {}", t, e))?; [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 278 | let v = if t == "nan" { ::std::f32::NAN } else { t.parse() [INFO] [stderr] 279 | .map_err(|e| format!("while parsing {}: {}", t, e))? }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/row_format.rs:312:3 [INFO] [stderr] | [INFO] [stderr] 312 | let v; [INFO] [stderr] | _________^ [INFO] [stderr] 313 | | [INFO] [stderr] 314 | | if t == "nan" [INFO] [stderr] 315 | | { v = ::std::f64::NAN; } [INFO] [stderr] ... | [INFO] [stderr] 319 | | .map_err(|e| format!("while parsing {}: {}", t, e))?; [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 312 | let v = if t == "nan" { ::std::f64::NAN } else { t.parse() [INFO] [stderr] 313 | .map_err(|e| format!("while parsing {}: {}", t, e))? }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | if address.starts_with("/") || address.starts_with("unix:") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:103:6 [INFO] [stderr] | [INFO] [stderr] 103 | .expect(&format!("binding to socket {}", address)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("binding to socket {}", address))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/metadata.rs:256:3 [INFO] [stderr] | [INFO] [stderr] 256 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/metadata.rs:255:11 [INFO] [stderr] | [INFO] [stderr] 255 | let f = parse_row_format(&v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/metadata.rs:269:3 [INFO] [stderr] | [INFO] [stderr] 269 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/metadata.rs:266:11 [INFO] [stderr] | [INFO] [stderr] 266 | let v = c.query(&[&name]).unwrap() [INFO] [stderr] | _________________^ [INFO] [stderr] 267 | | .next() [INFO] [stderr] 268 | | .map(|e| e.unwrap().get(0)); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/metadata.rs:327:3 [INFO] [stderr] | [INFO] [stderr] 327 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/metadata.rs:324:11 [INFO] [stderr] | [INFO] [stderr] 324 | let v = c.query(&[&name]).unwrap() [INFO] [stderr] | _________________^ [INFO] [stderr] 325 | | .next() [INFO] [stderr] 326 | | .map(|e| e.unwrap().get::<_,i64>(0) as u64); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wal.rs:299:4 [INFO] [stderr] | [INFO] [stderr] 299 | return Segment [INFO] [stderr] | _____________^ [INFO] [stderr] 300 | | { [INFO] [stderr] 301 | | offset: s.offset + len_to_create, [INFO] [stderr] 302 | | data: &s.data[len_to_create..], [INFO] [stderr] 303 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 299 | Segment [INFO] [stderr] 300 | { [INFO] [stderr] 301 | offset: s.offset + len_to_create, [INFO] [stderr] 302 | data: &s.data[len_to_create..], [INFO] [stderr] 303 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db.rs:482:3 [INFO] [stderr] | [INFO] [stderr] 482 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db.rs:468:11 [INFO] [stderr] | [INFO] [stderr] 468 | let f = move |format: &::row_format::RowFormat, data: &mut Vec| [INFO] [stderr] | _________________^ [INFO] [stderr] 469 | | -> Result, String> [INFO] [stderr] 470 | | { [INFO] [stderr] 471 | | if let Some((ts,val)) = i.next() [INFO] [stderr] ... | [INFO] [stderr] 480 | | } [INFO] [stderr] 481 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db.rs:727:28 [INFO] [stderr] | [INFO] [stderr] 727 | assert_eq!(get(Timestamp(300009), true).unwrap(), (Timestamp(300000), 300000.0)); [INFO] [stderr] | ^^^^^^ help: consider: `300_009` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db.rs:727:64 [INFO] [stderr] | [INFO] [stderr] 727 | assert_eq!(get(Timestamp(300009), true).unwrap(), (Timestamp(300000), 300000.0)); [INFO] [stderr] | ^^^^^^ help: consider: `300_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db.rs:727:73 [INFO] [stderr] | [INFO] [stderr] 727 | assert_eq!(get(Timestamp(300009), true).unwrap(), (Timestamp(300000), 300000.0)); [INFO] [stderr] | ^^^^^^^^ help: consider: `300_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db.rs:728:28 [INFO] [stderr] | [INFO] [stderr] 728 | assert_eq!(get(Timestamp(299999), true).unwrap(), (Timestamp(299990), 299990.0)); [INFO] [stderr] | ^^^^^^ help: consider: `299_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db.rs:728:64 [INFO] [stderr] | [INFO] [stderr] 728 | assert_eq!(get(Timestamp(299999), true).unwrap(), (Timestamp(299990), 299990.0)); [INFO] [stderr] | ^^^^^^ help: consider: `299_990` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db.rs:728:73 [INFO] [stderr] | [INFO] [stderr] 728 | assert_eq!(get(Timestamp(299999), true).unwrap(), (Timestamp(299990), 299990.0)); [INFO] [stderr] | ^^^^^^^^ help: consider: `299_990.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/disk_wal.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const MAGIC: &'static [u8] = b"tsrust.wal.0000\n"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:83:36 [INFO] [stderr] | [INFO] [stderr] 83 | self.file.write_i32::(0x07010503).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0701_0503` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | self.file.write_i32::(0x0d011e00).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0d01_1e00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:156:15 [INFO] [stderr] | [INFO] [stderr] 156 | if code == 0x0d011e00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0d01_1e00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disk_wal.rs:158:20 [INFO] [stderr] | [INFO] [stderr] 158 | else if code == 0x07010503 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0701_0503` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/service.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | fn one_command(&mut self, cmd: &str, remainder: &str) -> Result<(), String> [INFO] [stderr] | _____^ [INFO] [stderr] 73 | | { [INFO] [stderr] 74 | | let ref mut writer = self.writer; [INFO] [stderr] 75 | | let ref mut db = self.db; [INFO] [stderr] ... | [INFO] [stderr] 514 | | Ok(()) [INFO] [stderr] 515 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | let ref mut writer = self.writer; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let writer = &mut self.writer;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | let ref mut db = self.db; [INFO] [stderr] | ----^^^^^^^^^^----------- help: try: `let db = &mut self.db;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/service.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | let ref mut cache_last_series_id = self.cache_last_series_id; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- help: try: `let cache_last_series_id = &mut self.cache_last_series_id;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/service.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(_) = tx.create_series(&name, &format) [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 115 | | { [INFO] [stderr] 116 | | writeln!(writer, "creating a timeseries named \"{}\"", name).unwrap(); [INFO] [stderr] 117 | | } [INFO] [stderr] ... | [INFO] [stderr] 120 | | writeln!(writer, "error: format \"{}\" does not match existing", format).unwrap(); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________________- help: try this: `if tx.create_series(&name, &format).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/service.rs:184:11 [INFO] [stderr] | [INFO] [stderr] 184 | if let Some(_) = self.transaction.take() [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 185 | | { [INFO] [stderr] 186 | | writeln!(writer, "transaction ended").unwrap(); [INFO] [stderr] 187 | | } [INFO] [stderr] ... | [INFO] [stderr] 190 | | writeln!(writer, "error: not in a transaction").unwrap(); [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____________- help: try this: `if self.transaction.take().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/service.rs:428:22 [INFO] [stderr] | [INFO] [stderr] 428 | .ok_or_else(|| format!("failed to parse line"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to parse line".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metadata.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn as_read_transaction(self) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metadata.rs:172:3 [INFO] [stderr] | [INFO] [stderr] 172 | mut self, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:171:2 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn as_write_transaction<'db>( [INFO] [stderr] | _____^ [INFO] [stderr] 172 | | mut self, [INFO] [stderr] 173 | | new_generation: u64, [INFO] [stderr] 174 | | finishing_on: &'db Db, [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:411:14 [INFO] [stderr] | [INFO] [stderr] 411 | assert!(keeping1.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping1.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | assert!(keeping2.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping2.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:436:14 [INFO] [stderr] | [INFO] [stderr] 436 | assert!(keeping.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:454:14 [INFO] [stderr] | [INFO] [stderr] 454 | assert!(keeping.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keeping.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:796:7 [INFO] [stderr] | [INFO] [stderr] 796 | if blocks_group.len() == 0 { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `blocks_group.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:1228:12 [INFO] [stderr] | [INFO] [stderr] 1228 | assert!(one.len()>0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!one.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:1229:12 [INFO] [stderr] | [INFO] [stderr] 1229 | assert!(two.len()>0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!two.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/metadata.rs:1357:15 [INFO] [stderr] | [INFO] [stderr] 1357 | fn to_sqlite(&self) -> i64 [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/wal.rs:116:7 [INFO] [stderr] | [INFO] [stderr] 116 | let ref in_flight = *in_flight_ptr; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------ help: try: `let in_flight = &(*in_flight_ptr);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/wal.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | while s.data.len()!=0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/wal.rs:182:7 [INFO] [stderr] | [INFO] [stderr] 182 | let ref part_data = part.data; [INFO] [stderr] | ----^^^^^^^^^^^^^------------- help: try: `let part_data = &part.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/wal.rs:310:6 [INFO] [stderr] | [INFO] [stderr] 310 | if s.data.len() == 0 { return s.clone(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/db.rs:456:6 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!(a.1, (start+idx as u64) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/db.rs:456:6 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!(a.1, (start+idx as u64) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/db.rs:513:6 [INFO] [stderr] | [INFO] [stderr] 513 | assert_eq!(a.1, ((start+idx as u64)*10) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/db.rs:513:6 [INFO] [stderr] | [INFO] [stderr] 513 | assert_eq!(a.1, ((start+idx as u64)*10) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/db.rs:649:4 [INFO] [stderr] | [INFO] [stderr] 649 | drop(n); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type fn() -> (wal::tests::tempfile::TempDir, db::Db) {db::tests::n} [INFO] [stderr] --> src/db.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | drop(n); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/db.rs:665:4 [INFO] [stderr] | [INFO] [stderr] 665 | drop(n); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type fn() -> (wal::tests::tempfile::TempDir, db::Db) {db::tests::n} [INFO] [stderr] --> src/db.rs:665:9 [INFO] [stderr] | [INFO] [stderr] 665 | drop(n); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/db.rs:1162:3 [INFO] [stderr] | [INFO] [stderr] 1162 | f.read(&mut a).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `vals` [INFO] [stderr] --> src/db.rs:1248:15 [INFO] [stderr] | [INFO] [stderr] 1248 | for idx in 0..100 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1248 | for (idx, ) in vals.iter().enumerate().take(100) [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/disk_wal.rs:137:7 [INFO] [stderr] | [INFO] [stderr] 137 | let ref mut f = self.file; [INFO] [stderr] | ----^^^^^^^^^------------- help: try: `let f = &mut self.file;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/client.rs:431:12 [INFO] [stderr] | [INFO] [stderr] 431 | if let Err(_) = res [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 432 | | { [INFO] [stderr] 433 | | let _ = writeln!(stdin, "(unexpected failure)"); [INFO] [stderr] 434 | | return Some(false); [INFO] [stderr] 435 | | } [INFO] [stderr] | |_________________- help: try this: `if res.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/client.rs:481:12 [INFO] [stderr] | [INFO] [stderr] 481 | if let Err(_) = res [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 482 | | { [INFO] [stderr] 483 | | let _ = writeln!(stdin, "(unexpected failure)"); [INFO] [stderr] 484 | | return Some(false); [INFO] [stderr] 485 | | } [INFO] [stderr] | |_________________- help: try this: `if res.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/row_format.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | fn to_stored_format(&self, ts: &Timestamp, from: &str, dest: &mut Vec) [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/row_format.rs:278:3 [INFO] [stderr] | [INFO] [stderr] 278 | let v; [INFO] [stderr] | _________^ [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | if t == "nan" [INFO] [stderr] 281 | | { v = ::std::f32::NAN; } [INFO] [stderr] ... | [INFO] [stderr] 285 | | .map_err(|e| format!("while parsing {}: {}", t, e))?; [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 278 | let v = if t == "nan" { ::std::f32::NAN } else { t.parse() [INFO] [stderr] 279 | .map_err(|e| format!("while parsing {}: {}", t, e))? }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/row_format.rs:312:3 [INFO] [stderr] | [INFO] [stderr] 312 | let v; [INFO] [stderr] | _________^ [INFO] [stderr] 313 | | [INFO] [stderr] 314 | | if t == "nan" [INFO] [stderr] 315 | | { v = ::std::f64::NAN; } [INFO] [stderr] ... | [INFO] [stderr] 319 | | .map_err(|e| format!("while parsing {}: {}", t, e))?; [INFO] [stderr] 320 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 312 | let v = if t == "nan" { ::std::f64::NAN } else { t.parse() [INFO] [stderr] 313 | .map_err(|e| format!("while parsing {}: {}", t, e))? }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | if address.starts_with("/") || address.starts_with("unix:") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:103:6 [INFO] [stderr] | [INFO] [stderr] 103 | .expect(&format!("binding to socket {}", address)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("binding to socket {}", address))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sonnerie`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "53fcc10debde7dc2c2124f79e5f09e202da8a5e7b8092561ed5f458db89301a5"` [INFO] running `"docker" "rm" "-f" "53fcc10debde7dc2c2124f79e5f09e202da8a5e7b8092561ed5f458db89301a5"` [INFO] [stdout] 53fcc10debde7dc2c2124f79e5f09e202da8a5e7b8092561ed5f458db89301a5