[INFO] crate someip_parse 0.1.0 is already in cache [INFO] extracting crate someip_parse 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/someip_parse/0.1.0 [INFO] extracting crate someip_parse 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/someip_parse/0.1.0 [INFO] validating manifest of someip_parse-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of someip_parse-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing someip_parse-0.1.0 [INFO] finished frobbing someip_parse-0.1.0 [INFO] frobbed toml for someip_parse-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/someip_parse/0.1.0/Cargo.toml [INFO] started frobbing someip_parse-0.1.0 [INFO] finished frobbing someip_parse-0.1.0 [INFO] frobbed toml for someip_parse-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/someip_parse/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting someip_parse-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/someip_parse/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adb0b767aa0b187a31aab9ad620c5aa9aec8eb6b253474809af441729e46c740 [INFO] running `"docker" "start" "-a" "adb0b767aa0b187a31aab9ad620c5aa9aec8eb6b253474809af441729e46c740"` [INFO] [stderr] Compiling bytepack_derive v0.2.0 [INFO] [stderr] Checking someip_parse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking etherparse v0.5.0 [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | slice: slice [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub const SOMEIP_SD_MESSAGE_ID: u32 = 0xffff8100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_8100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | ((self.message_id & 0xffff0000) >> 16) as u16 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:96:46 [INFO] [stderr] | [INFO] [stderr] 96 | self.message_id = (self.message_id & 0x0000ffff) | ((service_id as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | self.message_id = (self.message_id & 0xffff0000) | ((0x8000 | event_id) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:107:46 [INFO] [stderr] | [INFO] [stderr] 107 | self.message_id = (self.message_id & 0xffff0000) | ((0x7fff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:46 [INFO] [stderr] | [INFO] [stderr] 112 | self.message_id = (self.message_id & 0xffff0000) | ((0xffff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:127:28 [INFO] [stderr] | [INFO] [stderr] 127 | (self.message_id & 0x0000ffff) as u16 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:96:61 [INFO] [stderr] | [INFO] [stderr] 96 | self.message_id = (self.message_id & 0x0000ffff) | ((service_id as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(service_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:101:60 [INFO] [stderr] | [INFO] [stderr] 101 | self.message_id = (self.message_id & 0xffff0000) | ((0x8000 | event_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(0x8000 | event_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:60 [INFO] [stderr] | [INFO] [stderr] 107 | self.message_id = (self.message_id & 0xffff0000) | ((0x7fff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(0x7fff & method_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:112:60 [INFO] [stderr] | [INFO] [stderr] 112 | self.message_id = (self.message_id & 0xffff0000) | ((0xffff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(0xffff & method_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `method_id` [INFO] [stderr] --> src/lib.rs:112:61 [INFO] [stderr] | [INFO] [stderr] 112 | self.message_id = (self.message_id & 0xffff0000) | ((0xffff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/lib.rs:185:35 [INFO] [stderr] | [INFO] [stderr] 185 | message_type_tp: 0 != message_type & SOMEIP_HEADER_MESSAGE_TYPE_TP_FLAG, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/lib.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | message_type = reader.read_u8()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:359:12 [INFO] [stderr] | [INFO] [stderr] 359 | if self.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Checking bytepack v0.4.1 [INFO] [stderr] Checking rpcap v0.3.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | slice: slice [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/print_messages.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / match value.transport { [INFO] [stderr] 67 | | Some(Udp(_)) => { [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | //trying parsing some ip messages located in a udp payload [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => {} [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | if let Some(Udp(_)) = value.transport { [INFO] [stderr] 67 | [INFO] [stderr] 68 | //trying parsing some ip messages located in a udp payload [INFO] [stderr] 69 | for someip_message in SliceIterator::new(value.payload) { [INFO] [stderr] 70 | match someip_message { [INFO] [stderr] 71 | Ok(value) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/print_messages.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | / match someip_message { [INFO] [stderr] 72 | | Ok(value) => { [INFO] [stderr] 73 | | if value.is_someip_sd() { [INFO] [stderr] 74 | | println!("someip service discovery packet"); [INFO] [stderr] ... | [INFO] [stderr] 83 | | Err(_) => {} //error reading a someip packet (based on size, protocol version value or message type value) [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Ok(value) = someip_message { [INFO] [stderr] 72 | if value.is_someip_sd() { [INFO] [stderr] 73 | println!("someip service discovery packet"); [INFO] [stderr] 74 | } else { [INFO] [stderr] 75 | println!("0x{:x} (service id: 0x{:x}, method/event id: 0x{:x})", [INFO] [stderr] 76 | value.message_id(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/count_messages_by_id.rs:127:53 [INFO] [stderr] | [INFO] [stderr] 127 | let duration_secs = duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub const SOMEIP_SD_MESSAGE_ID: u32 = 0xffff8100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_8100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | ((self.message_id & 0xffff0000) >> 16) as u16 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:96:46 [INFO] [stderr] | [INFO] [stderr] 96 | self.message_id = (self.message_id & 0x0000ffff) | ((service_id as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | self.message_id = (self.message_id & 0xffff0000) | ((0x8000 | event_id) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:107:46 [INFO] [stderr] | [INFO] [stderr] 107 | self.message_id = (self.message_id & 0xffff0000) | ((0x7fff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:46 [INFO] [stderr] | [INFO] [stderr] 112 | self.message_id = (self.message_id & 0xffff0000) | ((0xffff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:127:28 [INFO] [stderr] | [INFO] [stderr] 127 | (self.message_id & 0x0000ffff) as u16 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:432:33 [INFO] [stderr] | [INFO] [stderr] 432 | const MESSAGE_TYPE_VALUES: &'static [MessageType;5] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[MessageType;5]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:440:37 [INFO] [stderr] | [INFO] [stderr] 440 | const MESSAGE_TYPE_VALUES_RAW: &'static [u8;10] = &[ [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8;10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:813:40 [INFO] [stderr] | [INFO] [stderr] 813 | const SD_MESSAGE_ID: u32 = 0xFFFF8100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_8100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/proptest_generators/mod.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | length in SOMEIP_LEN_OFFSET_TO_PAYLOAD..SOMEIP_MAX_PAYLOAD_LEN + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `SOMEIP_LEN_OFFSET_TO_PAYLOAD..=SOMEIP_MAX_PAYLOAD_LEN` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:96:61 [INFO] [stderr] | [INFO] [stderr] 96 | self.message_id = (self.message_id & 0x0000ffff) | ((service_id as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(service_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:101:60 [INFO] [stderr] | [INFO] [stderr] 101 | self.message_id = (self.message_id & 0xffff0000) | ((0x8000 | event_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(0x8000 | event_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:60 [INFO] [stderr] | [INFO] [stderr] 107 | self.message_id = (self.message_id & 0xffff0000) | ((0x7fff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(0x7fff & method_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:112:60 [INFO] [stderr] | [INFO] [stderr] 112 | self.message_id = (self.message_id & 0xffff0000) | ((0xffff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(0xffff & method_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `method_id` [INFO] [stderr] --> src/lib.rs:112:61 [INFO] [stderr] | [INFO] [stderr] 112 | self.message_id = (self.message_id & 0xffff0000) | ((0xffff & method_id) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/lib.rs:185:35 [INFO] [stderr] | [INFO] [stderr] 185 | message_type_tp: 0 != message_type & SOMEIP_HEADER_MESSAGE_TYPE_TP_FLAG, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/lib.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | message_type = reader.read_u8()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:359:12 [INFO] [stderr] | [INFO] [stderr] 359 | if self.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | / proptest! { [INFO] [stderr] 485 | | #[test] [INFO] [stderr] 486 | | fn write_read(ref input_base in someip_header_any()) { [INFO] [stderr] 487 | | for message_type in MESSAGE_TYPE_VALUES { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:510:5 [INFO] [stderr] | [INFO] [stderr] 510 | / proptest! { [INFO] [stderr] 511 | | #[test] [INFO] [stderr] 512 | | fn from_slice(length in SOMEIP_LEN_OFFSET_TO_PAYLOAD..1234, [INFO] [stderr] 513 | | ref input_base in someip_header_any(), [INFO] [stderr] ... | [INFO] [stderr] 554 | | } [INFO] [stderr] 555 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:680:17 [INFO] [stderr] | [INFO] [stderr] 680 | buffer.write(&payload[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:709:13 [INFO] [stderr] | [INFO] [stderr] 709 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:755:13 [INFO] [stderr] | [INFO] [stderr] 755 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:779:13 [INFO] [stderr] | [INFO] [stderr] 779 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:801:13 [INFO] [stderr] | [INFO] [stderr] 801 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:826:17 [INFO] [stderr] | [INFO] [stderr] 826 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:835:17 [INFO] [stderr] | [INFO] [stderr] 835 | buffer.write(&packet.1[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `someip_parse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "adb0b767aa0b187a31aab9ad620c5aa9aec8eb6b253474809af441729e46c740"` [INFO] running `"docker" "rm" "-f" "adb0b767aa0b187a31aab9ad620c5aa9aec8eb6b253474809af441729e46c740"` [INFO] [stdout] adb0b767aa0b187a31aab9ad620c5aa9aec8eb6b253474809af441729e46c740