[INFO] crate solr 0.1.0 is already in cache [INFO] extracting crate solr 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/solr/0.1.0 [INFO] extracting crate solr 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solr/0.1.0 [INFO] validating manifest of solr-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solr-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solr-0.1.0 [INFO] finished frobbing solr-0.1.0 [INFO] frobbed toml for solr-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/solr/0.1.0/Cargo.toml [INFO] started frobbing solr-0.1.0 [INFO] finished frobbing solr-0.1.0 [INFO] frobbed toml for solr-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solr/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solr-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/solr/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5994e7ed5e8e932948413d2efd2b155f9ab8bac77eadaaf565536d7f048fd98 [INFO] running `"docker" "start" "-a" "d5994e7ed5e8e932948413d2efd2b155f9ab8bac77eadaaf565536d7f048fd98"` [INFO] [stderr] Checking errno v0.1.8 [INFO] [stderr] Checking semver-parser v0.6.2 [INFO] [stderr] Checking semver v0.4.1 [INFO] [stderr] Checking solr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | Error::FileNameError => format!("Failed to extract a filename"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to extract a filename".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | Error::FileNameError => format!("Failed to extract a filename"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to extract a filename".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.51s [INFO] running `"docker" "inspect" "d5994e7ed5e8e932948413d2efd2b155f9ab8bac77eadaaf565536d7f048fd98"` [INFO] running `"docker" "rm" "-f" "d5994e7ed5e8e932948413d2efd2b155f9ab8bac77eadaaf565536d7f048fd98"` [INFO] [stdout] d5994e7ed5e8e932948413d2efd2b155f9ab8bac77eadaaf565536d7f048fd98