[INFO] crate solana_rbpf 0.1.5 is already in cache [INFO] extracting crate solana_rbpf 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/solana_rbpf/0.1.5 [INFO] extracting crate solana_rbpf 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana_rbpf/0.1.5 [INFO] validating manifest of solana_rbpf-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solana_rbpf-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solana_rbpf-0.1.5 [INFO] finished frobbing solana_rbpf-0.1.5 [INFO] frobbed toml for solana_rbpf-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/solana_rbpf/0.1.5/Cargo.toml [INFO] started frobbing solana_rbpf-0.1.5 [INFO] finished frobbing solana_rbpf-0.1.5 [INFO] frobbed toml for solana_rbpf-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana_rbpf/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solana_rbpf-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/solana_rbpf/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3af3bd992e37ec2f5e0c64867cba8b58d8ea248068ec06c9a3855e9b952ff7c0 [INFO] running `"docker" "start" "-a" "3af3bd992e37ec2f5e0c64867cba8b58d8ea248068ec06c9a3855e9b952ff7c0"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking bloom v0.3.2 [INFO] [stderr] Checking ar v0.6.2 [INFO] [stderr] Checking combine v2.5.2 [INFO] [stderr] Compiling enum-primitive-derive v0.1.2 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking elfkit v0.0.6 [INFO] [stderr] Checking solana_rbpf v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/ubpf_jit_x86_64.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/ubpf_vm.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/misc.rs:9:45 [INFO] [stderr] | [INFO] [stderr] 9 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/load_elf.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/ubpf_vm.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/ubpf_jit_x86_64.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/assembler.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/assembler.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | opc: opc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/assembler.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/assembler.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/assembler.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | off: off, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/assembler.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | imm: imm, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/misc.rs:9:45 [INFO] [stderr] | [INFO] [stderr] 9 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub const TCP_SACK_ASM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub const TCP_SACK_ASM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/load_elf.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> tests/misc.rs:286:28 [INFO] [stderr] | [INFO] [stderr] 286 | let mut data = mbuff.as_ptr().offset(8) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> tests/misc.rs:287:28 [INFO] [stderr] | [INFO] [stderr] 287 | let mut data_end = mbuff.as_ptr().offset(24) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> tests/misc.rs:313:28 [INFO] [stderr] | [INFO] [stderr] 313 | let mut data = mbuff.as_ptr().offset(8) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> tests/misc.rs:314:28 [INFO] [stderr] | [INFO] [stderr] 314 | let mut data_end = mbuff.as_ptr().offset(24) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> tests/misc.rs:340:28 [INFO] [stderr] | [INFO] [stderr] 340 | let mut data = mbuff.as_ptr().offset(8) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut u64`) [INFO] [stderr] --> tests/misc.rs:341:28 [INFO] [stderr] | [INFO] [stderr] 341 | let mut data_end = mbuff.as_ptr().offset(24) as *mut u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:364:20 [INFO] [stderr] | [INFO] [stderr] 364 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:385:20 [INFO] [stderr] | [INFO] [stderr] 385 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:406:20 [INFO] [stderr] | [INFO] [stderr] 406 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:427:20 [INFO] [stderr] | [INFO] [stderr] 427 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:479:20 [INFO] [stderr] | [INFO] [stderr] 479 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:501:20 [INFO] [stderr] | [INFO] [stderr] 501 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:523:20 [INFO] [stderr] | [INFO] [stderr] 523 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/misc.rs:545:20 [INFO] [stderr] | [INFO] [stderr] 545 | let mut mem2 = mem1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `mem1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `solana_rbpf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub const TCP_SACK_ASM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/assembler.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub const TCP_SACK_ASM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub const TCP_SACK_ASM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "3af3bd992e37ec2f5e0c64867cba8b58d8ea248068ec06c9a3855e9b952ff7c0"` [INFO] running `"docker" "rm" "-f" "3af3bd992e37ec2f5e0c64867cba8b58d8ea248068ec06c9a3855e9b952ff7c0"` [INFO] [stdout] 3af3bd992e37ec2f5e0c64867cba8b58d8ea248068ec06c9a3855e9b952ff7c0