[INFO] crate solana-lualoader 0.10.4 is already in cache [INFO] extracting crate solana-lualoader 0.10.4 into work/ex/clippy-test-run/sources/stable/reg/solana-lualoader/0.10.4 [INFO] extracting crate solana-lualoader 0.10.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana-lualoader/0.10.4 [INFO] validating manifest of solana-lualoader-0.10.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solana-lualoader-0.10.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solana-lualoader-0.10.4 [INFO] finished frobbing solana-lualoader-0.10.4 [INFO] frobbed toml for solana-lualoader-0.10.4 written to work/ex/clippy-test-run/sources/stable/reg/solana-lualoader/0.10.4/Cargo.toml [INFO] started frobbing solana-lualoader-0.10.4 [INFO] finished frobbing solana-lualoader-0.10.4 [INFO] frobbed toml for solana-lualoader-0.10.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana-lualoader/0.10.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solana-lualoader-0.10.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/solana-lualoader/0.10.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1de8b6e7a5d7aa4381f20a7a7f4b3af8b21f28d5f6199b27caf3991ad4236b61 [INFO] running `"docker" "start" "-a" "1de8b6e7a5d7aa4381f20a7a7f4b3af8b21f28d5f6199b27caf3991ad4236b61"` [INFO] [stderr] Checking bs58 v0.2.2 [INFO] [stderr] Compiling rlua v0.15.3 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking solana-sdk v0.10.4 [INFO] [stderr] Checking solana-lualoader v0.10.4 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:34:46 [INFO] [stderr] | [INFO] [stderr] 34 | for (i, keyed_account) in keyed_accounts.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:34:46 [INFO] [stderr] | [INFO] [stderr] 34 | for (i, keyed_account) in keyed_accounts.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:150:24 [INFO] [stderr] | [INFO] [stderr] 150 | let userdata = r#" [INFO] [stderr] | ________________________^ [INFO] [stderr] 151 | | local tokens, _ = string.unpack("I", data) [INFO] [stderr] 152 | | accounts[1].tokens = accounts[1].tokens - tokens [INFO] [stderr] 153 | | accounts[2].tokens = accounts[2].tokens + tokens [INFO] [stderr] 154 | | "#.as_bytes() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 150 | let userdata = br#" [INFO] [stderr] 151 | local tokens, _ = string.unpack("I", data) [INFO] [stderr] 152 | accounts[1].tokens = accounts[1].tokens - tokens [INFO] [stderr] 153 | accounts[2].tokens = accounts[2].tokens + tokens [INFO] [stderr] 154 | "# [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:196:24 [INFO] [stderr] | [INFO] [stderr] 196 | let userdata = r#" [INFO] [stderr] | ________________________^ [INFO] [stderr] 197 | | local serialize = load(accounts[2].userdata)().serialize [INFO] [stderr] 198 | | accounts[3].userdata = serialize({a=1, b=2, c=3}, nil, "s") [INFO] [stderr] 199 | | "#.as_bytes() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 196 | let userdata = br#" [INFO] [stderr] 197 | local serialize = load(accounts[2].userdata)().serialize [INFO] [stderr] 198 | accounts[3].userdata = serialize({a=1, b=2, c=3}, nil, "s") [INFO] [stderr] 199 | "# [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.21s [INFO] running `"docker" "inspect" "1de8b6e7a5d7aa4381f20a7a7f4b3af8b21f28d5f6199b27caf3991ad4236b61"` [INFO] running `"docker" "rm" "-f" "1de8b6e7a5d7aa4381f20a7a7f4b3af8b21f28d5f6199b27caf3991ad4236b61"` [INFO] [stdout] 1de8b6e7a5d7aa4381f20a7a7f4b3af8b21f28d5f6199b27caf3991ad4236b61