[INFO] crate solana-jsonrpc-tcp-server 0.4.0 is already in cache [INFO] extracting crate solana-jsonrpc-tcp-server 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/solana-jsonrpc-tcp-server/0.4.0 [INFO] extracting crate solana-jsonrpc-tcp-server 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana-jsonrpc-tcp-server/0.4.0 [INFO] validating manifest of solana-jsonrpc-tcp-server-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solana-jsonrpc-tcp-server-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solana-jsonrpc-tcp-server-0.4.0 [INFO] finished frobbing solana-jsonrpc-tcp-server-0.4.0 [INFO] frobbed toml for solana-jsonrpc-tcp-server-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/solana-jsonrpc-tcp-server/0.4.0/Cargo.toml [INFO] started frobbing solana-jsonrpc-tcp-server-0.4.0 [INFO] finished frobbing solana-jsonrpc-tcp-server-0.4.0 [INFO] frobbed toml for solana-jsonrpc-tcp-server-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana-jsonrpc-tcp-server/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solana-jsonrpc-tcp-server-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/solana-jsonrpc-tcp-server/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b926829e2c7d76c50a5a8f02d9d19d2ad8eb9b29257388be281d5cf56e3fb52 [INFO] running `"docker" "start" "-a" "8b926829e2c7d76c50a5a8f02d9d19d2ad8eb9b29257388be281d5cf56e3fb52"` [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking solana-jsonrpc-core v0.4.0 [INFO] [stderr] Checking solana-jsonrpc-server-utils v0.4.0 [INFO] [stderr] Checking solana-jsonrpc-tcp-server v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatch.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatch.rs:58:4 [INFO] [stderr] | [INFO] [stderr] 58 | channels: channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:98:7 [INFO] [stderr] | [INFO] [stderr] 98 | peer_addr: peer_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | Service { peer_addr: peer_addr, handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | Service { peer_addr: peer_addr, handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:16:53 [INFO] [stderr] | [INFO] [stderr] 16 | Service { peer_addr: peer_addr, handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatch.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatch.rs:58:4 [INFO] [stderr] | [INFO] [stderr] 58 | channels: channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:98:7 [INFO] [stderr] | [INFO] [stderr] 98 | peer_addr: peer_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | Service { peer_addr: peer_addr, handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | Service { peer_addr: peer_addr, handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:16:53 [INFO] [stderr] | [INFO] [stderr] 16 | Service { peer_addr: peer_addr, handler: handler, meta: meta } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:183:20 [INFO] [stderr] | [INFO] [stderr] 183 | SocketMetadata { addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dispatch.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return Err(PushMessageError::NoSuchPeer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(PushMessageError::NoSuchPeer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dispatch.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | try!(channel.send(msg).wait().map_err(|e| PushMessageError::from(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PushMessageError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | channels.insert(peer_addr.clone(), sender.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server.rs:136:8 [INFO] [stderr] | [INFO] [stderr] 136 | peer_addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:212:3 [INFO] [stderr] | [INFO] [stderr] 212 | self.executor.take().map(|executor| executor.close()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(executor) = self.executor.take() { executor.close() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dispatch.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return Err(PushMessageError::NoSuchPeer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(PushMessageError::NoSuchPeer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dispatch.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | try!(channel.send(msg).wait().map_err(|e| PushMessageError::from(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PushMessageError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | channels.insert(peer_addr.clone(), sender.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server.rs:136:8 [INFO] [stderr] | [INFO] [stderr] 136 | peer_addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:212:3 [INFO] [stderr] | [INFO] [stderr] 212 | self.executor.take().map(|executor| executor.close()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(executor) = self.executor.take() { executor.close() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/logger.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | if let Ok(_) = builder.try_init() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 15 | | println!("logger initialized"); [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________- help: try this: `if builder.try_init().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:138:14 [INFO] [stderr] | [INFO] [stderr] 138 | let addr = addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | self.peers.lock().push(context.peer_addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `context.peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests.rs:268:20 [INFO] [stderr] | [INFO] [stderr] 268 | let peer_addr = peer_list.lock()[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer_list.lock()[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.44s [INFO] running `"docker" "inspect" "8b926829e2c7d76c50a5a8f02d9d19d2ad8eb9b29257388be281d5cf56e3fb52"` [INFO] running `"docker" "rm" "-f" "8b926829e2c7d76c50a5a8f02d9d19d2ad8eb9b29257388be281d5cf56e3fb52"` [INFO] [stdout] 8b926829e2c7d76c50a5a8f02d9d19d2ad8eb9b29257388be281d5cf56e3fb52