[INFO] crate solana-jsonrpc-macros 0.4.0 is already in cache [INFO] extracting crate solana-jsonrpc-macros 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/solana-jsonrpc-macros/0.4.0 [INFO] extracting crate solana-jsonrpc-macros 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana-jsonrpc-macros/0.4.0 [INFO] validating manifest of solana-jsonrpc-macros-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solana-jsonrpc-macros-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solana-jsonrpc-macros-0.4.0 [INFO] finished frobbing solana-jsonrpc-macros-0.4.0 [INFO] frobbed toml for solana-jsonrpc-macros-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/solana-jsonrpc-macros/0.4.0/Cargo.toml [INFO] started frobbing solana-jsonrpc-macros-0.4.0 [INFO] finished frobbing solana-jsonrpc-macros-0.4.0 [INFO] frobbed toml for solana-jsonrpc-macros-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solana-jsonrpc-macros/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solana-jsonrpc-macros-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/solana-jsonrpc-macros/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 734e87aafbe5b8c3de00658bf92f71720f9ac9f2cf1bb609ce60e0826136c6d5 [INFO] running `"docker" "start" "-a" "734e87aafbe5b8c3de00658bf92f71720f9ac9f2cf1bb609ce60e0826136c6d5"` [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking solana-jsonrpc-core v0.4.0 [INFO] [stderr] Checking solana-jsonrpc-server-utils v0.4.0 [INFO] [stderr] Checking solana-jsonrpc-pubsub v0.4.0 [INFO] [stderr] Checking solana-jsonrpc-macros v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delegates.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | delegate: delegate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delegate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pubsub.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | subscriber: subscriber, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscriber` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pubsub.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pubsub.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | sink: sink, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/auto_args.rs:523:2 [INFO] [stderr] | [INFO] [stderr] 523 | id [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/auto_args.rs:517:11 [INFO] [stderr] | [INFO] [stderr] 517 | let id = match len { [INFO] [stderr] | ______________^ [INFO] [stderr] 518 | | 0 => Ok((None,)), [INFO] [stderr] 519 | | 1 => params.parse::<(T,)>().map(|(x, )| (Some(x), )), [INFO] [stderr] 520 | | _ => Err(invalid_params("Expecting only one optional parameter.", "")), [INFO] [stderr] 521 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Checking solana-jsonrpc-tcp-server v0.4.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/delegates.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | delegate: delegate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delegate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pubsub.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | subscriber: subscriber, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subscriber` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pubsub.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pubsub.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | sink: sink, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/auto_args.rs:523:2 [INFO] [stderr] | [INFO] [stderr] 523 | id [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/auto_args.rs:517:11 [INFO] [stderr] | [INFO] [stderr] 517 | let id = match len { [INFO] [stderr] | ______________^ [INFO] [stderr] 518 | | 0 => Ok((None,)), [INFO] [stderr] 519 | | 1 => params.parse::<(T,)>().map(|(x, )| (Some(x), )), [INFO] [stderr] 520 | | _ => Err(invalid_params("Expecting only one optional parameter.", "")), [INFO] [stderr] 521 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.36s [INFO] running `"docker" "inspect" "734e87aafbe5b8c3de00658bf92f71720f9ac9f2cf1bb609ce60e0826136c6d5"` [INFO] running `"docker" "rm" "-f" "734e87aafbe5b8c3de00658bf92f71720f9ac9f2cf1bb609ce60e0826136c6d5"` [INFO] [stdout] 734e87aafbe5b8c3de00658bf92f71720f9ac9f2cf1bb609ce60e0826136c6d5