[INFO] crate sol 0.1.0 is already in cache [INFO] extracting crate sol 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/sol/0.1.0 [INFO] extracting crate sol 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sol/0.1.0 [INFO] validating manifest of sol-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sol-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sol-0.1.0 [INFO] finished frobbing sol-0.1.0 [INFO] frobbed toml for sol-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/sol/0.1.0/Cargo.toml [INFO] started frobbing sol-0.1.0 [INFO] finished frobbing sol-0.1.0 [INFO] frobbed toml for sol-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sol/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sol-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sol/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05b374b51b96eb897247ec853a804457094c5945ba6139c3ea1e3bf88ee7ec74 [INFO] running `"docker" "start" "-a" "05b374b51b96eb897247ec853a804457094c5945ba6139c3ea1e3bf88ee7ec74"` [INFO] [stderr] Checking sol v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | scene: scene, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/quad_mesh.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/quad_mesh.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | vertex_buffer: vertex_buffer, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:40:13 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] 40 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/quad_mesh.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | tnear: tnear, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tnear` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instance.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | tfar: tfar, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tfar` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/instance.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | scene: scene, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/quad_mesh.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] --> src/ray.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/quad_mesh.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/quad_mesh.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:24:13 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 24 | tnear: tnear, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tnear` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | tfar: tfar, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tfar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_mesh.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_mesh.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_mesh.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_mesh.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_mesh.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_mesh.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `geometry::Geometry` [INFO] [stderr] --> src/instance.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use geometry::Geometry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Scene` [INFO] [stderr] --> src/instance.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use scene::{Scene, CommittedScene}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufferType` [INFO] [stderr] --> src/instance.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | use {BufferType, Format, GeometryType}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `geometry::Geometry` [INFO] [stderr] --> src/quad_mesh.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use geometry::Geometry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sys.rs:7:32 [INFO] [stderr] | [INFO] [stderr] 7 | pub const RTC_VERSION_STRING: &'static [u8; 6usize] = b"3.2.4\0"; [INFO] [stderr] | -^^^^^^^------------- help: consider removing `'static`: `&[u8; 6usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `geometry::Geometry` [INFO] [stderr] --> src/triangle_mesh.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use geometry::Geometry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/buffer.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/instance.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `scene` [INFO] [stderr] --> src/instance.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | scene: &'a CommittedScene<'a>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/quad_mesh.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/triangle_mesh.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buffer.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn map<'b>(&'b mut self) -> MappedBuffer<'b, T> { [INFO] [stderr] 35 | | let len = self.bytes / mem::size_of::(); [INFO] [stderr] 36 | | let slice = unsafe { rtcGetBufferData(self.handle) as *mut T }; [INFO] [stderr] 37 | | MappedBuffer { [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `buffer::MappedBuffer<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | / impl<'a, T: 'a> MappedBuffer<'a, T> { [INFO] [stderr] 60 | | pub fn len(&self) -> usize { [INFO] [stderr] 61 | | self.len [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:73:20 [INFO] [stderr] | [INFO] [stderr] 73 | unsafe { &*self.slice.offset(index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.slice.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:82:24 [INFO] [stderr] | [INFO] [stderr] 82 | unsafe { &mut *self.slice.offset(index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.slice.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `device::Device` [INFO] [stderr] --> src/device.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Device { [INFO] [stderr] 11 | | Device { [INFO] [stderr] 12 | | handle: unsafe { rtcNewDevice(ptr::null()) }, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for device::Device { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/geometry.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Geometry::Triangle(ref m) => m.handle, [INFO] [stderr] 18 | | &Geometry::Quad(ref q) => q.handle, [INFO] [stderr] 19 | | &Geometry::Instance(ref i) => i.handle [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Geometry::Triangle(ref m) => m.handle, [INFO] [stderr] 18 | Geometry::Quad(ref q) => q.handle, [INFO] [stderr] 19 | Geometry::Instance(ref i) => i.handle [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sys::RTCHit` [INFO] [stderr] --> src/ray.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Hit { [INFO] [stderr] 36 | | sys::RTCHit { [INFO] [stderr] 37 | | Ng_x: 0.0, [INFO] [stderr] 38 | | Ng_y: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 700| #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `geometry::Geometry` [INFO] [stderr] --> src/instance.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use geometry::Geometry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Scene` [INFO] [stderr] --> src/instance.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | use scene::{Scene, CommittedScene}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufferType` [INFO] [stderr] --> src/instance.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | use {BufferType, Format, GeometryType}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `geometry::Geometry` [INFO] [stderr] --> src/quad_mesh.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use geometry::Geometry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sys.rs:7:32 [INFO] [stderr] | [INFO] [stderr] 7 | pub const RTC_VERSION_STRING: &'static [u8; 6usize] = b"3.2.4\0"; [INFO] [stderr] | -^^^^^^^------------- help: consider removing `'static`: `&[u8; 6usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `geometry::Geometry` [INFO] [stderr] --> src/triangle_mesh.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use geometry::Geometry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/buffer.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/instance.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `scene` [INFO] [stderr] --> src/instance.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | scene: &'a CommittedScene<'a>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/quad_mesh.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `device` [INFO] [stderr] --> src/triangle_mesh.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | device: &'a Device, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buffer.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn map<'b>(&'b mut self) -> MappedBuffer<'b, T> { [INFO] [stderr] 35 | | let len = self.bytes / mem::size_of::(); [INFO] [stderr] 36 | | let slice = unsafe { rtcGetBufferData(self.handle) as *mut T }; [INFO] [stderr] 37 | | MappedBuffer { [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `buffer::MappedBuffer<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | / impl<'a, T: 'a> MappedBuffer<'a, T> { [INFO] [stderr] 60 | | pub fn len(&self) -> usize { [INFO] [stderr] 61 | | self.len [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:73:20 [INFO] [stderr] | [INFO] [stderr] 73 | unsafe { &*self.slice.offset(index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.slice.add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:82:24 [INFO] [stderr] | [INFO] [stderr] 82 | unsafe { &mut *self.slice.offset(index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.slice.add(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `device::Device` [INFO] [stderr] --> src/device.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Device { [INFO] [stderr] 11 | | Device { [INFO] [stderr] 12 | | handle: unsafe { rtcNewDevice(ptr::null()) }, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for device::Device { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/geometry.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Geometry::Triangle(ref m) => m.handle, [INFO] [stderr] 18 | | &Geometry::Quad(ref q) => q.handle, [INFO] [stderr] 19 | | &Geometry::Instance(ref i) => i.handle [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Geometry::Triangle(ref m) => m.handle, [INFO] [stderr] 18 | Geometry::Quad(ref q) => q.handle, [INFO] [stderr] 19 | Geometry::Instance(ref i) => i.handle [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sys::RTCHit` [INFO] [stderr] --> src/ray.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Hit { [INFO] [stderr] 36 | | sys::RTCHit { [INFO] [stderr] 37 | | Ng_x: 0.0, [INFO] [stderr] 38 | | Ng_y: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 700| #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.89s [INFO] running `"docker" "inspect" "05b374b51b96eb897247ec853a804457094c5945ba6139c3ea1e3bf88ee7ec74"` [INFO] running `"docker" "rm" "-f" "05b374b51b96eb897247ec853a804457094c5945ba6139c3ea1e3bf88ee7ec74"` [INFO] [stdout] 05b374b51b96eb897247ec853a804457094c5945ba6139c3ea1e3bf88ee7ec74