[INFO] crate sokol 0.2.0 is already in cache
[INFO] extracting crate sokol 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/sokol/0.2.0
[INFO] extracting crate sokol 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sokol/0.2.0
[INFO] validating manifest of sokol-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sokol-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sokol-0.2.0
[INFO] finished frobbing sokol-0.2.0
[INFO] frobbed toml for sokol-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sokol/0.2.0/Cargo.toml
[INFO] started frobbing sokol-0.2.0
[INFO] finished frobbing sokol-0.2.0
[INFO] frobbed toml for sokol-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sokol/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sokol-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sokol/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a7f5e72383d6f32a99ea553614f6c0ccf32a5a64b6b46701d41b82223b5b9b81
[INFO] running `"docker" "start" "-a" "a7f5e72383d6f32a99ea553614f6c0ccf32a5a64b6b46701d41b82223b5b9b81"`
[INFO] [stderr]    Compiling sokol v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/app.rs:463:9
[INFO] [stderr]     |
[INFO] [stderr] 463 |         app
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/app.rs:458:19
[INFO] [stderr]     |
[INFO] [stderr] 458 |           let app = unsafe {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 459 | |             let app_ptr = ffi::sapp_get_user_ptr() as *mut SAppImpl;
[INFO] [stderr] 460 | |             &mut *app_ptr
[INFO] [stderr] 461 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/app.rs:463:9
[INFO] [stderr]     |
[INFO] [stderr] 463 |         app
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/app.rs:458:19
[INFO] [stderr]     |
[INFO] [stderr] 458 |           let app = unsafe {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 459 | |             let app_ptr = ffi::sapp_get_user_ptr() as *mut SAppImpl;
[INFO] [stderr] 460 | |             &mut *app_ptr
[INFO] [stderr] 461 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/app.rs:148:15
[INFO] [stderr]     |
[INFO] [stderr] 148 |             &*event
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/app.rs:147:17
[INFO] [stderr]     |
[INFO] [stderr] 147 |           let e = unsafe {
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 148 | |             &*event
[INFO] [stderr] 149 | |         }.clone();
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let e = *unsafe {
[INFO] [stderr] 148 |             &*event
[INFO] [stderr] 149 |         };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/app.rs:174:28
[INFO] [stderr]     |
[INFO] [stderr] 174 |             CStr::from_ptr(message)
[INFO] [stderr]     |                            ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/app.rs:184:32
[INFO] [stderr]     |
[INFO] [stderr] 184 |             from_raw_parts_mut(buffer, len as usize)
[INFO] [stderr]     |                                ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:419:34
[INFO] [stderr]     |
[INFO] [stderr] 419 |                             src: &Vec<super::SgShaderUniformDesc>) {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgShaderUniformDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:432:40
[INFO] [stderr]     |
[INFO] [stderr] 432 |                                   src: &Vec<super::SgShaderUniformBlockDesc>) {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgShaderUniformBlockDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:441:32
[INFO] [stderr]     |
[INFO] [stderr] 441 |                           src: &Vec<super::SgShaderImageDesc>) {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgShaderImageDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:556:40
[INFO] [stderr]     |
[INFO] [stderr] 556 |                                   src: &Vec<super::SgBufferLayoutDesc>) {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgBufferLayoutDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:567:38
[INFO] [stderr]     |
[INFO] [stderr] 567 |                                 src: &Vec<super::SgVertexAttrDesc>) {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgVertexAttrDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]     --> src/gfx.rs:1444:50
[INFO] [stderr]      |
[INFO] [stderr] 1444 | pub fn sg_update_image<T>(img: SgImage, content: &Vec<(*const T, i32)>) {
[INFO] [stderr]      |                                                  ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(*const T, i32)]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]     --> src/gfx.rs:1500:28
[INFO] [stderr]      |
[INFO] [stderr] 1500 | pub fn sg_begin_pass(pass: &SgPass,
[INFO] [stderr]      |                            ^^^^^^^ help: consider passing by value instead: `SgPass`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/gfx.rs:1504:28
[INFO] [stderr]      |
[INFO] [stderr] 1504 |         ffi::sg_begin_pass(pass.clone(), &action);
[INFO] [stderr]      |                            ^^^^^^^^^^^^ help: try dereferencing it: `*pass`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/time.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |         ffi::stm_laptime(last_time)
[INFO] [stderr]    |                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sokol`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/app.rs:148:15
[INFO] [stderr]     |
[INFO] [stderr] 148 |             &*event
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/app.rs:147:17
[INFO] [stderr]     |
[INFO] [stderr] 147 |           let e = unsafe {
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 148 | |             &*event
[INFO] [stderr] 149 | |         }.clone();
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let e = *unsafe {
[INFO] [stderr] 148 |             &*event
[INFO] [stderr] 149 |         };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/app.rs:174:28
[INFO] [stderr]     |
[INFO] [stderr] 174 |             CStr::from_ptr(message)
[INFO] [stderr]     |                            ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/app.rs:184:32
[INFO] [stderr]     |
[INFO] [stderr] 184 |             from_raw_parts_mut(buffer, len as usize)
[INFO] [stderr]     |                                ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:419:34
[INFO] [stderr]     |
[INFO] [stderr] 419 |                             src: &Vec<super::SgShaderUniformDesc>) {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgShaderUniformDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:432:40
[INFO] [stderr]     |
[INFO] [stderr] 432 |                                   src: &Vec<super::SgShaderUniformBlockDesc>) {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgShaderUniformBlockDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:441:32
[INFO] [stderr]     |
[INFO] [stderr] 441 |                           src: &Vec<super::SgShaderImageDesc>) {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgShaderImageDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:556:40
[INFO] [stderr]     |
[INFO] [stderr] 556 |                                   src: &Vec<super::SgBufferLayoutDesc>) {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgBufferLayoutDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/gfx.rs:567:38
[INFO] [stderr]     |
[INFO] [stderr] 567 |                                 src: &Vec<super::SgVertexAttrDesc>) {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[super::SgVertexAttrDesc]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]     --> src/gfx.rs:1444:50
[INFO] [stderr]      |
[INFO] [stderr] 1444 | pub fn sg_update_image<T>(img: SgImage, content: &Vec<(*const T, i32)>) {
[INFO] [stderr]      |                                                  ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(*const T, i32)]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]     --> src/gfx.rs:1500:28
[INFO] [stderr]      |
[INFO] [stderr] 1500 | pub fn sg_begin_pass(pass: &SgPass,
[INFO] [stderr]      |                            ^^^^^^^ help: consider passing by value instead: `SgPass`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/gfx.rs:1504:28
[INFO] [stderr]      |
[INFO] [stderr] 1504 |         ffi::sg_begin_pass(pass.clone(), &action);
[INFO] [stderr]      |                            ^^^^^^^^^^^^ help: try dereferencing it: `*pass`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/time.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |         ffi::stm_laptime(last_time)
[INFO] [stderr]    |                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sokol`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "a7f5e72383d6f32a99ea553614f6c0ccf32a5a64b6b46701d41b82223b5b9b81"`
[INFO] running `"docker" "rm" "-f" "a7f5e72383d6f32a99ea553614f6c0ccf32a5a64b6b46701d41b82223b5b9b81"`
[INFO] [stdout] a7f5e72383d6f32a99ea553614f6c0ccf32a5a64b6b46701d41b82223b5b9b81