[INFO] crate softprimes 0.1.0 is already in cache [INFO] extracting crate softprimes 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/softprimes/0.1.0 [INFO] extracting crate softprimes 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/softprimes/0.1.0 [INFO] validating manifest of softprimes-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of softprimes-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing softprimes-0.1.0 [INFO] finished frobbing softprimes-0.1.0 [INFO] frobbed toml for softprimes-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/softprimes/0.1.0/Cargo.toml [INFO] started frobbing softprimes-0.1.0 [INFO] finished frobbing softprimes-0.1.0 [INFO] frobbed toml for softprimes-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/softprimes/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting softprimes-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/softprimes/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f46febcb0e836276e6f180ad3858e241a2ba7ab4fbb07adc0c374b4c66f515ee [INFO] running `"docker" "start" "-a" "f46febcb0e836276e6f180ad3858e241a2ba7ab4fbb07adc0c374b4c66f515ee"` [INFO] [stderr] Checking softprimes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:3 [INFO] [stderr] | [INFO] [stderr] 65 | return primes.into_iter().filter(|&x| x != 0).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `primes.into_iter().filter(|&x| x != 0).collect::>()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:3 [INFO] [stderr] | [INFO] [stderr] 65 | return primes.into_iter().filter(|&x| x != 0).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `primes.into_iter().filter(|&x| x != 0).collect::>()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | for x in 1..root+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for y in 1..root+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | for r in 5..root+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `5..=root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `a` is used to index `sieve` [INFO] [stderr] --> src/lib.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | for a in 5..max { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (a, ) in sieve.iter().enumerate().take(max).skip(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | for x in 1..root+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for y in 1..root+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | for r in 5..root+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `5..=root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `a` is used to index `sieve` [INFO] [stderr] --> src/lib.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | for a in 5..max { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (a, ) in sieve.iter().enumerate().take(max).skip(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `"docker" "inspect" "f46febcb0e836276e6f180ad3858e241a2ba7ab4fbb07adc0c374b4c66f515ee"` [INFO] running `"docker" "rm" "-f" "f46febcb0e836276e6f180ad3858e241a2ba7ab4fbb07adc0c374b4c66f515ee"` [INFO] [stdout] f46febcb0e836276e6f180ad3858e241a2ba7ab4fbb07adc0c374b4c66f515ee