[INFO] crate sofa 0.6.0 is already in cache
[INFO] extracting crate sofa 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/sofa/0.6.0
[INFO] extracting crate sofa 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sofa/0.6.0
[INFO] validating manifest of sofa-0.6.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sofa-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sofa-0.6.0
[INFO] finished frobbing sofa-0.6.0
[INFO] frobbed toml for sofa-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/sofa/0.6.0/Cargo.toml
[INFO] started frobbing sofa-0.6.0
[INFO] finished frobbing sofa-0.6.0
[INFO] frobbed toml for sofa-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sofa/0.6.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sofa-0.6.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sofa/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 673d3e6aff03a4a0b6a81cde7e3aa9c0a97345c539a472af02f976831b5c58d7
[INFO] running `"docker" "start" "-a" "673d3e6aff03a4a0b6a81cde7e3aa9c0a97345c539a472af02f976831b5c58d7"`
[INFO] [stderr]     Checking sofa v0.6.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/database.rs:221:17
[INFO] [stderr]     |
[INFO] [stderr] 221 |                 return Err(SofaError(err).into());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SofaError(err).into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/database.rs:252:17
[INFO] [stderr]     |
[INFO] [stderr] 252 |                 return Err(SofaError(err).into());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SofaError(err).into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/database.rs:221:17
[INFO] [stderr]     |
[INFO] [stderr] 221 |                 return Err(SofaError(err).into());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SofaError(err).into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/database.rs:252:17
[INFO] [stderr]     |
[INFO] [stderr] 252 |                 return Err(SofaError(err).into());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SofaError(err).into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/client.rs:44:36
[INFO] [stderr]    |
[INFO] [stderr] 44 |             .timeout(Duration::new(self._timeout as u64, 0))
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self._timeout)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/client.rs:122:35
[INFO] [stderr]     |
[INFO] [stderr] 122 |                 let err = s.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/database.rs:220:38
[INFO] [stderr]     |
[INFO] [stderr] 220 |                 let err = data.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/database.rs:251:38
[INFO] [stderr]     |
[INFO] [stderr] 251 |                 let err = data.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/database.rs:298:34
[INFO] [stderr]     |
[INFO] [stderr] 298 |             let err = data.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/document.rs:71:39
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn populate(&mut self, field: &String, db: Database) -> &Self {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/document.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |         let ref val = self[field].clone();
[INFO] [stderr]    |         ----^^^^^^^----------------------- help: try: `let val = &self[field].clone();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/document.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |             .into_iter()
[INFO] [stderr]    |              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/document.rs:184:40
[INFO] [stderr]     |
[INFO] [stderr] 184 |             rows: docs.into_iter().map(|d| DocumentCollectionItem::new(d)).collect(),
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DocumentCollectionItem::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/document.rs:198:10
[INFO] [stderr]     |
[INFO] [stderr] 198 |         &self.rows.get(index).unwrap()
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.rows[index]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/document.rs:204:9
[INFO] [stderr]     |
[INFO] [stderr] 204 |         self.rows.get_mut(index).unwrap()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.rows[index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/client.rs:44:36
[INFO] [stderr]    |
[INFO] [stderr] 44 |             .timeout(Duration::new(self._timeout as u64, 0))
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self._timeout)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/client.rs:122:35
[INFO] [stderr]     |
[INFO] [stderr] 122 |                 let err = s.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/database.rs:220:38
[INFO] [stderr]     |
[INFO] [stderr] 220 |                 let err = data.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/database.rs:251:38
[INFO] [stderr]     |
[INFO] [stderr] 251 |                 let err = data.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/database.rs:298:34
[INFO] [stderr]     |
[INFO] [stderr] 298 |             let err = data.error.unwrap_or(s!("unspecified error"));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s!("unspecified error"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/document.rs:71:39
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn populate(&mut self, field: &String, db: Database) -> &Self {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/document.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |         let ref val = self[field].clone();
[INFO] [stderr]    |         ----^^^^^^^----------------------- help: try: `let val = &self[field].clone();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/document.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |             .into_iter()
[INFO] [stderr]    |              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/document.rs:184:40
[INFO] [stderr]     |
[INFO] [stderr] 184 |             rows: docs.into_iter().map(|d| DocumentCollectionItem::new(d)).collect(),
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DocumentCollectionItem::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/document.rs:198:10
[INFO] [stderr]     |
[INFO] [stderr] 198 |         &self.rows.get(index).unwrap()
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.rows[index]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/document.rs:204:9
[INFO] [stderr]     |
[INFO] [stderr] 204 |         self.rows.get_mut(index).unwrap()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.rows[index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:280:17
[INFO] [stderr]     |
[INFO] [stderr] 280 |             let ref findex = index_list.indexes[1];
[INFO] [stderr]     |             ----^^^^^^^^^^------------------------- help: try: `let findex = &index_list.indexes[1];`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.88s
[INFO] running `"docker" "inspect" "673d3e6aff03a4a0b6a81cde7e3aa9c0a97345c539a472af02f976831b5c58d7"`
[INFO] running `"docker" "rm" "-f" "673d3e6aff03a4a0b6a81cde7e3aa9c0a97345c539a472af02f976831b5c58d7"`
[INFO] [stdout] 673d3e6aff03a4a0b6a81cde7e3aa9c0a97345c539a472af02f976831b5c58d7