[INFO] crate socksv5_future 0.2.5 is already in cache [INFO] extracting crate socksv5_future 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/socksv5_future/0.2.5 [INFO] extracting crate socksv5_future 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socksv5_future/0.2.5 [INFO] validating manifest of socksv5_future-0.2.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of socksv5_future-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing socksv5_future-0.2.5 [INFO] finished frobbing socksv5_future-0.2.5 [INFO] frobbed toml for socksv5_future-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/socksv5_future/0.2.5/Cargo.toml [INFO] started frobbing socksv5_future-0.2.5 [INFO] finished frobbing socksv5_future-0.2.5 [INFO] frobbed toml for socksv5_future-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socksv5_future/0.2.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting socksv5_future-0.2.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/socksv5_future/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcb15b551fb89a2840e62d371120c18fbfa691d562146cc03cd6bbdccecde8cc [INFO] running `"docker" "start" "-a" "fcb15b551fb89a2840e62d371120c18fbfa691d562146cc03cd6bbdccecde8cc"` [INFO] [stderr] Checking socksv5_future v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same prefix: `Wait` [INFO] [stderr] --> src/socks_fut.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / enum ClientState { [INFO] [stderr] 30 | | WaitSentAuthentication(WriteAll>), [INFO] [stderr] 31 | | WaitAuthenticationMethod(ReadExact>), [INFO] [stderr] 32 | | WaitSentRequest(WriteAll>), [INFO] [stderr] 33 | | WaitReply(ReadExact>) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/socks_fut.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/socks_fut.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/socks_fut.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Wait` [INFO] [stderr] --> src/socks_fut.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / enum ClientState { [INFO] [stderr] 30 | | WaitSentAuthentication(WriteAll>), [INFO] [stderr] 31 | | WaitAuthenticationMethod(ReadExact>), [INFO] [stderr] 32 | | WaitSentRequest(WriteAll>), [INFO] [stderr] 33 | | WaitReply(ReadExact>) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/socks_fut.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/socks_fut.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/socks_fut.rs:206:48 [INFO] [stderr] | [INFO] [stderr] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:50:10 [INFO] [stderr] | [INFO] [stderr] 50 | ((self.bytes[n-2] as u16) << 8) | (self.bytes[n-1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[n-2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:50:43 [INFO] [stderr] | [INFO] [stderr] 50 | ((self.bytes[n-2] as u16) << 8) | (self.bytes[n-1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[n-1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | ((self.bytes[4] as u16) <<8)+(self.bytes[5] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:63:66 [INFO] [stderr] | [INFO] [stderr] 63 | ((self.bytes[4] as u16) <<8)+(self.bytes[5] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.bytes[6] as u16) <<8)+(self.bytes[7] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:64:66 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.bytes[6] as u16) <<8)+(self.bytes[7] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | ((self.bytes[8] as u16) <<8)+(self.bytes[9] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:65:66 [INFO] [stderr] | [INFO] [stderr] 65 | ((self.bytes[8] as u16) <<8)+(self.bytes[9] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:66:38 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.bytes[10] as u16) <<8)+(self.bytes[11] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:66:67 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.bytes[10] as u16) <<8)+(self.bytes[11] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.bytes[12] as u16) <<8)+(self.bytes[13] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:67:67 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.bytes[12] as u16) <<8)+(self.bytes[13] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | ((self.bytes[14] as u16) <<8)+(self.bytes[15] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:68:67 [INFO] [stderr] | [INFO] [stderr] 68 | ((self.bytes[14] as u16) <<8)+(self.bytes[15] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[15])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | ((self.bytes[16] as u16) <<8)+(self.bytes[17] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:69:67 [INFO] [stderr] | [INFO] [stderr] 69 | ((self.bytes[16] as u16) <<8)+(self.bytes[17] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | ((self.bytes[18] as u16) <<8)+(self.bytes[19] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[18])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:70:67 [INFO] [stderr] | [INFO] [stderr] 70 | ((self.bytes[18] as u16) <<8)+(self.bytes[19] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[19])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/socks_fut.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn clone(&self) -> SocksRequestResponse { [INFO] [stderr] 104 | | SocksRequestResponse { [INFO] [stderr] 105 | | bytes: self.bytes.clone() [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/socks_fut.rs:257:24 [INFO] [stderr] | [INFO] [stderr] 257 | if self.response.bytes[2] != self.response.bytes[2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `socksv5_future`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:50:10 [INFO] [stderr] | [INFO] [stderr] 50 | ((self.bytes[n-2] as u16) << 8) | (self.bytes[n-1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[n-2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:50:43 [INFO] [stderr] | [INFO] [stderr] 50 | ((self.bytes[n-2] as u16) << 8) | (self.bytes[n-1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[n-1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | ((self.bytes[4] as u16) <<8)+(self.bytes[5] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:63:66 [INFO] [stderr] | [INFO] [stderr] 63 | ((self.bytes[4] as u16) <<8)+(self.bytes[5] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.bytes[6] as u16) <<8)+(self.bytes[7] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:64:66 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.bytes[6] as u16) <<8)+(self.bytes[7] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | ((self.bytes[8] as u16) <<8)+(self.bytes[9] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:65:66 [INFO] [stderr] | [INFO] [stderr] 65 | ((self.bytes[8] as u16) <<8)+(self.bytes[9] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:66:38 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.bytes[10] as u16) <<8)+(self.bytes[11] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:66:67 [INFO] [stderr] | [INFO] [stderr] 66 | ((self.bytes[10] as u16) <<8)+(self.bytes[11] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.bytes[12] as u16) <<8)+(self.bytes[13] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:67:67 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.bytes[12] as u16) <<8)+(self.bytes[13] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | ((self.bytes[14] as u16) <<8)+(self.bytes[15] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:68:67 [INFO] [stderr] | [INFO] [stderr] 68 | ((self.bytes[14] as u16) <<8)+(self.bytes[15] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[15])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | ((self.bytes[16] as u16) <<8)+(self.bytes[17] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:69:67 [INFO] [stderr] | [INFO] [stderr] 69 | ((self.bytes[16] as u16) <<8)+(self.bytes[17] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | ((self.bytes[18] as u16) <<8)+(self.bytes[19] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[18])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/socks_fut.rs:70:67 [INFO] [stderr] | [INFO] [stderr] 70 | ((self.bytes[18] as u16) <<8)+(self.bytes[19] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.bytes[19])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/socks_fut.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn clone(&self) -> SocksRequestResponse { [INFO] [stderr] 104 | | SocksRequestResponse { [INFO] [stderr] 105 | | bytes: self.bytes.clone() [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/socks_fut.rs:257:24 [INFO] [stderr] | [INFO] [stderr] 257 | if self.response.bytes[2] != self.response.bytes[2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `socksv5_future`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcb15b551fb89a2840e62d371120c18fbfa691d562146cc03cd6bbdccecde8cc"` [INFO] running `"docker" "rm" "-f" "fcb15b551fb89a2840e62d371120c18fbfa691d562146cc03cd6bbdccecde8cc"` [INFO] [stdout] fcb15b551fb89a2840e62d371120c18fbfa691d562146cc03cd6bbdccecde8cc