[INFO] crate socks 0.3.2 is already in cache
[INFO] extracting crate socks 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/socks/0.3.2
[INFO] extracting crate socks 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socks/0.3.2
[INFO] validating manifest of socks-0.3.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of socks-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing socks-0.3.2
[INFO] finished frobbing socks-0.3.2
[INFO] frobbed toml for socks-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/socks/0.3.2/Cargo.toml
[INFO] started frobbing socks-0.3.2
[INFO] finished frobbing socks-0.3.2
[INFO] frobbed toml for socks-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socks/0.3.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting socks-0.3.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/socks/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 36578d80f7bc5e960a279f726b206b87a9f061dc08d33502b5e9904ec27161d7
[INFO] running `"docker" "start" "-a" "36578d80f7bc5e960a279f726b206b87a9f061dc08d33502b5e9904ec27161d7"`
[INFO] [stderr]     Checking socks v0.3.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v4.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v4.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             proxy_addr: proxy_addr,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proxy_addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:195:13
[INFO] [stderr]     |
[INFO] [stderr] 195 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:196:13
[INFO] [stderr]     |
[INFO] [stderr] 196 |             proxy_addr: proxy_addr,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proxy_addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:370:13
[INFO] [stderr]     |
[INFO] [stderr] 370 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:371:13
[INFO] [stderr]     |
[INFO] [stderr] 371 |             stream: stream,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v4.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v4.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             proxy_addr: proxy_addr,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proxy_addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:195:13
[INFO] [stderr]     |
[INFO] [stderr] 195 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:196:13
[INFO] [stderr]     |
[INFO] [stderr] 196 |             proxy_addr: proxy_addr,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proxy_addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:370:13
[INFO] [stderr]     |
[INFO] [stderr] 370 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/v5.rs:371:13
[INFO] [stderr]     |
[INFO] [stderr] 371 |             stream: stream,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/v4.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 let _ = packet.extend(host.as_bytes());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/v5.rs:201:12
[INFO] [stderr]     |
[INFO] [stderr] 201 |         if username.len() < 1 || username.len() > 255 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `username.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/v5.rs:204:12
[INFO] [stderr]     |
[INFO] [stderr] 204 |         if password.len() < 1 || password.len() > 255 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/v5.rs:414:37
[INFO] [stderr]     |
[INFO] [stderr] 414 |             ptr::copy(buf.as_ptr(), buf.as_mut_ptr().offset(header.len() as isize), overflow);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add(header.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/v4.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 let _ = packet.extend(host.as_bytes());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/v5.rs:201:12
[INFO] [stderr]     |
[INFO] [stderr] 201 |         if username.len() < 1 || username.len() > 255 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `username.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/v5.rs:204:12
[INFO] [stderr]     |
[INFO] [stderr] 204 |         if password.len() < 1 || password.len() > 255 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/v5.rs:414:37
[INFO] [stderr]     |
[INFO] [stderr] 414 |             ptr::copy(buf.as_ptr(), buf.as_mut_ptr().offset(header.len() as isize), overflow);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add(header.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "36578d80f7bc5e960a279f726b206b87a9f061dc08d33502b5e9904ec27161d7"`
[INFO] running `"docker" "rm" "-f" "36578d80f7bc5e960a279f726b206b87a9f061dc08d33502b5e9904ec27161d7"`
[INFO] [stdout] 36578d80f7bc5e960a279f726b206b87a9f061dc08d33502b5e9904ec27161d7