[INFO] crate socket2 0.3.8 is already in cache [INFO] extracting crate socket2 0.3.8 into work/ex/clippy-test-run/sources/stable/reg/socket2/0.3.8 [INFO] extracting crate socket2 0.3.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socket2/0.3.8 [INFO] validating manifest of socket2-0.3.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of socket2-0.3.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing socket2-0.3.8 [INFO] finished frobbing socket2-0.3.8 [INFO] frobbed toml for socket2-0.3.8 written to work/ex/clippy-test-run/sources/stable/reg/socket2/0.3.8/Cargo.toml [INFO] started frobbing socket2-0.3.8 [INFO] finished frobbing socket2-0.3.8 [INFO] frobbed toml for socket2-0.3.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socket2/0.3.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting socket2-0.3.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/socket2/0.3.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b54dd0457269378794e0714780625ad53621092c7b1b7ead10812160ddc2e1c5 [INFO] running `"docker" "start" "-a" "b54dd0457269378794e0714780625ad53621092c7b1b7ead10812160ddc2e1c5"` [INFO] [stderr] Checking socket2 v0.3.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sockaddr.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sockaddr.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/mod.rs:296:54 [INFO] [stderr] | [INFO] [stderr] 296 | Ok(fd) => socket = Some(Socket { fd: fd }), [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/mod.rs:856:18 [INFO] [stderr] | [INFO] [stderr] 856 | Socket { fd: fd } [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sockaddr.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sockaddr.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/mod.rs:296:54 [INFO] [stderr] | [INFO] [stderr] 296 | Ok(fd) => socket = Some(Socket { fd: fd }), [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/mod.rs:856:18 [INFO] [stderr] | [INFO] [stderr] 856 | Socket { fd: fd } [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:850:9 [INFO] [stderr] | [INFO] [stderr] 850 | return fd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:1078:5 [INFO] [stderr] | [INFO] [stderr] 1078 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:850:9 [INFO] [stderr] | [INFO] [stderr] 850 | return fd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sys/unix/mod.rs:1078:5 [INFO] [stderr] | [INFO] [stderr] 1078 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: item `SockAddr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/sockaddr.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / impl SockAddr { [INFO] [stderr] 34 | | /// Constructs a `SockAddr` from its raw components. [INFO] [stderr] 35 | | pub unsafe fn from_raw_parts(addr: *const sockaddr, len: socklen_t) -> SockAddr { [INFO] [stderr] 36 | | let mut storage = mem::uninitialized::(); [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:462:50 [INFO] [stderr] | [INFO] [stderr] 462 | pub fn set_multicast_if_v4(&self, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:512:48 [INFO] [stderr] | [INFO] [stderr] 512 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:512:70 [INFO] [stderr] | [INFO] [stderr] 512 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:531:49 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:531:71 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:177:33 [INFO] [stderr] | [INFO] [stderr] 177 | .saturating_add(timeout.subsec_nanos() as u64 / 1_000_000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:581:50 [INFO] [stderr] | [INFO] [stderr] 581 | pub fn set_multicast_if_v4(&self, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:622:48 [INFO] [stderr] | [INFO] [stderr] 622 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:622:70 [INFO] [stderr] | [INFO] [stderr] 622 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:641:49 [INFO] [stderr] | [INFO] [stderr] 641 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:641:71 [INFO] [stderr] | [INFO] [stderr] 641 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1032:26 [INFO] [stderr] | [INFO] [stderr] 1032 | tv_usec: (dur.subsec_nanos() / 1000) as libc::suseconds_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dur.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/sys/unix/mod.rs:1032:26 [INFO] [stderr] | [INFO] [stderr] 1032 | tv_usec: (dur.subsec_nanos() / 1000) as libc::suseconds_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:1056:20 [INFO] [stderr] | [INFO] [stderr] 1056 | fn to_s_addr(addr: &Ipv4Addr) -> libc::in_addr_t { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1059:10 [INFO] [stderr] | [INFO] [stderr] 1059 | ((octets[0] as libc::in_addr_t) << 24) | ((octets[1] as libc::in_addr_t) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1059:51 [INFO] [stderr] | [INFO] [stderr] 1059 | ((octets[0] as libc::in_addr_t) << 24) | ((octets[1] as libc::in_addr_t) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1060:16 [INFO] [stderr] | [INFO] [stderr] 1060 | | ((octets[2] as libc::in_addr_t) << 8) | ((octets[3] as libc::in_addr_t) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(octets[3] as libc::in_addr_t)` [INFO] [stderr] --> src/sys/unix/mod.rs:1060:55 [INFO] [stderr] | [INFO] [stderr] 1060 | | ((octets[2] as libc::in_addr_t) << 8) | ((octets[3] as libc::in_addr_t) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1060:56 [INFO] [stderr] | [INFO] [stderr] 1060 | | ((octets[2] as libc::in_addr_t) << 8) | ((octets[3] as libc::in_addr_t) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `h_addr` [INFO] [stderr] --> src/sys/unix/mod.rs:1070:17 [INFO] [stderr] | [INFO] [stderr] 1070 | let d: u8 = (h_addr >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: item `SockAddr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/sockaddr.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / impl SockAddr { [INFO] [stderr] 34 | | /// Constructs a `SockAddr` from its raw components. [INFO] [stderr] 35 | | pub unsafe fn from_raw_parts(addr: *const sockaddr, len: socklen_t) -> SockAddr { [INFO] [stderr] 36 | | let mut storage = mem::uninitialized::(); [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:462:50 [INFO] [stderr] | [INFO] [stderr] 462 | pub fn set_multicast_if_v4(&self, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:512:48 [INFO] [stderr] | [INFO] [stderr] 512 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:512:70 [INFO] [stderr] | [INFO] [stderr] 512 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:531:49 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/socket.rs:531:71 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:177:33 [INFO] [stderr] | [INFO] [stderr] 177 | .saturating_add(timeout.subsec_nanos() as u64 / 1_000_000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(timeout.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:581:50 [INFO] [stderr] | [INFO] [stderr] 581 | pub fn set_multicast_if_v4(&self, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:622:48 [INFO] [stderr] | [INFO] [stderr] 622 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:622:70 [INFO] [stderr] | [INFO] [stderr] 622 | pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:641:49 [INFO] [stderr] | [INFO] [stderr] 641 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:641:71 [INFO] [stderr] | [INFO] [stderr] 641 | pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1032:26 [INFO] [stderr] | [INFO] [stderr] 1032 | tv_usec: (dur.subsec_nanos() / 1000) as libc::suseconds_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dur.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/sys/unix/mod.rs:1032:26 [INFO] [stderr] | [INFO] [stderr] 1032 | tv_usec: (dur.subsec_nanos() / 1000) as libc::suseconds_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/unix/mod.rs:1056:20 [INFO] [stderr] | [INFO] [stderr] 1056 | fn to_s_addr(addr: &Ipv4Addr) -> libc::in_addr_t { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1059:10 [INFO] [stderr] | [INFO] [stderr] 1059 | ((octets[0] as libc::in_addr_t) << 24) | ((octets[1] as libc::in_addr_t) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1059:51 [INFO] [stderr] | [INFO] [stderr] 1059 | ((octets[0] as libc::in_addr_t) << 24) | ((octets[1] as libc::in_addr_t) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1060:16 [INFO] [stderr] | [INFO] [stderr] 1060 | | ((octets[2] as libc::in_addr_t) << 8) | ((octets[3] as libc::in_addr_t) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(octets[3] as libc::in_addr_t)` [INFO] [stderr] --> src/sys/unix/mod.rs:1060:55 [INFO] [stderr] | [INFO] [stderr] 1060 | | ((octets[2] as libc::in_addr_t) << 8) | ((octets[3] as libc::in_addr_t) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/unix/mod.rs:1060:56 [INFO] [stderr] | [INFO] [stderr] 1060 | | ((octets[2] as libc::in_addr_t) << 8) | ((octets[3] as libc::in_addr_t) << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `h_addr` [INFO] [stderr] --> src/sys/unix/mod.rs:1070:17 [INFO] [stderr] | [INFO] [stderr] 1070 | let d: u8 = (h_addr >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `"docker" "inspect" "b54dd0457269378794e0714780625ad53621092c7b1b7ead10812160ddc2e1c5"` [INFO] running `"docker" "rm" "-f" "b54dd0457269378794e0714780625ad53621092c7b1b7ead10812160ddc2e1c5"` [INFO] [stdout] b54dd0457269378794e0714780625ad53621092c7b1b7ead10812160ddc2e1c5