[INFO] crate socket 0.0.7 is already in cache [INFO] extracting crate socket 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/socket/0.0.7 [INFO] extracting crate socket 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socket/0.0.7 [INFO] validating manifest of socket-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of socket-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing socket-0.0.7 [INFO] finished frobbing socket-0.0.7 [INFO] frobbed toml for socket-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/socket/0.0.7/Cargo.toml [INFO] started frobbing socket-0.0.7 [INFO] finished frobbing socket-0.0.7 [INFO] frobbed toml for socket-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/socket/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting socket-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/socket/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d28dc6374f565046f6ab3135ff5d805a4f79ae1adfcdbfcaa43144f68754dfcb [INFO] running `"docker" "start" "-a" "d28dc6374f565046f6ab3135ff5d805a4f79ae1adfcdbfcaa43144f68754dfcb"` [INFO] [stderr] Checking socket v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | Ok(Socket { fd: fd }) [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:22 [INFO] [stderr] | [INFO] [stderr] 235 | Ok((Socket { fd: fd }, sockaddr_to_socketaddr(&sa))) [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | Ok(Socket { fd: fd }) [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:22 [INFO] [stderr] | [INFO] [stderr] 235 | Ok((Socket { fd: fd }, sockaddr_to_socketaddr(&sa))) [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let value = unsafe { $fun($($x,)*) }; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 81 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] 82 | let mut fds: [c_int; 2] = mem::zeroed(); [INFO] [stderr] 83 | _try!(c_socketpair, domain as c_int, type_ as c_int, protocol as c_int, &mut fds as *mut [c_int]); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let value = unsafe { $fun($($x,)*) }; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 129 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] 130 | let value = &value as *const T as *const c_void; [INFO] [stderr] 131 | / _try!( [INFO] [stderr] 132 | | setsockopt, [INFO] [stderr] 133 | | self.fd, level, name, value, mem::size_of::() as socklen_t); [INFO] [stderr] | |_______________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: `extern` block uses type `[i32]` which is not FFI-safe: slices have no C equivalent [INFO] [stderr] --> src/lib.rs:49:71 [INFO] [stderr] | [INFO] [stderr] 49 | fn c_socketpair(domain: c_int, type_: c_int, protocol: c_int, sv: *mut [c_int]) -> c_int; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(improper_ctypes)] on by default [INFO] [stderr] = help: consider using a raw pointer instead [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 174 | let mut a = Vec::with_capacity(bytes); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; bytes]` [INFO] [stderr] ... [INFO] [stderr] 177 | a.extend(repeat(0u8).take(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 199 | let mut a = Vec::with_capacity(bytes); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; bytes]` [INFO] [stderr] ... [INFO] [stderr] 202 | a.extend(repeat(0u8).take(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const libc::in_addr`) [INFO] [stderr] --> src/lib.rs:264:32 [INFO] [stderr] | [INFO] [stderr] 264 | sa.sin_addr = *(&v4.ip().octets() as *const u8 as *const in_addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:281:11 [INFO] [stderr] | [INFO] [stderr] 281 | match sa.sa_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(sa.sa_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:283:46 [INFO] [stderr] | [INFO] [stderr] 283 | let sin: &sockaddr_in = unsafe { mem::transmute(sa) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `&*(sa as *const libc::sockaddr as *const libc::sockaddr_in)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `socket`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let value = unsafe { $fun($($x,)*) }; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 81 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] 82 | let mut fds: [c_int; 2] = mem::zeroed(); [INFO] [stderr] 83 | _try!(c_socketpair, domain as c_int, type_ as c_int, protocol as c_int, &mut fds as *mut [c_int]); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let value = unsafe { $fun($($x,)*) }; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 129 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] 130 | let value = &value as *const T as *const c_void; [INFO] [stderr] 131 | / _try!( [INFO] [stderr] 132 | | setsockopt, [INFO] [stderr] 133 | | self.fd, level, name, value, mem::size_of::() as socklen_t); [INFO] [stderr] | |_______________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: `extern` block uses type `[i32]` which is not FFI-safe: slices have no C equivalent [INFO] [stderr] --> src/lib.rs:49:71 [INFO] [stderr] | [INFO] [stderr] 49 | fn c_socketpair(domain: c_int, type_: c_int, protocol: c_int, sv: *mut [c_int]) -> c_int; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(improper_ctypes)] on by default [INFO] [stderr] = help: consider using a raw pointer instead [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 174 | let mut a = Vec::with_capacity(bytes); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; bytes]` [INFO] [stderr] ... [INFO] [stderr] 177 | a.extend(repeat(0u8).take(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 199 | let mut a = Vec::with_capacity(bytes); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; bytes]` [INFO] [stderr] ... [INFO] [stderr] 202 | a.extend(repeat(0u8).take(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const libc::in_addr`) [INFO] [stderr] --> src/lib.rs:264:32 [INFO] [stderr] | [INFO] [stderr] 264 | sa.sin_addr = *(&v4.ip().octets() as *const u8 as *const in_addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:281:11 [INFO] [stderr] | [INFO] [stderr] 281 | match sa.sa_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(sa.sa_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:283:46 [INFO] [stderr] | [INFO] [stderr] 283 | let sin: &sockaddr_in = unsafe { mem::transmute(sa) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `&*(sa as *const libc::sockaddr as *const libc::sockaddr_in)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:343:34 [INFO] [stderr] | [INFO] [stderr] 343 | assert_eq!(sender.sendto("abcd".as_bytes(), 0, &address).unwrap(), 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:366:32 [INFO] [stderr] | [INFO] [stderr] 366 | let sent = client.send("abcd".as_bytes(), 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | thread.join(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:382:28 [INFO] [stderr] | [INFO] [stderr] 382 | let sent = s2.send("abcd".as_bytes(), 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | thread.join(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `socket`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d28dc6374f565046f6ab3135ff5d805a4f79ae1adfcdbfcaa43144f68754dfcb"` [INFO] running `"docker" "rm" "-f" "d28dc6374f565046f6ab3135ff5d805a4f79ae1adfcdbfcaa43144f68754dfcb"` [INFO] [stdout] d28dc6374f565046f6ab3135ff5d805a4f79ae1adfcdbfcaa43144f68754dfcb