[INFO] crate snowflake-rs 0.1.1 is already in cache [INFO] extracting crate snowflake-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/snowflake-rs/0.1.1 [INFO] extracting crate snowflake-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snowflake-rs/0.1.1 [INFO] validating manifest of snowflake-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of snowflake-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing snowflake-rs-0.1.1 [INFO] finished frobbing snowflake-rs-0.1.1 [INFO] frobbed toml for snowflake-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/snowflake-rs/0.1.1/Cargo.toml [INFO] started frobbing snowflake-rs-0.1.1 [INFO] finished frobbing snowflake-rs-0.1.1 [INFO] frobbed toml for snowflake-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snowflake-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting snowflake-rs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/snowflake-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4db9c80c25562c5a3760777054fc84d3f65c9b316b7ba90b3778656a608a966e [INFO] running `"docker" "start" "-a" "4db9c80c25562c5a3760777054fc84d3f65c9b316b7ba90b3778656a608a966e"` [INFO] [stderr] Checking snowflake-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snowflake.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | worker_id : worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snowflake.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | worker_id : worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snowflake.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | worker_id : worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snowflake.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | worker_id : worker_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/snowflake.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | pub const STANDARD_EPOCH: u64 = 1514736000_000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_514_736_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/snowflake.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | / if self.sequence == 0 { [INFO] [stderr] 63 | | if curr_timestamp == self.last_timestamp { [INFO] [stderr] 64 | | curr_timestamp = self.wait_for_next_milli_sec(); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | if self.sequence == 0 && curr_timestamp == self.last_timestamp { [INFO] [stderr] 63 | curr_timestamp = self.wait_for_next_milli_sec(); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/snowflake.rs:92:48 [INFO] [stderr] | [INFO] [stderr] 92 | milli_sec += (time_spec.nsec as u64) / 1000_000u64; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/snowflake.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | (self.worker_id as u64) << WORKER_ID_SHIFT | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.worker_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/snowflake.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | (self.sequence as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/snowflake.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | pub const STANDARD_EPOCH: u64 = 1514736000_000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_514_736_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/snowflake.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | / if self.sequence == 0 { [INFO] [stderr] 63 | | if curr_timestamp == self.last_timestamp { [INFO] [stderr] 64 | | curr_timestamp = self.wait_for_next_milli_sec(); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | if self.sequence == 0 && curr_timestamp == self.last_timestamp { [INFO] [stderr] 63 | curr_timestamp = self.wait_for_next_milli_sec(); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/snowflake.rs:92:48 [INFO] [stderr] | [INFO] [stderr] 92 | milli_sec += (time_spec.nsec as u64) / 1000_000u64; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/snowflake.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | (self.worker_id as u64) << WORKER_ID_SHIFT | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.worker_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/snowflake.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | (self.sequence as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/snowflake.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | t.join(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "4db9c80c25562c5a3760777054fc84d3f65c9b316b7ba90b3778656a608a966e"` [INFO] running `"docker" "rm" "-f" "4db9c80c25562c5a3760777054fc84d3f65c9b316b7ba90b3778656a608a966e"` [INFO] [stdout] 4db9c80c25562c5a3760777054fc84d3f65c9b316b7ba90b3778656a608a966e