[INFO] crate snoot 0.1.2 is already in cache [INFO] extracting crate snoot 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/snoot/0.1.2 [INFO] extracting crate snoot 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snoot/0.1.2 [INFO] validating manifest of snoot-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of snoot-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing snoot-0.1.2 [INFO] finished frobbing snoot-0.1.2 [INFO] frobbed toml for snoot-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/snoot/0.1.2/Cargo.toml [INFO] started frobbing snoot-0.1.2 [INFO] finished frobbing snoot-0.1.2 [INFO] frobbed toml for snoot-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snoot/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting snoot-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/snoot/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba3af33c32e9aa32403fcd78b09aa2dd38afe03c516a805e4852a9d53b15176c [INFO] running `"docker" "start" "-a" "ba3af33c32e9aa32403fcd78b09aa2dd38afe03c516a805e4852a9d53b15176c"` [INFO] [stderr] Checking utf-8 v0.6.0 [INFO] [stderr] Checking tendril v0.2.4 [INFO] [stderr] Checking snoot v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | string: string, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diagnostic/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diagnostic/mod.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde_serialization/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | sexpr: sexpr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sexpr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | string: string, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/scopestack.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diagnostic/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diagnostic/mod.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde_serialization/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | sexpr: sexpr, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sexpr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | return next; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diagnostic/mod.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/diagnostic/mod.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | shortest_dist [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/diagnostic/mod.rs:264:25 [INFO] [stderr] | [INFO] [stderr] 264 | let shortest_dist = ::std::cmp::min(dist_start, dist_end); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/serde_serialization/mod.rs:322:20 [INFO] [stderr] | [INFO] [stderr] 322 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 323 | | if let &Sexpr::Terminal(_, ref span) = &children[0] { [INFO] [stderr] 324 | | if span.text().as_ref() != name { [INFO] [stderr] 325 | | self.bag.add(diagnostic!(span, "expected tuple struct name `{}`, but found `{}`", name, span.text())); [INFO] [stderr] ... | [INFO] [stderr] 337 | | } [INFO] [stderr] 338 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | } else if let &Sexpr::Terminal(_, ref span) = &children[0] { [INFO] [stderr] 323 | if span.text().as_ref() != name { [INFO] [stderr] 324 | self.bag.add(diagnostic!(span, "expected tuple struct name `{}`, but found `{}`", name, span.text())); [INFO] [stderr] 325 | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 326 | } else { [INFO] [stderr] 327 | let vr = { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | return next; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diagnostic/mod.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/diagnostic/mod.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | shortest_dist [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/diagnostic/mod.rs:264:25 [INFO] [stderr] | [INFO] [stderr] 264 | let shortest_dist = ::std::cmp::min(dist_start, dist_end); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Enum` [INFO] [stderr] --> src/serde_serialization/test.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / enum Foo { [INFO] [stderr] 168 | | UnitEnum, [INFO] [stderr] 169 | | NewtypeEnum(i32), [INFO] [stderr] 170 | | TupleEnum(i32, bool), [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/serde_serialization/mod.rs:322:20 [INFO] [stderr] | [INFO] [stderr] 322 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 323 | | if let &Sexpr::Terminal(_, ref span) = &children[0] { [INFO] [stderr] 324 | | if span.text().as_ref() != name { [INFO] [stderr] 325 | | self.bag.add(diagnostic!(span, "expected tuple struct name `{}`, but found `{}`", name, span.text())); [INFO] [stderr] ... | [INFO] [stderr] 337 | | } [INFO] [stderr] 338 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | } else if let &Sexpr::Terminal(_, ref span) = &children[0] { [INFO] [stderr] 323 | if span.text().as_ref() != name { [INFO] [stderr] 324 | self.bag.add(diagnostic!(span, "expected tuple struct name `{}`, but found `{}`", name, span.text())); [INFO] [stderr] 325 | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 326 | } else { [INFO] [stderr] 327 | let vr = { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serde_serialization/mod.rs:300:29 [INFO] [stderr] | [INFO] [stderr] 300 | fn deserialize_tuple(mut self, len: usize, visitor: V) -> Result [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serde_serialization/mod.rs:310:36 [INFO] [stderr] | [INFO] [stderr] 310 | fn deserialize_tuple_struct(mut self, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serde_serialization/mod.rs:357:30 [INFO] [stderr] | [INFO] [stderr] 357 | fn deserialize_struct(mut self, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/token.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn to_string(&self, open: bool) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/scopestack.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | let recurse = match self.stack.last_mut().unwrap() { [INFO] [stderr] | _______________________^ [INFO] [stderr] 55 | | &mut ParseStackItem::Global { ref mut children } => { [INFO] [stderr] 56 | | children.push(expr); [INFO] [stderr] 57 | | None [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | let recurse = match *self.stack.last_mut().unwrap() { [INFO] [stderr] 55 | ParseStackItem::Global { ref mut children } => { [INFO] [stderr] 56 | children.push(expr); [INFO] [stderr] 57 | None [INFO] [stderr] 58 | } [INFO] [stderr] 59 | ParseStackItem::ListOpening { ref mut children, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse/scopestack.rs:77:43 [INFO] [stderr] | [INFO] [stderr] 77 | match (self.stack.pop().unwrap(), closed_by.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `closed_by` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse/scopestack.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | chld.last_token().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*chld.last_token()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse/scopestack.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | opening.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `opening` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `diagnostic::diagnostic_bag::DiagnosticBag` [INFO] [stderr] --> src/diagnostic/diagnostic_bag.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> DiagnosticBag { [INFO] [stderr] 21 | | DiagnosticBag { diagnostics: vec![] } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diagnostic/diagnostic_bag.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | / if let &DiagnosticLevel::Custom(_) = &error.error_level { [INFO] [stderr] 88 | | return true; [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | if let DiagnosticLevel::Custom(_) = error.error_level { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diagnostic/diagnostic_bag.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &DiagnosticLevel::Custom(ref c) = &error.error_level { [INFO] [stderr] 99 | | if c == custom { [INFO] [stderr] 100 | | return true; [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 98 | if let DiagnosticLevel::Custom(ref c) = error.error_level { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/diagnostic/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &DiagnosticLevel::Info => "info", [INFO] [stderr] 83 | | &DiagnosticLevel::Warn => "warn", [INFO] [stderr] 84 | | &DiagnosticLevel::Error => "error", [INFO] [stderr] 85 | | &DiagnosticLevel::Custom(ref s) => s, [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | DiagnosticLevel::Info => "info", [INFO] [stderr] 83 | DiagnosticLevel::Warn => "warn", [INFO] [stderr] 84 | DiagnosticLevel::Error => "error", [INFO] [stderr] 85 | DiagnosticLevel::Custom(ref s) => s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diagnostic/mod.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / if let &Some(ref file) = &builder.global_span.file { [INFO] [stderr] 147 | | writeln!(f, [INFO] [stderr] 148 | | " --> {}:{}:{}", [INFO] [stderr] 149 | | file, [INFO] [stderr] ... | [INFO] [stderr] 156 | | builder.global_span.columns.start)?; [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(ref file) = builder.global_span.file { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/diagnostic/mod.rs:198:1 [INFO] [stderr] | [INFO] [stderr] 198 | / fn get_span<'a>(ann: &'a DiagnosticAnnotation) -> &'a Span { [INFO] [stderr] 199 | | &ann.span [INFO] [stderr] 200 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diagnostic/mod.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | r = r + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `r += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match self { [INFO] [stderr] 129 | | &DeserError::Custom{ref message} => message, [INFO] [stderr] 130 | | &DeserError::DiagnosticAdded => "diagnostic added", [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 128 | match *self { [INFO] [stderr] 129 | DeserError::Custom{ref message} => message, [INFO] [stderr] 130 | DeserError::DiagnosticAdded => "diagnostic added", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match self { [INFO] [stderr] 138 | | &DeserError::Custom{ref message} => write!(formatter, "{}", message), [INFO] [stderr] 139 | | &DeserError::DiagnosticAdded => write!(formatter, "Diagnostic Added"), [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 137 | match *self { [INFO] [stderr] 138 | DeserError::Custom{ref message} => write!(formatter, "{}", message), [INFO] [stderr] 139 | DeserError::DiagnosticAdded => write!(formatter, "Diagnostic Added"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 191 | deserialize_value!(self, visitor, visit_bool, bool, str::parse, "boolean value") [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 195 | deserialize_value!(self, visitor, visit_u8, u8, str::parse, "unsigned integer (u8)") [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 199 | deserialize_value!(self, visitor, visit_u16, u16, str::parse, "unsigned integer (u16)") [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 203 | deserialize_value!(self, visitor, visit_u32, u32, str::parse, "unsigned integer (u32)") [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 207 | deserialize_value!(self, visitor, visit_u64, u64, str::parse, "unsigned integer (u64)") [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 211 | deserialize_value!(self, visitor, visit_i8, i8, str::parse, "signed integer (i8)") [INFO] [stderr] | ---------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 215 | deserialize_value!(self, visitor, visit_i16, i16, str::parse, "signed integer (i16)") [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 219 | deserialize_value!(self, visitor, visit_i32, i32, str::parse, "signed integer (i32)") [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 223 | deserialize_value!(self, visitor, visit_i64, i64, str::parse, "signed integer (i64)") [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 227 | deserialize_value!(self, visitor, visit_f32, f32, str::parse, "floating point number (f32)") [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 231 | deserialize_value!(self, visitor, visit_f64, f64, str::parse, "floating point number (f64)") [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | / if let &Sexpr::Terminal(_, ref span) = self.sexpr { [INFO] [stderr] 248 | | if span.text().as_ref() == "nil" { [INFO] [stderr] 249 | | wrap_visitor_result(visitor.visit_none(), self.sexpr.span(), self.bag) [INFO] [stderr] 250 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 256 | | wrap_visitor_result(r, &self.sexpr.span(), self.bag) [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 247 | if let Sexpr::Terminal(_, ref span) = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 262 | | if children.len() == 0 { [INFO] [stderr] 263 | | wrap_visitor_result(visitor.visit_unit(), self.sexpr.span(), self.bag) [INFO] [stderr] 264 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 270 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 271 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 261 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 293 | | wrap_visitor_result(visitor.visit_seq(SeqDeserializer{sexprs: children, bag: self.bag}), &self.sexpr.span(), self.bag) [INFO] [stderr] 294 | | } else { [INFO] [stderr] 295 | | self.bag.add(diagnostic!(self.sexpr.span(), "expected list, found {:?}", self.sexpr.kind())); [INFO] [stderr] 296 | | return Err(DeserError::DiagnosticAdded); [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 292 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 304 | | wrap_visitor_result(visitor.visit_seq(SeqDeserializer{sexprs: children, bag: self.bag}), &self.sexpr.span(), self.bag) [INFO] [stderr] 305 | | } else { [INFO] [stderr] 306 | | self.bag.add(diagnostic!(self.sexpr.span(), "expected list, found {:?}", self.sexpr.kind())); [INFO] [stderr] 307 | | return Err(DeserError::DiagnosticAdded); [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 319 | | if children.len() == 0 { [INFO] [stderr] 320 | | self.bag.add(diagnostics::nothing_found(span, struct_descr())); [INFO] [stderr] 321 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] ... | [INFO] [stderr] 341 | | return Err(DeserError::DiagnosticAdded); [INFO] [stderr] 342 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 318 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:323:17 [INFO] [stderr] | [INFO] [stderr] 323 | / if let &Sexpr::Terminal(_, ref span) = &children[0] { [INFO] [stderr] 324 | | if span.text().as_ref() != name { [INFO] [stderr] 325 | | self.bag.add(diagnostic!(span, "expected tuple struct name `{}`, but found `{}`", name, span.text())); [INFO] [stderr] 326 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] ... | [INFO] [stderr] 336 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 323 | if let Sexpr::Terminal(_, ref span) = children[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 347 | | let vr = { [INFO] [stderr] 348 | | let map_deser = SeqDeserializer{sexprs: children, bag: self.bag}; [INFO] [stderr] 349 | | visitor.visit_map(map_deser) [INFO] [stderr] ... | [INFO] [stderr] 354 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 346 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 366 | | if children.len() == 0 { [INFO] [stderr] 367 | | self.bag.add(diagnostics::nothing_found(span, struct_descr())); [INFO] [stderr] 368 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] ... | [INFO] [stderr] 393 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 394 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 365 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:366:16 [INFO] [stderr] | [INFO] [stderr] 366 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | / if let &Sexpr::Terminal(_, ref span) = first_child { [INFO] [stderr] 373 | | if span.text().as_ref() == name { [INFO] [stderr] 374 | | wrap_visitor_result(visitor.visit_map( [INFO] [stderr] 375 | | SeqDeserializer{sexprs: &children[1..], bag: self.bag}), &rest_span, self.bag) [INFO] [stderr] ... | [INFO] [stderr] 388 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 389 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 372 | if let Sexpr::Terminal(_, ref span) = *first_child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 400 | deserialize_value!(self, visitor, visit_str, &str, id, "identifier") [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:411:9 [INFO] [stderr] | [INFO] [stderr] 411 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 412 | | if children.len() == 0 { [INFO] [stderr] 413 | | add(self.bag, diagnostic!(span, "expected {}, found empty list", desc())) [INFO] [stderr] 414 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 428 | | add(self.bag, diagnostic!(self.sexpr.span(), "expected {}, found {:?}", desc(), self.sexpr.kind())) [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 411 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:412:16 [INFO] [stderr] | [INFO] [stderr] 412 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | / if let &Sexpr::Terminal(_, ref span) = first { [INFO] [stderr] 417 | | if let Some(idx) = variants.iter().position(|&c| c == span.text().as_ref()) { [INFO] [stderr] 418 | | let res = visitor.visit_enum(EnumDeserializer{sexprs: &children[1..], bag: self.bag, index: idx as u32}); [INFO] [stderr] 419 | | wrap_visitor_result(res, span, self.bag) [INFO] [stderr] ... | [INFO] [stderr] 424 | | add(self.bag, diagnostic!(span, "expected variant name for {}, found empty list", desc())) [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 416 | if let Sexpr::Terminal(_, ref span) = *first { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:445:12 [INFO] [stderr] | [INFO] [stderr] 445 | if self.sexprs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sexprs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:462:12 [INFO] [stderr] | [INFO] [stderr] 462 | if self.sexprs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sexprs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | / if let &Sexpr::Terminal(_, ref span) = colon { [INFO] [stderr] 476 | | if span.text().as_ref() != ":" { [INFO] [stderr] 477 | | self.bag.add(diagnostic!(span, "expected `:`, found `{}`", span.text())); [INFO] [stderr] 478 | | } [INFO] [stderr] 479 | | } else { [INFO] [stderr] 480 | | self.bag.add(diagnostic!(colon.span(), "expected terminal `:`, found `{:?}`", colon.kind())); [INFO] [stderr] 481 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 475 | if let Sexpr::Terminal(_, ref span) = *colon { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:492:12 [INFO] [stderr] | [INFO] [stderr] 492 | if self.sexprs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sexprs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &Sexpr::List { .. } => SexprKind::List, [INFO] [stderr] 51 | | &Sexpr::UnaryOperator { .. } => SexprKind::UnaryOperator, [INFO] [stderr] 52 | | &Sexpr::String(_, _) => SexprKind::String, [INFO] [stderr] 53 | | &Sexpr::Terminal(_, _) => SexprKind::Terminal, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | Sexpr::List { .. } => SexprKind::List, [INFO] [stderr] 51 | Sexpr::UnaryOperator { .. } => SexprKind::UnaryOperator, [INFO] [stderr] 52 | Sexpr::String(_, _) => SexprKind::String, [INFO] [stderr] 53 | Sexpr::Terminal(_, _) => SexprKind::Terminal, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match self { [INFO] [stderr] 60 | | &Sexpr::List { ref span, .. } => span, [INFO] [stderr] 61 | | &Sexpr::UnaryOperator { ref span, .. } => span, [INFO] [stderr] 62 | | &Sexpr::String(_, ref span) | [INFO] [stderr] 63 | | &Sexpr::Terminal(_, ref span) => span, [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Sexpr::List { ref span, .. } => span, [INFO] [stderr] 61 | Sexpr::UnaryOperator { ref span, .. } => span, [INFO] [stderr] 62 | Sexpr::String(_, ref span) | [INFO] [stderr] 63 | Sexpr::Terminal(_, ref span) => span, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &Sexpr::List { ref closing_token, .. } => closing_token, [INFO] [stderr] 71 | | &Sexpr::UnaryOperator { ref child, .. } => child.last_token(), [INFO] [stderr] 72 | | &Sexpr::String(ref token, _) | [INFO] [stderr] 73 | | &Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | Sexpr::List { ref closing_token, .. } => closing_token, [INFO] [stderr] 71 | Sexpr::UnaryOperator { ref child, .. } => child.last_token(), [INFO] [stderr] 72 | Sexpr::String(ref token, _) | [INFO] [stderr] 73 | Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / match self { [INFO] [stderr] 80 | | &Sexpr::List { ref opening_token, .. } => opening_token, [INFO] [stderr] 81 | | &Sexpr::UnaryOperator { ref op, .. } => op, [INFO] [stderr] 82 | | &Sexpr::String(ref token, _) | [INFO] [stderr] 83 | | &Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | match *self { [INFO] [stderr] 80 | Sexpr::List { ref opening_token, .. } => opening_token, [INFO] [stderr] 81 | Sexpr::UnaryOperator { ref op, .. } => op, [INFO] [stderr] 82 | Sexpr::String(ref token, _) | [INFO] [stderr] 83 | Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / if let &Sexpr::Terminal(_, ref span) = self { [INFO] [stderr] 89 | | if let Ok(parsed) = span.text().as_ref().parse() { [INFO] [stderr] 90 | | Some(parsed) [INFO] [stderr] 91 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 98 | | None [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | if let Sexpr::Terminal(_, ref span) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / if let &Sexpr::Terminal(_, ref span) = self { [INFO] [stderr] 104 | | if let Ok(parsed) = span.text().as_ref().parse() { [INFO] [stderr] 105 | | Some(parsed) [INFO] [stderr] 106 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 113 | | None [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | if let Sexpr::Terminal(_, ref span) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / if let &Sexpr::List { ref children, .. } = self { [INFO] [stderr] 119 | | Some(children) [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | diagnostics.add(diagnostic!(self.span(), "Expected to find a list, but found {:?} instead", self.kind())); [INFO] [stderr] 122 | | None [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 118 | if let Sexpr::List { ref children, .. } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / if let &Sexpr::Terminal(_, ref span) = self { [INFO] [stderr] 128 | | if symbol == span.text().as_ref() { [INFO] [stderr] 129 | | Some(()) [INFO] [stderr] 130 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 136 | | None [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | if let Sexpr::Terminal(_, ref span) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / if let &Sexpr::List { ref children, .. } = self { [INFO] [stderr] 145 | | if children.len() == 0 { [INFO] [stderr] 146 | | diagnostics.add(diagnostic!(self.span(), "Expected a list with symbol `{}` but found an empty list", symbol)); [INFO] [stderr] 147 | | None [INFO] [stderr] ... | [INFO] [stderr] 155 | | None [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | if let Sexpr::List { ref children, .. } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sexpr.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serde_serialization/mod.rs:300:29 [INFO] [stderr] | [INFO] [stderr] 300 | fn deserialize_tuple(mut self, len: usize, visitor: V) -> Result [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serde_serialization/mod.rs:310:36 [INFO] [stderr] | [INFO] [stderr] 310 | fn deserialize_tuple_struct(mut self, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serde_serialization/mod.rs:357:30 [INFO] [stderr] | [INFO] [stderr] 357 | fn deserialize_struct(mut self, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/token.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn to_string(&self, open: bool) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/scopestack.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | let recurse = match self.stack.last_mut().unwrap() { [INFO] [stderr] | _______________________^ [INFO] [stderr] 55 | | &mut ParseStackItem::Global { ref mut children } => { [INFO] [stderr] 56 | | children.push(expr); [INFO] [stderr] 57 | | None [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | let recurse = match *self.stack.last_mut().unwrap() { [INFO] [stderr] 55 | ParseStackItem::Global { ref mut children } => { [INFO] [stderr] 56 | children.push(expr); [INFO] [stderr] 57 | None [INFO] [stderr] 58 | } [INFO] [stderr] 59 | ParseStackItem::ListOpening { ref mut children, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse/scopestack.rs:77:43 [INFO] [stderr] | [INFO] [stderr] 77 | match (self.stack.pop().unwrap(), closed_by.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `closed_by` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse/scopestack.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | chld.last_token().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*chld.last_token()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse/scopestack.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | opening.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `opening` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse/test.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | test_ok("foo".into(), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `"foo"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse/test.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | test_ok("foo bar".into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"foo bar"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse/test.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | test_ok("()".into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `"()"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse/test.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | test_ok("{}".into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `"{}"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parse/test.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | test_ok("[]".into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `"[]"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `diagnostic::diagnostic_bag::DiagnosticBag` [INFO] [stderr] --> src/diagnostic/diagnostic_bag.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> DiagnosticBag { [INFO] [stderr] 21 | | DiagnosticBag { diagnostics: vec![] } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diagnostic/diagnostic_bag.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | / if let &DiagnosticLevel::Custom(_) = &error.error_level { [INFO] [stderr] 88 | | return true; [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | if let DiagnosticLevel::Custom(_) = error.error_level { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diagnostic/diagnostic_bag.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &DiagnosticLevel::Custom(ref c) = &error.error_level { [INFO] [stderr] 99 | | if c == custom { [INFO] [stderr] 100 | | return true; [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 98 | if let DiagnosticLevel::Custom(ref c) = error.error_level { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/diagnostic/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &DiagnosticLevel::Info => "info", [INFO] [stderr] 83 | | &DiagnosticLevel::Warn => "warn", [INFO] [stderr] 84 | | &DiagnosticLevel::Error => "error", [INFO] [stderr] 85 | | &DiagnosticLevel::Custom(ref s) => s, [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | DiagnosticLevel::Info => "info", [INFO] [stderr] 83 | DiagnosticLevel::Warn => "warn", [INFO] [stderr] 84 | DiagnosticLevel::Error => "error", [INFO] [stderr] 85 | DiagnosticLevel::Custom(ref s) => s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/diagnostic/mod.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / if let &Some(ref file) = &builder.global_span.file { [INFO] [stderr] 147 | | writeln!(f, [INFO] [stderr] 148 | | " --> {}:{}:{}", [INFO] [stderr] 149 | | file, [INFO] [stderr] ... | [INFO] [stderr] 156 | | builder.global_span.columns.start)?; [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(ref file) = builder.global_span.file { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/diagnostic/mod.rs:198:1 [INFO] [stderr] | [INFO] [stderr] 198 | / fn get_span<'a>(ann: &'a DiagnosticAnnotation) -> &'a Span { [INFO] [stderr] 199 | | &ann.span [INFO] [stderr] 200 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diagnostic/mod.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | r = r + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `r += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/serde_serialization/test.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / match sexpr { [INFO] [stderr] 11 | | &Sexpr::List{ref children, ..} => { [INFO] [stderr] 12 | | for child in children { [INFO] [stderr] 13 | | visit_sexpr(child); [INFO] [stderr] ... | [INFO] [stderr] 16 | | _ => {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let &Sexpr::List{ref children, ..} = sexpr { [INFO] [stderr] 11 | for child in children { [INFO] [stderr] 12 | visit_sexpr(child); [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/test.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / match sexpr { [INFO] [stderr] 11 | | &Sexpr::List{ref children, ..} => { [INFO] [stderr] 12 | | for child in children { [INFO] [stderr] 13 | | visit_sexpr(child); [INFO] [stderr] ... | [INFO] [stderr] 16 | | _ => {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *sexpr { [INFO] [stderr] 11 | Sexpr::List{ref children, ..} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match self { [INFO] [stderr] 129 | | &DeserError::Custom{ref message} => message, [INFO] [stderr] 130 | | &DeserError::DiagnosticAdded => "diagnostic added", [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 128 | match *self { [INFO] [stderr] 129 | DeserError::Custom{ref message} => message, [INFO] [stderr] 130 | DeserError::DiagnosticAdded => "diagnostic added", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match self { [INFO] [stderr] 138 | | &DeserError::Custom{ref message} => write!(formatter, "{}", message), [INFO] [stderr] 139 | | &DeserError::DiagnosticAdded => write!(formatter, "Diagnostic Added"), [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 137 | match *self { [INFO] [stderr] 138 | DeserError::Custom{ref message} => write!(formatter, "{}", message), [INFO] [stderr] 139 | DeserError::DiagnosticAdded => write!(formatter, "Diagnostic Added"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 191 | deserialize_value!(self, visitor, visit_bool, bool, str::parse, "boolean value") [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 195 | deserialize_value!(self, visitor, visit_u8, u8, str::parse, "unsigned integer (u8)") [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 199 | deserialize_value!(self, visitor, visit_u16, u16, str::parse, "unsigned integer (u16)") [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 203 | deserialize_value!(self, visitor, visit_u32, u32, str::parse, "unsigned integer (u32)") [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 207 | deserialize_value!(self, visitor, visit_u64, u64, str::parse, "unsigned integer (u64)") [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 211 | deserialize_value!(self, visitor, visit_i8, i8, str::parse, "signed integer (i8)") [INFO] [stderr] | ---------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 215 | deserialize_value!(self, visitor, visit_i16, i16, str::parse, "signed integer (i16)") [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 219 | deserialize_value!(self, visitor, visit_i32, i32, str::parse, "signed integer (i32)") [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 223 | deserialize_value!(self, visitor, visit_i64, i64, str::parse, "signed integer (i64)") [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 227 | deserialize_value!(self, visitor, visit_f32, f32, str::parse, "floating point number (f32)") [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 231 | deserialize_value!(self, visitor, visit_f64, f64, str::parse, "floating point number (f64)") [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | / if let &Sexpr::Terminal(_, ref span) = self.sexpr { [INFO] [stderr] 248 | | if span.text().as_ref() == "nil" { [INFO] [stderr] 249 | | wrap_visitor_result(visitor.visit_none(), self.sexpr.span(), self.bag) [INFO] [stderr] 250 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 256 | | wrap_visitor_result(r, &self.sexpr.span(), self.bag) [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 247 | if let Sexpr::Terminal(_, ref span) = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 262 | | if children.len() == 0 { [INFO] [stderr] 263 | | wrap_visitor_result(visitor.visit_unit(), self.sexpr.span(), self.bag) [INFO] [stderr] 264 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 270 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 271 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 261 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 293 | | wrap_visitor_result(visitor.visit_seq(SeqDeserializer{sexprs: children, bag: self.bag}), &self.sexpr.span(), self.bag) [INFO] [stderr] 294 | | } else { [INFO] [stderr] 295 | | self.bag.add(diagnostic!(self.sexpr.span(), "expected list, found {:?}", self.sexpr.kind())); [INFO] [stderr] 296 | | return Err(DeserError::DiagnosticAdded); [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 292 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 304 | | wrap_visitor_result(visitor.visit_seq(SeqDeserializer{sexprs: children, bag: self.bag}), &self.sexpr.span(), self.bag) [INFO] [stderr] 305 | | } else { [INFO] [stderr] 306 | | self.bag.add(diagnostic!(self.sexpr.span(), "expected list, found {:?}", self.sexpr.kind())); [INFO] [stderr] 307 | | return Err(DeserError::DiagnosticAdded); [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 319 | | if children.len() == 0 { [INFO] [stderr] 320 | | self.bag.add(diagnostics::nothing_found(span, struct_descr())); [INFO] [stderr] 321 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] ... | [INFO] [stderr] 341 | | return Err(DeserError::DiagnosticAdded); [INFO] [stderr] 342 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 318 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:323:17 [INFO] [stderr] | [INFO] [stderr] 323 | / if let &Sexpr::Terminal(_, ref span) = &children[0] { [INFO] [stderr] 324 | | if span.text().as_ref() != name { [INFO] [stderr] 325 | | self.bag.add(diagnostic!(span, "expected tuple struct name `{}`, but found `{}`", name, span.text())); [INFO] [stderr] 326 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] ... | [INFO] [stderr] 336 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 323 | if let Sexpr::Terminal(_, ref span) = children[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 347 | | let vr = { [INFO] [stderr] 348 | | let map_deser = SeqDeserializer{sexprs: children, bag: self.bag}; [INFO] [stderr] 349 | | visitor.visit_map(map_deser) [INFO] [stderr] ... | [INFO] [stderr] 354 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 346 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 366 | | if children.len() == 0 { [INFO] [stderr] 367 | | self.bag.add(diagnostics::nothing_found(span, struct_descr())); [INFO] [stderr] 368 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] ... | [INFO] [stderr] 393 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 394 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 365 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:366:16 [INFO] [stderr] | [INFO] [stderr] 366 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | / if let &Sexpr::Terminal(_, ref span) = first_child { [INFO] [stderr] 373 | | if span.text().as_ref() == name { [INFO] [stderr] 374 | | wrap_visitor_result(visitor.visit_map( [INFO] [stderr] 375 | | SeqDeserializer{sexprs: &children[1..], bag: self.bag}), &rest_span, self.bag) [INFO] [stderr] ... | [INFO] [stderr] 388 | | Err(DeserError::DiagnosticAdded) [INFO] [stderr] 389 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 372 | if let Sexpr::Terminal(_, ref span) = *first_child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / if let &Sexpr::Terminal(_, ref span) = $this.sexpr { [INFO] [stderr] 164 | | let text = span.text(); [INFO] [stderr] 165 | | let text2 = text.as_ref(); [INFO] [stderr] 166 | | let x: Result<$typ, _> = $parser(text2); [INFO] [stderr] ... | [INFO] [stderr] 176 | | wrap_visitor_result($visitor.$func(Default::default()), $this.sexpr.span(), &mut $this.bag) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 400 | deserialize_value!(self, visitor, visit_str, &str, id, "identifier") [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:411:9 [INFO] [stderr] | [INFO] [stderr] 411 | / if let &Sexpr::List{ref children, ref span, ..} = self.sexpr { [INFO] [stderr] 412 | | if children.len() == 0 { [INFO] [stderr] 413 | | add(self.bag, diagnostic!(span, "expected {}, found empty list", desc())) [INFO] [stderr] 414 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 428 | | add(self.bag, diagnostic!(self.sexpr.span(), "expected {}, found {:?}", desc(), self.sexpr.kind())) [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 411 | if let Sexpr::List{ref children, ref span, ..} = *self.sexpr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:412:16 [INFO] [stderr] | [INFO] [stderr] 412 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | / if let &Sexpr::Terminal(_, ref span) = first { [INFO] [stderr] 417 | | if let Some(idx) = variants.iter().position(|&c| c == span.text().as_ref()) { [INFO] [stderr] 418 | | let res = visitor.visit_enum(EnumDeserializer{sexprs: &children[1..], bag: self.bag, index: idx as u32}); [INFO] [stderr] 419 | | wrap_visitor_result(res, span, self.bag) [INFO] [stderr] ... | [INFO] [stderr] 424 | | add(self.bag, diagnostic!(span, "expected variant name for {}, found empty list", desc())) [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 416 | if let Sexpr::Terminal(_, ref span) = *first { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:445:12 [INFO] [stderr] | [INFO] [stderr] 445 | if self.sexprs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sexprs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:462:12 [INFO] [stderr] | [INFO] [stderr] 462 | if self.sexprs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sexprs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_serialization/mod.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | / if let &Sexpr::Terminal(_, ref span) = colon { [INFO] [stderr] 476 | | if span.text().as_ref() != ":" { [INFO] [stderr] 477 | | self.bag.add(diagnostic!(span, "expected `:`, found `{}`", span.text())); [INFO] [stderr] 478 | | } [INFO] [stderr] 479 | | } else { [INFO] [stderr] 480 | | self.bag.add(diagnostic!(colon.span(), "expected terminal `:`, found `{:?}`", colon.kind())); [INFO] [stderr] 481 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 475 | if let Sexpr::Terminal(_, ref span) = *colon { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/serde_serialization/mod.rs:492:12 [INFO] [stderr] | [INFO] [stderr] 492 | if self.sexprs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sexprs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &Sexpr::List { .. } => SexprKind::List, [INFO] [stderr] 51 | | &Sexpr::UnaryOperator { .. } => SexprKind::UnaryOperator, [INFO] [stderr] 52 | | &Sexpr::String(_, _) => SexprKind::String, [INFO] [stderr] 53 | | &Sexpr::Terminal(_, _) => SexprKind::Terminal, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | Sexpr::List { .. } => SexprKind::List, [INFO] [stderr] 51 | Sexpr::UnaryOperator { .. } => SexprKind::UnaryOperator, [INFO] [stderr] 52 | Sexpr::String(_, _) => SexprKind::String, [INFO] [stderr] 53 | Sexpr::Terminal(_, _) => SexprKind::Terminal, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match self { [INFO] [stderr] 60 | | &Sexpr::List { ref span, .. } => span, [INFO] [stderr] 61 | | &Sexpr::UnaryOperator { ref span, .. } => span, [INFO] [stderr] 62 | | &Sexpr::String(_, ref span) | [INFO] [stderr] 63 | | &Sexpr::Terminal(_, ref span) => span, [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Sexpr::List { ref span, .. } => span, [INFO] [stderr] 61 | Sexpr::UnaryOperator { ref span, .. } => span, [INFO] [stderr] 62 | Sexpr::String(_, ref span) | [INFO] [stderr] 63 | Sexpr::Terminal(_, ref span) => span, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &Sexpr::List { ref closing_token, .. } => closing_token, [INFO] [stderr] 71 | | &Sexpr::UnaryOperator { ref child, .. } => child.last_token(), [INFO] [stderr] 72 | | &Sexpr::String(ref token, _) | [INFO] [stderr] 73 | | &Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | Sexpr::List { ref closing_token, .. } => closing_token, [INFO] [stderr] 71 | Sexpr::UnaryOperator { ref child, .. } => child.last_token(), [INFO] [stderr] 72 | Sexpr::String(ref token, _) | [INFO] [stderr] 73 | Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / match self { [INFO] [stderr] 80 | | &Sexpr::List { ref opening_token, .. } => opening_token, [INFO] [stderr] 81 | | &Sexpr::UnaryOperator { ref op, .. } => op, [INFO] [stderr] 82 | | &Sexpr::String(ref token, _) | [INFO] [stderr] 83 | | &Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | match *self { [INFO] [stderr] 80 | Sexpr::List { ref opening_token, .. } => opening_token, [INFO] [stderr] 81 | Sexpr::UnaryOperator { ref op, .. } => op, [INFO] [stderr] 82 | Sexpr::String(ref token, _) | [INFO] [stderr] 83 | Sexpr::Terminal(ref token, _) => token, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / if let &Sexpr::Terminal(_, ref span) = self { [INFO] [stderr] 89 | | if let Ok(parsed) = span.text().as_ref().parse() { [INFO] [stderr] 90 | | Some(parsed) [INFO] [stderr] 91 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 98 | | None [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | if let Sexpr::Terminal(_, ref span) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / if let &Sexpr::Terminal(_, ref span) = self { [INFO] [stderr] 104 | | if let Ok(parsed) = span.text().as_ref().parse() { [INFO] [stderr] 105 | | Some(parsed) [INFO] [stderr] 106 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 113 | | None [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | if let Sexpr::Terminal(_, ref span) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / if let &Sexpr::List { ref children, .. } = self { [INFO] [stderr] 119 | | Some(children) [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | diagnostics.add(diagnostic!(self.span(), "Expected to find a list, but found {:?} instead", self.kind())); [INFO] [stderr] 122 | | None [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 118 | if let Sexpr::List { ref children, .. } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / if let &Sexpr::Terminal(_, ref span) = self { [INFO] [stderr] 128 | | if symbol == span.text().as_ref() { [INFO] [stderr] 129 | | Some(()) [INFO] [stderr] 130 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 136 | | None [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | if let Sexpr::Terminal(_, ref span) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sexpr.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / if let &Sexpr::List { ref children, .. } = self { [INFO] [stderr] 145 | | if children.len() == 0 { [INFO] [stderr] 146 | | diagnostics.add(diagnostic!(self.span(), "Expected a list with symbol `{}` but found an empty list", symbol)); [INFO] [stderr] 147 | | None [INFO] [stderr] ... | [INFO] [stderr] 155 | | None [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | if let Sexpr::List { ref children, .. } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sexpr.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/errors.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const PROGRAM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/parsing.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const PROGRAM: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.45s [INFO] running `"docker" "inspect" "ba3af33c32e9aa32403fcd78b09aa2dd38afe03c516a805e4852a9d53b15176c"` [INFO] running `"docker" "rm" "-f" "ba3af33c32e9aa32403fcd78b09aa2dd38afe03c516a805e4852a9d53b15176c"` [INFO] [stdout] ba3af33c32e9aa32403fcd78b09aa2dd38afe03c516a805e4852a9d53b15176c