[INFO] crate snmp-parser 0.2.0 is already in cache
[INFO] extracting crate snmp-parser 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/snmp-parser/0.2.0
[INFO] extracting crate snmp-parser 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snmp-parser/0.2.0
[INFO] validating manifest of snmp-parser-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of snmp-parser-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing snmp-parser-0.2.0
[INFO] finished frobbing snmp-parser-0.2.0
[INFO] frobbed toml for snmp-parser-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/snmp-parser/0.2.0/Cargo.toml
[INFO] started frobbing snmp-parser-0.2.0
[INFO] finished frobbing snmp-parser-0.2.0
[INFO] frobbed toml for snmp-parser-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snmp-parser/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting snmp-parser-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/snmp-parser/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5483dc39d87e379770e38475c9045c56fe3d37e6d86d6413b7bf3676a2bad3e1
[INFO] running `"docker" "start" "-a" "5483dc39d87e379770e38475c9045c56fe3d37e6d86d6413b7bf3676a2bad3e1"`
[INFO] [stderr]     Checking nom v4.1.1
[INFO] [stderr]     Checking rusticata-macros v1.1.0
[INFO] [stderr]     Checking der-parser v1.1.1
[INFO] [stderr]     Checking snmp-parser v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> tests/v3.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 data: data,
[INFO] [stderr]    |                 ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/v3.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |         req_id: 2098071598,
[INFO] [stderr]    |                 ^^^^^^^^^^ help: consider: `2_098_071_598`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/v3.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 |             msg_id: 821490644,
[INFO] [stderr]    |                     ^^^^^^^^^ help: consider: `821_490_644`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> tests/v1.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     match &res {
[INFO] [stderr] 34 | |         &Ok((_,ref r)) => {
[INFO] [stderr] 35 | |             // debug!("r: {:?}",r);
[INFO] [stderr] 36 | |             eprintln!("SNMP: v={}, c={:?}, pdu_type={:?}",r.version,r.community,r.pdu_type());
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |         _ => (),
[INFO] [stderr] 43 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 33 |     if let &Ok((_,ref r)) = &res {
[INFO] [stderr] 34 |     // debug!("r: {:?}",r);
[INFO] [stderr] 35 |     eprintln!("SNMP: v={}, c={:?}, pdu_type={:?}",r.version,r.community,r.pdu_type());
[INFO] [stderr] 36 |     // debug!("PDU: type={}, {:?}", pdu_type, pdu_res);
[INFO] [stderr] 37 |     for ref v in r.vars_iter() {
[INFO] [stderr] 38 |         eprintln!("v: {:?}",v);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> tests/v1.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     match &res {
[INFO] [stderr] 34 | |         &Ok((_,ref r)) => {
[INFO] [stderr] 35 | |             // debug!("r: {:?}",r);
[INFO] [stderr] 36 | |             eprintln!("SNMP: v={}, c={:?}, pdu_type={:?}",r.version,r.community,r.pdu_type());
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |         _ => (),
[INFO] [stderr] 43 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 33 |     match res {
[INFO] [stderr] 34 |         Ok((_,ref r)) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> tests/v1.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 |             for ref v in r.vars_iter() {
[INFO] [stderr]    |                 ^^^^^    ------------- help: try: `let v = &r.vars_iter();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.00s
[INFO] running `"docker" "inspect" "5483dc39d87e379770e38475c9045c56fe3d37e6d86d6413b7bf3676a2bad3e1"`
[INFO] running `"docker" "rm" "-f" "5483dc39d87e379770e38475c9045c56fe3d37e6d86d6413b7bf3676a2bad3e1"`
[INFO] [stdout] 5483dc39d87e379770e38475c9045c56fe3d37e6d86d6413b7bf3676a2bad3e1