[INFO] crate snapshot 0.1.0 is already in cache [INFO] extracting crate snapshot 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/snapshot/0.1.0 [INFO] extracting crate snapshot 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snapshot/0.1.0 [INFO] validating manifest of snapshot-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of snapshot-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing snapshot-0.1.0 [INFO] finished frobbing snapshot-0.1.0 [INFO] frobbed toml for snapshot-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/snapshot/0.1.0/Cargo.toml [INFO] started frobbing snapshot-0.1.0 [INFO] finished frobbing snapshot-0.1.0 [INFO] frobbed toml for snapshot-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/snapshot/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting snapshot-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/snapshot/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 722cb24082905da22e94100af684577ce693e998997bea734316a0f6588b5e4d [INFO] running `"docker" "start" "-a" "722cb24082905da22e94100af684577ce693e998997bea734316a0f6588b5e4d"` [INFO] [stderr] Checking pretty_assertions v0.2.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling snapshot-proc-macro v0.1.0 [INFO] [stderr] Checking snapshot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:218:33 [INFO] [stderr] | [INFO] [stderr] 218 | let mut relative_path = PathBuf::from(dir.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `dir.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:218:33 [INFO] [stderr] | [INFO] [stderr] 218 | let mut relative_path = PathBuf::from(dir.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `dir.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/simple.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/simple.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let x = 1; [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> tests/simple.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | #[snapshot] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> tests/simple.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | #[snapshot] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/second.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/second.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | let x = 2; [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> tests/second.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | #[snapshot] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.21s [INFO] running `"docker" "inspect" "722cb24082905da22e94100af684577ce693e998997bea734316a0f6588b5e4d"` [INFO] running `"docker" "rm" "-f" "722cb24082905da22e94100af684577ce693e998997bea734316a0f6588b5e4d"` [INFO] [stdout] 722cb24082905da22e94100af684577ce693e998997bea734316a0f6588b5e4d