[INFO] crate smtp2go 0.1.4 is already in cache [INFO] extracting crate smtp2go 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/smtp2go/0.1.4 [INFO] extracting crate smtp2go 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smtp2go/0.1.4 [INFO] validating manifest of smtp2go-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smtp2go-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smtp2go-0.1.4 [INFO] finished frobbing smtp2go-0.1.4 [INFO] frobbed toml for smtp2go-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/smtp2go/0.1.4/Cargo.toml [INFO] started frobbing smtp2go-0.1.4 [INFO] finished frobbing smtp2go-0.1.4 [INFO] frobbed toml for smtp2go-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smtp2go/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smtp2go-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/smtp2go/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4d42796c13d1ab642952f08ad23df3418bf285e6e0a751b4d57b1b2909482f2 [INFO] running `"docker" "start" "-a" "a4d42796c13d1ab642952f08ad23df3418bf285e6e0a751b4d57b1b2909482f2"` [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking smtp2go v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/core.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | headers.set(XSmtp2goApiKey(String::from(api_key)).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn from<'a, T: Into>(&'a mut self, from: T) -> &'a mut Email { [INFO] [stderr] 35 | | self.from = from.into(); [INFO] [stderr] 36 | | self [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn subject<'a, T: Into>(&'a mut self, subject: T) -> &'a mut Email { [INFO] [stderr] 45 | | self.subject = subject.into(); [INFO] [stderr] 46 | | self [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn text_body<'a, T: Into>(&'a mut self, body: T) -> &'a mut Email { [INFO] [stderr] 50 | | self.text_body = body.into(); [INFO] [stderr] 51 | | self [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn html_body<'a, T: Into>(&'a mut self, body: T) -> &'a mut Email { [INFO] [stderr] 55 | | self.html_body = body.into(); [INFO] [stderr] 56 | | self [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/core.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | headers.set(XSmtp2goApiKey(String::from(api_key)).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn from<'a, T: Into>(&'a mut self, from: T) -> &'a mut Email { [INFO] [stderr] 35 | | self.from = from.into(); [INFO] [stderr] 36 | | self [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn subject<'a, T: Into>(&'a mut self, subject: T) -> &'a mut Email { [INFO] [stderr] 45 | | self.subject = subject.into(); [INFO] [stderr] 46 | | self [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn text_body<'a, T: Into>(&'a mut self, body: T) -> &'a mut Email { [INFO] [stderr] 50 | | self.text_body = body.into(); [INFO] [stderr] 51 | | self [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/email.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn html_body<'a, T: Into>(&'a mut self, body: T) -> &'a mut Email { [INFO] [stderr] 55 | | self.html_body = body.into(); [INFO] [stderr] 56 | | self [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match smtp2go::Email::new().send() { [INFO] [stderr] 28 | | Ok(_) => panic!("Send didn't fail on missing 'from' field"), [INFO] [stderr] 29 | | Err(_) => (), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = smtp2go::Email::new().send() { panic!("Send didn't fail on missing 'from' field") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / match smtp2go::Email::new() [INFO] [stderr] 38 | | .from("Matt ") [INFO] [stderr] 39 | | .send() { [INFO] [stderr] 40 | | Ok(_) => panic!("Send didn't fail on missing 'to' field"), [INFO] [stderr] 41 | | Err(_) => (), [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Ok(_) = smtp2go::Email::new() [INFO] [stderr] 38 | .from("Matt ") [INFO] [stderr] 39 | .send() { panic!("Send didn't fail on missing 'to' field") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / match smtp2go::Email::new() [INFO] [stderr] 50 | | .from("Matt ") [INFO] [stderr] 51 | | .to(&["Data ".to_string()]) [INFO] [stderr] 52 | | .send() { [INFO] [stderr] 53 | | Ok(_) => panic!("Send didn't fail on missing 'subject' field"), [INFO] [stderr] 54 | | Err(_) => (), [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Ok(_) = smtp2go::Email::new() [INFO] [stderr] 50 | .from("Matt ") [INFO] [stderr] 51 | .to(&["Data ".to_string()]) [INFO] [stderr] 52 | .send() { panic!("Send didn't fail on missing 'subject' field") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match smtp2go::Email::new() [INFO] [stderr] 63 | | .from("Matt ") [INFO] [stderr] 64 | | .to(&["Dave ".to_string()]) [INFO] [stderr] 65 | | .subject("test subject") [INFO] [stderr] ... | [INFO] [stderr] 68 | | Err(_) => (), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(_) = smtp2go::Email::new() [INFO] [stderr] 63 | .from("Matt ") [INFO] [stderr] 64 | .to(&["Dave ".to_string()]) [INFO] [stderr] 65 | .subject("test subject") [INFO] [stderr] 66 | .send() { panic!("Send didn't fail on missing 'text_body' field") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / match send_test_email() { [INFO] [stderr] 80 | | Ok(_) => panic!("Send didn't fail on missing api root"), [INFO] [stderr] 81 | | Err(_) => (), [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = send_test_email() { panic!("Send didn't fail on missing api root") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / match send_test_email() { [INFO] [stderr] 93 | | Ok(_) => panic!("Send didn't fail on missing ApiKey"), [INFO] [stderr] 94 | | Err(_) => (), [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = send_test_email() { panic!("Send didn't fail on missing ApiKey") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/email.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / match send_test_email() { [INFO] [stderr] 106 | | Ok(_) => panic!("Send didn't fail on incorrect ApiKey"), [INFO] [stderr] 107 | | Err(_) => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = send_test_email() { panic!("Send didn't fail on incorrect ApiKey") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.84s [INFO] running `"docker" "inspect" "a4d42796c13d1ab642952f08ad23df3418bf285e6e0a751b4d57b1b2909482f2"` [INFO] running `"docker" "rm" "-f" "a4d42796c13d1ab642952f08ad23df3418bf285e6e0a751b4d57b1b2909482f2"` [INFO] [stdout] a4d42796c13d1ab642952f08ad23df3418bf285e6e0a751b4d57b1b2909482f2