[INFO] crate smetamath 3.0.0 is already in cache
[INFO] extracting crate smetamath 3.0.0 into work/ex/clippy-test-run/sources/stable/reg/smetamath/3.0.0
[INFO] extracting crate smetamath 3.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smetamath/3.0.0
[INFO] validating manifest of smetamath-3.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of smetamath-3.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing smetamath-3.0.0
[INFO] finished frobbing smetamath-3.0.0
[INFO] frobbed toml for smetamath-3.0.0 written to work/ex/clippy-test-run/sources/stable/reg/smetamath/3.0.0/Cargo.toml
[INFO] started frobbing smetamath-3.0.0
[INFO] finished frobbing smetamath-3.0.0
[INFO] frobbed toml for smetamath-3.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smetamath/3.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting smetamath-3.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/smetamath/3.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c886de70d9b2a3194313b8e3dd084357ef57be6f3d3ebd830d623c6de22c4bfa
[INFO] running `"docker" "start" "-a" "c886de70d9b2a3194313b8e3dd084357ef57be6f3d3ebd830d623c6de22c4bfa"`
[INFO] [stderr]    Compiling libc v0.2.48
[INFO] [stderr]     Checking unicode-width v0.1.5
[INFO] [stderr]     Checking cfg-if v0.1.6
[INFO] [stderr]     Checking strsim v0.7.0
[INFO] [stderr]     Checking vec_map v0.8.1
[INFO] [stderr]     Checking bitflags v1.0.4
[INFO] [stderr]     Checking ansi_term v0.11.0
[INFO] [stderr]     Checking fnv v1.0.6
[INFO] [stderr]     Checking textwrap v0.10.0
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking filetime v0.1.15
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking smetamath v3.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             concurrency: concurrency,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `concurrency`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             mutex: mutex,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `mutex`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/database.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 |             options: options,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `options`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             span: span,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 |         notes: notes,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `notes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         sset: sset,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `sset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         stmt: stmt,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `stmt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:209:17
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 id: id,
[INFO] [stderr]     |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:303:13
[INFO] [stderr]     |
[INFO] [stderr] 303 |             nameset: nameset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `nameset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:354:25
[INFO] [stderr]     |
[INFO] [stderr] 354 |                         stype: stype,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `stype`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             start: start,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             end: end,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:152:13
[INFO] [stderr]     |
[INFO] [stderr] 152 |             segment_id: segment_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:267:13
[INFO] [stderr]     |
[INFO] [stderr] 267 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:425:17
[INFO] [stderr]     |
[INFO] [stderr] 425 |                 index: index,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:622:13
[INFO] [stderr]     |
[INFO] [stderr] 622 |             stype: stype,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `stype`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:623:13
[INFO] [stderr]     |
[INFO] [stderr] 623 |             label: label,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:983:40
[INFO] [stderr]     |
[INFO] [stderr] 983 |             seg.labels.push(LabelDef { index: index });
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:991:25
[INFO] [stderr]     |
[INFO] [stderr] 991 |                         index: index,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scopeck.rs:293:13
[INFO] [stderr]     |
[INFO] [stderr] 293 |             typecode: typecode,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `typecode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scopeck.rs:445:9
[INFO] [stderr]     |
[INFO] [stderr] 445 |         label_atom: label_atom,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `label_atom`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scopeck.rs:531:9
[INFO] [stderr]     |
[INFO] [stderr] 531 |         vars: vars,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `vars`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/verify.rs:222:17
[INFO] [stderr]     |
[INFO] [stderr] 222 |                 code: code,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `code`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/verify.rs:488:9
[INFO] [stderr]     |
[INFO] [stderr] 488 |         diagnostics: diagnostics,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diagnostics`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 |             concurrency: concurrency,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `concurrency`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             mutex: mutex,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `mutex`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/database.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 |             options: options,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `options`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             span: span,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `span`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 |         notes: notes,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `notes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         sset: sset,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `sset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/diag.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         stmt: stmt,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `stmt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:209:17
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 id: id,
[INFO] [stderr]     |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:303:13
[INFO] [stderr]     |
[INFO] [stderr] 303 |             nameset: nameset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `nameset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/nameck.rs:354:25
[INFO] [stderr]     |
[INFO] [stderr] 354 |                         stype: stype,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `stype`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             start: start,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             end: end,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:152:13
[INFO] [stderr]     |
[INFO] [stderr] 152 |             segment_id: segment_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:267:13
[INFO] [stderr]     |
[INFO] [stderr] 267 |             index: index,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:425:17
[INFO] [stderr]     |
[INFO] [stderr] 425 |                 index: index,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:622:13
[INFO] [stderr]     |
[INFO] [stderr] 622 |             stype: stype,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `stype`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:623:13
[INFO] [stderr]     |
[INFO] [stderr] 623 |             label: label,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:983:40
[INFO] [stderr]     |
[INFO] [stderr] 983 |             seg.labels.push(LabelDef { index: index });
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:991:25
[INFO] [stderr]     |
[INFO] [stderr] 991 |                         index: index,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scopeck.rs:293:13
[INFO] [stderr]     |
[INFO] [stderr] 293 |             typecode: typecode,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `typecode`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scopeck.rs:445:9
[INFO] [stderr]     |
[INFO] [stderr] 445 |         label_atom: label_atom,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `label_atom`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scopeck.rs:531:9
[INFO] [stderr]     |
[INFO] [stderr] 531 |         vars: vars,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `vars`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/verify.rs:222:17
[INFO] [stderr]     |
[INFO] [stderr] 222 |                 code: code,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `code`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/verify.rs:488:9
[INFO] [stderr]     |
[INFO] [stderr] 488 |         diagnostics: diagnostics,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diagnostics`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nameck.rs:455:9
[INFO] [stderr]     |
[INFO] [stderr] 455 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:516:13
[INFO] [stderr]     |
[INFO] [stderr] 516 |             return slf.get_raw();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slf.get_raw()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/parser.rs:576:24
[INFO] [stderr]     |
[INFO] [stderr] 576 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 577 | |                     if tok_ref == b"$j" {
[INFO] [stderr] 578 | |                         ctype = CommentType::Extra;
[INFO] [stderr] 579 | |                     } else {
[INFO] [stderr] 580 | |                         ctype = CommentType::Typesetting;
[INFO] [stderr] 581 | |                     }
[INFO] [stderr] 582 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 576 |                 } else if tok_ref == b"$j" {
[INFO] [stderr] 577 |     ctype = CommentType::Extra;
[INFO] [stderr] 578 | } else {
[INFO] [stderr] 579 |     ctype = CommentType::Typesetting;
[INFO] [stderr] 580 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:738:9
[INFO] [stderr]     |
[INFO] [stderr] 738 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:809:9
[INFO] [stderr]     |
[INFO] [stderr] 809 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scopeck.rs:190:5
[INFO] [stderr]     |
[INFO] [stderr] 190 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scopeck.rs:922:9
[INFO] [stderr]     |
[INFO] [stderr] 922 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/util.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/util.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 |             if word == 0x2a232a23 || word == 0x232a232a {
[INFO] [stderr]     |                        ^^^^^^^^^^ help: consider: `0x2a23_2a23`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/util.rs:103:46
[INFO] [stderr]     |
[INFO] [stderr] 103 |             if word == 0x2a232a23 || word == 0x232a232a {
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0x232a_232a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 |     return Some(Diagnostic::StepMissing(copy_token(label)));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Diagnostic::StepMissing(copy_token(label)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:148:5
[INFO] [stderr]     |
[INFO] [stderr] 148 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/verify.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     if valid.end != NO_STATEMENT {
[INFO] [stderr] 127 | |         if pos.segment_id != valid.start.segment_id || pos.index >= valid.end {
[INFO] [stderr] 128 | |             return Some(Diagnostic::StepUsedAfterScope(copy_token(label)));
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 126 |     if valid.end != NO_STATEMENT && (pos.segment_id != valid.start.segment_id || pos.index >= valid.end) {
[INFO] [stderr] 127 |     return Some(Diagnostic::StepUsedAfterScope(copy_token(label)));
[INFO] [stderr] 128 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 |     return compare.is_empty();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `compare.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:294:5
[INFO] [stderr]     |
[INFO] [stderr] 294 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/verify.rs:258:16
[INFO] [stderr]     |
[INFO] [stderr] 258 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 259 | |             if !do_substitute_eq(&state.stack_buffer[slot.expr.clone()],
[INFO] [stderr] 260 | |                                  fref,
[INFO] [stderr] 261 | |                                  &hyp.expr,
[INFO] [stderr] ...   |
[INFO] [stderr] 265 | |             }
[INFO] [stderr] 266 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 258 |         } else if !do_substitute_eq(&state.stack_buffer[slot.expr.clone()],
[INFO] [stderr] 259 |                      fref,
[INFO] [stderr] 260 |                      &hyp.expr,
[INFO] [stderr] 261 |                      &state.subst_info,
[INFO] [stderr] 262 |                      &state.stack_buffer) {
[INFO] [stderr] 263 |     return Some(Diagnostic::StepEssenWrong);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:433:5
[INFO] [stderr]     |
[INFO] [stderr] 433 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nameck.rs:455:9
[INFO] [stderr]     |
[INFO] [stderr] 455 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:516:13
[INFO] [stderr]     |
[INFO] [stderr] 516 |             return slf.get_raw();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slf.get_raw()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/parser.rs:576:24
[INFO] [stderr]     |
[INFO] [stderr] 576 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 577 | |                     if tok_ref == b"$j" {
[INFO] [stderr] 578 | |                         ctype = CommentType::Extra;
[INFO] [stderr] 579 | |                     } else {
[INFO] [stderr] 580 | |                         ctype = CommentType::Typesetting;
[INFO] [stderr] 581 | |                     }
[INFO] [stderr] 582 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 576 |                 } else if tok_ref == b"$j" {
[INFO] [stderr] 577 |     ctype = CommentType::Extra;
[INFO] [stderr] 578 | } else {
[INFO] [stderr] 579 |     ctype = CommentType::Typesetting;
[INFO] [stderr] 580 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:738:9
[INFO] [stderr]     |
[INFO] [stderr] 738 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:809:9
[INFO] [stderr]     |
[INFO] [stderr] 809 |         return res;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scopeck.rs:190:5
[INFO] [stderr]     |
[INFO] [stderr] 190 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scopeck.rs:922:9
[INFO] [stderr]     |
[INFO] [stderr] 922 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/util.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/util.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 |             if word == 0x2a232a23 || word == 0x232a232a {
[INFO] [stderr]     |                        ^^^^^^^^^^ help: consider: `0x2a23_2a23`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/util.rs:103:46
[INFO] [stderr]     |
[INFO] [stderr] 103 |             if word == 0x2a232a23 || word == 0x232a232a {
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0x232a_232a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 |     return Some(Diagnostic::StepMissing(copy_token(label)));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Diagnostic::StepMissing(copy_token(label)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:148:5
[INFO] [stderr]     |
[INFO] [stderr] 148 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/verify.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     if valid.end != NO_STATEMENT {
[INFO] [stderr] 127 | |         if pos.segment_id != valid.start.segment_id || pos.index >= valid.end {
[INFO] [stderr] 128 | |             return Some(Diagnostic::StepUsedAfterScope(copy_token(label)));
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 126 |     if valid.end != NO_STATEMENT && (pos.segment_id != valid.start.segment_id || pos.index >= valid.end) {
[INFO] [stderr] 127 |     return Some(Diagnostic::StepUsedAfterScope(copy_token(label)));
[INFO] [stderr] 128 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 |     return compare.is_empty();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `compare.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:294:5
[INFO] [stderr]     |
[INFO] [stderr] 294 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/verify.rs:258:16
[INFO] [stderr]     |
[INFO] [stderr] 258 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 259 | |             if !do_substitute_eq(&state.stack_buffer[slot.expr.clone()],
[INFO] [stderr] 260 | |                                  fref,
[INFO] [stderr] 261 | |                                  &hyp.expr,
[INFO] [stderr] ...   |
[INFO] [stderr] 265 | |             }
[INFO] [stderr] 266 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 258 |         } else if !do_substitute_eq(&state.stack_buffer[slot.expr.clone()],
[INFO] [stderr] 259 |                      fref,
[INFO] [stderr] 260 |                      &hyp.expr,
[INFO] [stderr] 261 |                      &state.subst_info,
[INFO] [stderr] 262 |                      &state.stack_buffer) {
[INFO] [stderr] 263 |     return Some(Diagnostic::StepEssenWrong);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/verify.rs:433:5
[INFO] [stderr]     |
[INFO] [stderr] 433 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                     let mut ns = Arc::make_mut(self.prev_nameset.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                     let mut ns = Arc::make_mut(self.prev_nameset.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:268:25
[INFO] [stderr]     |
[INFO] [stderr] 268 |                     let mut ns = Arc::make_mut(self.prev_scopes.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:291:25
[INFO] [stderr]     |
[INFO] [stderr] 291 |                     let mut ver = Arc::make_mut(self.prev_verify.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]  --> src/bit_set.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 |     tail: Option<Box<Vec<usize>>>,
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::box_vec)] on by default
[INFO] [stderr]   = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/bit_set.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn clone_slow(arg: &Box<Vec<usize>>) -> Box<Vec<usize>> {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: try: `&Vec<usize>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]   --> src/bit_set.rs:15:41
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn clone_slow(arg: &Box<Vec<usize>>) -> Box<Vec<usize>> {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/database.rs:144:26
[INFO] [stderr]     |
[INFO] [stderr] 144 |         Promise(Box::new(move || (funcell.take().unwrap())()))
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `(funcell.take().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                     let mut ns = Arc::make_mut(self.prev_nameset.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                     let mut ns = Arc::make_mut(self.prev_nameset.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:268:25
[INFO] [stderr]     |
[INFO] [stderr] 268 |                     let mut ns = Arc::make_mut(self.prev_scopes.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/database.rs:291:25
[INFO] [stderr]     |
[INFO] [stderr] 291 |                     let mut ver = Arc::make_mut(self.prev_verify.as_mut().unwrap());
[INFO] [stderr]     |                         ----^^^
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/nameck.rs:86:8
[INFO] [stderr]    |
[INFO] [stderr] 86 |     if table.reverse.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `table.reverse.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:118:23
[INFO] [stderr]     |
[INFO] [stderr] 118 |         for (&seg_id, &ref seg) in &self.segments {
[INFO] [stderr]     |                       ^^^^^^^^ help: try removing the `&ref` part and just keep: `seg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |         for &ref symdef in &seg.symbols {
[INFO] [stderr]     |             ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `symdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |         for &ref lsymdef in &seg.local_vars {
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `lsymdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:167:13
[INFO] [stderr]     |
[INFO] [stderr] 167 |         for &ref labdef in &seg.labels {
[INFO] [stderr]     |             ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `labdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |         for &ref floatdef in &seg.floats {
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `floatdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:195:13
[INFO] [stderr]     |
[INFO] [stderr] 195 |         for &ref dvdef in &seg.global_dvs {
[INFO] [stderr]     |             ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `dvdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:212:17
[INFO] [stderr]     |
[INFO] [stderr] 212 |             for &ref symdef in &seg.symbols {
[INFO] [stderr]     |                 ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `symdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:221:17
[INFO] [stderr]     |
[INFO] [stderr] 221 |             for &ref labdef in &seg.labels {
[INFO] [stderr]     |                 ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `labdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:229:17
[INFO] [stderr]     |
[INFO] [stderr] 229 |             for &ref floatdef in &seg.floats {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `floatdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:237:17
[INFO] [stderr]     |
[INFO] [stderr] 237 |             for &ref dvdef in &seg.global_dvs {
[INFO] [stderr]     |                 ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `dvdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:326:18
[INFO] [stderr]     |
[INFO] [stderr] 326 |             Some(&ref lslot) => {
[INFO] [stderr]     |                  ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `lslot`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:348:18
[INFO] [stderr]     |
[INFO] [stderr] 348 |             Some(&ref syminfo) => {
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `syminfo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:373:18
[INFO] [stderr]     |
[INFO] [stderr] 373 |             Some(&ref syminfo) => {
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `syminfo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:432:13
[INFO] [stderr]     |
[INFO] [stderr] 432 |         for &ref name in &self.not_found_symbol {
[INFO] [stderr]     |             ^^^^^^^^^ help: try removing the `&ref` part and just keep: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:449:13
[INFO] [stderr]     |
[INFO] [stderr] 449 |         for &ref name in &self.not_found_label {
[INFO] [stderr]     |             ^^^^^^^^^ help: try removing the `&ref` part and just keep: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:688:19
[INFO] [stderr]     |
[INFO] [stderr] 688 |         } else if self.labels.len() == 0 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:800:23
[INFO] [stderr]     |
[INFO] [stderr] 800 |             } else if tref.len() > 0 && tref[0] == b'$' {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tref.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/parser.rs:980:17
[INFO] [stderr]     |
[INFO] [stderr] 980 |     for (index, &ref stmt) in seg.statements.iter().enumerate() {
[INFO] [stderr]     |                 ^^^^^^^^^ help: try removing the `&ref` part and just keep: `stmt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scopeck.rs:155:33
[INFO] [stderr]     |
[INFO] [stderr] 155 |     state.diagnostics.entry(ix).or_insert(Vec::new()).push(diag);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scopeck.rs:266:20
[INFO] [stderr]     |
[INFO] [stderr] 266 |       let typecode = match iter.next().expect("parser checks $eap token count") {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 267 | |         &CheckedToken::Const(_, typecode) => typecode,
[INFO] [stderr] 268 | |         _ => unreachable!(),
[INFO] [stderr] 269 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 266 |     let typecode = match *iter.next().expect("parser checks $eap token count") {
[INFO] [stderr] 267 |         CheckedToken::Const(_, typecode) => typecode,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/scopeck.rs:273:28
[INFO] [stderr]     |
[INFO] [stderr] 273 |     while let Some(ctok) = iter.next() {
[INFO] [stderr]     |                            ^^^^^^^^^^^ help: try: `for ctok in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scopeck.rs:317:16
[INFO] [stderr]     |
[INFO] [stderr] 317 |       let head = match iter.next().expect("parser checks $eap token count") {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 318 | |         &CheckedToken::Const(_, head) => head,
[INFO] [stderr] 319 | |         _ => unreachable!(),
[INFO] [stderr] 320 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 317 |     let head = match *iter.next().expect("parser checks $eap token count") {
[INFO] [stderr] 318 |         CheckedToken::Const(_, head) => head,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/scopeck.rs:324:28
[INFO] [stderr]     |
[INFO] [stderr] 324 |     while let Some(ctok) = iter.next() {
[INFO] [stderr]     |                            ^^^^^^^^^^^ help: try: `for ctok in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/scopeck.rs:357:12
[INFO] [stderr]     |
[INFO] [stderr] 357 | fn scan_dv<'a>(iframe: &mut InchoateFrame, var_set: &[Atom]) {
[INFO] [stderr]     |            ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:435:9
[INFO] [stderr]     |
[INFO] [stderr] 435 |     for &ref dv in &state.gnames.lookup_global_dv() {
[INFO] [stderr]     |         ^^^^^^^ help: try removing the `&ref` part and just keep: `dv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:439:9
[INFO] [stderr]     |
[INFO] [stderr] 439 |     for &ref dv in &state.local_dv {
[INFO] [stderr]     |         ^^^^^^^ help: try removing the `&ref` part and just keep: `dv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scopeck.rs:599:14
[INFO] [stderr]     |
[INFO] [stderr] 599 |             .or_insert(Vec::new())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scopeck.rs:620:68
[INFO] [stderr]     |
[INFO] [stderr] 620 |     let lv_slot = state.local_vars.entry(copy_token(tokref.slice)).or_insert(Vec::new());
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:746:19
[INFO] [stderr]     |
[INFO] [stderr] 746 |         for (sid, &ref ssro) in self.segments.iter().enumerate() {
[INFO] [stderr]     |                   ^^^^^^^^^ help: try removing the `&ref` part and just keep: `ssro`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:748:28
[INFO] [stderr]     |
[INFO] [stderr] 748 |                 for (&six, &ref diag) in &ssr.diagnostics {
[INFO] [stderr]     |                            ^^^^^^^^^ help: try removing the `&ref` part and just keep: `diag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:749:25
[INFO] [stderr]     |
[INFO] [stderr] 749 |                     for &ref d in diag {
[INFO] [stderr]     |                         ^^^^^^ help: try removing the `&ref` part and just keep: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:772:19
[INFO] [stderr]     |
[INFO] [stderr] 772 |         for (sid, &ref ssr) in result.segments.iter().enumerate() {
[INFO] [stderr]     |                   ^^^^^^^^ help: try removing the `&ref` part and just keep: `ssr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:800:15
[INFO] [stderr]     |
[INFO] [stderr] 800 |     for (sid, &ref res) in result.segments.iter().enumerate() {
[INFO] [stderr]     |               ^^^^^^^^ help: try removing the `&ref` part and just keep: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:916:13
[INFO] [stderr]     |
[INFO] [stderr] 916 |         for &ref name in &self.not_found {
[INFO] [stderr]     |             ^^^^^^^^^ help: try removing the `&ref` part and just keep: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq`
[INFO] [stderr]   --> src/segment_set.rs:35:1
[INFO] [stderr]    |
[INFO] [stderr] 35 | / impl Hash for LongBuf {
[INFO] [stderr] 36 | |     fn hash<H: Hasher>(&self, state: &mut H) {
[INFO] [stderr] 37 | |         self.0.len().hash(state);
[INFO] [stderr] 38 | |     }
[INFO] [stderr] 39 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/segment_set.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 | #[derive(Eq,PartialEq,Clone,Debug)]
[INFO] [stderr]    |             ^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/util.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     &vec[from]; // for the bounds check
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/util.rs:66:25
[INFO] [stderr]    |
[INFO] [stderr] 66 |         let copy_from = vec.as_ptr().offset(copy_start as isize);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_ptr().add(copy_start)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/util.rs:67:23
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let copy_to = vec.as_mut_ptr().offset(old_len as isize);
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(old_len)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/verify.rs:298:8
[INFO] [stderr]     |
[INFO] [stderr] 298 |     if state.stack.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `state.stack.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/verify.rs:451:23
[INFO] [stderr]     |
[INFO] [stderr] 451 |             for (&sa, &ref diag) in &vsr.diagnostics {
[INFO] [stderr]     |                       ^^^^^^^^^ help: try removing the `&ref` part and just keep: `diag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `smetamath`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]  --> src/bit_set.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 |     tail: Option<Box<Vec<usize>>>,
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::box_vec)] on by default
[INFO] [stderr]   = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/bit_set.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn clone_slow(arg: &Box<Vec<usize>>) -> Box<Vec<usize>> {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: try: `&Vec<usize>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]   --> src/bit_set.rs:15:41
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn clone_slow(arg: &Box<Vec<usize>>) -> Box<Vec<usize>> {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/database.rs:144:26
[INFO] [stderr]     |
[INFO] [stderr] 144 |         Promise(Box::new(move || (funcell.take().unwrap())()))
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `(funcell.take().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/nameck.rs:86:8
[INFO] [stderr]    |
[INFO] [stderr] 86 |     if table.reverse.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `table.reverse.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:118:23
[INFO] [stderr]     |
[INFO] [stderr] 118 |         for (&seg_id, &ref seg) in &self.segments {
[INFO] [stderr]     |                       ^^^^^^^^ help: try removing the `&ref` part and just keep: `seg`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |         for &ref symdef in &seg.symbols {
[INFO] [stderr]     |             ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `symdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |         for &ref lsymdef in &seg.local_vars {
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `lsymdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:167:13
[INFO] [stderr]     |
[INFO] [stderr] 167 |         for &ref labdef in &seg.labels {
[INFO] [stderr]     |             ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `labdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |         for &ref floatdef in &seg.floats {
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `floatdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:195:13
[INFO] [stderr]     |
[INFO] [stderr] 195 |         for &ref dvdef in &seg.global_dvs {
[INFO] [stderr]     |             ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `dvdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:212:17
[INFO] [stderr]     |
[INFO] [stderr] 212 |             for &ref symdef in &seg.symbols {
[INFO] [stderr]     |                 ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `symdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:221:17
[INFO] [stderr]     |
[INFO] [stderr] 221 |             for &ref labdef in &seg.labels {
[INFO] [stderr]     |                 ^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `labdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:229:17
[INFO] [stderr]     |
[INFO] [stderr] 229 |             for &ref floatdef in &seg.floats {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `floatdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:237:17
[INFO] [stderr]     |
[INFO] [stderr] 237 |             for &ref dvdef in &seg.global_dvs {
[INFO] [stderr]     |                 ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `dvdef`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:326:18
[INFO] [stderr]     |
[INFO] [stderr] 326 |             Some(&ref lslot) => {
[INFO] [stderr]     |                  ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `lslot`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:348:18
[INFO] [stderr]     |
[INFO] [stderr] 348 |             Some(&ref syminfo) => {
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `syminfo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:373:18
[INFO] [stderr]     |
[INFO] [stderr] 373 |             Some(&ref syminfo) => {
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `syminfo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:432:13
[INFO] [stderr]     |
[INFO] [stderr] 432 |         for &ref name in &self.not_found_symbol {
[INFO] [stderr]     |             ^^^^^^^^^ help: try removing the `&ref` part and just keep: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/nameck.rs:449:13
[INFO] [stderr]     |
[INFO] [stderr] 449 |         for &ref name in &self.not_found_label {
[INFO] [stderr]     |             ^^^^^^^^^ help: try removing the `&ref` part and just keep: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:688:19
[INFO] [stderr]     |
[INFO] [stderr] 688 |         } else if self.labels.len() == 0 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.labels.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:800:23
[INFO] [stderr]     |
[INFO] [stderr] 800 |             } else if tref.len() > 0 && tref[0] == b'$' {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tref.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/parser.rs:980:17
[INFO] [stderr]     |
[INFO] [stderr] 980 |     for (index, &ref stmt) in seg.statements.iter().enumerate() {
[INFO] [stderr]     |                 ^^^^^^^^^ help: try removing the `&ref` part and just keep: `stmt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scopeck.rs:155:33
[INFO] [stderr]     |
[INFO] [stderr] 155 |     state.diagnostics.entry(ix).or_insert(Vec::new()).push(diag);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scopeck.rs:266:20
[INFO] [stderr]     |
[INFO] [stderr] 266 |       let typecode = match iter.next().expect("parser checks $eap token count") {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 267 | |         &CheckedToken::Const(_, typecode) => typecode,
[INFO] [stderr] 268 | |         _ => unreachable!(),
[INFO] [stderr] 269 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 266 |     let typecode = match *iter.next().expect("parser checks $eap token count") {
[INFO] [stderr] 267 |         CheckedToken::Const(_, typecode) => typecode,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/scopeck.rs:273:28
[INFO] [stderr]     |
[INFO] [stderr] 273 |     while let Some(ctok) = iter.next() {
[INFO] [stderr]     |                            ^^^^^^^^^^^ help: try: `for ctok in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/scopeck.rs:317:16
[INFO] [stderr]     |
[INFO] [stderr] 317 |       let head = match iter.next().expect("parser checks $eap token count") {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 318 | |         &CheckedToken::Const(_, head) => head,
[INFO] [stderr] 319 | |         _ => unreachable!(),
[INFO] [stderr] 320 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 317 |     let head = match *iter.next().expect("parser checks $eap token count") {
[INFO] [stderr] 318 |         CheckedToken::Const(_, head) => head,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/scopeck.rs:324:28
[INFO] [stderr]     |
[INFO] [stderr] 324 |     while let Some(ctok) = iter.next() {
[INFO] [stderr]     |                            ^^^^^^^^^^^ help: try: `for ctok in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/scopeck.rs:357:12
[INFO] [stderr]     |
[INFO] [stderr] 357 | fn scan_dv<'a>(iframe: &mut InchoateFrame, var_set: &[Atom]) {
[INFO] [stderr]     |            ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:435:9
[INFO] [stderr]     |
[INFO] [stderr] 435 |     for &ref dv in &state.gnames.lookup_global_dv() {
[INFO] [stderr]     |         ^^^^^^^ help: try removing the `&ref` part and just keep: `dv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:439:9
[INFO] [stderr]     |
[INFO] [stderr] 439 |     for &ref dv in &state.local_dv {
[INFO] [stderr]     |         ^^^^^^^ help: try removing the `&ref` part and just keep: `dv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scopeck.rs:599:14
[INFO] [stderr]     |
[INFO] [stderr] 599 |             .or_insert(Vec::new())
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/scopeck.rs:620:68
[INFO] [stderr]     |
[INFO] [stderr] 620 |     let lv_slot = state.local_vars.entry(copy_token(tokref.slice)).or_insert(Vec::new());
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:746:19
[INFO] [stderr]     |
[INFO] [stderr] 746 |         for (sid, &ref ssro) in self.segments.iter().enumerate() {
[INFO] [stderr]     |                   ^^^^^^^^^ help: try removing the `&ref` part and just keep: `ssro`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:748:28
[INFO] [stderr]     |
[INFO] [stderr] 748 |                 for (&six, &ref diag) in &ssr.diagnostics {
[INFO] [stderr]     |                            ^^^^^^^^^ help: try removing the `&ref` part and just keep: `diag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:749:25
[INFO] [stderr]     |
[INFO] [stderr] 749 |                     for &ref d in diag {
[INFO] [stderr]     |                         ^^^^^^ help: try removing the `&ref` part and just keep: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:772:19
[INFO] [stderr]     |
[INFO] [stderr] 772 |         for (sid, &ref ssr) in result.segments.iter().enumerate() {
[INFO] [stderr]     |                   ^^^^^^^^ help: try removing the `&ref` part and just keep: `ssr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:800:15
[INFO] [stderr]     |
[INFO] [stderr] 800 |     for (sid, &ref res) in result.segments.iter().enumerate() {
[INFO] [stderr]     |               ^^^^^^^^ help: try removing the `&ref` part and just keep: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/scopeck.rs:916:13
[INFO] [stderr]     |
[INFO] [stderr] 916 |         for &ref name in &self.not_found {
[INFO] [stderr]     |             ^^^^^^^^^ help: try removing the `&ref` part and just keep: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq`
[INFO] [stderr]   --> src/segment_set.rs:35:1
[INFO] [stderr]    |
[INFO] [stderr] 35 | / impl Hash for LongBuf {
[INFO] [stderr] 36 | |     fn hash<H: Hasher>(&self, state: &mut H) {
[INFO] [stderr] 37 | |         self.0.len().hash(state);
[INFO] [stderr] 38 | |     }
[INFO] [stderr] 39 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/segment_set.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 | #[derive(Eq,PartialEq,Clone,Debug)]
[INFO] [stderr]    |             ^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/util.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     &vec[from]; // for the bounds check
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/util.rs:66:25
[INFO] [stderr]    |
[INFO] [stderr] 66 |         let copy_from = vec.as_ptr().offset(copy_start as isize);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_ptr().add(copy_start)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/util.rs:67:23
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let copy_to = vec.as_mut_ptr().offset(old_len as isize);
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.as_mut_ptr().add(old_len)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/verify.rs:298:8
[INFO] [stderr]     |
[INFO] [stderr] 298 |     if state.stack.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `state.stack.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/verify.rs:451:23
[INFO] [stderr]     |
[INFO] [stderr] 451 |             for (&sa, &ref diag) in &vsr.diagnostics {
[INFO] [stderr]     |                       ^^^^^^^^^ help: try removing the `&ref` part and just keep: `diag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `smetamath`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c886de70d9b2a3194313b8e3dd084357ef57be6f3d3ebd830d623c6de22c4bfa"`
[INFO] running `"docker" "rm" "-f" "c886de70d9b2a3194313b8e3dd084357ef57be6f3d3ebd830d623c6de22c4bfa"`
[INFO] [stdout] c886de70d9b2a3194313b8e3dd084357ef57be6f3d3ebd830d623c6de22c4bfa