[INFO] crate smelter 0.0.2 is already in cache [INFO] extracting crate smelter 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/smelter/0.0.2 [INFO] extracting crate smelter 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smelter/0.0.2 [INFO] validating manifest of smelter-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smelter-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smelter-0.0.2 [INFO] finished frobbing smelter-0.0.2 [INFO] frobbed toml for smelter-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/smelter/0.0.2/Cargo.toml [INFO] started frobbing smelter-0.0.2 [INFO] finished frobbing smelter-0.0.2 [INFO] frobbed toml for smelter-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smelter/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smelter-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/smelter/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76f7b45854caf4ec1faa4869a28195c0d6d10f24e2df656b302540e95407bff0 [INFO] running `"docker" "start" "-a" "76f7b45854caf4ec1faa4869a28195c0d6d10f24e2df656b302540e95407bff0"` [INFO] [stderr] Checking unicode-xid v0.0.3 [INFO] [stderr] Compiling syn v0.9.2 [INFO] [stderr] Checking smelter v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_borrow` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/code_gen.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(unknown_lints, needless_borrow)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_borrow` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_gen.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_borrow` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/code_gen.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(unknown_lints, needless_borrow)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_borrow` [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/code_gen.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | attrs.into_iter().filter(|attr| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/test.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | of: of, [INFO] [stderr] | ^^^^^^ help: replace it with: `of` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> tests/test.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(PartialEq, Debug, Builder, Default)] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | structure: structure.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `structure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | has: has.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `has` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | lot: lot.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> tests/test.rs:98:10 [INFO] [stderr] | [INFO] [stderr] 98 | #[derive(Builder, PartialEq, Debug)] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> tests/test.rs:98:10 [INFO] [stderr] | [INFO] [stderr] 98 | #[derive(Builder, PartialEq, Debug)] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> tests/test.rs:98:10 [INFO] [stderr] | [INFO] [stderr] 98 | #[derive(Builder, PartialEq, Debug)] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.28s [INFO] running `"docker" "inspect" "76f7b45854caf4ec1faa4869a28195c0d6d10f24e2df656b302540e95407bff0"` [INFO] running `"docker" "rm" "-f" "76f7b45854caf4ec1faa4869a28195c0d6d10f24e2df656b302540e95407bff0"` [INFO] [stdout] 76f7b45854caf4ec1faa4869a28195c0d6d10f24e2df656b302540e95407bff0