[INFO] crate smawk 0.1.0 is already in cache [INFO] extracting crate smawk 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/smawk/0.1.0 [INFO] extracting crate smawk 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smawk/0.1.0 [INFO] validating manifest of smawk-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smawk-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smawk-0.1.0 [INFO] finished frobbing smawk-0.1.0 [INFO] frobbed toml for smawk-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/smawk/0.1.0/Cargo.toml [INFO] started frobbing smawk-0.1.0 [INFO] finished frobbing smawk-0.1.0 [INFO] frobbed toml for smawk-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smawk/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smawk-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/smawk/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b67684bf2c91ffe3914c6ffe0d6c715a38ef295049b5b45ca2a3c0512fe11ca1 [INFO] running `"docker" "start" "-a" "b67684bf2c91ffe3914c6ffe0d6c715a38ef295049b5b45ca2a3c0512fe11ca1"` [INFO] [stderr] Checking syntex_pos v0.58.1 [INFO] [stderr] Checking unicode-bidi v0.3.3 [INFO] [stderr] Compiling rand_derive v0.3.1 [INFO] [stderr] Checking ndarray v0.10.14 [INFO] [stderr] Checking syntex_errors v0.58.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking syntex_syntax v0.58.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking smawk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:399:24 [INFO] [stderr] | [INFO] [stderr] 399 | let rows = (base..finished + 1).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(base..=finished)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:401:24 [INFO] [stderr] | [INFO] [stderr] 401 | let cols = (finished + 1..tentative + 1).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(finished + 1..=tentative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 403 | smawk_inner(&|i, j| m![i, j], &rows, &cols, &mut minima); [INFO] [stderr] | -------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 406 | let v = m![row, col]; [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 422 | let diag = m![i - 1, i]; [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 434 | if m![i - 1, tentative] >= result[tentative].1 { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:527:19 [INFO] [stderr] | [INFO] [stderr] 527 | let tmp = match rng.gen() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 528 | | true => MongePrim::LowerLeftOnes, [INFO] [stderr] 529 | | false => MongePrim::UpperRightOnes, [INFO] [stderr] 530 | | }.to_matrix(m, n, rng); [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if rng.gen() { MongePrim::LowerLeftOnes } else { MongePrim::UpperRightOnes }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Checking version-sync v0.3.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/complexity.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/complexity.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | beta: beta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `beta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/complexity.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | r_squared: r_squared, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_squared` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/comparison.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `smawk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/complexity.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | let ys = Array1::from_iter(values.iter().map(|&(_, y)| y as f64)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:399:24 [INFO] [stderr] | [INFO] [stderr] 399 | let rows = (base..finished + 1).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(base..=finished)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:401:24 [INFO] [stderr] | [INFO] [stderr] 401 | let cols = (finished + 1..tentative + 1).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(finished + 1..=tentative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 403 | smawk_inner(&|i, j| m![i, j], &rows, &cols, &mut minima); [INFO] [stderr] | -------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 406 | let v = m![row, col]; [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 422 | let diag = m![i - 1, i]; [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:386:28 [INFO] [stderr] | [INFO] [stderr] 386 | matrix(&result[..finished + 1], $i, $j) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=finished` [INFO] [stderr] ... [INFO] [stderr] 434 | if m![i - 1, tentative] >= result[tentative].1 { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:527:19 [INFO] [stderr] | [INFO] [stderr] 527 | let tmp = match rng.gen() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 528 | | true => MongePrim::LowerLeftOnes, [INFO] [stderr] 529 | | false => MongePrim::UpperRightOnes, [INFO] [stderr] 530 | | }.to_matrix(m, n, rng); [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if rng.gen() { MongePrim::LowerLeftOnes } else { MongePrim::UpperRightOnes }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:914:41 [INFO] [stderr] | [INFO] [stderr] 914 | matrix.slice_mut(s![idx..idx + 1, ..idx + 1]).fill(max); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `idx..=idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:914:55 [INFO] [stderr] | [INFO] [stderr] 914 | matrix.slice_mut(s![idx..idx + 1, ..idx + 1]).fill(max); [INFO] [stderr] | ^^^^^^^^^ help: use: `..=idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b67684bf2c91ffe3914c6ffe0d6c715a38ef295049b5b45ca2a3c0512fe11ca1"` [INFO] running `"docker" "rm" "-f" "b67684bf2c91ffe3914c6ffe0d6c715a38ef295049b5b45ca2a3c0512fe11ca1"` [INFO] [stdout] b67684bf2c91ffe3914c6ffe0d6c715a38ef295049b5b45ca2a3c0512fe11ca1