[INFO] crate smart-default 0.3.0 is already in cache [INFO] extracting crate smart-default 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/smart-default/0.3.0 [INFO] extracting crate smart-default 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smart-default/0.3.0 [INFO] validating manifest of smart-default-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smart-default-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smart-default-0.3.0 [INFO] finished frobbing smart-default-0.3.0 [INFO] frobbed toml for smart-default-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/smart-default/0.3.0/Cargo.toml [INFO] started frobbing smart-default-0.3.0 [INFO] finished frobbing smart-default-0.3.0 [INFO] frobbed toml for smart-default-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smart-default/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smart-default-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/smart-default/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2eaab0580e1c41b5ab4280a671d560d63cbc4516f4277461b4616a030fff48b1 [INFO] running `"docker" "start" "-a" "2eaab0580e1c41b5ab4280a671d560d63cbc4516f4277461b4616a030fff48b1"` [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Compiling smart-default v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | let body_tt = match body { [INFO] [stderr] | ___________________^ [INFO] [stderr] 124 | | &syn::Fields::Named(ref fields) => { [INFO] [stderr] 125 | | doc.push_str(" {"); [INFO] [stderr] 126 | | let result = { [INFO] [stderr] ... | [INFO] [stderr] 168 | | &syn::Fields::Unit => quote!{}, [INFO] [stderr] 169 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | let body_tt = match *body { [INFO] [stderr] 124 | syn::Fields::Named(ref fields) => { [INFO] [stderr] 125 | doc.push_str(" {"); [INFO] [stderr] 126 | let result = { [INFO] [stderr] 127 | let field_assignments = fields.named.iter().map(|field| { [INFO] [stderr] 128 | let field_name = field.ident.as_ref(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `ends_with` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | if (&mut doc).ends_with(",") { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | if (&mut doc).ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `ends_with` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | if (&mut doc).ends_with(", ") { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:204:8 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(segment.ident.to_string() == "default") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*segment.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/lib.rs:207:64 [INFO] [stderr] | [INFO] [stderr] 207 | fn find_default_attr_value(attrs: &[syn::Attribute]) -> Result>, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | let body_tt = match body { [INFO] [stderr] | ___________________^ [INFO] [stderr] 124 | | &syn::Fields::Named(ref fields) => { [INFO] [stderr] 125 | | doc.push_str(" {"); [INFO] [stderr] 126 | | let result = { [INFO] [stderr] ... | [INFO] [stderr] 168 | | &syn::Fields::Unit => quote!{}, [INFO] [stderr] 169 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | let body_tt = match *body { [INFO] [stderr] 124 | syn::Fields::Named(ref fields) => { [INFO] [stderr] 125 | doc.push_str(" {"); [INFO] [stderr] 126 | let result = { [INFO] [stderr] 127 | let field_assignments = fields.named.iter().map(|field| { [INFO] [stderr] 128 | let field_name = field.ident.as_ref(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `ends_with` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | if (&mut doc).ends_with(",") { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | if (&mut doc).ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `ends_with` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | if (&mut doc).ends_with(", ") { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:204:8 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(segment.ident.to_string() == "default") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*segment.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/lib.rs:207:64 [INFO] [stderr] | [INFO] [stderr] 207 | fn find_default_attr_value(attrs: &[syn::Attribute]) -> Result>, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.07s [INFO] running `"docker" "inspect" "2eaab0580e1c41b5ab4280a671d560d63cbc4516f4277461b4616a030fff48b1"` [INFO] running `"docker" "rm" "-f" "2eaab0580e1c41b5ab4280a671d560d63cbc4516f4277461b4616a030fff48b1"` [INFO] [stdout] 2eaab0580e1c41b5ab4280a671d560d63cbc4516f4277461b4616a030fff48b1