[INFO] crate smallstr 0.1.0 is already in cache [INFO] extracting crate smallstr 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/smallstr/0.1.0 [INFO] extracting crate smallstr 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smallstr/0.1.0 [INFO] validating manifest of smallstr-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smallstr-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smallstr-0.1.0 [INFO] finished frobbing smallstr-0.1.0 [INFO] frobbed toml for smallstr-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/smallstr/0.1.0/Cargo.toml [INFO] started frobbing smallstr-0.1.0 [INFO] finished frobbing smallstr-0.1.0 [INFO] frobbed toml for smallstr-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/smallstr/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smallstr-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/smallstr/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f2438192f9e866acafea22c0442a178a51f154e1bd4b62df7124136bc806981 [INFO] running `"docker" "start" "-a" "4f2438192f9e866acafea22c0442a178a51f154e1bd4b62df7124136bc806981"` [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking smallstr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/string.rs:393:22 [INFO] [stderr] | [INFO] [stderr] 393 | self.slice_unchecked(idx, len).chars().next().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/string.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn from_str(s: &str) -> SmallString { [INFO] [stderr] 64 | | SmallString{ [INFO] [stderr] 65 | | data: SmallVec::from_slice(s.as_bytes()), [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | self.as_ptr().offset(next as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(next)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:298:17 [INFO] [stderr] | [INFO] [stderr] 298 | self.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | self.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | self.as_mut_ptr().offset((idx + amt) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add((idx + amt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | self.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | self.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | self.as_mut_ptr().offset((idx - del_bytes) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add((idx - del_bytes))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 680 | eq_str!(str); [INFO] [stderr] | ------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 681 | eq_str!(&'a str); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 682 | eq_str!(String); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 683 | eq_str!(Cow<'a, str>); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:693:5 [INFO] [stderr] | [INFO] [stderr] 693 | / fn ne(&self, rhs: &OsStr) -> bool { [INFO] [stderr] 694 | | &self[..] != rhs [INFO] [stderr] 695 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:706:5 [INFO] [stderr] | [INFO] [stderr] 706 | / fn ne(&self, rhs: &&OsStr) -> bool { [INFO] [stderr] 707 | | &self[..] != *rhs [INFO] [stderr] 708 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:719:5 [INFO] [stderr] | [INFO] [stderr] 719 | / fn ne(&self, rhs: &OsString) -> bool { [INFO] [stderr] 720 | | &self[..] != rhs [INFO] [stderr] 721 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:732:5 [INFO] [stderr] | [INFO] [stderr] 732 | / fn ne(&self, rhs: &Cow) -> bool { [INFO] [stderr] 733 | | self[..] != **rhs [INFO] [stderr] 734 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:745:5 [INFO] [stderr] | [INFO] [stderr] 745 | / fn ne(&self, rhs: &SmallString) -> bool { [INFO] [stderr] 746 | | &self[..] != &rhs[..] [INFO] [stderr] 747 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/string.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | &self[..] == &rhs[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 741 | self[..] == rhs[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/string.rs:746:9 [INFO] [stderr] | [INFO] [stderr] 746 | &self[..] != &rhs[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 746 | self[..] != rhs[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/string.rs:393:22 [INFO] [stderr] | [INFO] [stderr] 393 | self.slice_unchecked(idx, len).chars().next().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/string.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn from_str(s: &str) -> SmallString { [INFO] [stderr] 64 | | SmallString{ [INFO] [stderr] 65 | | data: SmallVec::from_slice(s.as_bytes()), [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | self.as_ptr().offset(next as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(next)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:298:17 [INFO] [stderr] | [INFO] [stderr] 298 | self.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | self.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | self.as_mut_ptr().offset((idx + amt) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add((idx + amt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | self.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | self.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/string.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | self.as_mut_ptr().offset((idx - del_bytes) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add((idx - del_bytes))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 680 | eq_str!(str); [INFO] [stderr] | ------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 681 | eq_str!(&'a str); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 682 | eq_str!(String); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / fn ne(&self, rhs: &$rhs) -> bool { [INFO] [stderr] 674 | | &self[..] != &rhs[..] [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 683 | eq_str!(Cow<'a, str>); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:693:5 [INFO] [stderr] | [INFO] [stderr] 693 | / fn ne(&self, rhs: &OsStr) -> bool { [INFO] [stderr] 694 | | &self[..] != rhs [INFO] [stderr] 695 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:706:5 [INFO] [stderr] | [INFO] [stderr] 706 | / fn ne(&self, rhs: &&OsStr) -> bool { [INFO] [stderr] 707 | | &self[..] != *rhs [INFO] [stderr] 708 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:719:5 [INFO] [stderr] | [INFO] [stderr] 719 | / fn ne(&self, rhs: &OsString) -> bool { [INFO] [stderr] 720 | | &self[..] != rhs [INFO] [stderr] 721 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:732:5 [INFO] [stderr] | [INFO] [stderr] 732 | / fn ne(&self, rhs: &Cow) -> bool { [INFO] [stderr] 733 | | self[..] != **rhs [INFO] [stderr] 734 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/string.rs:745:5 [INFO] [stderr] | [INFO] [stderr] 745 | / fn ne(&self, rhs: &SmallString) -> bool { [INFO] [stderr] 746 | | &self[..] != &rhs[..] [INFO] [stderr] 747 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/string.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | &self[..] == &rhs[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 741 | self[..] == rhs[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/string.rs:746:9 [INFO] [stderr] | [INFO] [stderr] 746 | &self[..] != &rhs[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 746 | self[..] != rhs[..] [INFO] [stderr] | ^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.89s [INFO] running `"docker" "inspect" "4f2438192f9e866acafea22c0442a178a51f154e1bd4b62df7124136bc806981"` [INFO] running `"docker" "rm" "-f" "4f2438192f9e866acafea22c0442a178a51f154e1bd4b62df7124136bc806981"` [INFO] [stdout] 4f2438192f9e866acafea22c0442a178a51f154e1bd4b62df7124136bc806981