[INFO] crate slugify 0.1.0 is already in cache [INFO] extracting crate slugify 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/slugify/0.1.0 [INFO] extracting crate slugify 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slugify/0.1.0 [INFO] validating manifest of slugify-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slugify-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slugify-0.1.0 [INFO] finished frobbing slugify-0.1.0 [INFO] frobbed toml for slugify-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/slugify/0.1.0/Cargo.toml [INFO] started frobbing slugify-0.1.0 [INFO] finished frobbing slugify-0.1.0 [INFO] frobbed toml for slugify-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slugify/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slugify-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slugify/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7de71da3224fd27a03192ce8f6b36bb67e9279dc31de1bcb626643d972dd7a2d [INFO] running `"docker" "start" "-a" "7de71da3224fd27a03192ce8f6b36bb67e9279dc31de1bcb626643d972dd7a2d"` [INFO] [stderr] Checking slugify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:164:40 [INFO] [stderr] | [INFO] [stderr] 164 | let mut string: String = unidecode(string.into()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:171:34 [INFO] [stderr] | [INFO] [stderr] 171 | for word in stop_words.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / match max_length { [INFO] [stderr] 205 | | Some(x) => { [INFO] [stderr] 206 | | s.truncate(x); [INFO] [stderr] 207 | | s = s.trim_right_matches(char_vec[0]).to_string(); [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | None => {} [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 204 | if let Some(x) = max_length { [INFO] [stderr] 205 | s.truncate(x); [INFO] [stderr] 206 | s = s.trim_right_matches(char_vec[0]).to_string(); [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:164:40 [INFO] [stderr] | [INFO] [stderr] 164 | let mut string: String = unidecode(string.into()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:171:34 [INFO] [stderr] | [INFO] [stderr] 171 | for word in stop_words.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / match max_length { [INFO] [stderr] 205 | | Some(x) => { [INFO] [stderr] 206 | | s.truncate(x); [INFO] [stderr] 207 | | s = s.trim_right_matches(char_vec[0]).to_string(); [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | None => {} [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 204 | if let Some(x) = max_length { [INFO] [stderr] 205 | s.truncate(x); [INFO] [stderr] 206 | s = s.trim_right_matches(char_vec[0]).to_string(); [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "7de71da3224fd27a03192ce8f6b36bb67e9279dc31de1bcb626643d972dd7a2d"` [INFO] running `"docker" "rm" "-f" "7de71da3224fd27a03192ce8f6b36bb67e9279dc31de1bcb626643d972dd7a2d"` [INFO] [stdout] 7de71da3224fd27a03192ce8f6b36bb67e9279dc31de1bcb626643d972dd7a2d