[INFO] crate slowloris 1.2.0 is already in cache [INFO] extracting crate slowloris 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/slowloris/1.2.0 [INFO] extracting crate slowloris 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slowloris/1.2.0 [INFO] validating manifest of slowloris-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slowloris-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slowloris-1.2.0 [INFO] finished frobbing slowloris-1.2.0 [INFO] frobbed toml for slowloris-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/slowloris/1.2.0/Cargo.toml [INFO] started frobbing slowloris-1.2.0 [INFO] finished frobbing slowloris-1.2.0 [INFO] frobbed toml for slowloris-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slowloris/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slowloris-1.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slowloris/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ed4514a6eefebb2fa0c88ac6fe4dfdfc1d7101b353802092a5324c07892606e [INFO] running `"docker" "start" "-a" "4ed4514a6eefebb2fa0c88ac6fe4dfdfc1d7101b353802092a5324c07892606e"` [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking slowloris v1.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | pub const USER_AGENTS: &'static [&str] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | pub const USER_AGENTS: &'static [&str] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | .expect(&format!("Failed to connect to {}:{}", domain, port)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect to {}:{}", domain))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Failed to connect to {} via TLS", domain)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect to {} via TLS", domain))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:77:10 [INFO] [stderr] | [INFO] [stderr] 77 | .expect(&format!("Failed to send header to {}", addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to send header to {}", addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | .expect(&format!("Failed to connect to {}:{}", domain, port)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect to {}:{}", domain))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Failed to connect to {} via TLS", domain)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect to {} via TLS", domain))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:77:10 [INFO] [stderr] | [INFO] [stderr] 77 | .expect(&format!("Failed to send header to {}", addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to send header to {}", addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:49:52 [INFO] [stderr] | [INFO] [stderr] 49 | matches.value_of(name).unwrap().parse::().expect( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 50 | | &format!( [INFO] [stderr] 51 | | "Please provide a valid number as value for the parameter '{}'", [INFO] [stderr] 52 | | name [INFO] [stderr] 53 | | ), [INFO] [stderr] 54 | | ) [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Please provide a valid number as value for the parameter '{}'", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:49:52 [INFO] [stderr] | [INFO] [stderr] 49 | matches.value_of(name).unwrap().parse::().expect( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 50 | | &format!( [INFO] [stderr] 51 | | "Please provide a valid number as value for the parameter '{}'", [INFO] [stderr] 52 | | name [INFO] [stderr] 53 | | ), [INFO] [stderr] 54 | | ) [INFO] [stderr] | |_____^ help: try this: `unwrap_or_else(|_| panic!("Please provide a valid number as value for the parameter '{}'", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.97s [INFO] running `"docker" "inspect" "4ed4514a6eefebb2fa0c88ac6fe4dfdfc1d7101b353802092a5324c07892606e"` [INFO] running `"docker" "rm" "-f" "4ed4514a6eefebb2fa0c88ac6fe4dfdfc1d7101b353802092a5324c07892606e"` [INFO] [stdout] 4ed4514a6eefebb2fa0c88ac6fe4dfdfc1d7101b353802092a5324c07892606e