[INFO] crate slow_primes 0.1.14 is already in cache [INFO] extracting crate slow_primes 0.1.14 into work/ex/clippy-test-run/sources/stable/reg/slow_primes/0.1.14 [INFO] extracting crate slow_primes 0.1.14 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slow_primes/0.1.14 [INFO] validating manifest of slow_primes-0.1.14 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slow_primes-0.1.14 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slow_primes-0.1.14 [INFO] finished frobbing slow_primes-0.1.14 [INFO] frobbed toml for slow_primes-0.1.14 written to work/ex/clippy-test-run/sources/stable/reg/slow_primes/0.1.14/Cargo.toml [INFO] started frobbing slow_primes-0.1.14 [INFO] finished frobbing slow_primes-0.1.14 [INFO] frobbed toml for slow_primes-0.1.14 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slow_primes/0.1.14/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slow_primes-0.1.14 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slow_primes/0.1.14:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14cffebb9b8252c470b428a5b9f1415c11e8b455e65d30758d27a586d29809d8 [INFO] running `"docker" "start" "-a" "14cffebb9b8252c470b428a5b9f1415c11e8b455e65d30758d27a586d29809d8"` [INFO] [stderr] Checking slow_primes v0.1.14 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | nbits: nbits [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nbits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1107:18 [INFO] [stderr] | [INFO] [stderr] 1107 | BitSet { bit_vec: bit_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1313:13 [INFO] [stderr] | [INFO] [stderr] 1313 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1342:13 [INFO] [stderr] | [INFO] [stderr] 1342 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1378:13 [INFO] [stderr] | [INFO] [stderr] 1378 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1408:13 [INFO] [stderr] | [INFO] [stderr] 1408 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | small: small, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `small` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | low: low, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | current: current, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | limit: limit [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | nbits: nbits [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nbits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1107:18 [INFO] [stderr] | [INFO] [stderr] 1107 | BitSet { bit_vec: bit_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1313:13 [INFO] [stderr] | [INFO] [stderr] 1313 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1342:13 [INFO] [stderr] | [INFO] [stderr] 1342 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1378:13 [INFO] [stderr] | [INFO] [stderr] 1378 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bit.rs:1408:13 [INFO] [stderr] | [INFO] [stderr] 1408 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | small: small, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `small` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | low: low, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | current: current, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fast_sieve.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | limit: limit [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/bit.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | !0 >> (32 - bits % 32) % 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `!0 >> ((32 - bits % 32) % 32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1582:9 [INFO] [stderr] | [INFO] [stderr] 1582 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1594:9 [INFO] [stderr] | [INFO] [stderr] 1594 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1660:9 [INFO] [stderr] | [INFO] [stderr] 1660 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1696:9 [INFO] [stderr] | [INFO] [stderr] 1696 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | } else if n >= 355991 { [INFO] [stderr] | ^^^^^^ help: consider: `355_991` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | const HINT: &'static [u64] = &[2]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------------------------ help: consider removing `'static`: `&[(u64, &'static [u64])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:32:39 [INFO] [stderr] | [INFO] [stderr] 32 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/is_prime.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | (1_112_004_669_632, &[2, 13, 23, 1662803]), [INFO] [stderr] | ^^^^^^^ help: consider: `1_662_803` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/bit.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | !0 >> (32 - bits % 32) % 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `!0 >> ((32 - bits % 32) % 32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1582:9 [INFO] [stderr] | [INFO] [stderr] 1582 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1594:9 [INFO] [stderr] | [INFO] [stderr] 1594 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1660:9 [INFO] [stderr] | [INFO] [stderr] 1660 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit.rs:1696:9 [INFO] [stderr] | [INFO] [stderr] 1696 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | } else if n >= 355991 { [INFO] [stderr] | ^^^^^^ help: consider: `355_991` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | (7, 664579), [INFO] [stderr] | ^^^^^^ help: consider: `664_579` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | (8, 5761455), [INFO] [stderr] | ^^^^^^^ help: consider: `5_761_455` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | (9, 50847534), [INFO] [stderr] | ^^^^^^^^ help: consider: `50_847_534` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | (10, 455052511), [INFO] [stderr] | ^^^^^^^^^ help: consider: `455_052_511` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:152:18 [INFO] [stderr] | [INFO] [stderr] 152 | (11, 4118054813), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_118_054_813` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | (12, 37607912018), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `37_607_912_018` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | (13, 346065536839), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `346_065_536_839` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | (14, 3204941750802), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `3_204_941_750_802` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | (15, 29844570422669), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `29_844_570_422_669` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | (16, 279238341033925), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `279_238_341_033_925` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | (17, 2623557157654233), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2_623_557_157_654_233` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | (4, 104729), [INFO] [stderr] | ^^^^^^ help: consider: `104_729` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | (5, 1299709), [INFO] [stderr] | ^^^^^^^ help: consider: `1_299_709` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | (6, 15485863), [INFO] [stderr] | ^^^^^^^^ help: consider: `15_485_863` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | (7, 179424673), [INFO] [stderr] | ^^^^^^^^^ help: consider: `179_424_673` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | (8, 2038074743), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_038_074_743` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | (9, 22801763489), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `22_801_763_489` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | (10, 252097800623), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `252_097_800_623` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:193:18 [INFO] [stderr] | [INFO] [stderr] 193 | (11, 2760727302517), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_760_727_302_517` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:194:18 [INFO] [stderr] | [INFO] [stderr] 194 | (12, 29996224275833), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `29_996_224_275_833` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | (13, 323780508946331), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `323_780_508_946_331` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:196:18 [INFO] [stderr] | [INFO] [stderr] 196 | (14, 3475385758524527), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `3_475_385_758_524_527` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/estimate.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | (15, 37124508045065437), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `37_124_508_045_065_437` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | const HINT: &'static [u64] = &[2]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------------------------ help: consider removing `'static`: `&[(u64, &'static [u64])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/is_prime.rs:32:39 [INFO] [stderr] | [INFO] [stderr] 32 | const WITNESSES: &'static [(u64, &'static [u64])] = [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/is_prime.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | (1_112_004_669_632, &[2, 13, 23, 1662803]), [INFO] [stderr] | ^^^^^^^ help: consider: `1_662_803` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/perfect_power.rs:106:43 [INFO] [stderr] | [INFO] [stderr] 106 | if is_prime { Some((expected))} else { None }) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/perfect_power.rs:106:43 [INFO] [stderr] | [INFO] [stderr] 106 | if is_prime { Some((expected))} else { None }) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/perfect_power.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | for n in (1..MAX.log(pq as f64) as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(reverse_bits(bytes[i * 4 + 0]) as u32)` [INFO] [stderr] --> src/bit.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | ((reverse_bits(bytes[i * 4 + 0]) as u32) << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:306:18 [INFO] [stderr] | [INFO] [stderr] 306 | ((reverse_bits(bytes[i * 4 + 0]) as u32) << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/bit.rs:306:38 [INFO] [stderr] | [INFO] [stderr] 306 | ((reverse_bits(bytes[i * 4 + 0]) as u32) << 0) | [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:307:18 [INFO] [stderr] | [INFO] [stderr] 307 | ((reverse_bits(bytes[i * 4 + 1]) as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:308:18 [INFO] [stderr] | [INFO] [stderr] 308 | ((reverse_bits(bytes[i * 4 + 2]) as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:309:18 [INFO] [stderr] | [INFO] [stderr] 309 | ((reverse_bits(bytes[i * 4 + 3]) as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 3]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:316:30 [INFO] [stderr] | [INFO] [stderr] 316 | last_word |= (reverse_bits(byte) as u32) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(byte))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bit.rs:1537:35 [INFO] [stderr] | [INFO] [stderr] 1537 | pub fn contains(&self, value: &usize) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bit.rs:1587:37 [INFO] [stderr] | [INFO] [stderr] 1587 | pub fn remove(&mut self, value: &usize) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/estimate.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let x = tables::SMALL_PRIME_PI[n as usize] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tables::SMALL_PRIME_PI[n as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/estimate.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let x = tables::SMALL_PRIMES[n as usize - 1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tables::SMALL_PRIMES[n as usize - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fast_sieve.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn next(&mut self) -> Option<(usize, &BitVec)> { [INFO] [stderr] 60 | | if self.low >= self.limit { [INFO] [stderr] 61 | | return None [INFO] [stderr] 62 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | Some((low, &self.sieve)) [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perfect_power.rs:45:34 [INFO] [stderr] | [INFO] [stderr] 45 | let factor = x_.powf(1.0/expn as f64).round() as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(expn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sieve.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn primes<'a>(&'a self) -> PrimeIterator<'a> { [INFO] [stderr] 92 | | PrimeIterator { [INFO] [stderr] 93 | | two: true, [INFO] [stderr] 94 | | iter: self.v.iter().enumerate() [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(reverse_bits(bytes[i * 4 + 0]) as u32)` [INFO] [stderr] --> src/bit.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | ((reverse_bits(bytes[i * 4 + 0]) as u32) << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:306:18 [INFO] [stderr] | [INFO] [stderr] 306 | ((reverse_bits(bytes[i * 4 + 0]) as u32) << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/bit.rs:306:38 [INFO] [stderr] | [INFO] [stderr] 306 | ((reverse_bits(bytes[i * 4 + 0]) as u32) << 0) | [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:307:18 [INFO] [stderr] | [INFO] [stderr] 307 | ((reverse_bits(bytes[i * 4 + 1]) as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:308:18 [INFO] [stderr] | [INFO] [stderr] 308 | ((reverse_bits(bytes[i * 4 + 2]) as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:309:18 [INFO] [stderr] | [INFO] [stderr] 309 | ((reverse_bits(bytes[i * 4 + 3]) as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(bytes[i * 4 + 3]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit.rs:316:30 [INFO] [stderr] | [INFO] [stderr] 316 | last_word |= (reverse_bits(byte) as u32) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reverse_bits(byte))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bit.rs:1537:35 [INFO] [stderr] | [INFO] [stderr] 1537 | pub fn contains(&self, value: &usize) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bit.rs:1587:37 [INFO] [stderr] | [INFO] [stderr] 1587 | pub fn remove(&mut self, value: &usize) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/estimate.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let x = tables::SMALL_PRIME_PI[n as usize] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tables::SMALL_PRIME_PI[n as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/estimate.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let x = tables::SMALL_PRIMES[n as usize - 1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tables::SMALL_PRIMES[n as usize - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fast_sieve.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn next(&mut self) -> Option<(usize, &BitVec)> { [INFO] [stderr] 60 | | if self.low >= self.limit { [INFO] [stderr] 61 | | return None [INFO] [stderr] 62 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | Some((low, &self.sieve)) [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perfect_power.rs:45:34 [INFO] [stderr] | [INFO] [stderr] 45 | let factor = x_.powf(1.0/expn as f64).round() as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(expn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/perfect_power.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / loop { [INFO] [stderr] 114 | | let p = match primes.next() { [INFO] [stderr] 115 | | Some(p) => p as u64, [INFO] [stderr] 116 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(p) = primes.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sieve.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn primes<'a>(&'a self) -> PrimeIterator<'a> { [INFO] [stderr] 92 | | PrimeIterator { [INFO] [stderr] 93 | | two: true, [INFO] [stderr] 94 | | iter: self.v.iter().enumerate() [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> examples/small_prime_props.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for _ in (last..p) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.28s [INFO] running `"docker" "inspect" "14cffebb9b8252c470b428a5b9f1415c11e8b455e65d30758d27a586d29809d8"` [INFO] running `"docker" "rm" "-f" "14cffebb9b8252c470b428a5b9f1415c11e8b455e65d30758d27a586d29809d8"` [INFO] [stdout] 14cffebb9b8252c470b428a5b9f1415c11e8b455e65d30758d27a586d29809d8