[INFO] crate sloppy-rfc4880 0.1.2 is already in cache [INFO] extracting crate sloppy-rfc4880 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/sloppy-rfc4880/0.1.2 [INFO] extracting crate sloppy-rfc4880 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sloppy-rfc4880/0.1.2 [INFO] validating manifest of sloppy-rfc4880-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sloppy-rfc4880-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sloppy-rfc4880-0.1.2 [INFO] finished frobbing sloppy-rfc4880-0.1.2 [INFO] frobbed toml for sloppy-rfc4880-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/sloppy-rfc4880/0.1.2/Cargo.toml [INFO] started frobbing sloppy-rfc4880-0.1.2 [INFO] finished frobbing sloppy-rfc4880-0.1.2 [INFO] frobbed toml for sloppy-rfc4880-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sloppy-rfc4880/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sloppy-rfc4880-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sloppy-rfc4880/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b43db14f0a73d344bca2e8bdfeefd89b091ff7150607ce513a5bede6614efe6c [INFO] running `"docker" "start" "-a" "b43db14f0a73d344bca2e8bdfeefd89b091ff7150607ce513a5bede6614efe6c"` [INFO] [stderr] Checking sloppy-rfc4880 v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/armor.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | bytes [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/armor.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | let bytes = base64::decode_config(r#"mQENBFu6q90BCADgD7Q9aH5683yt7hzPktDkAUNAZJHwYhUNeyGK43frPyDRWQmqN+oXTfiYWLQN [INFO] [stderr] | _____________________^ [INFO] [stderr] 49 | | +d7KNBTnF9uwyBdaLM7SH44lLNYo8W09mVM2eK+wt19uf5HYNgAE8la45QLo/ce9CQVe1a4oXNWq [INFO] [stderr] 50 | | 6l0FOY7M+wLe+G2wMwz8RXGgwd/qQp4/PB5YpUhxnAnzClxvwymrL6BQXsRcKSMSD5bIzIv95n10 [INFO] [stderr] 51 | | 5CvW5Hql7JR9zgOR+gHqVOH8HBUcZxMumrTM6aKLgAhgM8Sn36gCFOfjlG1b1OFLZhUtgro/nnEO [INFO] [stderr] ... | [INFO] [stderr] 73 | | base64::LineWrap::NoWrap, [INFO] [stderr] 74 | | )).expect("base64"); [INFO] [stderr] | |___________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> examples/dump.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / loop { [INFO] [stderr] 16 | | match parser.next() { [INFO] [stderr] 17 | | Some(x) => println!("{:?}", x), [INFO] [stderr] 18 | | None => break, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | info!("Remaining: {:?}", parser.inner().len()); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = parser.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/split.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | let prefix = env::args().skip(1).next().expect("Missing prefix"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.14s [INFO] running `"docker" "inspect" "b43db14f0a73d344bca2e8bdfeefd89b091ff7150607ce513a5bede6614efe6c"` [INFO] running `"docker" "rm" "-f" "b43db14f0a73d344bca2e8bdfeefd89b091ff7150607ce513a5bede6614efe6c"` [INFO] [stdout] b43db14f0a73d344bca2e8bdfeefd89b091ff7150607ce513a5bede6614efe6c