[INFO] crate slog-term 2.4.0 is already in cache [INFO] extracting crate slog-term 2.4.0 into work/ex/clippy-test-run/sources/stable/reg/slog-term/2.4.0 [INFO] extracting crate slog-term 2.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slog-term/2.4.0 [INFO] validating manifest of slog-term-2.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slog-term-2.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slog-term-2.4.0 [INFO] finished frobbing slog-term-2.4.0 [INFO] frobbed toml for slog-term-2.4.0 written to work/ex/clippy-test-run/sources/stable/reg/slog-term/2.4.0/Cargo.toml [INFO] started frobbing slog-term-2.4.0 [INFO] finished frobbing slog-term-2.4.0 [INFO] frobbed toml for slog-term-2.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slog-term/2.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slog-term-2.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slog-term/2.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d311596647da43054165b5d7ece1876fd97e673f7780e624b033c60bfacc08b3 [INFO] running `"docker" "start" "-a" "d311596647da43054165b5d7ece1876fd97e673f7780e624b033c60bfacc08b3"` [INFO] [stderr] Checking slog-term v2.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | comma_needed: comma_needed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `comma_needed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:562:13 [INFO] [stderr] | [INFO] [stderr] 562 | reverse: reverse, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reverse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:721:13 [INFO] [stderr] | [INFO] [stderr] 721 | history: history, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `history` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:883:13 [INFO] [stderr] | [INFO] [stderr] 883 | wrapped: wrapped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `wrapped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1237:17 [INFO] [stderr] | [INFO] [stderr] 1237 | use_color: use_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1262:13 [INFO] [stderr] | [INFO] [stderr] 1262 | use_color: use_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | comma_needed: comma_needed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `comma_needed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:562:13 [INFO] [stderr] | [INFO] [stderr] 562 | reverse: reverse, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reverse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:721:13 [INFO] [stderr] | [INFO] [stderr] 721 | history: history, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `history` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:883:13 [INFO] [stderr] | [INFO] [stderr] 883 | wrapped: wrapped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `wrapped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1237:17 [INFO] [stderr] | [INFO] [stderr] 1237 | use_color: use_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1262:13 [INFO] [stderr] | [INFO] [stderr] 1262 | use_color: use_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:908:13 [INFO] [stderr] | [INFO] [stderr] 908 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:937:26 [INFO] [stderr] | [INFO] [stderr] 937 | const TIMESTAMP_FORMAT: &'static str = "%b %d %H:%M:%S%.3f"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:908:13 [INFO] [stderr] | [INFO] [stderr] 908 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:937:26 [INFO] [stderr] | [INFO] [stderr] 937 | const TIMESTAMP_FORMAT: &'static str = "%b %d %H:%M:%S%.3f"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / pub fn new(d: D) -> FullFormatBuilder { [INFO] [stderr] 370 | | FullFormatBuilder { [INFO] [stderr] 371 | | fn_timestamp: Box::new(timestamp_local), [INFO] [stderr] 372 | | decorator: d, [INFO] [stderr] 373 | | original_order: false, [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:493:5 [INFO] [stderr] | [INFO] [stderr] 493 | / pub fn new(d: D) -> CompactFormatBuilder { [INFO] [stderr] 494 | | CompactFormatBuilder { [INFO] [stderr] 495 | | fn_timestamp: Box::new(timestamp_local), [INFO] [stderr] 496 | | decorator: d, [INFO] [stderr] 497 | | } [INFO] [stderr] 498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / pub fn new(d: D) -> FullFormatBuilder { [INFO] [stderr] 370 | | FullFormatBuilder { [INFO] [stderr] 371 | | fn_timestamp: Box::new(timestamp_local), [INFO] [stderr] 372 | | decorator: d, [INFO] [stderr] 373 | | original_order: false, [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:493:5 [INFO] [stderr] | [INFO] [stderr] 493 | / pub fn new(d: D) -> CompactFormatBuilder { [INFO] [stderr] 494 | | CompactFormatBuilder { [INFO] [stderr] 495 | | fn_timestamp: Box::new(timestamp_local), [INFO] [stderr] 496 | | decorator: d, [INFO] [stderr] 497 | | } [INFO] [stderr] 498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:1235:40 [INFO] [stderr] | [INFO] [stderr] 1235 | let use_color = self.color.unwrap_or(io.should_use_color()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| io.should_use_color())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:1259:36 [INFO] [stderr] | [INFO] [stderr] 1259 | let use_color = self.color.unwrap_or(io.should_use_color()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| io.should_use_color())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:1281:5 [INFO] [stderr] | [INFO] [stderr] 1281 | / pub fn new() -> TermDecoratorBuilder { [INFO] [stderr] 1282 | | TermDecoratorBuilder::new() [INFO] [stderr] 1283 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1332:9 [INFO] [stderr] | [INFO] [stderr] 1332 | / match self.term { [INFO] [stderr] 1333 | | &mut AnyTerminal::Stdout(ref mut term) => term.write(buf), [INFO] [stderr] 1334 | | &mut AnyTerminal::Stderr(ref mut term) => term.write(buf), [INFO] [stderr] 1335 | | &mut AnyTerminal::FallbackStdout => std::io::stdout().write(buf), [INFO] [stderr] 1336 | | &mut AnyTerminal::FallbackStderr => std::io::stderr().write(buf), [INFO] [stderr] 1337 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1332 | match *self.term { [INFO] [stderr] 1333 | AnyTerminal::Stdout(ref mut term) => term.write(buf), [INFO] [stderr] 1334 | AnyTerminal::Stderr(ref mut term) => term.write(buf), [INFO] [stderr] 1335 | AnyTerminal::FallbackStdout => std::io::stdout().write(buf), [INFO] [stderr] 1336 | AnyTerminal::FallbackStderr => std::io::stderr().write(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1341:9 [INFO] [stderr] | [INFO] [stderr] 1341 | / match self.term { [INFO] [stderr] 1342 | | &mut AnyTerminal::Stdout(ref mut term) => term.flush(), [INFO] [stderr] 1343 | | &mut AnyTerminal::Stderr(ref mut term) => term.flush(), [INFO] [stderr] 1344 | | &mut AnyTerminal::FallbackStdout => std::io::stdout().flush(), [INFO] [stderr] 1345 | | &mut AnyTerminal::FallbackStderr => std::io::stderr().flush(), [INFO] [stderr] 1346 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1341 | match *self.term { [INFO] [stderr] 1342 | AnyTerminal::Stdout(ref mut term) => term.flush(), [INFO] [stderr] 1343 | AnyTerminal::Stderr(ref mut term) => term.flush(), [INFO] [stderr] 1344 | AnyTerminal::FallbackStdout => std::io::stdout().flush(), [INFO] [stderr] 1345 | AnyTerminal::FallbackStderr => std::io::stderr().flush(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1368:9 [INFO] [stderr] | [INFO] [stderr] 1368 | / match self.term { [INFO] [stderr] 1369 | | &mut AnyTerminal::Stdout(ref mut term) => term.reset(), [INFO] [stderr] 1370 | | &mut AnyTerminal::Stderr(ref mut term) => term.reset(), [INFO] [stderr] 1371 | | &mut AnyTerminal::FallbackStdout | [INFO] [stderr] 1372 | | &mut AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] 1373 | | }.map_err(term_error_to_io_error) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1368 | match *self.term { [INFO] [stderr] 1369 | AnyTerminal::Stdout(ref mut term) => term.reset(), [INFO] [stderr] 1370 | AnyTerminal::Stderr(ref mut term) => term.reset(), [INFO] [stderr] 1371 | AnyTerminal::FallbackStdout | [INFO] [stderr] 1372 | AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1381:9 [INFO] [stderr] | [INFO] [stderr] 1381 | / match self.term { [INFO] [stderr] 1382 | | &mut AnyTerminal::Stdout(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1383 | | &mut AnyTerminal::Stderr(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1384 | | &mut AnyTerminal::FallbackStdout | [INFO] [stderr] 1385 | | &mut AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] 1386 | | }.map_err(term_error_to_io_error) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1381 | match *self.term { [INFO] [stderr] 1382 | AnyTerminal::Stdout(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1383 | AnyTerminal::Stderr(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1384 | AnyTerminal::FallbackStdout | [INFO] [stderr] 1385 | AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1382:63 [INFO] [stderr] | [INFO] [stderr] 1382 | &mut AnyTerminal::Stdout(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(color)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1383:63 [INFO] [stderr] | [INFO] [stderr] 1383 | &mut AnyTerminal::Stderr(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1393:9 [INFO] [stderr] | [INFO] [stderr] 1393 | / match self.term { [INFO] [stderr] 1394 | | &mut AnyTerminal::Stdout(ref mut term) => { [INFO] [stderr] 1395 | | if term.supports_attr(term::Attr::Bold) { [INFO] [stderr] 1396 | | term.attr(term::Attr::Bold) [INFO] [stderr] ... | [INFO] [stderr] 1409 | | &mut AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] 1410 | | }.map_err(term_error_to_io_error) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1393 | match *self.term { [INFO] [stderr] 1394 | AnyTerminal::Stdout(ref mut term) => { [INFO] [stderr] 1395 | if term.supports_attr(term::Attr::Bold) { [INFO] [stderr] 1396 | term.attr(term::Attr::Bold) [INFO] [stderr] 1397 | } else { [INFO] [stderr] 1398 | term.fg(term::color::BRIGHT_WHITE) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:1235:40 [INFO] [stderr] | [INFO] [stderr] 1235 | let use_color = self.color.unwrap_or(io.should_use_color()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| io.should_use_color())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:1259:36 [INFO] [stderr] | [INFO] [stderr] 1259 | let use_color = self.color.unwrap_or(io.should_use_color()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| io.should_use_color())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:1281:5 [INFO] [stderr] | [INFO] [stderr] 1281 | / pub fn new() -> TermDecoratorBuilder { [INFO] [stderr] 1282 | | TermDecoratorBuilder::new() [INFO] [stderr] 1283 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1332:9 [INFO] [stderr] | [INFO] [stderr] 1332 | / match self.term { [INFO] [stderr] 1333 | | &mut AnyTerminal::Stdout(ref mut term) => term.write(buf), [INFO] [stderr] 1334 | | &mut AnyTerminal::Stderr(ref mut term) => term.write(buf), [INFO] [stderr] 1335 | | &mut AnyTerminal::FallbackStdout => std::io::stdout().write(buf), [INFO] [stderr] 1336 | | &mut AnyTerminal::FallbackStderr => std::io::stderr().write(buf), [INFO] [stderr] 1337 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1332 | match *self.term { [INFO] [stderr] 1333 | AnyTerminal::Stdout(ref mut term) => term.write(buf), [INFO] [stderr] 1334 | AnyTerminal::Stderr(ref mut term) => term.write(buf), [INFO] [stderr] 1335 | AnyTerminal::FallbackStdout => std::io::stdout().write(buf), [INFO] [stderr] 1336 | AnyTerminal::FallbackStderr => std::io::stderr().write(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1341:9 [INFO] [stderr] | [INFO] [stderr] 1341 | / match self.term { [INFO] [stderr] 1342 | | &mut AnyTerminal::Stdout(ref mut term) => term.flush(), [INFO] [stderr] 1343 | | &mut AnyTerminal::Stderr(ref mut term) => term.flush(), [INFO] [stderr] 1344 | | &mut AnyTerminal::FallbackStdout => std::io::stdout().flush(), [INFO] [stderr] 1345 | | &mut AnyTerminal::FallbackStderr => std::io::stderr().flush(), [INFO] [stderr] 1346 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1341 | match *self.term { [INFO] [stderr] 1342 | AnyTerminal::Stdout(ref mut term) => term.flush(), [INFO] [stderr] 1343 | AnyTerminal::Stderr(ref mut term) => term.flush(), [INFO] [stderr] 1344 | AnyTerminal::FallbackStdout => std::io::stdout().flush(), [INFO] [stderr] 1345 | AnyTerminal::FallbackStderr => std::io::stderr().flush(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1368:9 [INFO] [stderr] | [INFO] [stderr] 1368 | / match self.term { [INFO] [stderr] 1369 | | &mut AnyTerminal::Stdout(ref mut term) => term.reset(), [INFO] [stderr] 1370 | | &mut AnyTerminal::Stderr(ref mut term) => term.reset(), [INFO] [stderr] 1371 | | &mut AnyTerminal::FallbackStdout | [INFO] [stderr] 1372 | | &mut AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] 1373 | | }.map_err(term_error_to_io_error) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1368 | match *self.term { [INFO] [stderr] 1369 | AnyTerminal::Stdout(ref mut term) => term.reset(), [INFO] [stderr] 1370 | AnyTerminal::Stderr(ref mut term) => term.reset(), [INFO] [stderr] 1371 | AnyTerminal::FallbackStdout | [INFO] [stderr] 1372 | AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1381:9 [INFO] [stderr] | [INFO] [stderr] 1381 | / match self.term { [INFO] [stderr] 1382 | | &mut AnyTerminal::Stdout(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1383 | | &mut AnyTerminal::Stderr(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1384 | | &mut AnyTerminal::FallbackStdout | [INFO] [stderr] 1385 | | &mut AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] 1386 | | }.map_err(term_error_to_io_error) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1381 | match *self.term { [INFO] [stderr] 1382 | AnyTerminal::Stdout(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1383 | AnyTerminal::Stderr(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] 1384 | AnyTerminal::FallbackStdout | [INFO] [stderr] 1385 | AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1382:63 [INFO] [stderr] | [INFO] [stderr] 1382 | &mut AnyTerminal::Stdout(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(color)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1383:63 [INFO] [stderr] | [INFO] [stderr] 1383 | &mut AnyTerminal::Stderr(ref mut term) => term.fg(color as term::color::Color), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(color)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1393:9 [INFO] [stderr] | [INFO] [stderr] 1393 | / match self.term { [INFO] [stderr] 1394 | | &mut AnyTerminal::Stdout(ref mut term) => { [INFO] [stderr] 1395 | | if term.supports_attr(term::Attr::Bold) { [INFO] [stderr] 1396 | | term.attr(term::Attr::Bold) [INFO] [stderr] ... | [INFO] [stderr] 1409 | | &mut AnyTerminal::FallbackStderr => Ok(()), [INFO] [stderr] 1410 | | }.map_err(term_error_to_io_error) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1393 | match *self.term { [INFO] [stderr] 1394 | AnyTerminal::Stdout(ref mut term) => { [INFO] [stderr] 1395 | if term.supports_attr(term::Attr::Bold) { [INFO] [stderr] 1396 | term.attr(term::Attr::Bold) [INFO] [stderr] 1397 | } else { [INFO] [stderr] 1398 | term.fg(term::color::BRIGHT_WHITE) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.01s [INFO] running `"docker" "inspect" "d311596647da43054165b5d7ece1876fd97e673f7780e624b033c60bfacc08b3"` [INFO] running `"docker" "rm" "-f" "d311596647da43054165b5d7ece1876fd97e673f7780e624b033c60bfacc08b3"` [INFO] [stdout] d311596647da43054165b5d7ece1876fd97e673f7780e624b033c60bfacc08b3