[INFO] crate slog-retry 0.1.1 is already in cache [INFO] extracting crate slog-retry 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/slog-retry/0.1.1 [INFO] extracting crate slog-retry 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slog-retry/0.1.1 [INFO] validating manifest of slog-retry-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slog-retry-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slog-retry-0.1.1 [INFO] finished frobbing slog-retry-0.1.1 [INFO] frobbed toml for slog-retry-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/slog-retry/0.1.1/Cargo.toml [INFO] started frobbing slog-retry-0.1.1 [INFO] finished frobbing slog-retry-0.1.1 [INFO] frobbed toml for slog-retry-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slog-retry/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slog-retry-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slog-retry/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0b2a7768093307f5ef8a45ba6ad875e0c7097d190ed185240dbb0fba26f0c67 [INFO] running `"docker" "start" "-a" "a0b2a7768093307f5ef8a45ba6ad875e0c7097d190ed185240dbb0fba26f0c67"` [INFO] [stderr] Checking slog-json v2.3.0 [INFO] [stderr] Checking version-sync v0.5.0 [INFO] [stderr] Checking slog-retry v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/retry.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | fn part(&self) -> Part { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/retry.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | fn result(&self) -> Result<(), ()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/retry.rs:73:62 [INFO] [stderr] | [INFO] [stderr] 73 | let next_action = self.actions.lock().unwrap().pop().expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 74 | | "No more actions are expected, but {:?} asked for one", [INFO] [stderr] 75 | | part [INFO] [stderr] 76 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("No more actions are expected, but {:?} asked for one", part))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.07s [INFO] running `"docker" "inspect" "a0b2a7768093307f5ef8a45ba6ad875e0c7097d190ed185240dbb0fba26f0c67"` [INFO] running `"docker" "rm" "-f" "a0b2a7768093307f5ef8a45ba6ad875e0c7097d190ed185240dbb0fba26f0c67"` [INFO] [stdout] a0b2a7768093307f5ef8a45ba6ad875e0c7097d190ed185240dbb0fba26f0c67