[INFO] crate slog-envlogger 2.1.0 is already in cache
[INFO] extracting crate slog-envlogger 2.1.0 into work/ex/clippy-test-run/sources/stable/reg/slog-envlogger/2.1.0
[INFO] extracting crate slog-envlogger 2.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slog-envlogger/2.1.0
[INFO] validating manifest of slog-envlogger-2.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of slog-envlogger-2.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing slog-envlogger-2.1.0
[INFO] removed 1 missing tests
[INFO] finished frobbing slog-envlogger-2.1.0
[INFO] frobbed toml for slog-envlogger-2.1.0 written to work/ex/clippy-test-run/sources/stable/reg/slog-envlogger/2.1.0/Cargo.toml
[INFO] started frobbing slog-envlogger-2.1.0
[INFO] removed 1 missing tests
[INFO] finished frobbing slog-envlogger-2.1.0
[INFO] frobbed toml for slog-envlogger-2.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slog-envlogger/2.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting slog-envlogger-2.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slog-envlogger/2.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 598fabf18c6ffc327226cf41b36a68faf85be0ea75f0d975d9bce05600a3368a
[INFO] running `"docker" "start" "-a" "598fabf18c6ffc327226cf41b36a68faf85be0ea75f0d975d9bce05600a3368a"`
[INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other test targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a test target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/tests/regexp_filter.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autotests = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr]     Checking slog-envlogger v2.1.0 (/opt/crater/workdir)
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             level: level,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `level`
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:72:24
[INFO] [stderr]     |
[INFO] [stderr] 72  | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             drain: drain,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `drain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             directives: directives,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             filter: filter,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `filter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             level: level,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `level`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             drain: drain,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `drain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             directives: directives,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             filter: filter,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `filter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:75:1
[INFO] [stderr]    |
[INFO] [stderr] 75 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:330:5
[INFO] [stderr]     |
[INFO] [stderr] 330 |     return (dirs, filter);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dirs, filter)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/lib.rs:285:5
[INFO] [stderr]     |
[INFO] [stderr] 285 |        mods.map(|m| { for s in m.split(',') {
[INFO] [stderr]     |   _____^
[INFO] [stderr]     |  |_____|
[INFO] [stderr]     | ||
[INFO] [stderr] 286 | ||         if s.len() == 0 { continue }
[INFO] [stderr] 287 | ||         let mut parts = s.split('=');
[INFO] [stderr] 288 | ||         let (log_level, name) = match (parts.next(), parts.next().map(|s| s.trim()), parts.next()) {
[INFO] [stderr] ...   ||
[INFO] [stderr] 317 | ||         });
[INFO] [stderr] 318 | ||     }});
[INFO] [stderr]     | ||_______^- help: try this: `if let Some(m) = mods { ... }`
[INFO] [stderr]     | |________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:286:12
[INFO] [stderr]     |
[INFO] [stderr] 286 |         if s.len() == 0 { continue }
[INFO] [stderr]     |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/lib.rs:320:18
[INFO] [stderr]     |
[INFO] [stderr] 320 |       let filter = filter.map_or(None, |filter| {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 321 | |         match Regex::new(filter) {
[INFO] [stderr] 322 | |             Ok(re) => Some(re),
[INFO] [stderr] 323 | |             Err(e) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 327 | |         }
[INFO] [stderr] 328 | |     });
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] help: try using and_then instead
[INFO] [stderr]     |
[INFO] [stderr] 320 |     let filter = filter.and_then(|filter| {
[INFO] [stderr] 321 |         match Regex::new(filter) {
[INFO] [stderr] 322 |             Ok(re) => Some(re),
[INFO] [stderr] 323 |             Err(e) => {
[INFO] [stderr] 324 |                 println!("warning: invalid regex filter - {}", e);
[INFO] [stderr] 325 |                 None
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:75:1
[INFO] [stderr]    |
[INFO] [stderr] 75 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:72:24
[INFO] [stderr]    |
[INFO] [stderr] 72 | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]    |                        ^^^^^^^^
[INFO] [stderr]    = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[INFO] [stderr] 
[INFO] [stderr] error: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:330:5
[INFO] [stderr]     |
[INFO] [stderr] 330 |     return (dirs, filter);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dirs, filter)`
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:72:24
[INFO] [stderr]     |
[INFO] [stderr] 72  | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 6 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `slog-envlogger`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proper.rs:8:48
[INFO] [stderr]   |
[INFO] [stderr] 8 | #[macro_use(slog_error, slog_info, slog_trace, slog_log, slog_o, slog_record,
[INFO] [stderr]   |                                                ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proper.rs:8:66
[INFO] [stderr]   |
[INFO] [stderr] 8 | #[macro_use(slog_error, slog_info, slog_trace, slog_log, slog_o, slog_record,
[INFO] [stderr]   |                                                                  ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proper.rs:9:13
[INFO] [stderr]   |
[INFO] [stderr] 9 |             slog_record_static, slog_b, slog_kv)]
[INFO] [stderr]   |             ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proper.rs:9:33
[INFO] [stderr]   |
[INFO] [stderr] 9 |             slog_record_static, slog_b, slog_kv)]
[INFO] [stderr]   |                                 ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proper.rs:9:41
[INFO] [stderr]   |
[INFO] [stderr] 9 |             slog_record_static, slog_b, slog_kv)]
[INFO] [stderr]   |                                         ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/scopes.rs:5:16
[INFO] [stderr]   |
[INFO] [stderr] 5 | #[macro_use(o, kv)]
[INFO] [stderr]   |                ^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> examples/scopes.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         || foo()
[INFO] [stderr]    |         ^^^^^^^^ help: remove closure as shown: `foo`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> examples/scopes.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         || bar()
[INFO] [stderr]    |         ^^^^^^^^ help: remove closure as shown: `bar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "598fabf18c6ffc327226cf41b36a68faf85be0ea75f0d975d9bce05600a3368a"`
[INFO] running `"docker" "rm" "-f" "598fabf18c6ffc327226cf41b36a68faf85be0ea75f0d975d9bce05600a3368a"`
[INFO] [stdout] 598fabf18c6ffc327226cf41b36a68faf85be0ea75f0d975d9bce05600a3368a