[INFO] crate sloc 0.0.1 is already in cache [INFO] extracting crate sloc 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/sloc/0.0.1 [INFO] extracting crate sloc 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sloc/0.0.1 [INFO] validating manifest of sloc-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sloc-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sloc-0.0.1 [INFO] finished frobbing sloc-0.0.1 [INFO] frobbed toml for sloc-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/sloc/0.0.1/Cargo.toml [INFO] started frobbing sloc-0.0.1 [INFO] finished frobbing sloc-0.0.1 [INFO] frobbed toml for sloc-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sloc/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sloc-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sloc/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1bdba27d079d73dcb443296d996f0fb600f9334383a3c3e146137f47d5220d37 [INFO] running `"docker" "start" "-a" "1bdba27d079d73dcb443296d996f0fb600f9334383a3c3e146137f47d5220d37"` [INFO] [stderr] Checking sloc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | total_loc: total_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | empty_loc: empty_loc [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `empty_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | total_loc: total_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | empty_loc: empty_loc [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `empty_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let matches = App::new("Source lines of code") [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/counting.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | .filter(|x| match *x { [INFO] [stderr] | _____________________^ [INFO] [stderr] 74 | | Some(_) => true, [INFO] [stderr] 75 | | None => false [INFO] [stderr] 76 | | }) [INFO] [stderr] | |_________^ help: try this: `*x.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/counting.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn get_stats(counters: &Vec) -> Stats { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | fn show_counters(counters: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let matches = App::new("Source lines of code") [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/counting.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | .filter(|x| match *x { [INFO] [stderr] | _____________________^ [INFO] [stderr] 74 | | Some(_) => true, [INFO] [stderr] 75 | | None => false [INFO] [stderr] 76 | | }) [INFO] [stderr] | |_________^ help: try this: `*x.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/counting.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn get_stats(counters: &Vec) -> Stats { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | fn show_counters(counters: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.62s [INFO] running `"docker" "inspect" "1bdba27d079d73dcb443296d996f0fb600f9334383a3c3e146137f47d5220d37"` [INFO] running `"docker" "rm" "-f" "1bdba27d079d73dcb443296d996f0fb600f9334383a3c3e146137f47d5220d37"` [INFO] [stdout] 1bdba27d079d73dcb443296d996f0fb600f9334383a3c3e146137f47d5220d37