[INFO] crate slk581 0.0.2 is already in cache [INFO] extracting crate slk581 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/slk581/0.0.2 [INFO] extracting crate slk581 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slk581/0.0.2 [INFO] validating manifest of slk581-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slk581-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slk581-0.0.2 [INFO] finished frobbing slk581-0.0.2 [INFO] frobbed toml for slk581-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/slk581/0.0.2/Cargo.toml [INFO] started frobbing slk581-0.0.2 [INFO] finished frobbing slk581-0.0.2 [INFO] frobbed toml for slk581-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slk581/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slk581-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slk581/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67706529792ba13cb06a296088ae7ec8e618dfcb6d1927b7e25a2ac5de59410a [INFO] running `"docker" "start" "-a" "67706529792ba13cb06a296088ae7ec8e618dfcb6d1927b7e25a2ac5de59410a"` [INFO] [stderr] Checking slk581 v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | pub const UNKNOWN_FAMILY_NAME: &'static str = "999"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | pub const UNKNOWN_GIVEN_NAME: &'static str = "99"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | pub const MALE: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | pub const FEMALE: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | pub const TRANSGENDER: &'static str = "3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | pub const UNKNOWN_SEX: &'static str = "3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | pub const INPUT_DATE_FORMAT: &'static str = "%Y-%m-%d"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | pub const OUTPUT_DATE_FORMAT: &'static str = "%d%m%Y"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / return vec_pos.into_iter() [INFO] [stderr] 82 | | .map(|position| { [INFO] [stderr] 83 | | if let Some(c) = chars_iter.nth(position) { [INFO] [stderr] 84 | | return c; [INFO] [stderr] ... | [INFO] [stderr] 91 | | buf [INFO] [stderr] 92 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 81 | vec_pos.into_iter() [INFO] [stderr] 82 | .map(|position| { [INFO] [stderr] 83 | if let Some(c) = chars_iter.nth(position) { [INFO] [stderr] 84 | return c; [INFO] [stderr] 85 | } else { [INFO] [stderr] 86 | return UNKNOWN_CHARACTER_IN_NAME; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match c { [INFO] [stderr] 68 | | 'A' ... 'Z' => buf.push(c), [INFO] [stderr] 69 | | _ => () [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: try this: `if let 'A' ... 'Z' = c { buf.push(c) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | let mut chars_iter = clean_name.chars().into_iter().take(take); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `clean_name.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | / fn encode_sex<'a>(sex: Option<&'a str>) -> Result> { [INFO] [stderr] 127 | | if sex.is_none() { [INFO] [stderr] 128 | | return Ok(String::from(UNKNOWN_SEX)); [INFO] [stderr] 129 | | } [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | pub const UNKNOWN_FAMILY_NAME: &'static str = "999"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | pub const UNKNOWN_GIVEN_NAME: &'static str = "99"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | pub const MALE: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | pub const FEMALE: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | pub const TRANSGENDER: &'static str = "3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | pub const UNKNOWN_SEX: &'static str = "3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | pub const INPUT_DATE_FORMAT: &'static str = "%Y-%m-%d"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | pub const OUTPUT_DATE_FORMAT: &'static str = "%d%m%Y"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / return vec_pos.into_iter() [INFO] [stderr] 82 | | .map(|position| { [INFO] [stderr] 83 | | if let Some(c) = chars_iter.nth(position) { [INFO] [stderr] 84 | | return c; [INFO] [stderr] ... | [INFO] [stderr] 91 | | buf [INFO] [stderr] 92 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 81 | vec_pos.into_iter() [INFO] [stderr] 82 | .map(|position| { [INFO] [stderr] 83 | if let Some(c) = chars_iter.nth(position) { [INFO] [stderr] 84 | return c; [INFO] [stderr] 85 | } else { [INFO] [stderr] 86 | return UNKNOWN_CHARACTER_IN_NAME; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match c { [INFO] [stderr] 68 | | 'A' ... 'Z' => buf.push(c), [INFO] [stderr] 69 | | _ => () [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: try this: `if let 'A' ... 'Z' = c { buf.push(c) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | let mut chars_iter = clean_name.chars().into_iter().take(take); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `clean_name.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | / fn encode_sex<'a>(sex: Option<&'a str>) -> Result> { [INFO] [stderr] 127 | | if sex.is_none() { [INFO] [stderr] 128 | | return Ok(String::from(UNKNOWN_SEX)); [INFO] [stderr] 129 | | } [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `"docker" "inspect" "67706529792ba13cb06a296088ae7ec8e618dfcb6d1927b7e25a2ac5de59410a"` [INFO] running `"docker" "rm" "-f" "67706529792ba13cb06a296088ae7ec8e618dfcb6d1927b7e25a2ac5de59410a"` [INFO] [stdout] 67706529792ba13cb06a296088ae7ec8e618dfcb6d1927b7e25a2ac5de59410a