[INFO] crate slink 0.1.2 is already in cache
[INFO] extracting crate slink 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/slink/0.1.2
[INFO] extracting crate slink 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slink/0.1.2
[INFO] validating manifest of slink-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of slink-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing slink-0.1.2
[INFO] finished frobbing slink-0.1.2
[INFO] frobbed toml for slink-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/slink/0.1.2/Cargo.toml
[INFO] started frobbing slink-0.1.2
[INFO] finished frobbing slink-0.1.2
[INFO] frobbed toml for slink-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slink/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting slink-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slink/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fc6dd5231f5ecad5aa55d2fbe3e26a8b20918f328b49b42fd79220bd4de12de3
[INFO] running `"docker" "start" "-a" "fc6dd5231f5ecad5aa55d2fbe3e26a8b20918f328b49b42fd79220bd4de12de3"`
[INFO] [stderr]     Checking serde_yaml v0.7.5
[INFO] [stderr]     Checking slink v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config.rs:13:26
[INFO] [stderr]    |
[INFO] [stderr] 13 | const HOST_CONFIG_FILE: &'static str = "hostname";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/config.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     return Some(path.join(chars.as_str()).to_str().unwrap().into());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(path.join(chars.as_str()).to_str().unwrap().into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/paths.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     env::home_dir().and_then(|home_dir| {
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/config.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |     let home_dir = env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/config.rs:13:26
[INFO] [stderr]    |
[INFO] [stderr] 13 | const HOST_CONFIG_FILE: &'static str = "hostname";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/config.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     return Some(path.join(chars.as_str()).to_str().unwrap().into());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(path.join(chars.as_str()).to_str().unwrap().into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/paths.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     env::home_dir().and_then(|home_dir| {
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/config.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |     let home_dir = env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/process.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | / pub fn run<'a, F>(cmd_str: &'a str, cmd_closure: F) -> Result<(), Error<'a>>
[INFO] [stderr] 15 | |     where F: FnOnce(&mut Command) -> ()
[INFO] [stderr] 16 | | {
[INFO] [stderr] 17 | |     // Build command and configure
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |     }
[INFO] [stderr] 38 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/rsync.rs:24:35
[INFO] [stderr]    |
[INFO] [stderr] 24 |             if ignore.starts_with("/") {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     match dirs.find_config_file("ignore") {
[INFO] [stderr] 72 | |         Some(path) => read_ignore_file(home_dir.clone(), path, &mut ignored),
[INFO] [stderr] 73 | |         None => (),
[INFO] [stderr] 74 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Some(path) = dirs.find_config_file("ignore") { read_ignore_file(home_dir.clone(), path, &mut ignored) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:102:48
[INFO] [stderr]     |
[INFO] [stderr] 102 |                     let lines = contents.split("\n");
[INFO] [stderr]     |                                                ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/config.rs:104:25
[INFO] [stderr]     |
[INFO] [stderr] 104 | /                         match parse_ignore(root.clone(), line) {
[INFO] [stderr] 105 | |                             Some(ignore) => { ignored.insert(ignore); },
[INFO] [stderr] 106 | |                             None => (),
[INFO] [stderr] 107 | |                         }
[INFO] [stderr]     | |_________________________^ help: try this: `if let Some(ignore) = parse_ignore(root.clone(), line) { ignored.insert(ignore); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/process.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | / pub fn run<'a, F>(cmd_str: &'a str, cmd_closure: F) -> Result<(), Error<'a>>
[INFO] [stderr] 15 | |     where F: FnOnce(&mut Command) -> ()
[INFO] [stderr] 16 | | {
[INFO] [stderr] 17 | |     // Build command and configure
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |     }
[INFO] [stderr] 38 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/rsync.rs:24:35
[INFO] [stderr]    |
[INFO] [stderr] 24 |             if ignore.starts_with("/") {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     match dirs.find_config_file("ignore") {
[INFO] [stderr] 72 | |         Some(path) => read_ignore_file(home_dir.clone(), path, &mut ignored),
[INFO] [stderr] 73 | |         None => (),
[INFO] [stderr] 74 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Some(path) = dirs.find_config_file("ignore") { read_ignore_file(home_dir.clone(), path, &mut ignored) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:102:48
[INFO] [stderr]     |
[INFO] [stderr] 102 |                     let lines = contents.split("\n");
[INFO] [stderr]     |                                                ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/config.rs:104:25
[INFO] [stderr]     |
[INFO] [stderr] 104 | /                         match parse_ignore(root.clone(), line) {
[INFO] [stderr] 105 | |                             Some(ignore) => { ignored.insert(ignore); },
[INFO] [stderr] 106 | |                             None => (),
[INFO] [stderr] 107 | |                         }
[INFO] [stderr]     | |_________________________^ help: try this: `if let Some(ignore) = parse_ignore(root.clone(), line) { ignored.insert(ignore); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.91s
[INFO] running `"docker" "inspect" "fc6dd5231f5ecad5aa55d2fbe3e26a8b20918f328b49b42fd79220bd4de12de3"`
[INFO] running `"docker" "rm" "-f" "fc6dd5231f5ecad5aa55d2fbe3e26a8b20918f328b49b42fd79220bd4de12de3"`
[INFO] [stdout] fc6dd5231f5ecad5aa55d2fbe3e26a8b20918f328b49b42fd79220bd4de12de3