[INFO] crate sliding_extrema 0.1.2 is already in cache [INFO] extracting crate sliding_extrema 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/sliding_extrema/0.1.2 [INFO] extracting crate sliding_extrema 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sliding_extrema/0.1.2 [INFO] validating manifest of sliding_extrema-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sliding_extrema-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sliding_extrema-0.1.2 [INFO] finished frobbing sliding_extrema-0.1.2 [INFO] frobbed toml for sliding_extrema-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/sliding_extrema/0.1.2/Cargo.toml [INFO] started frobbing sliding_extrema-0.1.2 [INFO] finished frobbing sliding_extrema-0.1.2 [INFO] frobbed toml for sliding_extrema-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sliding_extrema/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sliding_extrema-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sliding_extrema/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9ea0fb89626bc989b61511f84ba7c06197c472e55ca052a4e2c38bbf41e1fe7 [INFO] running `"docker" "start" "-a" "c9ea0fb89626bc989b61511f84ba7c06197c472e55ca052a4e2c38bbf41e1fe7"` [INFO] [stderr] Checking sliding_extrema v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if self.data.len()==0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `SlidingExtrema` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl T> SlidingExtrema { [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | pub fn new(f:F) -> SlidingExtrema { [INFO] [stderr] 80 | | SlidingExtrema { [INFO] [stderr] ... | [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:151:20 [INFO] [stderr] | [INFO] [stderr] 151 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 152 | | if b.len() > 0 { [INFO] [stderr] 153 | | assert_eq!(a.get_extrema().unwrap(), b.iter().fold(10000,|a,b|a.min(*b))); [INFO] [stderr] 154 | | let bpop = b.remove(0); [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if b.len() > 0 { [INFO] [stderr] 152 | assert_eq!(a.get_extrema().unwrap(), b.iter().fold(10000,|a,b|a.min(*b))); [INFO] [stderr] 153 | let bpop = b.remove(0); [INFO] [stderr] 154 | assert_eq!(a.pop().unwrap(),bpop); [INFO] [stderr] 155 | [INFO] [stderr] 156 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if self.data.len()==0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `SlidingExtrema` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl T> SlidingExtrema { [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | pub fn new(f:F) -> SlidingExtrema { [INFO] [stderr] 80 | | SlidingExtrema { [INFO] [stderr] ... | [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | if b.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "c9ea0fb89626bc989b61511f84ba7c06197c472e55ca052a4e2c38bbf41e1fe7"` [INFO] running `"docker" "rm" "-f" "c9ea0fb89626bc989b61511f84ba7c06197c472e55ca052a4e2c38bbf41e1fe7"` [INFO] [stdout] c9ea0fb89626bc989b61511f84ba7c06197c472e55ca052a4e2c38bbf41e1fe7