[INFO] crate slicetools 0.3.0 is already in cache [INFO] extracting crate slicetools 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/slicetools/0.3.0 [INFO] extracting crate slicetools 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slicetools/0.3.0 [INFO] validating manifest of slicetools-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slicetools-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slicetools-0.3.0 [INFO] finished frobbing slicetools-0.3.0 [INFO] frobbed toml for slicetools-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/slicetools/0.3.0/Cargo.toml [INFO] started frobbing slicetools-0.3.0 [INFO] finished frobbing slicetools-0.3.0 [INFO] frobbed toml for slicetools-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slicetools/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slicetools-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slicetools/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8a5482ff0d7de08055aeca3bf8a4bb53ef62dd440d439a38592df271d98a700 [INFO] running `"docker" "start" "-a" "b8a5482ff0d7de08055aeca3bf8a4bb53ef62dd440d439a38592df271d98a700"` [INFO] [stderr] Checking slicetools v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cartesian_product_mut/mod.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | let ret = Some((first, self.slice.1.get_mut(self.index.1).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.slice.1[self.index.1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pairs_mut/mod.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | Some((&mut *ptr.offset(first as isize), &mut *ptr.offset(second as isize))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(first)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pairs_mut/mod.rs:45:55 [INFO] [stderr] | [INFO] [stderr] 45 | Some((&mut *ptr.offset(first as isize), &mut *ptr.offset(second as isize))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cartesian_product_mut/mod.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | let ret = Some((first, self.slice.1.get_mut(self.index.1).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.slice.1[self.index.1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pairs_mut/mod.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | Some((&mut *ptr.offset(first as isize), &mut *ptr.offset(second as isize))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(first)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pairs_mut/mod.rs:45:55 [INFO] [stderr] | [INFO] [stderr] 45 | Some((&mut *ptr.offset(first as isize), &mut *ptr.offset(second as isize))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "b8a5482ff0d7de08055aeca3bf8a4bb53ef62dd440d439a38592df271d98a700"` [INFO] running `"docker" "rm" "-f" "b8a5482ff0d7de08055aeca3bf8a4bb53ef62dd440d439a38592df271d98a700"` [INFO] [stdout] b8a5482ff0d7de08055aeca3bf8a4bb53ef62dd440d439a38592df271d98a700