[INFO] crate slice_queue 0.3.2 is already in cache [INFO] extracting crate slice_queue 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/slice_queue/0.3.2 [INFO] extracting crate slice_queue 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice_queue/0.3.2 [INFO] validating manifest of slice_queue-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slice_queue-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slice_queue-0.3.2 [INFO] finished frobbing slice_queue-0.3.2 [INFO] frobbed toml for slice_queue-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/slice_queue/0.3.2/Cargo.toml [INFO] started frobbing slice_queue-0.3.2 [INFO] finished frobbing slice_queue-0.3.2 [INFO] frobbed toml for slice_queue-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice_queue/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slice_queue-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slice_queue/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fb3baffb5f4ff32979ea022558571d103b9b25f79732b673e2d2ee892a55da9 [INFO] running `"docker" "start" "-a" "8fb3baffb5f4ff32979ea022558571d103b9b25f79732b673e2d2ee892a55da9"` [INFO] [stderr] Checking slice_queue v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/queue.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | match self.is_empty() { [INFO] [stderr] | _________^ [INFO] [stderr] 172 | | true => Err(()), [INFO] [stderr] 173 | | false => { [INFO] [stderr] 174 | | let element = self.backing.remove(0); [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 171 | if self.is_empty() { Err(()) } else { [INFO] [stderr] 172 | let element = self.backing.remove(0); [INFO] [stderr] 173 | self.auto_shrink(); [INFO] [stderr] 174 | Ok(element) [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/queue.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | if self.remaining() >= 1 { Ok(self.backing.push(element)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 296 | if self.remaining() >= 1 { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/queue.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | match self.is_empty() { [INFO] [stderr] | _________^ [INFO] [stderr] 172 | | true => Err(()), [INFO] [stderr] 173 | | false => { [INFO] [stderr] 174 | | let element = self.backing.remove(0); [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 171 | if self.is_empty() { Err(()) } else { [INFO] [stderr] 172 | let element = self.backing.remove(0); [INFO] [stderr] 173 | self.auto_shrink(); [INFO] [stderr] 174 | Ok(element) [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/queue.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | if self.remaining() >= 1 { Ok(self.backing.push(element)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 296 | if self.remaining() >= 1 { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/ok.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | RcVec((0..n).map(|i| Rc::new(i)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.73s [INFO] running `"docker" "inspect" "8fb3baffb5f4ff32979ea022558571d103b9b25f79732b673e2d2ee892a55da9"` [INFO] running `"docker" "rm" "-f" "8fb3baffb5f4ff32979ea022558571d103b9b25f79732b673e2d2ee892a55da9"` [INFO] [stdout] 8fb3baffb5f4ff32979ea022558571d103b9b25f79732b673e2d2ee892a55da9