[INFO] crate slice-deque 0.1.16 is already in cache [INFO] extracting crate slice-deque 0.1.16 into work/ex/clippy-test-run/sources/stable/reg/slice-deque/0.1.16 [INFO] extracting crate slice-deque 0.1.16 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice-deque/0.1.16 [INFO] validating manifest of slice-deque-0.1.16 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slice-deque-0.1.16 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slice-deque-0.1.16 [INFO] finished frobbing slice-deque-0.1.16 [INFO] frobbed toml for slice-deque-0.1.16 written to work/ex/clippy-test-run/sources/stable/reg/slice-deque/0.1.16/Cargo.toml [INFO] started frobbing slice-deque-0.1.16 [INFO] finished frobbing slice-deque-0.1.16 [INFO] frobbed toml for slice-deque-0.1.16 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice-deque/0.1.16/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slice-deque-0.1.16 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slice-deque/0.1.16:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa63a89b26b6289086ef5c511dbbbfcdfb6060cea5c4000800e38cc3d518a300 [INFO] running `"docker" "start" "-a" "fa63a89b26b6289086ef5c511dbbbfcdfb6060cea5c4000800e38cc3d518a300"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking slice-deque v0.1.16 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:3931:26 [INFO] [stderr] | [INFO] [stderr] 3931 | if *x == 0xbadbeef { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:3938:51 [INFO] [stderr] | [INFO] [stderr] 3938 | sdeq![BadElem(1), BadElem(2), BadElem(0xbadbeef), BadElem(4)]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0bad_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/mirrored/linux.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | (ptr as *mut u8).offset(half_size as isize) as *mut c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ptr as *mut u8).add(half_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/mirrored/linux.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | (ptr as *mut u8).offset(half_size as isize) as *mut c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ptr as *mut u8).add(half_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/san.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | allow(cyclomatic_complexity, option_unwrap_used) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `option_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/san.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | allow(cyclomatic_complexity, option_unwrap_used) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_unwrap_used` [INFO] [stderr] [INFO] [stderr] warning: lint name `option_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> benches/pop_front.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(option_unwrap_used))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_unwrap_used` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> benches/index.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `option_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> benches/pop_back.rs:2:45 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(feature = "cargo-clippy", allow(option_unwrap_used))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_unwrap_used` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/san.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | allow(cyclomatic_complexity, option_unwrap_used) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/index.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/alloc.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/push_back.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/iter.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/pop_back.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/pop_front.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/mirrored/linux.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | (ptr as *mut u8).offset(half_size as isize) as *mut c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(ptr as *mut u8).add(half_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:3476:13 [INFO] [stderr] | [INFO] [stderr] 3476 | *num = *num - 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `*num -= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:3500:17 [INFO] [stderr] | [INFO] [stderr] 3500 | assert!(a == a); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/lib.rs:3501:18 [INFO] [stderr] | [INFO] [stderr] 3501 | assert!(!(a != a)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:3689:25 [INFO] [stderr] | [INFO] [stderr] 3689 | assert!(&left[..left.len()] == &[1, 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 3689 | assert!(left[..left.len()] == [1, 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:3697:25 [INFO] [stderr] | [INFO] [stderr] 3697 | assert!(&right[..right.len()] == &[3, 4, 5]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 3697 | assert!(right[..right.len()] == [3, 4, 5]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:3959:9 [INFO] [stderr] | [INFO] [stderr] 3959 | &x[!0..]; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x;!0..;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:3966:9 [INFO] [stderr] | [INFO] [stderr] 3966 | &x[..6]; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `x;..6;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:3973:9 [INFO] [stderr] | [INFO] [stderr] 3973 | &x[!0..4]; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x;!0..4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:3980:9 [INFO] [stderr] | [INFO] [stderr] 3980 | &x[1..6]; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x;1..6;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:3987:9 [INFO] [stderr] | [INFO] [stderr] 3987 | &x[3..2]; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x;3..2;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:4022:28 [INFO] [stderr] | [INFO] [stderr] 4022 | deq2.push_back(i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4022 | deq2.push_back(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `deq` [INFO] [stderr] --> src/lib.rs:4625:18 [INFO] [stderr] | [INFO] [stderr] 4625 | for i in 0..66 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 4625 | for (i, ) in deq.iter().enumerate().take(66) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `deq` [INFO] [stderr] --> src/lib.rs:4634:18 [INFO] [stderr] | [INFO] [stderr] 4634 | for i in 0..66 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 4634 | for (i, ) in deq.iter().enumerate().take(66) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:4655:9 [INFO] [stderr] | [INFO] [stderr] 4655 | deq[3]; [INFO] [stderr] | ^^^^^^^ help: replace it with: `deq;3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:4881:13 [INFO] [stderr] | [INFO] [stderr] 4881 | d.iter_mut().rev().map(|x| *x).collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `d.iter_mut().rev().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:5106:17 [INFO] [stderr] | [INFO] [stderr] 5106 | assert!(&e == &d); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 5106 | assert!(e == d); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `<=` [INFO] [stderr] --> src/lib.rs:5208:17 [INFO] [stderr] | [INFO] [stderr] 5208 | assert!(x <= x); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `>=` [INFO] [stderr] --> src/lib.rs:5209:17 [INFO] [stderr] | [INFO] [stderr] 5209 | assert!(x >= x); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:5458:9 [INFO] [stderr] | [INFO] [stderr] 5458 | / match ring.get_mut(1) { [INFO] [stderr] 5459 | | Some(x) => *x = -1, [INFO] [stderr] 5460 | | None => (), [INFO] [stderr] 5461 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ring.get_mut(1) { *x = -1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:5496:36 [INFO] [stderr] | [INFO] [stderr] 5496 | let expected: Vec<_> = (0..i + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:5504:45 [INFO] [stderr] | [INFO] [stderr] 5504 | let mut expected_left: Vec<_> = (-last..j + 1).rev().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(-last..=j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:5524:36 [INFO] [stderr] | [INFO] [stderr] 5524 | let expected: Vec<_> = (0..i + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:5532:45 [INFO] [stderr] | [INFO] [stderr] 5532 | let mut expected_left: Vec<_> = (-last..j + 1).rev().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(-last..=j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `slice`. [INFO] [stderr] --> src/lib.rs:5802:18 [INFO] [stderr] | [INFO] [stderr] 5802 | for i in 0..slice.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5802 | for in &mut slice { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `slice-deque`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fa63a89b26b6289086ef5c511dbbbfcdfb6060cea5c4000800e38cc3d518a300"` [INFO] running `"docker" "rm" "-f" "fa63a89b26b6289086ef5c511dbbbfcdfb6060cea5c4000800e38cc3d518a300"` [INFO] [stdout] fa63a89b26b6289086ef5c511dbbbfcdfb6060cea5c4000800e38cc3d518a300