[INFO] crate sled-search 0.2.0 is already in cache [INFO] extracting crate sled-search 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/sled-search/0.2.0 [INFO] extracting crate sled-search 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sled-search/0.2.0 [INFO] validating manifest of sled-search-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sled-search-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sled-search-0.2.0 [INFO] finished frobbing sled-search-0.2.0 [INFO] frobbed toml for sled-search-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sled-search/0.2.0/Cargo.toml [INFO] started frobbing sled-search-0.2.0 [INFO] finished frobbing sled-search-0.2.0 [INFO] frobbed toml for sled-search-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sled-search/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sled-search-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sled-search/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 037e2f471daf69cacc5b126d2823f5a5905c8d17f6b96e565adeb8f71171f468 [INFO] running `"docker" "start" "-a" "037e2f471daf69cacc5b126d2823f5a5905c8d17f6b96e565adeb8f71171f468"` [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking sled_sync v0.2.2 [INFO] [stderr] Checking pagetable v0.0.3 [INFO] [stderr] Checking historian v3.0.11 [INFO] [stderr] Checking pagecache v0.6.0 [INFO] [stderr] Checking sled v0.15.21 [INFO] [stderr] Checking sled-search v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn search(tree: &sled::Tree, mut guide: F) -> sled::Result, Vec)>, ()> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn max(tree: &sled::Tree) -> sled::Result, Vec)>, ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn pred(tree: &sled::Tree, key: &[u8]) -> sled::Result, Vec)>, ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | search(tree, |k, _v| match k >= key { [INFO] [stderr] | __________________________^ [INFO] [stderr] 89 | | true => (false, Ordering::Greater), [INFO] [stderr] 90 | | false => (true, Ordering::Less), [INFO] [stderr] 91 | | }) [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if k >= key { (false, Ordering::Greater) } else { (true, Ordering::Less) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:95:52 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn pred_incl(tree: &sled::Tree, key: &[u8]) -> sled::Result, Vec)>, ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | search(tree, |k, _v| match k > key { [INFO] [stderr] | __________________________^ [INFO] [stderr] 97 | | true => (false, Ordering::Greater), [INFO] [stderr] 98 | | false => (true, Ordering::Less), [INFO] [stderr] 99 | | }) [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if k > key { (false, Ordering::Greater) } else { (true, Ordering::Less) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn search(tree: &sled::Tree, mut guide: F) -> sled::Result, Vec)>, ()> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn max(tree: &sled::Tree) -> sled::Result, Vec)>, ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn pred(tree: &sled::Tree, key: &[u8]) -> sled::Result, Vec)>, ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | search(tree, |k, _v| match k >= key { [INFO] [stderr] | __________________________^ [INFO] [stderr] 89 | | true => (false, Ordering::Greater), [INFO] [stderr] 90 | | false => (true, Ordering::Less), [INFO] [stderr] 91 | | }) [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if k >= key { (false, Ordering::Greater) } else { (true, Ordering::Less) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:95:52 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn pred_incl(tree: &sled::Tree, key: &[u8]) -> sled::Result, Vec)>, ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | search(tree, |k, _v| match k > key { [INFO] [stderr] | __________________________^ [INFO] [stderr] 97 | | true => (false, Ordering::Greater), [INFO] [stderr] 98 | | false => (true, Ordering::Less), [INFO] [stderr] 99 | | }) [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if k > key { (false, Ordering::Greater) } else { (true, Ordering::Less) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.64s [INFO] running `"docker" "inspect" "037e2f471daf69cacc5b126d2823f5a5905c8d17f6b96e565adeb8f71171f468"` [INFO] running `"docker" "rm" "-f" "037e2f471daf69cacc5b126d2823f5a5905c8d17f6b96e565adeb8f71171f468"` [INFO] [stdout] 037e2f471daf69cacc5b126d2823f5a5905c8d17f6b96e565adeb8f71171f468